Re: [VOTE] Adding new AEQ feature to release/1.10.0

+1 On Fri, Sep 13, 2019 at 3:58 PM Donal Evans wrote: > +1 > > On Fri, Sep 13, 2019 at 3:37 PM Benjamin Ross wrote: > > > +1 > > > > On Fri, Sep 13, 2019 at 3:25 PM Anilkumar Gingade > > wrote: > > > > > +1. This is needed for spring data-geode; whose upcoming release is > based > > > on older

Re: [VOTE] Apache Geode 1.9.1 RC2

+1 On Thu, Aug 29, 2019 at 5:11 PM Kirk Lund wrote: > +1 > > On Thu, Aug 29, 2019 at 5:02 PM Owen Nichols wrote: > > > Hello Geode dev community, > > > > This is a release candidate for Apache Geode, version 1.9.1.RC2. > > Thanks to all the community members for their contributions to this > >

Re: [DISCUSS] Pulling the current proposed 1.10 release until we can agree on develop being stable

+1 to continuing with the release branch we have. I don't think that anybody is aiming to cause instability on the develop branch. We are all designing, writing code, refactoring, and writing exhaustive tests to the best of our ability to ensure high quality. We have to accept that there will so

Re: Proposal to include GEODE-7088 and GEODE-7089 in 1.10.0

/3976 The original PR for this change when it was added to develop is here: https://github.com/apache/geode/pull/3929 Thanks all for reading and considering. Ryan On Mon, Aug 26, 2019 at 4:22 PM Udo Kohlmeyer wrote: > Thank you Ryan, > > +1 for inclusion > > On 8/26/19 3:33 PM

Re: Proposal to include GEODE-7088 and GEODE-7089 in 1.10.0

ompared to adding another hidden issue, which we will discover > in another few weeks from now? > > > --Udo > > On 8/26/19 3:10 PM, Ryan McMahon wrote: > > Hi all, > > > > I would like to propose cherry-picking GEODE-7088 and GEODE-7089 to the > > 1.10.0 release

Proposal to include GEODE-7088 and GEODE-7089 in 1.10.0

mory leak. The SHAs for the fixes and tests in develop are: GEODE-7088 - 174af1d23fb7e09eb2bc2fa55479df854850fadb - 5bb753a8f4ff2886acd8e62d6f51fea58e37881d GEODE-7089 - 5d0153ad4adb1612a1083673f98b1982819a6589 This proposal is to cherry-pick these commits to 1.10.0 release branch. Thanks, Ryan McMahon

Re: [DISCUSS] Controlling event dispatch to AsyncEventListener (review by Aug 22)

+1 to Juan's comment. I wonder if it would make sense just to have a variation on the existing create() method. Either have a createPaused() method or add an overload for create() that takes a startPaused boolean. That will really drive home that the AsyncEventQueue will be created in a paused st

Re: Hardcoded list of jars for Jetty tests

Hi Kirk, I’m curious if you’ve found an alternative so we don’t have to hard code this list? We actually recently ran into an issue where this test list was updated due to missing dependencies, but our documentation was not updated and therefore it was missing the new dependencies. I currently h

Re: Unit tests are hanging?

ug 8, 2019 at 11:28 AM Ryan McMahon wrote: > Looks like we have a general consensus from the community. I'll go ahead > and make a PR for the changes. > > Thanks, > Ryan > > On Thu, Aug 8, 2019 at 11:03 AM Juan José Ramos wrote: > >> +1 >> >> On

Re: Unit tests are hanging?

Looks like we have a general consensus from the community. I'll go ahead and make a PR for the changes. Thanks, Ryan On Thu, Aug 8, 2019 at 11:03 AM Juan José Ramos wrote: > +1 > > On Thu, Aug 8, 2019 at 6:55 PM Kirk Lund wrote: > > > +1 > > > > On Thu, Aug 8, 2019 at 10:14 AM Dan Smith wrot

Re: Another change for 1.10.0 release

+1 On Thu, Aug 8, 2019 at 10:40 AM John Blum wrote: > +1 for Dan's changes. > > On Thu, Aug 8, 2019 at 10:28 AM Owen Nichols wrote: > > > Hi Dan, thank you for bringing your concern. > > > > Our “critical fixes” rule allows critical fixes to be brought to the > > release branch by proposal on t

Re: Unit tests are hanging?

, Aug 7, 2019 at 11:39 AM Ryan McMahon wrote: > Still trying to identify the cause of the unit test hangs.stay tuned. > For other people who might not know this, the reason the entire CI job > fails rather than the hanging test is because we don't have any global > test-lev

Re: Unit tests are hanging?

.. > > > > Started @ 2019-08-07 07:25:18.494 + > > 2019-08-07 07:51:25.252 + > > org.apache.geode.cache30.DistributedMulticastRegionDUnitTest > > testMulticastAfterReconnect > > Ended @ 2019-08-07 08:28:16.591 + > > > > Thanks for digging into

Re: Unit tests are hanging?

I think the reflection and PowerMock warnings here are probably a red herring. We pulled down the artifacts and found that the DUnit job is hanging due to stuck threads in a newer DUnit test. I am not sure why it isn't failing the test but rather failing the entire job. I believe Bruce Schuchart

Re: Unnecessary uses of final on local variables

I agree with this sentiment, and have generally only been using final on class fields and method parameters where I want to guarantee immutability as of late. However, I was at one time adding final to local variables, and I know that I have checked in code with final locals. Should we actively b

Re: "Output path is not specified for module" (IntelliJ)

Fair warning - some have wiped their .idea file and it works temporarily, but inevitably will return. I would recommend the setting changes as described above if it recurs. Ryan On Thu, Jun 6, 2019 at 12:04 PM Peter Tran wrote: > Awesome - a wipe of my .idea file worked. Thank you! > > On Thu,

Re: "Output path is not specified for module" (IntelliJ)

I have seen this issue and this seems to be a pretty reliable solution: 1. Upgrade to IntelliJ 2019.1.3 (the latest and greatest) if you haven't already. 2. Reimport the Geode project as described in the "Setting up IntelliJ" section of the BUILDING.MD 3. Set your "Build and run using" setting in

Re: [DISCUSS] Criteria for PMC, committers

My two cents... 1) What is our criteria for becoming a committer and PMC member? I don't have anything particularly enlightening to say here, and I think I am just reinforcing what we already do, but here goes... I think this piece from the ASF notes is key for measuring candidacy for committer/P

Re: Backwards compatibility issue with JSONFormatter

Fixed in https://github.com/apache/geode/commit/cc0b37a504480f554b1884491f44a3cca4113ef5 On Tue, May 14, 2019 at 2:06 PM Ryan McMahon wrote: > Thanks Anthony! Have we considered using a compliance checker in our CI > like the one in the first link? > > Side note - I think that v

Re: Backwards compatibility issue with JSONFormatter

n Smith wrote: > > > > Sounds good! Yeah, this is a bit of an interesting case where code will > > still compile against the new API without change, but I think maintaining > > compatibility of the binary API is also important. Thanks for looking > into > > it. &

Re: Backwards compatibility issue with JSONFormatter

Hi all, This is my mistake - it was a misunderstanding of what constitutes a breaking public API change. If a client app were to recompile using the new bits with the new method signature, there wouldn't be an issue because the new signature would work with 0 varargs. The problem arises when you

Re: [VOTE] Apache Geode 1.9.0 RC4

+1 Verified signatures, compiled from source, and ran all examples. Ryan On Tue, Apr 23, 2019 at 3:44 PM Owen Nichols wrote: > +1 > > I used gpg --verify to check all signatures, compiled geode from source, > ran all examples, and set up a cluster with 2 locators, 3 servers, a simple > client a

Re: 1.9 release date

+1 to prioritizing quality over releasing on the desired cadence. The quarterly release cadence is a good goal, but it shouldn't be a strict rule if there is more work to be done to ensure good quality. Ryan On Fri, Mar 1, 2019 at 8:02 AM Anthony Baker wrote: > IMHO we start release work based

Re: Should Geode stats conform to backwards compatibility constraints?

Sorry that should read “and if the value exceeds MAX_INT” On Wed, Feb 13, 2019 at 8:21 PM Ryan McMahon wrote: > +1 to introducing a new method which returns the stat as long per Jake’s > suggestion. I vote for getInt() to downcast as an int, and the value > exceeds MAX_INT, return MA

Re: Should Geode stats conform to backwards compatibility constraints?

+1 to introducing a new method which returns the stat as long per Jake’s suggestion. I vote for getInt() to downcast as an int, and the value exceeds MAX_INT, return MAX_INT and possibly add a warning message which points users to the new long version of the method. I think throwing an exception

Re: [Proposal] Change default gemfire.memoryEventTolerance from 1 to 0

cussion. haha > > On Thu, Jan 24, 2019 at 9:38 AM Ryan McMahon wrote: > >> Hey David, >> >> Alexander responded to the dev list, but not sure you got a copy. >> Basically he is asking if we can wait to change the default tolerance until >> Geode 2.0, since it

[Proposal] Change default gemfire.memoryEventTolerance from 1 to 0

Hi all, I am currently fixing a bug with the HeapMemoryMonitor event tolerance feature, and came across a decision that I thought would be more appropriate for the Geode dev list. For those familiar with the feature, we are proposing that the def

Re: [VOTE] Apache Geode 1.8.0 RC2

+1 - Ran all examples - Ran gfsh, created region, performed basic entry operations - Verified SHAs - Verified signatures Ryan On Mon, Dec 10, 2018 at 4:01 PM Alexander Murmann wrote: > A reminder for everyone that the vote is scheduled to end tonight. Please > verify and vote! > > @Galen I'll

Re: PowerMock and mock ClassLoader

oblems. > > > > On Wed, Dec 5, 2018 at 10:35 AM Galen O'Sullivan > > wrote: > > > > > Can we just remove PowerMock from our dependencies and skip the rule? > I'd > > > like to hope we can control our dependencies reasonably well. > > >

Re: PowerMock and mock ClassLoader

it the reintroduction of > PowerMock. > > On Tue, Dec 4, 2018 at 3:32 PM Ryan McMahon > wrote: > > > I am interested in contributing to this effort. I removed PowerMock > usage > > from one set of tests (GEODE-6052), and at that time I took a quick > glance > > at ot

Re: PowerMock and mock ClassLoader

I am interested in contributing to this effort. I removed PowerMock usage from one set of tests (GEODE-6052), and at that time I took a quick glance at other usages. I’ll assign GEODE-6143 to myself and see about removing the remaining usages. Ryan On Tue, Dec 4, 2018 at 3:08 PM Kirk Lund wrot

Re: PowerMock unit test errors

the log4j code. > > On 11/14/18 10:57 AM, Ryan McMahon wrote: > > I will write up a story to address the use of PowerMock in these JMX > tests > > in particular. I remember attempting to avoid PowerMock when writing > this > > test, because I agree that it should be

Re: Release branch for Apache Geode 1.8.0 has been cut

There was a previous commit that modified the way > > > FunctionInvocationTargetExceptions were being wrapped or sent back to > the > > > client. This could negatively impact a user that was drilling down > into > > > exceptions.getCause() methods as sometimes i

Re: [DISCUSS] - Create new repository for geode benchmarks

+1 I think a separate repo makes sense, and I'm excited for this effort! On Thu, Nov 15, 2018 at 10:47 AM Dan Smith wrote: > Hi all, > > We (Naba, Sean, Brian and I) would like to add some benchmarks for geode, > with a goal of eventually running them as part of our concourse build and > detect

Re: PowerMock unit test errors

I've created a Jira to track the elimination of PowerMock from these tests in particular, which will probably involve doing the major refactoring mentioned in item #4 in my previous email. https://issues.apache.org/jira/browse/GEODE-6052 On Wed, Nov 14, 2018 at 10:57 AM Ryan McMahon wrote:

Re: PowerMock unit test errors

I will write up a story to address the use of PowerMock in these JMX tests in particular. I remember attempting to avoid PowerMock when writing this test, because I agree that it should be avoided. I just want to explain my thinking so that we can discuss what would have been a better approach.

Re: [DISCUSS] Disable merge for failing pull requests

+1 I like this idea, but I recognize that it will be a challenge when there is still some flakiness to the pipeline. I think we'd need clear guidelines on what to do if your PR fails due to something seemingly unrelated. For instance, we ran into GEODE-5943 (flaky EvictionDUnitTest) in our last P

Re: Release branch for Apache Geode 1.8.0 has been cut

Hi Alexander, I would like to cherry pick the following commits from develop to release/1.8.0: https://github.com/apache/geode/commit/e9ea18e18c85b977b91192d4edbb9a4e18b2643e *Reason*: This was a revert of a previous commit which addressed data inconsistencies between WAN sites, but it was found

Re: [DISCUSS] Cutting 1.8 release branch

Bill Burcham and I have been working on a data inconsistency issue which involves a lost event across WAN sites during rebalance on the originating site. We are currently performing root cause analysis. Below is a Geode ticket which we will update with more details as we learn more. https://issu

Re: [VOTE] Time-based release schedule for minor releases

I’m with Sai that it seems like we need to clear up our definitions of minor versus patch releases. The referenced SemVer definition indicates that any backwards compatible bug fix qualifies for a patch release. But it was stated earlier that only security-related or critidal bug fixes justify a

Re: [DISCUSS] Predictable minor release cadence

+1 for scheduled releases and cutting the branch one month prior to release. Given the time it took to fully root out, classify, and solve issues with this 1.7 release, I think a month is the right amount of time between cutting the branch and releasing. If it ends up being too much or too little,

Re: [VOTE] Apache Geode 1.7.0 RC2

+1 - Verified clean build from source - Built and ran all geode-examples On Fri, Sep 28, 2018 at 8:52 PM Sai Boorlagadda wrote: > +1 > > * verified signatures > > * verified source distribution builds > > * ran basic gfsh commands > > * started pulse > > * verified examples work with rc2 > > >

Re: LoggingTest category

This information is now in the TESTING.md in the Git repo as well FYI. Ryan On Tue, Sep 25, 2018 at 11:51 AM Anthony Baker wrote: > Add a property like this on the command line when you execute a test task: > > -PtestCategory=org.apache.geode.test.junit.categories.GfshTest > > Anthony > > > > O

Re: [VOTE] Apache Geode 1.7.0 RC1

+1 - Read release notes and verified no incorrect/misspelled content - Verified clean build from source - Built and ran all geode-examples Ryan On Mon, Sep 17, 2018 at 5:33 PM, Anthony Baker wrote: > +1 > > Reviewed LICENSE and NOTICE* > Verified signatures and hashes > Checked source releas

Updating instructions to run tests

Hi all, I recently added instructions on how to setup Geode in IntelliJ , and as part of that effort realized there is some duplication between the Wiki [1

Re: Instructions for Setting Up IntelliJ

tructions that I could update either location with. Maybe a > > detailed "Setting up IntelliJ" section on BUILDING.md? Just let me know > if > > you'd like my version. > > > >> On Tue, Sep 11, 2018 at 3:36 PM, Jianxia Chen > wrote: > >> > &g

Instructions for Setting Up IntelliJ

Hi all, I am looking to add more comprehensive instructions for how to bring Geode into IntelliJ. I've written the instructions but am now looking at where to put them. There appears to be duplicate information in these sections of the Geode wiki and the README.md/BUILDING.md in the Geode Git re

New Committers: Use GitBox to Link Apache Account to GitHub Account

Hi Everyone, I just wanted to relay some information to new committers. We determined that in order to get write access to the Geode repository, you need to go to this site and go through the linking process. https://gitbox.apache.org/setup/ If you don't to do this, you will be added to the "Ap

Re: 2 minute gateway startup time due to GEODE-5591

+1 for reverting in both places. I see that there is already an isGatewayReceiver flag in the AcceptorImpl constructor. It's not ideal, but could we use this flag to prevent the 2 minute retry logic for happening if this flag is true? Ryan On Wed, Sep 5, 2018 at 10:01 AM, Lynn Hughes-Godfrey <

Re: Geode Wiki Write/Edit Permissions

Follow up: looks like my wiki username is just 'rmcmahon'. Thanks, Ryan McMahon rmcma...@pivotal.io On Tue, Sep 4, 2018 at 9:21 AM, Ryan McMahon wrote: > Hello, > > I'd like to request write/edit permissions on the Geode wiki. My Apache > username is mcmellawatt a

Geode Wiki Write/Edit Permissions

Hello, I'd like to request write/edit permissions on the Geode wiki. My Apache username is mcmellawatt and the email address I used with Confluence is rmcma...@pivotal.io. Thanks, Ryan McMahon rmcma...@pivotal.io

Re: no test category, rename tests?

+1 for the naming convention of *Test, *IntegrationTest, and *DistributedTest. It’s mostly personal preference, but I also agree with Kirk’s comment that it makes it easier to find the test you are looking for by file name. I also find it easier to see the test type I’m working with in the file t

Re: trying to implement SSL configuration

Hi Liron, The first thing that jumps out to me when you say that GFSH could not connect to the JMX manager is that you need to have `jmx` in addition to `locator` in your `ssl-enabled-components` Geode system property. For example, you'd need ssl-enabled-components=locator,jmx at a minimum for G

Re: Geode JIRA permissions

mail > address mcmellawatt and rmcmahon. > > -Dan > > On Wed, Mar 14, 2018 at 11:09 AM, Ryan McMahon > wrote: > >> Hello, >> >> I need permissions to update tickets in Geode JIRA. If someone can grant >> me those permissions it would be appreciated. >> >> Thanks, >> Ryan >> > >

Geode JIRA permissions

Hello, I need permissions to update tickets in Geode JIRA. If someone can grant me those permissions it would be appreciated. Thanks, Ryan