Benchmark instability

Hi All, We are dealing with some instability in benchmarks that is making the pass/fail signal from CI irrelevant. Since it isn't giving us any useful information, and is mostly failing, we will be removing it as a blocking task in the main CI pipeline. This will be a temporary change until we are

Re: Website Banner Graphic

+1 On Thu, Nov 14, 2019 at 10:47 AM Jacob Barrett wrote: > Does anyone know who is responsible for our website’s graphics. The > recently added “TM” to the Geode logo needs to be redone. My design brain > can’t handle that the text is in the wrong font, the wrong color and isn’t > anti-aliased l

Re: bug fix needed for release/1.11.0

found that it resolved the issue with SSL and passed the benchmarks. Obviously we still need to confirm that it works through the main pipeline, but I feel confident that it will pass the benchmark job. Thanks, Helena Bales (they/them) On Wed, Nov 6, 2019 at 9:28 AM Mark Hanson wrote: > Any oth

Re: [PSA] Github branch protection

To Kirk's point, there is actually a way to dismiss requests for review. Info here: https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/dismissing-a-pull-request-review There's instructions in there for how to dismiss a request for changes. Not everyone can do that, so if

Re: [DISCUSS] Blocking merge button in PR

To Bruce's point: I don't see stress new test as something that's supposed to be easy to pass. I do agree that it should be easy to figure out what went wrong, but the point of this task was the catch issues with tests being flaky or non-repeatable for other reasons. If we reduce the scope of this

Re: Rat check reporting error in travis-ci for geode-native

you have more questions. Thank you, Helena Bales On Tue, Aug 20, 2019 at 7:40 AM Alberto Gomez wrote: > Hi, > > I sent a PR for the geode-native repo and the travis-ci is reporting a > Rat error on the following file: > > ./packer/windows/install-doxygen.ps1 > > The reas

Wiki edit permissions

Hello, I am trying to update a wiki doc and need permissions for Confluence. My LDAP username is heybales. Thank you! ~Helena

Re: Unit tests are hanging?

Kirk, as Lynn said in slack, these warnings are showing up with JDK11. So you'd probably see them locally if you used 11 instead of 8. On Wed, Aug 7, 2019, 10:05 AM Kirk Lund wrote: > We previously decided to stop using PowerMock in any Geode tests and remove > it. Ryan and I created https://iss

Re: Unit tests are hanging?

I'm on CIO duty today. There have been some network issues over the last 24h and all of the hangs in the CIO dashboard corresponded with network failures. The jobs have been kicked off again, so hopefully we won't see this issues again for a while. Are you consistently seeing these hangs in the PR

Re: Access to update JIRA

Hi Kamilla, What is your username for Jira? We'll need that to give you access. ~Helena On Wed, Jun 26, 2019, 6:05 PM Kamilla Aslami wrote: > Hello, > > Can I get access to update issues in JIRA, please? Right now I can't change > status of issues I'm working on. > > Thank you, > Kamilla >

Re: [DISCUSS] require reviews before merging a PR

I'm happy to provide feedback on a CONTRIBUTING.md, but I don't want to take the lead on this particular doc right now. On Fri, May 31, 2019 at 1:48 PM Jacob Barrett wrote: > It is probably worthwhile to codify our “policy” so that it’s not confused > later. Simply adding something about lazy co

Re: [DISCUSS] require reviews before merging a PR

To Naba's point, there's an even easier way to keep track of all the PRs: https://github.com/pulls/review-requested It shows your PRs, your assigned PRs, your requested reviews, and your mentions (keep an eye on this tab, because people who aren't committers yet can't request reviews and may inste

Re: what is the best way to update a geode pull request

+1. I would guess that it is the checklist as part of the PR that is confusing people. The other reason that history gets rewritten is when force pushing after a rebase. While fast-forwarding is necessary on occasion, this can be accomplished without rewriting history by using a merge. As part of

Re: [DISCUSS] require reviews before merging a PR

Thanks for the filter, Jinmei! +1 to Naba and Bruce. I will add that I think we should have a formal policy of getting *a* review (and more for large changes), and that PRs that are merged without one should include (in the PR) a comment providing a justification for this merge, so that committer

Re: [DISCUSS] Criteria for PMC, committers

I agree with Jake that the lack of guidelines is an issue that introduces our own biases. I don't think this means that we need to change our process, but rather that we need to formalize it. If a -1 vote requires a justification, then we need to have expectations defined. It's a lot harder to argu

Re: Test coverage and PRs

+1 On Tue, Apr 16, 2019 at 1:33 AM Juan José Ramos wrote: > +1 > > On Mon, Apr 15, 2019 at 11:22 PM Alexander Murmann > wrote: > > > Hi everyone, > > > > TL;DR: > > 1. Let's call each other out on our PRs when test coverage is missing or > > insufficient > > 2. Let's require test coverage for c

Re: Jetty Webapp marked as optional?

out how to work around the apache listserv limitations. On Tue, Mar 5, 2019 at 12:48 PM Helena Bales wrote: > Here is the stack trace. A lot of information is lost due to the way that > we are starting members in our benchmark, but I will see what I can get > from the

Re: Jetty Webapp marked as optional?

:24 AM Anthony Baker wrote: > Do you have a full stack trace? I’m curious where we are using this…I > assume it’s on the client? > > > On Mar 5, 2019, at 11:08 AM, Helena Bales wrote: > > > > It appears the jetty-webapp dependency is now required, and not optional. >

Jetty Webapp marked as optional?

like benchmarks to fail tests due to ClassNotFound exceptions on WebAppContext. Removing the optional flag fixed benchmark tests. ~Helena Bales

Re: Changes to statistics types

rt anyone who may be directly accessing stats. > > For me, the key information here is "This change does not affect VSD”. > For most people, VSD is the "public interface" to statistics. > > +1 for moving from ints to longs wherever possible > > -Owen > >

Changes to statistics types

Hello all, The performance team wants to change some of the statistics that are currently ints to be longs so that they do not overflow as quickly. We were encountering issues with the performance tests due to overflows in stats following an increase in performance for gets. Recent pull requests t

Re: Merging GEODE-6424 into release/1.9.0

Does anyone have an issue with merging https://github.com/apache/geode/pull/3220 to the 1.9.0 release branch? It fixes a race condition introduced by the fix to GEODE-6424 that was approved above. It is critical that we keep the fix to GEODE-6424 in 1.9.0 in order to be able to proceed with benchm

Re: [DISCUSS] Disable merge for failing pull requests

Kirk, this change would not require you to get someone to merge it. It would just require that your PR pass CI before it can be merged. On Thu, Dec 20, 2018 at 2:38 PM Kirk Lund wrote: > I have enough trouble just getting other developers to review my PR. I > don't want to have to struggle to fi

Re: Pull Request builder timing out

Regarding Owen's comments, there has been discussion in past CIO Retros about changing how stressNewTest runs things. From that, I believe that the current behavior is that when the number of tests changed is above some arbitrary number, it doesn't run any of them (please correct me if my knowledge

Failing to get resources from Maven in CI

Hello, It looks like we are still having some problems with Maven in CI. I got the following error in the pre-checkin for this PR (the first commit). Since I didn't change any dependencies, I would expect the image to already have all the dependencies, a

Re: PowerMock and mock ClassLoader

our dependencies reasonably well. > > > > On Tue, Dec 4, 2018 at 4:45 PM Ryan McMahon > > wrote: > > > > > +1 to a spotless rule. Unless anyone objects, I’ll look into doing > that > > > after PowerMock is eliminated. > > > > > > R

Re: PowerMock and mock ClassLoader

Once we have refactored tests currently using PowerMock, it might be prudent to introduce a spotless rule to prohibit the reintroduction of PowerMock. On Tue, Dec 4, 2018 at 3:32 PM Ryan McMahon wrote: > I am interested in contributing to this effort. I removed PowerMock usage > from one set of

Re: What is the new process for flaky test failures in precheckin?

For test failures that do not have a ticket for that particular stack trace, you should re-trigger your pre-checkin. If the test fails again, your change probably caused it to start failing, even if it doesn't seem related (like the unit test ordering issue we had Friday before last), and you would

Re: Avoiding Unpredictability in Our DUnit Testing Rules

Is there a preferred ordering of the above list of rules? Or is the preferred ordering whichever passes? On Wed, Nov 21, 2018 at 4:36 PM Mark Hanson wrote: > It is frowned upon. VM.getVM(0) is now the accepted way to get VM 0. > > Thanks, > Mark > > > > On Nov 21, 2018, at 10:41 AM, Nabarun Nag

Re: Release 1.8.0 pipeline issue

The change Owen mentioned has been merged to develop and release/1.8.0. On Thu, Nov 15, 2018 at 4:35 PM Owen Nichols wrote: > https://github.com/apache/geode/pull/2865 < > https://github.com/apache/geode/pull/2865> fixes this. Patrick or Helena > will take point on getting it reviewed and merge

Re: Our use of Jira "Fix Version/s"

+1 to Alexander's suggestion. I don't know where to put stuff like that, but once we have one we should link to it from our new CIO instructions page. On Wed, Nov 7, 2018 at 2:59 PM Alexander Murmann wrote: > Kirk, I think most of us are in agreement that it works as you are > describing. The no

Re: [DISCUSS] Deprecating JUnit4CacheTestCase (and maybe JUnit4DistributedTestCase?)

+1 for deprecating old test bases. Many of the tests that gave me the most trouble this summer were because of JUnit4CacheTestCase. Also +1 for pulling out Blackboard into a rule. I will, however, argue for continuing to use ClusterStartupRule. The benefit of that is that it makes sure that all JV

Re: [DISCUSS] Disable merge for failing pull requests

+1 As far as the failure rate goes, even if the rate is 25% restarting the pipeline usually gives a passing run. And this would make us less likely to incorrectly dismiss a failure as not related. If the second build also fails with the same failures, those should be investigated and resolved in so

Requesting Geode CI Access

Hello, I would like to access to all the Geode CI pipelines. I am already a Geode Committer. Thank you, Helena Bales

Re: proposing reduced default for "membership-port-range"

Could and should the port selecting logic be pulled out into one common implementation used throughout the code base? It seems like having a common implementation of this would make it a lot easier to solve this type of problem in the future. On Thu, Oct 11, 2018 at 11:27 AM Brian Rowe wrote: >

Re: [discuss] Should we evaluate at commit messages as part of PR review?

I'm a fan of having useful commit messages. I would prefer this to be another checkbox in our list of 6 things to do for Pull Requests as opposed to something that is strictly enforced. There are cases where a simple one-liner commit message is enough. I personally use commit messages often, even w

Awaitility may time out before evaluating the condition

Hello All, Dale and I encountered an interesting Awaitility bug where an Awaitility using "untilAsserted" timed out before it evaluated the condition. It appears that Awaitility starts its timer before the thread has completely started, and when the duration specified in "atMost" is reached, a Tim

[geode-dev] Gfsh Start Server option "disable-exit-when-out-of-memory"

e its name more closely match its behaviour. ~Helena Bales

Proposed API for a ConcurrencyTestHelper

more readable. I would like feedback on the API below. I have provided the method signatures that I plan on implementing, as well as an example usage. Please let me know if there are any methods that seem unnecessary or if there are any important use cases that I missed here. Thank you, Helena Bales

Requesting to be added to Geode dev list

Hello, I would like to be added to the Geode dev list and get access to JIRA. I am working on a GEODE ticket and would like to be able to assign it and ask for reviews on my pull request and such. My Jira username is balesh2. Thank you, Helena Bales

Re: Requesting to be added to Geode dev list

ase follow the steps indicated. > > Someone, with relevant karma, will be in touch shortly to add you to the > JIRA project. > > --Udo > > > > On 7/6/18 14:00, Helena Bales wrote: > >> Hello, >> >> I would like to be added to the Geode dev list and get

Requesting to be added to Geode dev list

Hello, I would like to be added to the Geode dev list and get access to JIRA. I am working on a GEODE ticket and would like to be able to assign it and ask for reviews on my pull request and such. My Jira username is balesh2. Thank you, Helena Bales