Re: Commit message review opt-in

2022-03-03 Thread Eric Zoerner
I would like to opt-in. GitHub user name is ezoerner, and yes include draft PRs From: Owen Nichols Date: Friday, February 25, 2022 at 15:44 To: geode Subject: Commit message review opt-in If you received an automated-looking PR review comment from onichols-pivotal in the past few weeks without

Re: @TestOnly or @VisibleForTesting

2021-11-04 Thread Eric Zoerner
My opinion is that @VisibleForTesting is a code smell and either indicates that there is refactoring needed or there are tests that are unnecessary. If there is functionality in a private method that needs to be tested independently, then that code should be extracted and placed in a separate cl

Request JIRA contributor permissions

2021-09-01 Thread Eric Zoerner
I am a new developer on the Geode project and need permissions to assign tickets to myself and move them into the current iteration. Thanks, Eric