Re: [DISCUSSION] Should We Backport Publishing of Geode Tomcat Module

2021-01-12 Thread Benjamin Ross
The only downside I'm aware of is the effort to backport it which is minimal. Although a missing dependency in this way might be easy to diagnose it would still be awesome if we could prevent a potential failure ahead of time. From: John Hutchison Sent: Tuesday,

Re: [DISCUSS] is overriding a PR check ever justified?

2019-10-31 Thread Benjamin Ross
I would agree with udo, +1 to having an emergency 'break glass' override but -1 to having the ability to do it routinely or for convenience. The main use case in my mind is for infrastructure related issues that block a PR behind unrelated changes which can be really frustrating and inconvenient (

Re: [DISCUSS] Blocking merge button in PR

2019-10-21 Thread Benjamin Ross
+1 On Mon, Oct 21, 2019 at 11:53 AM Udo Kohlmeyer wrote: > BIG +1 (Yes, I'm changing my -1) > > @Naba, thank you for the offline chat. It seems that the proposal of > Github enforcing our good practices is a great option. > > 2 merged PR's without a full green pipeline, since 18 Oct 2019, shocki

Re: [VOTE] Adding a lucene specific fix to release/1.10.0

2019-09-19 Thread Benjamin Ross
+1 On Thu, Sep 19, 2019 at 10:50 AM Nabarun Nag wrote: > +1 > > On Thu, Sep 19, 2019 at 10:49 AM Xiaojian Zhou wrote: > > > I want to merge GEODE-7208, which is lucene specific fix > > > > The fix will enable indexing on inherited attributes in user object. > > > > revision 4ec87419d456748a7d85

Re: [VOTE] Adding new AEQ feature to release/1.10.0

2019-09-13 Thread Benjamin Ross
+1 On Fri, Sep 13, 2019 at 3:25 PM Anilkumar Gingade wrote: > +1. This is needed for spring data-geode; whose upcoming release is based > on older geode version. > > -Anil. > > > On Fri, Sep 13, 2019 at 3:23 PM Nabarun Nag wrote: > > > Hi Geode Community , > > > > [GEODE-7121] > > > > I would l

Re: Proposal: For PR reviews and change requests can we have a 7 day turn around on re-reviews?

2019-07-09 Thread Benjamin Ross
+1 I think having an assignee would help set better expectations between committer and reviewer. On Tue, Jul 9, 2019 at 11:05 AM Dan Smith wrote: > +1 > > What do you think about assigning someone to each PR to make sure it gets > through the process? We don't currently seem to be using github'

Re: Access to geode github permissions

2018-07-24 Thread Benjamin Ross
you are likely able to get what you need with the process > described above. > > You can find more information in the Apache contribution guide: > https://www.apache.org/dev/contributors.html > > On Tue, Jul 24, 2018 at 10:35 AM, Benjamin Ross wrote: > > > Hi, > > &g

Access to geode github permissions

2018-07-24 Thread Benjamin Ross
Hi, I would like the ability to contribute to geode via git with my github user "BenjaminPerryRoss". Thanks! - Ben Ross

Jira Access

2018-07-24 Thread Benjamin Ross
Hi, I would like to request access to the Geode Jira to make contributions. My JIRA user is "Sarm Kahel". Thanks!