Please keep your PR in draft mode anytime it is not ready to be reviewed.
This includes if you have received request for changes, or if any PR checks are
not passing.
If you’re reviewing someone’s PR, and notice any checks not passing or you are
requesting changes, please also click “Convert to
> On May 3, 2021, at 11:23 AM, Blake Bender wrote:
>
> My $0.02 on these:
>
> Things I'd like to see us conform to Google style on:
> * I'd be happy to move to C++ 17
This is likely an ABI change and certainly moves the minimum runtime library.
The latter might be hard in a minor release.
>
100 is just a suggestion based on the Google Java Style Guide we follow on the
main repo. Why the two guides aren’t more aligned I don’t know.
> On May 3, 2021, at 2:06 PM, Robert Houghton wrote:
>
> 80 characters also feels arbitrary, especially with auto-formatters
> (clang-tidy?) of mangli
80 characters also feels arbitrary, especially with auto-formatters
(clang-tidy?) of mangling some otherwise very-readable code.
From: Blake Bender
Date: Monday, May 3, 2021 at 11:23 AM
To: dev@geode.apache.org
Subject: RE: DISCUSSION: Geode Native C++ Style and Formatting Guide
My $0.02 on the
My $0.02 on these:
Things I'd like to see us conform to Google style on:
* I'd be happy to move to C++ 17
* Would also be happy to remove forward declarations. "I'm not a critic, but I
know what I hate," as it were, and I hate forward declarations.
* I would also be happy with an 80-character
