Re: [VOTE] Requiring final keyword on every parameter and local variable

Argy! Sorry typo (corrected with surrounding ***)... I vote -1 for (generally) using final within constructor/method parameters and local variables. While final (e.g. on instance variables) has guaranteed benefits during construction (e.g. initialization safety of an object used in a muti-Th

Re: [VOTE] Requiring final keyword on every parameter and local variable

I vote -1 for (generally) using final within constructor/method parameters and local variables. While final (e.g. on instance variables) has guaranteed benefits during construction (e.g. initialization safety of an object used in a muti-Threaded context) as Kirk rightly pointed out, its non-ap

Re: [VOTE] Requiring final keyword on every parameter and local variable

Good point. We're probably stuck on vanilla JDK8 for years more anyway. Since this discussion seems to be mainly about personal viewing preference, I wonder if someone has written an IntellJ plugin that would simply render effectively-final variables as if they were preceded by the word "final"

Re: [VOTE] Requiring final keyword on every parameter and local variable

I wouldn't recommend Lombok for production code, primarily because it generates code. Generated code occasionally leads to unintended consequences or incompatibilities with newer Java versions. Additionally, it requires as 3rd-party dependency to gain these capabilities rather than being part o

Re: [VOTE] Requiring final keyword on every parameter and local variable

I'm interested in https://projectlombok.org and I remember John Blum using it on some projects. I would like to study it and do some perf testing on it before supporting it for Geode though. In general, I don't like generated code and it looks like at least some of the features involve generated co

Canceled: apache/geode-examples#541 (support/1.12 - 473561d)

Build Update for apache/geode-examples - Build: #541 Status: Canceled Duration: ? Commit: 473561d (support/1.12) Author: Owen Nichols Message: Revert "temporarily point to staging repo for CI purposes" View the changeset: https://github.com/apache/geode-examp

Failed: apache/geode-native#3076 (rel/v1.12.2 - 3e855a8)

Build Update for apache/geode-native - Build: #3076 Status: Failed Duration: 2 mins and 53 secs Commit: 3e855a8 (rel/v1.12.2) Author: Owen Nichols Message: Bumping Geode version to 1.12.1 for CI View the changeset: https://github.com/apache/geode-native/compar

Re: [VOTE] Requiring final keyword on every parameter and local variable

-1 as I've already explained in my DISCUSS thread for this topic, I don't think final gives sufficient benefit for local variables or method parameters because it only prevents reassigning object pointers and primitive values. I favor individuals making a personal decision on whether or not they w

Errored: apache/geode-examples#540 (rel/v1.12.2 - 8ad8ac0)

Build Update for apache/geode-examples - Build: #540 Status: Errored Duration: 1 min and 5 secs Commit: 8ad8ac0 (rel/v1.12.2) Author: Owen Nichols Message: Bumping version to 1.12.2 View the changeset: https://github.com/apache/geode-examples/compare/rel/v1.12

Re: [VOTE] Apache Geode 1.12.2.RC1

It's past the announced deadline and we have enough votes to close the vote. Voting status == +1: 4 binding votes * Donal Evans (PMC member) * Dave Barnes (PMC member) * John Blum (PMC member) * Nabarun Nag (PMC member) +0: zero votes -0: zero votes -1: zero votes The voting meets t

Re: [Suspected Spam] [VOTE] Apache Geode 1.12.2.RC1

Reversing the previous -1 to a +1 Please continue the vote. * The rebalance behavior has been fixed in later releases as a part of GEODE-7830 Regards Nabarun From: Nabarun Nag Sent: Monday, April 19, 2021 10:05 AM To: dev@geode.apache.org Subject: Re: [Sus