Re: Avoid PowerMockito

2021-03-10 Thread Donal Evans
Turns out I should have refreshed the ticket comments before submitting my PR, because Michael Oleske beat me to it yesterday: https://github.com/apache/geode/pull/6107 Sorry for the email spam! From: Donal Evans Sent: Wednesday, March 10, 2021 11:55 AM To: dev@

Re: Avoid PowerMockito

2021-03-10 Thread Donal Evans
I've just submitted a PR to remove three uses of PowerMock.when that can be trivially replaced with Mockito.when: https://github.com/apache/geode/pull/6112 and updated the ticket with a comment listing the remaining classes that are using PowerMock. Only 7 files remain, so this feels like a very

Re: Question regarding VersionRequest/VersionResponse messages

2021-03-10 Thread Bruce Schuchardt
Rolling upgrade is only supported for Geode v1.0 and up. Rolling from GemFire 8 isn't supported due to the JGroups upgrade. On 3/10/21, 10:37 AM, "Bill Burcham" wrote: Jakov, VersionRequest/VersionResponse is understood by the 8.1.x/GFE_81 product versions. I don't know what Geod

Re: Question regarding VersionRequest/VersionResponse messages

2021-03-10 Thread Bill Burcham
Jakov, VersionRequest/VersionResponse is understood by the 8.1.x/GFE_81 product versions. I don't know what Geode's stance is on supporting old locator versions. I see the recent: GEODE-8837 - Establishes GFE_81 as the oldest supported client. Does that imply that GFE_81 is now the oldest suppor

Re: Proposal to back port GEODE-8938 to 1.14

2021-03-10 Thread Owen Nichols
Sounds good. Added to 1.14.0 blocker board. On 3/10/21, 8:58 AM, "Darrel Schneider" wrote: +1 From: John Hutchison Sent: Wednesday, March 10, 2021 8:46 AM To: dev@geode.apache.org Subject: Proposal to back port GEODE-8938 to 1.14

Re: Proposal to back port GEODE-8938 to 1.14

2021-03-10 Thread Darrel Schneider
+1 From: John Hutchison Sent: Wednesday, March 10, 2021 8:46 AM To: dev@geode.apache.org Subject: Proposal to back port GEODE-8938 to 1.14 Hi all, Proposal to backport GEODE-8938. Rationale: GEODE-8864, which has previously been approved to be backported (and i

Proposal to back port GEODE-8938 to 1.14

2021-03-10 Thread John Hutchison
Hi all, Proposal to backport GEODE-8938. Rationale: GEODE-8864, which has previously been approved to be backported (and is marked as a release-blocker) relies on GEODE-8938. GEODE-8938 is small, does not alter any feature code, and exists entirely within the compatible-with-Redis area of the