Re: geodeOldVersionInstalls

2020-04-28 Thread Kirk Lund
Thanks, yes, it is created by Gradle. Unfortunately we have some tests which have part of their setup in gradle files which is a major anti-pattern for tests. We should NOT be doing this. The setup for the test should be within the test itself. On Tue, Apr 28, 2020 at 4:32 PM Robert Houghton wrot

Re: geodeOldVersionInstalls

2020-04-28 Thread Robert Houghton
Pretty sure it is generated by Gradle in geode-assembly On Tue, Apr 28, 2020, 16:09 Kirk Lund wrote: > Does anyone know how geodeOldVersionInstalls.txt gets created? > > When I try to run > TomcatSessionBackwardsCompatibilityTomcat8WithOldModuleCanDoPutsTest > locally, it fails with the followin

geodeOldVersionInstalls

2020-04-28 Thread Kirk Lund
Does anyone know how geodeOldVersionInstalls.txt gets created? When I try to run TomcatSessionBackwardsCompatibilityTomcat8WithOldModuleCanDoPutsTest locally, it fails with the following stack trace. I've searched for geodeOldVersionInstalls.txt and grepped for code that involves the file, but I

Re: Dangers of using sockets in unit tests

2020-04-28 Thread Kirk Lund
The UpgradeTest job refuses to pass on PR #5011. As far I can tell, changing a few tests from UnitTest to IntegrationTest should NOT cause UpgradeTest to fail. It's the Tomcat Session upgrade tests and they just seem to fail every single time in this PR. Again, dunno what to do with this. Anyone fa

Re: [Discuss] Cache.close synchronous is not synchronous, but code still expects it to be....

2020-04-28 Thread Kirk Lund
In addition to PR precheckin jobs, I've also run a full regression against the changes to make Cache.close() synchronous. There are failures, but I have no idea if they are normal or "ok" failures or not. So I'm not sure what to do next with this change unless someone else wants to review the Hydra

Re: [DISCUSS] Publish Builds, not Snapshots

2020-04-28 Thread Jacob Barrett
Probably for a separate discussion but I would opt for a future where the release manager validates and signs a specific build from produced by the CI. This takes a lot of error away in the what the release manager currently does, which has resulted in incorrect artifacts being voted on. In th

Re: [DISCUSS] Publish Builds, not Snapshots

2020-04-28 Thread Anthony Baker
Note that I’m asking about building on my local system. Will the version listed in gradle.properties use the full 1.13.0-build.123 syntax? How would it get bumped? Would a release manager end up using just 1.13.0? Hoping for yes :-) Anthony > On Apr 28, 2020, at 9:24 AM, Robert Houghton wr

Re: [DISCUSS] Publish Builds, not Snapshots

2020-04-28 Thread Robert Houghton
@anthony /develop would say 1.13.0-build.230 (as of this morning). Once cut, /release/1.13 would say 1.13.0-build.231, and /develop would switch to 1.14.0-build.1. gfsh would return that full value. That is the artifact version. On Mon, Apr 27, 2020 at 4:38 PM Anthony Baker wrote: > If I build

Re: [DISCUSS] Publish Builds, not Snapshots

2020-04-28 Thread Donal Evans
That just means we get to be trailblazers, I guess. On Tue, Apr 28, 2020 at 9:02 AM Robert Houghton wrote: > @donal I do not have an example of a Java project that builds using a > Gradle multi-module build, that cares as much as we do about re-running CI > tests with identical inputs. I wish I

Re: [DISCUSS] Publish Builds, not Snapshots

2020-04-28 Thread Robert Houghton
@donal I do not have an example of a Java project that builds using a Gradle multi-module build, that cares as much as we do about re-running CI tests with identical inputs. I wish I did, I would crib from their answer sheet without shame or remorse. On Mon, Apr 27, 2020 at 4:37 PM Donal Evans wr

Handling packet drop between sites

2020-04-28 Thread Mario Kevo
Hi geode-dev, I have a question about how Geode handle when some packets from batch is dropped. I create Geode WAN with two sites and established replication between them. Also modified iptables to drop all packets that comes to receiver port. In that case I have that some threads are stucked. S