dschneider-pivotal opened a new pull request #4983:
URL: https://github.com/apache/geode/pull/4983
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For
mhansonp opened a new pull request #4982:
URL: https://github.com/apache/geode/pull/4982
This test just needed some awaits added to allow the test to retry.
This is an automated message from the Apache Git Service.
To respond
dschneider-pivotal opened a new pull request #4981:
URL: https://github.com/apache/geode/pull/4981
Fixed docs to describe the new default.
Also if the system property it set to an unknown shortcut
then it now defaults to PARTITION_REDUNDANT instead of PARTITION.
The test now validat
DonalEvans commented on issue #4909:
URL: https://github.com/apache/geode/pull/4909#issuecomment-617470775
> it seems like there are several classes that are a tweaked copy of
existing classes - RestoreRedundancyBuilderImpl, RestoreRedundancyDirector,
RegionRedundancyStatus. Is there a way
DonalEvans commented on a change in pull request #4909:
URL: https://github.com/apache/geode/pull/4909#discussion_r412566753
##
File path:
geode-core/src/main/java/org/apache/geode/cache/control/RestoreRedundancyResults.java
##
@@ -0,0 +1,148 @@
+/*
+ * Licensed to the Apache
+1
On Tue, Apr 21, 2020 at 8:54 AM Anthony Baker wrote:
> I’d like a quick round of feedback so we can stop the dev@ spamming [1].
>
> ASF has implemented a cool way to give projects control of lots of things
> [2]. In short, you provide a .asf.yml in each and every GitHub repo to
> control lot
gesterzhou commented on a change in pull request #4970:
URL: https://github.com/apache/geode/pull/4970#discussion_r412539205
##
File path:
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/PartitionedRegionClearWithExpirationDUnitTest.java
##
@@ -0,0 +1,537 @
+1
--Mark
On Tue, Apr 21, 2020 at 9:27 AM Jacob Barrett wrote:
> +1 and fast! Well I guess it doesn’t need to be that fast since GitHub is
> down and not generating any notifications. ;)
>
> > On Apr 21, 2020, at 9:07 AM, Ju@N wrote:
> >
> > +1
> >
> > On Tue, 21 Apr 2020 at 17:02, Dan Smith
upthewaterspout commented on issue #4963:
URL: https://github.com/apache/geode/pull/4963#issuecomment-617442287
The combination of a `ThreadLocal`, a `CountDownLatch`, and
`synchronized()` seems a bit complicated.
The whole close block is already inside of
`synchronized(GemFireCach
kirklund removed a comment on issue #4924:
URL: https://github.com/apache/geode/pull/4924#issuecomment-614809461
The Concurrent Tests that don't use Mockito still seem to hang in
StressNewTest (I removed `@Ignore` so they now need to pass StressNewTest).
-
kirklund removed a comment on issue #4924:
URL: https://github.com/apache/geode/pull/4924#issuecomment-617298733
Another unrelated JMXMBeanReconnectDUnitTest failure.
This is an automated message from the Apache Git Service.
kirklund removed a comment on issue #4924:
URL: https://github.com/apache/geode/pull/4924#issuecomment-614181221
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
PR #4963 https://github.com/apache/geode/pull/4963 is ready for review. It
has passed precheckin once. After self-review, I reverted a couple small
changes that weren't needed so it needs to go through precheckin again.
On Fri, Apr 17, 2020 at 9:42 AM Kirk Lund wrote:
> Memcached IntegrationJUni
BenjaminPerryRoss commented on a change in pull request #4818:
URL: https://github.com/apache/geode/pull/4818#discussion_r412496115
##
File path:
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/domain/DataCommandResult.java
##
@@ -240,6 +242,16 @@ public stat
BenjaminPerryRoss commented on a change in pull request #4818:
URL: https://github.com/apache/geode/pull/4818#discussion_r412495880
##
File path:
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/RemoveCommand.java
##
@@ -90,7 +90,14 @@ public ResultMo
BenjaminPerryRoss commented on a change in pull request #4818:
URL: https://github.com/apache/geode/pull/4818#discussion_r412493711
##
File path:
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/domain/DataCommandResult.java
##
@@ -381,6 +397,12 @@ public Resu
BenjaminPerryRoss commented on a change in pull request #4818:
URL: https://github.com/apache/geode/pull/4818#discussion_r412493249
##
File path:
geode-gfsh/src/distributedTest/java/org/apache/geode/management/internal/cli/commands/ClearCommandDUnitTest.java
##
@@ -0,0 +1,130
BenjaminPerryRoss commented on a change in pull request #4818:
URL: https://github.com/apache/geode/pull/4818#discussion_r412492948
##
File path:
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/functions/DataCommandFunction.java
##
@@ -313,22 +313,21 @@ publi
BenjaminPerryRoss commented on a change in pull request #4818:
URL: https://github.com/apache/geode/pull/4818#discussion_r412492480
##
File path:
geode-gfsh/src/distributedTest/java/org/apache/geode/management/internal/cli/commands/ClearCommandDUnitTest.java
##
@@ -70,43 +72,4
> Anyhow, we wonder what would be as of today the recommended or official
way to downgrade a Geode system without downtime and data loss?
I think the without downtime option is difficult right now. The most bullet
proof way to downgrade without data loss is probably just to export/import
the data,
BenjaminPerryRoss commented on a change in pull request #4818:
URL: https://github.com/apache/geode/pull/4818#discussion_r412487003
##
File path:
geode-gfsh/src/distributedTest/java/org/apache/geode/management/internal/cli/commands/ClearCommandDUnitTest.java
##
@@ -0,0 +1,130
BenjaminPerryRoss commented on a change in pull request #4818:
URL: https://github.com/apache/geode/pull/4818#discussion_r412480534
##
File path:
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ClearCommand.java
##
@@ -0,0 +1,80 @@
+/*
+ * Licensed t
BenjaminPerryRoss commented on a change in pull request #4818:
URL: https://github.com/apache/geode/pull/4818#discussion_r412476686
##
File path:
geode-core/src/main/java/org/apache/geode/management/internal/i18n/CliStrings.java
##
@@ -1914,9 +1921,10 @@
public static final
BenjaminPerryRoss commented on a change in pull request #4818:
URL: https://github.com/apache/geode/pull/4818#discussion_r412473711
##
File path:
geode-gfsh/src/distributedTest/java/org/apache/geode/management/internal/cli/commands/ClearCommandDUnitTest.java
##
@@ -0,0 +1,123
BenjaminPerryRoss commented on a change in pull request #4818:
URL: https://github.com/apache/geode/pull/4818#discussion_r412473139
##
File path:
geode-core/src/main/java/org/apache/geode/management/internal/i18n/CliStrings.java
##
@@ -816,6 +816,13 @@
public static final S
BenjaminPerryRoss commented on a change in pull request #4818:
URL: https://github.com/apache/geode/pull/4818#discussion_r412472330
##
File path:
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/functions/DataCommandFunction.java
##
@@ -314,17 +314,13 @@ publi
BenjaminPerryRoss commented on a change in pull request #4818:
URL: https://github.com/apache/geode/pull/4818#discussion_r412471778
##
File path:
geode-core/src/main/java/org/apache/geode/management/internal/i18n/CliStrings.java
##
@@ -1915,6 +1922,9 @@
public static final
pivotal-jbarrett commented on a change in pull request #4909:
URL: https://github.com/apache/geode/pull/4909#discussion_r412469554
##
File path:
geode-core/src/main/java/org/apache/geode/cache/control/RestoreRedundancyResults.java
##
@@ -0,0 +1,148 @@
+/*
+ * Licensed to the A
pivotal-jbarrett commented on a change in pull request #4909:
URL: https://github.com/apache/geode/pull/4909#discussion_r412453438
##
File path:
geode-core/src/main/java/org/apache/geode/cache/control/RestoreRedundancyResults.java
##
@@ -0,0 +1,148 @@
+/*
+ * Licensed to the A
DonalEvans commented on a change in pull request #4818:
URL: https://github.com/apache/geode/pull/4818#discussion_r412366325
##
File path:
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ClearCommand.java
##
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the A
Bill commented on a change in pull request #4959:
URL: https://github.com/apache/geode/pull/4959#discussion_r412391692
##
File path:
geode-assembly/src/acceptanceTest/java/org/apache/geode/client/sni/ClientSNIDropProxyAcceptanceTest.java
##
@@ -0,0 +1,138 @@
+/*
+ * Licensed t
Bill commented on a change in pull request #4959:
URL: https://github.com/apache/geode/pull/4959#discussion_r412386787
##
File path:
geode-assembly/src/acceptanceTest/java/org/apache/geode/client/sni/ClientSNIDropProxyAcceptanceTest.java
##
@@ -0,0 +1,138 @@
+/*
+ * Licensed t
Bill commented on a change in pull request #4959:
URL: https://github.com/apache/geode/pull/4959#discussion_r412386539
##
File path:
geode-assembly/src/acceptanceTest/java/org/apache/geode/client/sni/ClientSNIDropProxyAcceptanceTest.java
##
@@ -0,0 +1,138 @@
+/*
+ * Licensed t
Bill commented on a change in pull request #4959:
URL: https://github.com/apache/geode/pull/4959#discussion_r412386248
##
File path:
geode-assembly/src/acceptanceTest/resources/org/apache/geode/client/sni/docker-compose.yml
##
@@ -33,7 +33,7 @@ services:
container_name: '
bschuchardt commented on a change in pull request #4959:
URL: https://github.com/apache/geode/pull/4959#discussion_r412381622
##
File path:
geode-assembly/src/acceptanceTest/java/org/apache/geode/client/sni/ClientSNIDropProxyAcceptanceTest.java
##
@@ -0,0 +1,197 @@
+/*
+ * Lic
upthewaterspout commented on a change in pull request #4909:
URL: https://github.com/apache/geode/pull/4909#discussion_r412362589
##
File path:
geode-core/src/main/java/org/apache/geode/cache/control/RestoreRedundancyResults.java
##
@@ -0,0 +1,148 @@
+/*
+ * Licensed to the Ap
upthewaterspout commented on issue #4949:
URL: https://github.com/apache/geode/pull/4949#issuecomment-617301600
JMXMBeanReconnectDUnitTest failed, but that is not related to this test.
This is an automated message from the Ap
metatype opened a new pull request #94:
URL: https://github.com/apache/geode-examples/pull/94
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
kirklund commented on issue #4924:
URL: https://github.com/apache/geode/pull/4924#issuecomment-617298733
Another unrelated JMXMBeanReconnectDUnitTest failure.
This is an automated message from the Apache Git Service.
To respo
prettyClouds commented on a change in pull request #4973:
URL: https://github.com/apache/geode/pull/4973#discussion_r412336050
##
File path:
geode-redis/src/integrationTest/java/org/apache/geode/redis/general/LoopingThreads.java
##
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apac
nabarunnag commented on a change in pull request #4976:
URL: https://github.com/apache/geode/pull/4976#discussion_r412320360
##
File path: geode-docs/managing/disk_storage/using_disk_stores.html.md.erb
##
@@ -170,7 +170,10 @@ Example of using a named disk store for PDX serializ
metatype commented on issue #93:
URL: https://github.com/apache/geode-examples/pull/93#issuecomment-617284504
Test comment number 2.
This is an automated message from the Apache Git Service.
To respond to the message, please
nabarunnag commented on a change in pull request #4976:
URL: https://github.com/apache/geode/pull/4976#discussion_r412320360
##
File path: geode-docs/managing/disk_storage/using_disk_stores.html.md.erb
##
@@ -170,7 +170,10 @@ Example of using a named disk store for PDX serializ
metatype commented on issue #93:
URL: https://github.com/apache/geode-examples/pull/93#issuecomment-617279841
Testing a comment. This should be a comment in the JIRA.
This is an automated message from the Apache Git Service.
dschneider-pivotal commented on a change in pull request #4973:
URL: https://github.com/apache/geode/pull/4973#discussion_r412318830
##
File path:
geode-redis/src/integrationTest/java/org/apache/geode/redis/general/LoopingThreads.java
##
@@ -0,0 +1,88 @@
+/*
+ * Licensed to th
mhansonp opened a new pull request #4980:
URL: https://github.com/apache/geode/pull/4980
This test just needed some awaits added to allow the test to retry.
This is an automated message from the Apache Git Service.
To respond
metatype opened a new pull request #93:
URL: https://github.com/apache/geode-examples/pull/93
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Build Update for apache/geode-examples
-
Build: #434
Status: Broken
Duration: 1 min and 30 secs
Commit: 28f5801 (develop)
Author: Anthony Baker
Message: Added .asf.yaml to control notifications
View the changeset:
https://github.com/apache/geode-examples/comp
+1 and fast! Well I guess it doesn’t need to be that fast since GitHub is down
and not generating any notifications. ;)
> On Apr 21, 2020, at 9:07 AM, Ju@N wrote:
>
> +1
>
> On Tue, 21 Apr 2020 at 17:02, Dan Smith wrote:
>
>> +1
>>
>> -Dan
>>
>> On Tue, Apr 21, 2020 at 9:00 AM Owen Nichols
+1
On 4/21/20, 9:09 AM, "Joris Melchior" wrote:
+1
From: Anthony Baker
Sent: April 21, 2020 11:54 AM
To: dev@geode.apache.org
Subject: Reconfiguring our notifications and more
I’d like a quick round of feedback so we can stop the
+1
From: Anthony Baker
Sent: April 21, 2020 11:54 AM
To: dev@geode.apache.org
Subject: Reconfiguring our notifications and more
I’d like a quick round of feedback so we can stop the dev@ spamming [1].
ASF has implemented a cool way to give projects control of lo
+1 to configure notifications as you listed
On Tue, Apr 21, 2020 at 8:54 AM Anthony Baker wrote:
> I’d like a quick round of feedback so we can stop the dev@ spamming [1].
>
> ASF has implemented a cool way to give projects control of lots of things
> [2]. In short, you provide a .asf.yml in ea
+1
Šalje: Dan Smith
Poslano: 21. travnja 2020. 18:01
Prima: dev@geode.apache.org
Predmet: Re: Reconfiguring our notifications and more
+1
-Dan
On Tue, Apr 21, 2020 at 9:00 AM Owen Nichols wrote:
> +1
>
> > On Apr 21, 2020, at 8:54 AM, Anthony Baker wrote:
>
+1
On Tue, 21 Apr 2020 at 17:02, Dan Smith wrote:
> +1
>
> -Dan
>
> On Tue, Apr 21, 2020 at 9:00 AM Owen Nichols wrote:
>
> > +1
> >
> > > On Apr 21, 2020, at 8:54 AM, Anthony Baker wrote:
> > >
> > > I’d like a quick round of feedback so we can stop the dev@ spamming
> [1].
> > >
> > > ASF ha
+1
-Dan
On Tue, Apr 21, 2020 at 9:00 AM Owen Nichols wrote:
> +1
>
> > On Apr 21, 2020, at 8:54 AM, Anthony Baker wrote:
> >
> > I’d like a quick round of feedback so we can stop the dev@ spamming [1].
> >
> > ASF has implemented a cool way to give projects control of lots of
> things [2]. In
+1
> On Apr 21, 2020, at 8:54 AM, Anthony Baker wrote:
>
> I’d like a quick round of feedback so we can stop the dev@ spamming [1].
>
> ASF has implemented a cool way to give projects control of lots of things
> [2]. In short, you provide a .asf.yml in each and every GitHub repo to
> control
+1
On Apr 21, 2020, at 8:55 AM, Robert Houghton
mailto:rhough...@pivotal.io>> wrote:
+1
On Tue, Apr 21, 2020, 08:54 Anthony Baker
mailto:aba...@pivotal.io>> wrote:
I’d like a quick round of feedback so we can stop the dev@ spamming [1].
ASF has implemented a cool way to give projects control
+1
On Tue, Apr 21, 2020, 08:54 Anthony Baker wrote:
> I’d like a quick round of feedback so we can stop the dev@ spamming [1].
>
> ASF has implemented a cool way to give projects control of lots of things
> [2]. In short, you provide a .asf.yml in each and every GitHub repo to
> control lots of
I’d like a quick round of feedback so we can stop the dev@ spamming [1].
ASF has implemented a cool way to give projects control of lots of things [2].
In short, you provide a .asf.yml in each and every GitHub repo to control lots
of interesting things. For us the most immediately relevant are
jujoramos opened a new pull request #4979:
URL: https://github.com/apache/geode/pull/4979
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
alb3rtobr opened a new pull request #4978:
URL: https://github.com/apache/geode/pull/4978
This PR reverts the revert of GEODE-7565 and introduces a fix for the
problem identified
This is an automated message from the Apache
jujoramos commented on a change in pull request #4970:
URL: https://github.com/apache/geode/pull/4970#discussion_r411996029
##
File path:
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/PartitionedRegionClearWithExpirationDUnitTest.java
##
@@ -0,0 +1,535 @@
jujoramos commented on a change in pull request #4970:
URL: https://github.com/apache/geode/pull/4970#discussion_r411993686
##
File path:
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/PartitionedRegionClearWithExpirationDUnitTest.java
##
@@ -0,0 +1,535 @@
jujoramos commented on a change in pull request #4970:
URL: https://github.com/apache/geode/pull/4970#discussion_r411992120
##
File path:
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/PartitionedRegionClearWithExpirationDUnitTest.java
##
@@ -0,0 +1,535 @@
jujoramos commented on a change in pull request #4970:
URL: https://github.com/apache/geode/pull/4970#discussion_r411988106
##
File path:
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/PartitionedRegionClearWithExpirationDUnitTest.java
##
@@ -0,0 +1,535 @@
jujoramos commented on a change in pull request #4970:
URL: https://github.com/apache/geode/pull/4970#discussion_r411985789
##
File path:
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/PartitionedRegionClearWithExpirationDUnitTest.java
##
@@ -0,0 +1,535 @@
jujoramos commented on a change in pull request #4970:
URL: https://github.com/apache/geode/pull/4970#discussion_r411981569
##
File path:
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/PartitionedRegionClearWithExpirationDUnitTest.java
##
@@ -0,0 +1,535 @@
67 matches
Mail list logo
