Re: Checking for a member is still part of distributed system

2020-04-17 Thread Anilkumar Gingade
Thanks Bruce. Will take a look at "WaitForViewInstallation". -Anil. On Fri, Apr 17, 2020 at 3:44 PM Anilkumar Gingade wrote: > Thanks Kirk. > This is for PR clear; I ended up registering/adding a new membership > listener on DistributionManager (DM). > > I was trying to take advantage of M

Re: Checking for a member is still part of distributed system

2020-04-17 Thread Anilkumar Gingade
Thanks Kirk. This is for PR clear; I ended up registering/adding a new membership listener on DistributionManager (DM). I was trying to take advantage of MembershipListener on PR region-advisor. It turns out that this gets called even before the view is updated on DM. -Anil On Fri, Apr 17, 2020

Re: Checking for a member is still part of distributed system

2020-04-17 Thread Bruce Schuchardt
AdvisorListener.memberDeparted() is invoked from paths other than membership view changes, such as when a Region is destroyed. A member may still be in the cluster (membership view) after AdvisorListener.memberDeparted() has been invoked. If isCurrentMember() returns true then the server is s

Re: Checking for a member is still part of distributed system

2020-04-17 Thread Kirk Lund
Any requirements for this to be a User API vs internal API? For internal APIs, you can register a MembershipListener on DistributionManager -- at least one flavor of which returns a Set of current members which you could check before relying on callbacks. On Fri, Apr 17, 2020 at 3:03 PM Anilkumar

Re: [PROPOSAL]: GEODE-7940 to support/1.12

2020-04-17 Thread Robert Houghton
Conditional +1 from me too, pending a few days on develop with happy results :) Thanks Juan! On Fri, Apr 17, 2020 at 1:41 AM Ju@N wrote: > Hello devs, > > I'd like to propose bringing *GEODE-7940 [1]* to the *support/1.12* branch. > The bug is not new, seems quite old actually, but still seems

Checking for a member is still part of distributed system

2020-04-17 Thread Anilkumar Gingade
Is there a better way to know if a member has left the distributed system, than following: I am checking using: "partitionedRegion.getDistributionManager().isCurrentMember(requester));" This returns true, even though the AdvisorListener on ParitionedRegion already processed memberDeparted() event.

IntelliJ Plugin Assertions2AssertJ

2020-04-17 Thread Kirk Lund
I just started using this IntelliJ plugin and really like it: https://plugins.jetbrains.com/plugin/10345-assertions2assertj To install, go to IntelliJ Preferences -> Plugins -> Marketplace. Search for "Assertions2Assertj" and Install it. You'll have to restart IntelliJ before you can use it. To u

Re: About Geode rolling downgrade

2020-04-17 Thread Bruce Schuchardt
Hi Alberto, I think that if we want to support limited rolling downgrade some other version interchange needs to be done and there need to be tests that prove that the downgrade works. That would let us document which versions are compatible for a downgrade and enforce that no-one attempts it

Re: Concurrent tests hitting OOME, hangs, etc

2020-04-17 Thread Kirk Lund
AvailableConnectionManagerConcurrentTest is passing after changing it to use plain java coded stubs (no Mockito) which required some changes to Connection and PooledConnection (internal classes). The other ConcurrentTests are passing on the Mockito upgrade PR branch. Locally, AvailableConnectionMa

Re: About Geode rolling downgrade

2020-04-17 Thread Alberto Gomez
Hi Bruce, Thanks a lot for your answer. We had not thought about the changes in distributed algorithms when analyzing rolling downgrades. Rolling downgrade is a pretty important requirement for our customers so we would not like to close the discussion here and instead try to see if it is stil

Re: [Discuss] Cache.close synchronous is not synchronous, but code still expects it to be....

2020-04-17 Thread Kirk Lund
Memcached IntegrationJUnitTest hangs the PR IntegrationTest job because Cache.close() calls GeodeMemcachedService.close() which again calls Cache.close(). Looks like the code base has lots of Cache.close() calls -- all of them could theoretically cause issues. I hate to add ThreadLocal isClosingThr

Re: Unable to get behavior described in documentation when using durable native client

2020-04-17 Thread Jacob Barrett
This log message about the GFE version is suspicious too. That is a VERY old version with ordinal value 1. The C++ client is supposed to be sending 45 which is GFE 9.0.0 / Geode 1.0.0. Looks like there might be a handshake protocol misalignment somewhere. Will keep digging. -Jake > On Apr 17,

Re: [PROPOSAL]: GEODE-7940 to support/1.12

2020-04-17 Thread Udo Kohlmeyer
Agreed… this definitely meets the inclusion requirements. +1 On Apr 17, 2020, 1:50 AM -0700, Owen Nichols , wrote: Hi Juan, this looks like a great fix and definitely meets the “critical fix" standard. Also thanks for the detailed description. I noticed it was just merged to develop very recentl

Re: Unable to get behavior described in documentation when using durable native client

2020-04-17 Thread Jacob Barrett
Can you confirm that when log level less than debug that the IOException goes away and the client appears to function? -Jake > On Apr 17, 2020, at 1:12 AM, Jakov Varenina wrote: > > Hi Jacob, > > Thanks for your response! > > Regarding GEODE-7944, "Unable to deserialize *membership id* > j

Re: [PROPOSAL]: GEODE-7940 to support/1.12

2020-04-17 Thread Joris Melchior
Sounds like something we should include. +1 On Fri, Apr 17, 2020 at 4:41 AM Ju@N wrote: > Hello devs, > > I'd like to propose bringing *GEODE-7940 [1]* to the *support/1.12* branch. > The bug is not new, seems quite old actually, but still seems pretty > critical as it can lead to data loss in

Re: [PROPOSAL]: GEODE-7940 to support/1.12

2020-04-17 Thread Ju@N
Sounds good Owen, thanks!. On Fri, 17 Apr 2020 at 09:50, Owen Nichols wrote: > Hi Juan, this looks like a great fix and definitely meets the “critical > fix" standard. Also thanks for the detailed description. > > I noticed it was just merged to develop very recently. I would like to > see tha

Re: [PROPOSAL]: GEODE-7940 to support/1.12

2020-04-17 Thread Owen Nichols
Hi Juan, this looks like a great fix and definitely meets the “critical fix" standard. Also thanks for the detailed description. I noticed it was just merged to develop very recently. I would like to see that it gets through all tests and spends a couple days on develop, then I will be happy

[PROPOSAL]: GEODE-7940 to support/1.12

2020-04-17 Thread Ju@N
Hello devs, I'd like to propose bringing *GEODE-7940 [1]* to the *support/1.12* branch. The bug is not new, seems quite old actually, but still seems pretty critical as it can lead to data loss in WAN topologies. Long story short: when there are multiple parallel *gateway-senders* attached to the

Re: Unable to get behavior described in documentation when using durable native client

2020-04-17 Thread Jakov Varenina
Hi Jacob, Thanks for your response! Regarding GEODE-7944, "Unable to deserialize *membership id* java.io.EOFException" is not logged but thrown, and it breaks processing of QueueConnectionRequest in locator. This reflects in native client with "No locators found" even though they are availabl