Odg: Odg: disable statistic archival

2020-01-23 Thread Mario Kevo
Hi Kirk, In DistributionConfig we have setStatisticArchiveFile() which is implemented in DistributionConfigImpl and RuntimeDistributionConfigImpl. There you can see when it read properties from properties file if statistic-archive-file is null then it writes an empty file: public void setStat

Re: Request for Docker Hub permissions

2020-01-23 Thread Owen Nichols
You should have access now. Thanks for stepping up as apprentice release manager with Ernie, and perhaps as a release manager in the future. > On Jan 21, 2020, at 2:37 PM, Dave Barnes wrote: > > Please grant me permission to upload Apache Geode artifacts to Docker hub > using my ID: dbarnes97.

Re: Old geode-benchmark PRs

2020-01-23 Thread Jacob Barrett
Why not just leave the PR open then? > On Jan 23, 2020, at 9:52 AM, Robert Houghton wrote: > > @Alberto I like this idea. The link between Jira and the GitHub PR will be > a nice breadcrumb to follow going forward as well, assuming the PRs are > correctly labeled for cross-linking to occur. > >

Re: Odg: disable statistic archival

2020-01-23 Thread Kirk Lund
I hadn't thought of this usage before, but it makes sense. If you want stats showing up on MBeans and/or in Micrometer, then setting --statistic-archive-file="" is probably the correct way to do it. It's possible that ServerLauncher or something deeper is setting --statistic-archive-file to a non-e

Re: Old geode-benchmark PRs

2020-01-23 Thread Robert Houghton
@Alberto I like this idea. The link between Jira and the GitHub PR will be a nice breadcrumb to follow going forward as well, assuming the PRs are correctly labeled for cross-linking to occur. On Thu, Jan 23, 2020 at 8:05 AM Alberto Bustamante Reyes wrote: > What about closing the PRs and creat

RE: Old geode-benchmark PRs

2020-01-23 Thread Alberto Bustamante Reyes
What about closing the PRs and creating a Jira ticket (or tickets) for the review and update of the code? If someone finds time to spend on benchmarks, at least he/she will find the tickets in Jira. De: Donal Evans Enviado: jueves, 23 de enero de 2020 16:45 Par

Re: Old geode-benchmark PRs

2020-01-23 Thread Donal Evans
@Alexander, I haven't looked at them in months and they never received any formal review on GitHub, so it's hard to know for sure if they're ready to merge or not, but as Jake said, they probably need some massaging to get the resource usage just right and minimize variance. If at this point there'

Re: Old geode-benchmark PRs

2020-01-23 Thread Alexander Murmann
Donal, are you still looking at these? If they aren't ready to merge and not being worked on, should they be closed? On Wed, Jan 22, 2020 at 3:32 PM Donal Evans wrote: > Two of those PRs are mine, so perhaps I can give a bit of context for > people who might look at them. The oldest of the two,

Odg: Odg: disable statistic archival

2020-01-23 Thread Mario Kevo
Yes, it works with redirecting to /dev/null. Do we need to document to use this to disable file, or just use this as a workaround and continue with adding new flag? Šalje: Owen Nichols Poslano: 23. siječnja 2020. 8:49 Prima: dev@geode.apache.org Predmet: Re: Odg