Yup. I am a little annoyed at myself about that..
Thanks for the reminder though.
Mark
> On Nov 5, 2019, at 11:48 AM, Owen Nichols wrote:
>
> +1
>
> When merging a PR from GitHub, if the green button does not already say
> “Squash and merge”, click the little triangle and select “Squash and
+1
When merging a PR from GitHub, if the green button does not already say “Squash
and merge”, click the little triangle and select “Squash and merge”.
In addition to all the reasons already listed in this thread, it make reverts a
lot cleaner too.
> On Oct 28, 2019, at 12:47 PM, Jacob Barrett
+1 for bringing this fix to release/1.11.0 (after it has passed Benchmarks on
develop)
> On Nov 5, 2019, at 10:45 AM, Bruce Schuchardt wrote:
>
> The PR for GEODE-6661 introduced a problem in SSL communications that needs
> to be fixed. It changed SSL handshakes to use a temporary buffer that
The PR for GEODE-6661 introduced a problem in SSL communications that
needs to be fixed. It changed SSL handshakes to use a temporary buffer
that's discarded when the handshake completes, but sometimes this buffer
contains application data that must be retained. This seems to be
causing our B
Hi Alberto,
Rebasing and merging your fix broke the build. I am going to revert it. Once
you resolve the issues. we can remerge it.
Thanks,
Mark
> On Nov 5, 2019, at 9:06 AM, Alberto Gomez wrote:
>
> Hi,
>
> Any volunteer to merge this PR that has already been approved?
>
> Thanks,
>
> /A
I took care of it.
Best regards,
Mark
> On Oct 28, 2019, at 8:05 AM, Alberto Gomez wrote:
>
> Hi,
>
> Could I ask for a review on https://github.com/apache/geode/pull/4204?
>
> This PR is about GEODE-7157:
> (https://jira.apache.org/jira/browse/GEODE-7157).
>
> Thanks,
>
> /Alberto G.
>
>
Some replies, inline:
* During testing we have observed, different behavior in parallel and
> serial gateway senders. In case we manually stop, than start gateway
> senders, for parallel gateway senders, queue is purged, but for serial
> gateway senders this is not the case. Is this normal beh
Hi,
Any volunteer to merge this PR that has already been approved?
Thanks,
/Alberto G.
On 28/10/19 16:05, Alberto Gómez wrote:
> Hi,
>
> Could I ask for a review on https://github.com/apache/geode/pull/4204?
>
> This PR is about GEODE-7157:
> (https://jira.apache.org/jira/browse/GEODE-7157).
>
