Re: [PSA] Github branch protection

2019-10-25 Thread Owen Nichols
I’d love to know what is our *current* process before discussing changing it. Is there a link, or are new folks expected to read through every email from the past 5 years to establish context? > On Oct 25, 2019, at 11:49 AM, Kirk Lund wrote: > > We've been operating under a different process

Re: [PSA] Github branch protection

2019-10-25 Thread Kirk Lund
We've been operating under a different process than what you are quoting -- I'm not saying that our current process is correct (or even wrong), however it has been different than the quoted process in some ways. We previously reached consensus for our own process during the first couple years of t

Re: [PSA] Github branch protection

2019-10-25 Thread Owen Nichols
Successful Apache projects value a broad and collaborative community over the details of the code itself. I don’t think the goal is to hammer out rules like “you can’t merge if someone has requested changes” or “anyone has the right to overrule someone’s request for changes”. Think of “reque

Re: [PSA] Github branch protection

2019-10-25 Thread Aaron Lindsey
@Owen I'm fine with following the "requesting changes is the same as -1" rule, but I don't think there is consensus from the whole community on this yet. I was previously told that contributors should make every effort to address the requested changes, but unless a committer actually comments "-1"