I like the idea especially if its only for compile/test time and doesn't
make it into the binary bits.
On Fri, Jun 21, 2019 at 1:04 PM Udo Kohlmeyer wrote:
> Thank you for the response...
>
> #1 - But isn't cyclical package dependent code not a smell and practice,
> whilst at the same time and u
Of equal importance to uni-directional dependencies in a "modular" design
is, classes in package A should not refer directly to classes in package B
when A depends on B, or alternately, when module A depends on module B.
All interactions are only ever through interfaces and all implementations
are
Thank you for the response...
#1 - But isn't cyclical package dependent code not a smell and practice,
whilst at the same time and uni-directional dependency is preferred.
Soo... I think I see the benefit to be more, that ArchUnit allows the
untangling of code into a modular way WITHOUT a big
Two things come to mind:
1) uni-directional dependency
Packages can be dependent on each other, because the classes inside of them can
use each other. e.g.let’s say package A has class A1 and class A2 and
package B has class B1 and B2. A1 can depend on B1, and B2 can depend on A2.
Hence, t
I know that I'm missing the benefit of physically moving the code from
the package into its own module.
Could you possibly explain to me what it is?
On 6/21/19 07:37, Murtuza Boxwala wrote:
I think that’s a really clever way to increment toward splitting geode-core
into more modules. I am exc
I briefly broke compile on develop with a bungled PR merge. I broke a
constructor in DistributionStats because of a conflict during merge. It's
fixed now.
We need some additional PR reviewers on the following PRs. I've tagged who
I think should review them but it's just a suggestion (or guess in some
cases). Please feel free to review anything you're not tagged on as well.
Some of these just need to be *re*-reviewed after requested changes have
been
Hello Dan,
Thanks a lot for the feedback!. Please find my answers below.
(1). Great point, I totally missed this one... I wrongly assumed that *this
particular method [1]* was in charge of authorizing the query execution on
the region but I was clearly wrong, the actual authorization happens *her
I think that’s a really clever way to increment toward splitting geode-core
into more modules. I am excited to see what it looks like 👍
> On Jun 20, 2019, at 7:45 PM, Jacob Barrett wrote:
>
> Gotcha! Sounds good.
>
>> On Jun 20, 2019, at 4:35 PM, Dan Smith wrote:
>>
>> We don't have a member
