Apache Geode 1.10 release

Hi all, I saw that on Wiki pages is not updated when should be next Geode release? Does anyone know when it is planned? Thanks in advance, Mario

Re: Confluence access

Done! You should have access now. Thanks, -Dan On Tue, Jun 18, 2019 at 4:03 PM Murtuza Boxwala wrote: > Can I get access to the confluence wiki, please? > > Email: mboxw...@pivotal.io > Username: mboxwala

Confluence access

Can I get access to the confluence wiki, please? Email: mboxw...@pivotal.io Username: mboxwala

Re: Unnecessary uses of final on local variables

I recommend: * Use final if you want to * Don’t -1 someone’s PR because they did or didn’t use final. Personally, there is one case where I like to use final on a local variable: forcing the compiler to tell me if I’ve covered all code paths. Here’s a very simple example: final int x; if (con

Re: Unnecessary uses of final on local variables

+1 to everything Bill said +1 to what Anthony recommended I think that we in many cases we should not confuse scope with variable reassignment. And we should not confuse variable reassignment with methods that affect change of a local object. Stateful objects don't have to be immutable and

Re: Unnecessary uses of final on local variables

What does "rough consensus"[1] look like on this thread? How do we make a decision and close it out? Kirk suggested an idea, there’s been a couple days of feedback, so we can: 1) reject the proposal and commit to using final ‘everywhere' 2) accept the proposal and use final very sparingly 3) con

Re: Unnecessary uses of final on local variables

I agree with Murtuza, most finals on local variables and method parameters are just noise to me. I only use "final" on these two situations: 1. to declare public static constants of immutable types (e.g. String, Integer) 2. to prevent children from overriding a method. But thought I can't offer an

Re: Unnecessary uses of final on local variables

I’ll offer this alternative: perhaps shorter method bodies obviate the need for explicit final vars. Anthony > On Jun 18, 2019, at 10:30 AM, Ernest Burghardt wrote: > > +1 to auto-enforcement (if possible) post-consensus > > On Tue, Jun 18, 2019 at 8:33 AM Murtuza Boxwala wrote: > >> fina

Re: Unnecessary uses of final on local variables

+1 to auto-enforcement (if possible) post-consensus On Tue, Jun 18, 2019 at 8:33 AM Murtuza Boxwala wrote: > final in Java does not guarantee immutability. It would be AWESOME if it > did but all it guarantees is that the variable cannot be reassigned. In > most cases the variable points to an

Re: Disk dir size units in javadoc comments

I think the comment is correct, but what that test is doing is weird. I see it's setting this property, which leads be to believe that there is some code that changes the units based on this property. DirectoryHolder.SET_DIRECTORY_SIZE_IN_BYTES_FOR_TESTING_PURPOSES = true; Maybe a better change w

Disk dir size units in javadoc comments

Hi all, I have observed that in the javadoc comments of setDiskDirsAndSizes method in DiskStoreFactory class, it is stated that dir sizes are expected to be in megabytes: /** * Sets the directories to which this disk store's data is written and also set the sizes in * megabytes of eac

Re: Unnecessary uses of final on local variables

final in Java does not guarantee immutability. It would be AWESOME if it did but all it guarantees is that the variable cannot be reassigned. In most cases the variable points to an object’s location (memory address), so you can still call methods on it, e.g. final var = new Foo(); var.mutateS

Review of pull request associated with GEODE-6798

Hi, Could someone review the following PR: https://github.com/apache/geode/pull/3710? Thanks in advance, Alberto