Re: [DISCUSS] is it time to make Windows tests gating?

2019-05-15 Thread Robert Houghton
They are also as red as the day is long... On Wed, May 15, 2019, 18:28 Owen Nichols wrote: > For a very long time we’ve had Windows tests in the main pipeline (hidden > away, not in the default view), but the pipeline proceeds to publish > regardless of whether Windows tests fail or even run at

[DISCUSS] is it time to make Windows tests gating?

2019-05-15 Thread Owen Nichols
For a very long time we’ve had Windows tests in the main pipeline (hidden away, not in the default view), but the pipeline proceeds to publish regardless of whether Windows tests fail or even run at all. Now seems like a good time to review whether to: a) treat Windows tests as first-class tests

[DISCUSS] run Windows tests concurrently with Linux tests in main pipeline

2019-05-15 Thread Owen Nichols
Currently we wait to run the Windows tests for a commit until all the Linux tests have passed. This results in unnecessarily long feedback time to know if a commit passed on Windows. The only benefit of staggering is a small efficiency in resource usage when a breaking commit is merged to deve

[DISCUSS] reduce PR checks to JDK11 only

2019-05-15 Thread Owen Nichols
Currently every PR commit triggers both JDK8 and JDK11 versions of each test job. I propose that we can eliminate the JDK8 version of each check. In the extremely rare case where a code change breaks on Java 8 but works fine on Java 11, it would still be caught by the main pipeline (just as Wi