Re: Dependency review for release 1.9.0

2019-03-27 Thread Anthony Baker
Sai and I are almost done with updating the LICENSE and NOTICE files. I also noticed that the geode jars are missing the NOTICE file (sorry for the bad pun). Anthony > On Mar 15, 2019, at 11:07 AM, Sai Boorlagadda > wrote: > > I have a PR[1] to include LICENSE and NOTICE changes to develop.

Re: Weird intermittent build error caused by spotlessJava

2019-03-27 Thread Patrick Rhomberg
I suppose that's true, yes -- if the branch is old enough that it predates our work to improve the gradle correctness, then sure, that work isn't there to guarantee correctness of the older build. But if your branch is as recent as the last few months, then Gradle should notice the changes in the

Re: geode-all-bom-1.9.0.jar

2019-03-27 Thread Anthony Baker
Comments below... > On Mar 26, 2019, at 5:09 PM, Robert Houghton wrote: > > A) Geode-all-bom contains the dependency versions for our projects. Got it. I think I’m confused by the name. I expected that a ‘geode-all-bom’ would get me all the geode bits not just a list of dependency versions.