Re: another critical bug: GEODE-6522

2019-03-18 Thread Bruce Schuchardt
The fix has been cherry-picked into release/1.9.0 On 3/18/19 3:11 PM, Bruce Schuchardt wrote: I've pushed the fix for GEODE-6522 to develop.  There are two commits... commit 7e59011c8e3b4fce6a5920af2c6ae82c6b164e7d (HEAD -> develop, origin/develop) Author: Bruce Schuchardt Dat

Re: another critical bug: GEODE-6522

2019-03-18 Thread Bruce Schuchardt
I've pushed the fix for GEODE-6522 to develop.  There are two commits... commit 7e59011c8e3b4fce6a5920af2c6ae82c6b164e7d (HEAD -> develop, origin/develop) Author: Bruce Schuchardt Date:   Mon Mar 18 15:03:12 2019 -0700     GEODE-6522 Server hangs during shutdown after becoming

Re: [DISCUSS] removal of geode-json module

2019-03-18 Thread Bruce Schuchardt
Ah, I missed that exclusion.  After removing it I was able to revert other build.gradle changes and everything seems to be working fine.  Thanks Dan On 3/18/19 11:38 AM, Dan Smith wrote: Huh, it looks like org.skyscreamer.jsonassert.JSONAssert is actually dependent that vaadin artifact anyway,

Re: [DISCUSS] removal of geode-json module

2019-03-18 Thread Dan Smith
Huh, it looks like org.skyscreamer.jsonassert.JSONAssert is actually dependent that vaadin artifact anyway, but we *excluded* it our geode-junit build file! That's why you are getting a runtime error. Maybe just remove the exclusion. >From geode-junit: compile('org.skyscreamer:jsonassert') { ex

re: [DISCUSS] removal of geode-json module

2019-03-18 Thread Bruce Schuchardt
I don't want to spend a lot more time on the removal of the geode-json module.  I'm going to delete it and leave the geode-web-api test dependent on the vaadin implementation of org.json. I still haven't been able to run the geode-pulse uiTests.  I'm going to leave that module dependent on the

another critical bug: GEODE-6522

2019-03-18 Thread Bruce Schuchardt
I'd like to get the fix for GEODE-6522 into the release.  This is a shutdown issue where a server can hang not realizing that the rest of the cluster has shut down.  This bug isn't in other releases of Geode. https://issues.apache.org/jira/browse/GEODE-6522

Re: [DISCUSS] removal of geode-json module

2019-03-18 Thread Bruce Schuchardt
Hi Udo As I said, org.json is not used in the Geode runtime anymore but there are test dependencies in geode-pulse and geode-web-api. I've removed the dependency in geode-pulse but no-one seems to know how to run those tests so I can't verify that my changes are correct. Geode-web-api (RestA

Re: [DISCUSS] removal of geode-json module

2019-03-18 Thread Bruce Schuchardt
Hi Dan The dependency is through a Spring framework testing package used in RestAccessControllerTest.  Maybe there are others but this is the one I've focused on.  I tried replacing the code comparing JSON documents with Jackson ObjectMapper JsonNode comparisons but it didn't work. java.l

Re: [DISCUSS] removal of geode-json module

2019-03-18 Thread Bruce Schuchardt
Yeah, I saw that it has org.json packaging on github but if you try to use openjson from a maven repo it's packaged as com.github.openjson Downloads> jar -tf ./openjson-1.0.10.jar META-INF/MANIFEST.MF META-INF/ com/ com/github/ com/github/openjson/ META-INF/maven/ META-IN