Re: Loner changes its membership port when starting an acceptor

2019-01-16 Thread Kirk Lund
Ah! I forgot about that (trying to do too many things at once). I'll file a ticket to fix it up. Thanks! On Wed, Jan 16, 2019 at 3:47 PM Bruce Schuchardt wrote: > Hmm, okay but I was looking at this code in MBeanJMXAdapter: > > public static String getMemberNameOrId(DistributedMember member) { >

Re: Loner changes its membership port when starting an acceptor

2019-01-16 Thread Bruce Schuchardt
Hmm, okay but I was looking at this code in MBeanJMXAdapter: public static String getMemberNameOrId(DistributedMember member) { if (member.getName() !=null && !member.getName().equals("")) { return makeCompliantName(member.getName()); } return makeCompliantName(member.getId()); } So if

Re: Loner changes its membership port when starting an acceptor

2019-01-16 Thread Kirk Lund
It's not using toString(). It's just using DistributedMember.getName(). This is implemented by InternalDistributedMember.getName() which delegates to NetMember.getName(). Are you saying we should add a new method to DistributedMember instead of using getName()? The mbeans are categorized a type of

Re: Preventing new build warnings

2019-01-16 Thread Robert Houghton
Would a middle-ground be to add a warning-count check to the pull-request pipeline, which would then be reflected to the GitHub PR? On Tue, Jan 15, 2019 at 2:09 PM Udo Kohlmeyer wrote: > So, to reduce the number of new warnings, are we then going to > standardize on JDK versions? i.e, we only bu