Re: [DISCUSS] Disable merge for failing pull requests

2018-12-26 Thread Kirk Lund
I'm changing my vote to -1 for disallowing merge until precheck passes. The reason is that it's rare for me to see a 100% clean precheckin for any of my PRs. There seems to always be some failure unrelated to my PR. For example PR #3042 just hit GEODE-6008. If we make the change to disable the mer

PR review requests

2018-12-26 Thread Kirk Lund
If anyone is free to review a couple PRs, please take a look at mine: GEODE-3205: Cleanup and reenable DiskSpaceLimitIntegrationTest https://github.com/apache/geode/pull/3035 - basically, the FILE_SIZE_LIMIT_BYTES was too small, resulting in rolling too many - added lots more info in assertion fai