Re: [VOTE] Apache Geode 1.8.0 RC2

2018-12-10 Thread Nabarun Nag
Hi Sai, I tried running the test on the source distribution using IntelliJ and gradle scripts. I have not encountered the failure. Regards Nabarun Nag On Mon, Dec 10, 2018 at 11:20 PM Sai Boorlagadda wrote: > -0 > > - Ran examples > - Building geode from source distribution or release branch co

Re: [VOTE] Apache Geode 1.8.0 RC2

2018-12-10 Thread Sai Boorlagadda
-0 - Ran examples - Building geode from source distribution or release branch consistently fails 1 unit test org.apache.geode.internal.cache.partitioned.rebalance.PartitionedRegionLoadModelJUnitTest > testRedundancySatisfactionPreferRemoteIp FAILED As CI is green on unit tests, I am considering t

Re: [VOTE] Apache Geode 1.8.0 RC2

2018-12-10 Thread Jacob Barrett
-0 I don’t think a user should have to specify a version when building the source release of geode-native. If you don’t specify a version it defaults to the development version of 0.0.42. It should probably default to the source release version. Outside of that issue the native sources build a

Re: [VOTE] Apache Geode 1.8.0 RC2

2018-12-10 Thread Dan Smith
-0. Code looks good to me and it passes geode-release-check. But I'd really like to see some people who have worked on the native code sign off on this release. We haven't released the native code before, and I don't know how to validate it other than just to see that it compiles, which doesn't sa

Re: [VOTE] Apache Geode 1.8.0 RC2

2018-12-10 Thread Ryan McMahon
+1 - Ran all examples - Ran gfsh, created region, performed basic entry operations - Verified SHAs - Verified signatures Ryan On Mon, Dec 10, 2018 at 4:01 PM Alexander Murmann wrote: > A reminder for everyone that the vote is scheduled to end tonight. Please > verify and vote! > > @Galen I'll

Re: [VOTE] Apache Geode 1.8.0 RC2

2018-12-10 Thread Alexander Murmann
A reminder for everyone that the vote is scheduled to end tonight. Please verify and vote! @Galen I'll take a look and fix the handwritten note.

Re: [VOTE] Apache Geode 1.8.0 RC2

2018-12-10 Thread Galen O'Sullivan
>From the release notes: > ConfigurationProperties.ssl-enabled-components supports `none` option as advertised. This is incorrect. The fix for GEODE-5830 was to remove "none" as an option. Signatures and digests look good, gfsh works. Speaking of verifying commits, does it make sense to sign rele

JMH performance help regarding InternalDataSerializer.basicReadObject

2018-12-10 Thread Udo Kohlmeyer
Hi there Geode Devs, I have a problem that needs some input... In bb87f20a2317bb40e2218ec11d467591 I refactored InternalDataSerializer

Geode Open PR's

2018-12-10 Thread Udo Kohlmeyer
Hi fellow Geode devs. For all those that have PR's that have not yet be closed/merged, could you please attend to them. This is ONLY if one is not actively working on the tickets in question. 26 open PR's look a little excessive to me. If there are some that require reviews, please respond t