Re: [DISCUSS] Geode packages mustn't span Jigsaw modules

2018-11-19 Thread Dan Smith
I think we can actually fix most of these issues without geode-2.0. Most of these are in internal packages, which means we can change the package of these classes without breaking users. The only concerning one is org.apache.geode.cache.util, which is a public package. However, the AutoBalancer is

[DISCUSS] Geode packages mustn't span Jigsaw modules

2018-11-19 Thread Owen Nichols
To package Geode as Java 11 Jigsaw module(s), a major hurdle is the requirement that packages cannot be split across modules. If we simply map existing Geode jars to Modules, we have about 10 split packages (see table below). Any restructuring would potentially have to wait until Geode 2.0. A

Re: [DISCUSS] Disable merge for failing pull requests

2018-11-19 Thread Udo Kohlmeyer
I don't believe "name and shame" is a hammer we should wield, but if we have use it... use it wisely Could one not configure the button that the owner of the PR cannot merge the PR? --Udo On 11/19/18 16:03, Dan Smith wrote: Closing the loop on this thread - I don't feel like there was enou

Re: [DISCUSS] Disable merge for failing pull requests

2018-11-19 Thread Dan Smith
Closing the loop on this thread - I don't feel like there was enough agreement to go forwards with disabling the merge button, so I'm going to drop this for now. I would like to see everyone make sure that they only merge green PRs. Maybe we can go with a name and shame approach? As in, we shouldn

Re: [DISCUSS] - Create new repository for geode benchmarks

2018-11-19 Thread Dan Smith
Seems like there is enough consensus. I will go ahead and create the repo. Thanks! -Dan On Fri, Nov 16, 2018 at 1:37 PM Kirk Lund wrote: > +1 total agreement then! > > On Fri, Nov 16, 2018 at 10:05 AM Dan Smith wrote: > > > Hi Kirk, > > > > What we're thinking of putting in geode-benchmarks ar

Re: Release 1.8.0 pipeline issue

2018-11-19 Thread Helena Bales
The change Owen mentioned has been merged to develop and release/1.8.0. On Thu, Nov 15, 2018 at 4:35 PM Owen Nichols wrote: > https://github.com/apache/geode/pull/2865 < > https://github.com/apache/geode/pull/2865> fixes this. Patrick or Helena > will take point on getting it reviewed and merge

Re: Jira write access

2018-11-19 Thread Robert Houghton
Thanks On Nov 19, 2018 15:07, "Dan Smith" wrote: Ok, you should have access now. -Dan On Mon, Nov 19, 2018 at 3:03 PM Robert Houghton wrote: > rhoughton > > On Mon, Nov 19, 2018 at 2:54 PM Dan Smith wrote: > > > What's your jira user name? > > > > -Dan > > > > On Mon, Nov 19, 2018 at 1:39

Re: Jira write access

2018-11-19 Thread Dan Smith
Ok, you should have access now. -Dan On Mon, Nov 19, 2018 at 3:03 PM Robert Houghton wrote: > rhoughton > > On Mon, Nov 19, 2018 at 2:54 PM Dan Smith wrote: > > > What's your jira user name? > > > > -Dan > > > > On Mon, Nov 19, 2018 at 1:39 PM Robert Houghton > > wrote: > > > > > Hi all. I ha

Re: Jira write access

2018-11-19 Thread Robert Houghton
rhoughton On Mon, Nov 19, 2018 at 2:54 PM Dan Smith wrote: > What's your jira user name? > > -Dan > > On Mon, Nov 19, 2018 at 1:39 PM Robert Houghton > wrote: > > > Hi all. I have a few opened Geode JIRA issues that I would like to be > able > > to delegate and work on, but I don't have access

Re: Jira write access

2018-11-19 Thread Dan Smith
What's your jira user name? -Dan On Mon, Nov 19, 2018 at 1:39 PM Robert Houghton wrote: > Hi all. I have a few opened Geode JIRA issues that I would like to be able > to delegate and work on, but I don't have access to the 'assign' or > 'resolve' actions. Can I get access? > > Thank you, > -Rob

Jira write access

2018-11-19 Thread Robert Houghton
Hi all. I have a few opened Geode JIRA issues that I would like to be able to delegate and work on, but I don't have access to the 'assign' or 'resolve' actions. Can I get access? Thank you, -Robert Houghton

Re: Questions about Poms and Publishing

2018-11-19 Thread Anthony Baker
Thanks for the helpful pointers Andy! Anthony > On Nov 19, 2018, at 2:14 AM, Andy Wilkinson wrote: > > IMO, dependency constraints that are available in Gradle 4 are not a > substitute for the dependency management plugin. However, it may be that > the improved pom support that's coming in Gra

Re: Questions about Poms and Publishing

2018-11-19 Thread Andy Wilkinson
IMO, dependency constraints that are available in Gradle 4 are not a substitute for the dependency management plugin. However, it may be that the improved pom support that's coming in Gradle 5.0 could be. It depends on your specific needs. There's as an open issue