Re: Pull request precheckin not firing automatically

2018-10-30 Thread Kirk Lund
Nevermind. I pushed again and it seems to have triggered this time. On Tue, Oct 30, 2018 at 2:51 PM, Kirk Lund wrote: > I have a PR that I updated a while ago, but it's not automatically firing > a precheckin. > > What's the expected behavior? Is it supposed to automatically trigger a > precheck

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #1086 was SUCCESSFUL (with 2457 tests)

2018-10-30 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #1086 was successful. --- Scheduled 2459 tests in total. https://build.spring.io/browse/SGF-NAG-1086/ -- Thi

Pull request precheckin not firing automatically

2018-10-30 Thread Kirk Lund
I have a PR that I updated a while ago, but it's not automatically firing a precheckin. What's the expected behavior? Is it supposed to automatically trigger a precheckin if I push more changes? Here's my PR: https://github.com/apache/geode/pull/2730 PS: the PR isn't ready to actually merge, it'

Re: Geode Native & Apache Geode 1.8 Release

2018-10-30 Thread Dave Barnes
unix_index.html and win_index.html cannot simply be removed, as they're referenced by Cmake. I created a ticket to address this: https://issues.apache.org/jira/browse/GEODE-5958. On Tue, Oct 30, 2018 at 11:48 AM Dave Barnes wrote: > Re: the docs links mentioned in Anthony's message: > > docs/REA

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #1085 was SUCCESSFUL (with 2457 tests). Change made by Mark Paluch.

2018-10-30 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #1085 was successful (rerun once). --- This build was rerun by John Blum. 2459 tests in total. https://build.spri

Re: Geode Native & Apache Geode 1.8 Release

2018-10-30 Thread Dave Barnes
Re: the docs links mentioned in Anthony's message: docs/README.md - the reference to the Geode CONTRIBUTE.md file is useful. I think we can assume that a user of the geode-native API will have a Geode installation, too. docs/api/unix_index.html and docs/api/win_index.html - These files (and their

Re: Geode Native & Apache Geode 1.8 Release

2018-10-30 Thread Anthony Baker
I ran rat manually and got this: Files with unapproved licenses: /geode/.cpackignore /geode/.lcovrc /geode/clicache/src/native_shared_ptr.hpp /geode/templates/security/CMakeLists.txt.forInstall Shouldn’t these failures be causing travis to fail? Many of the files rat that marks as binar