Re: Need gradle help

The concatenation is missing a : in front of the test-jar. > On Sep 14, 2018, at 4:10 PM, Kirk Lund wrote: > > Log4j2 publishes a test jar for log4j-core. The jar includes useful things > like LoggerContextRule. > > This blog post shows how to add the dependency for testing to maven: > https://

Need gradle help

Log4j2 publishes a test jar for log4j-core. The jar includes useful things like LoggerContextRule. This blog post shows how to add the dependency for testing to maven: https://relentlesscoding.com/2018/04/21/unit-test-log4j2-log-output/ This results look like this: org.apache.logging.log4j

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #1040 was SUCCESSFUL (with 2456 tests)

--- Spring Data GemFire > Nightly-ApacheGeode > #1040 was successful. --- Scheduled 2458 tests in total. https://build.spring.io/browse/SGF-NAG-1040/ -- Thi

Re: [discuss] Should we evaluate at commit messages as part of PR review?

While the wiki links to the great article, I wonder if it would make sense to explicitly call out the parts that we most care about in the wiki itself, especially if we end up agreeing that not meeting some criteria might result in a rejected PR. To me those would be violating the format and not in

Re: [discuss] Should we evaluate at commit messages as part of PR review?

Correction! The wiki page does have a link to *https://chris.beams.io/posts/git-commit/ *at the bottom of the page: How to write a Git commit message On Fri, Sep 14, 2018 at 3:05 PM, Kirk Lund wrote: > *The co

Re: [discuss] Should we evaluate at commit messages as part of PR review?

*The commit message should follow imperative style.* The wiki page seems to be missing this even though we agreed to it several times on the dev-list over the last 3 years. I'll add this to the wiki page. You can then say *"If I apply this commit, then it will..."* for any of the git commits. For

Re: [VOTE] Apache Geode 1.7.0 RC1

Correction : Please note that we are voting upon the source tags: rel/v1.7.0.RC1 On Fri, Sep 14, 2018 at 2:49 PM Nabarun Nag wrote: > This is the first release candidate for Apache Geode, version 1.7.0. > Thanks to all the community members for their contributions to this > release! > > Please d

[VOTE] Apache Geode 1.7.0 RC1

This is the first release candidate for Apache Geode, version 1.7.0. Thanks to all the community members for their contributions to this release! Please do review and give your feedback. It resolves 351 issues on Apache Geode JIRA system. Release notes can be found at: https://cwiki.apache.org/co

Errored: apache/geode-examples#265 (rel/v1.7.0.RC1 - 9dca29c)

Build Update for apache/geode-examples - Build: #265 Status: Errored Duration: 1 min and 35 secs Commit: 9dca29c (rel/v1.7.0.RC1) Author: nabarun Message: Version numbers updated to 1.7.0 View the changeset: https://github.com/apache/geode-examples/compare/re

Re: [discuss] Should we evaluate at commit messages as part of PR review?

I do find it very helpful to have the ticket number at the beginning of the title. It makes it really easy to scan the output of `git log --oneline` or GitX to see what tickets happened recently or since a certain tag. On Fri, Sep 14, 2018 at 11:55 AM, Bradford Boyle wrote: > How would people fe

Re: [discuss] Should we evaluate at commit messages as part of PR review?

-1 on removing the JIRA ticket number from the summary line. I believe that it is a vital piece of the comment, and putting it upfront enforces that all work is committed with a corresponding JIRA. I'm on the fence when it comes to the whole "let's put a lot more information into the git comm

Re: [discuss] Should we evaluate at commit messages as part of PR review?

How would people feel about removing the requirement to include the "GEODE-: " prefix in the summary line? That accounts for about 25% of the 52 character limit. We could move it to the first non-summary line of the commit message. --Bradford

Re: Write permission on cwiki

Granted! -Dan On Fri, Sep 14, 2018 at 1:05 AM, Nabarun Nag wrote: > Requesting write permissions on geode wiki page to update the release docs > for 1.7.0RC1 > username: nnag > name: nabarun > > Regards > Nabarun Nag >

Write permission on cwiki

Requesting write permissions on geode wiki page to update the release docs for 1.7.0RC1 username: nnag name: nabarun Regards Nabarun Nag