[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #739 was SUCCESSFUL (with 2187 tests)

2017-11-17 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #739 was successful. --- Scheduled 2189 tests in total. https://build.spring.io/browse/SGF-NAG-739/ -- This

Re: [DISCUSS] changes to registerInterest API

2017-11-17 Thread Jason Huynh
Thanks John for the clarification! On Fri, Nov 17, 2017 at 1:12 PM John Blum wrote: > This... > > > The Iterable version would handle any collection type by having the user > pass > in the iterator for the collection. > > Is not correct. > > The Collection interface itself "extends" the java.lan

Re: [DISCUSS] changes to registerInterest API

2017-11-17 Thread John Blum
This... > The Iterable version would handle any collection type by having the user pass in the iterator for the collection. Is not correct. The Collection interface itself "extends" the java.lang.Iterable interface (see here... https://docs.oracle.com/javase/8/docs/api/java/util/Collection.html

Re: [Discussion] Geode-Native Removing Stats from Public API

2017-11-17 Thread David Kimura
I agree, a statistics interface seems beyond the scope of Geode Native client responsibility. Hiding or removing seems appropriate to me. Thanks, David On Fri, Nov 17, 2017 at 11:29 AM, Ernest Burghardt wrote: > +1 for removal > > On Thu, Nov 16, 2017 at 1:46 PM, Jacob Barrett wrote: > >> I wa

Re: [DISCUSS] changes to registerInterest API

2017-11-17 Thread Jason Huynh
Current idea is to: - deprecate current "ALL_KEYS" and List passing behavior in registerInterest() - add registerInterestAllKeys(); - add registerInterest(T... keys) and registerInterest(Iterablekeys) and not have one specifically for List or specific collections. The Iterable version would handle

Re: [DISCUSS] changes to registerInterest API

2017-11-17 Thread Jacob Barrett
I am failing to see where registerInterest(List keys) is an issue for the key type in the region. If our region is Region then I would expect registerInterest(List). If the keys are unknown or a mix then you should have Region and thus registerInterest(List. Also, List does not restrict you from L

Re: [Discussion] Geode-Native Removing Stats from Public API

2017-11-17 Thread Ernest Burghardt
+1 for removal On Thu, Nov 16, 2017 at 1:46 PM, Jacob Barrett wrote: > I want to open a discussion regarding the removal of StatisticsFactory and > related APIs from the public API. I can't see that we would want the Geode > Native client to be a first class statistics/metrics gathering API. The

Re: [DISCUSS] changes to registerInterest API

2017-11-17 Thread John Blum
Personally, I prefer the var args method (registerInterest(T... keys)) myself. It is way more convenient if I only have a few keys when calling this method then to have to add the keys to a List, especially for testing purposes. But, I typically like to pair that with a registerInterest(Iterable

Re: [DISCUSS] changes to registerInterest API

2017-11-17 Thread Jason Huynh
Hi Mike, The current support for List leads to compilation issues if the region is type constrained. However I think you are suggesting instead of a var args method, instead provide a registerInterest(List keys) method? So far what I am hearing requested is: deprecate current "ALL_KEYS" and List