Re: [Discuss] CliStrings

2017-10-20 Thread Jacob Barrett
Exterminate! > On Oct 20, 2017, at 3:47 PM, Kenneth Howe wrote: > > +1 for removing both CliStrings and LocalizedStrings > >> On Oct 20, 2017, at 2:28 PM, Jinmei Liao wrote: >> >> +1 for removing it. >> >>> On Fri, Oct 20, 2017 at 2:04 PM, Jared Stewart wrote: >>> >>> On Oct 20, 2017

Native client examples

2017-10-20 Thread Dan Smith
Hi, I noticed some C# examples showed up in the geode-examples project. Awesome! However I do think we should be compiling (and hopefully running!) these examples so that they don't rot over time. Especially since I believe we are still evolving the native API with breaking changes and have not a

Build failed in Jenkins: Geode-release #97

2017-10-20 Thread Apache Jenkins Server
See -- [...truncated 7.80 MB...] at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35) at org.gradle.internal.dispatch.ReflectionDispatch.di

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #715 was SUCCESSFUL (with 2182 tests)

2017-10-20 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #715 was successful. --- Scheduled 2184 tests in total. https://build.spring.io/browse/SGF-NAG-715/ -- This

Re: [Discuss] CliStrings

2017-10-20 Thread Kenneth Howe
+1 for removing both CliStrings and LocalizedStrings > On Oct 20, 2017, at 2:28 PM, Jinmei Liao wrote: > > +1 for removing it. > > On Fri, Oct 20, 2017 at 2:04 PM, Jared Stewart wrote: > >> >>> On Oct 20, 2017, at 1:59 PM, Dan Smith wrote: >>> >>> +1 for removing it. >>> >>> I do think it

Re: [Discuss] CliStrings

2017-10-20 Thread Jinmei Liao
+1 for removing it. On Fri, Oct 20, 2017 at 2:04 PM, Jared Stewart wrote: > > > On Oct 20, 2017, at 1:59 PM, Dan Smith wrote: > > > > +1 for removing it. > > > > I do think it would be nice if we add localization in the future. But > > I don't really like the idea of leaving stuff in our code j

Re: [VOTE] Apache Geode release - 1.3.0 RC3

2017-10-20 Thread Swapnil Bawaskar
The commit sha in the vote request should be: 59f2a73d108101744ed7b2d88e8d1c 948d19781c Sorry I forgot to update it for the latest release candidate. Also, I ended up dropping and then re-adding all distributions https://dist.apache.org/repos/dist/dev/geode/1.3.0.RC3 Can you please give this anoth

Re: [Discuss] CliStrings

2017-10-20 Thread Jared Stewart
> On Oct 20, 2017, at 1:59 PM, Dan Smith wrote: > > +1 for removing it. > > I do think it would be nice if we add localization in the future. But > I don't really like the idea of leaving stuff in our code just in case > we decide to implement a feature in the future - we might not even > want

Re: [Discuss] CliStrings

2017-10-20 Thread Michael William Dodge
+1 for removing it based on Dan's reasoning. Sarge > On 20 Oct, 2017, at 13:59, Dan Smith wrote: > > +1 for removing it. > > I do think it would be nice if we add localization in the future. But > I don't really like the idea of leaving stuff in our code just in case > we decide to implement a

Re: [Discuss] CliStrings

2017-10-20 Thread Dan Smith
+1 for removing it. I do think it would be nice if we add localization in the future. But I don't really like the idea of leaving stuff in our code just in case we decide to implement a feature in the future - we might not even want what we left in there! In this case even with localization we mig

Failed: jinmeiliao/geode#50 (parseResult - 0c13b33)

2017-10-20 Thread Travis CI
Build Update for jinmeiliao/geode - Build: #50 Status: Failed Duration: 15 minutes and 15 seconds Commit: 0c13b33 (parseResult) Author: Jinmei Liao Message: GEODE-1897: refactor GfshParseResult for easy access of converted option value View the changeset: ht

Re: [Discuss] CliStrings

2017-10-20 Thread Anilkumar Gingade
As others mentioned this was done to support localization in the product; this was driven from customer request; mainly from AMEA customers... Now being open source; to build a wider community, Localization may become a key requirement...Having a framework will help community to build on that... -

Re: [Discuss] CliStrings

2017-10-20 Thread Kirk Lund
CliStrings has nothing to do with localization. The original authors of GFSH simply stored all GFSH strings as static final constants in that class. As for LocalizedStrings, it was a non-standard way of doing localization and was abandoned by the development team years ago because it's garbage. Th

Re: [VOTE] Apache Geode release - 1.3.0 RC3

2017-10-20 Thread Anthony Baker
I’m confused about which source tag we are voting on. ~/code/incubator-geode ((rel/v1.3.0.RC3))$ git tag -v rel/v1.3.0.RC3 object 59f2a73d108101744ed7b2d88e8d1c948d19781c type commit tag rel/v1.3.0.RC3 tagger Swapnil Bawaskar 1508355792 +0530 Release candidate 3 for 1.3.0 gpg: Signature made Wed

Build failed in Jenkins: Geode-nightly #990

2017-10-20 Thread Apache Jenkins Server
See Changes: [github] GEODE-3521: Allow region set operations to bootstrap a transaction. [kohlmu-pivotal] GEODE-3739: Refactor protobuf authentication (#922) [kohlmu-pivotal] GEODE-3864: Added protobuf message fil

Build failed in Jenkins: Geode-release #95

2017-10-20 Thread Apache Jenkins Server
See -- [...truncated 149.96 KB...] at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) at sun.reflect.DelegatingConstructorAccesso