Broken: apache/geode#4470 (develop - 2cb5fed)

2017-10-19 Thread Travis CI
Build Update for apache/geode - Build: #4470 Status: Broken Duration: 12 minutes and 24 seconds Commit: 2cb5fed (develop) Author: Barry Oglesby Message: GEODE-3810: Incremented test timestamp by 1 in case it is the same as the previous event View the changese

Re: [Discuss] CliStrings

2017-10-19 Thread Mark Hanson
From my product background, maintaining a single file is often preferred for localization as mentioned by Mike, the big question, I would ask is how important is localization? If localization is important, then keeping a single or few file(s) will dramatically ease the localization process. So f

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #714 was SUCCESSFUL (with 2182 tests)

2017-10-19 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #714 was successful. --- Scheduled 2184 tests in total. https://build.spring.io/browse/SGF-NAG-714/ -- This

Re: [Discuss] CliStrings

2017-10-19 Thread Michael Stolz
I know we did at one time go through the exercise to collect all of the strings and put them in one place and have them translated to at least Japanese. I don't know where the Japanese version of the file is though. -- Mike Stolz Principal Engineer, GemFire Product Lead Mobile: +1-631-835-4771 O

Re: [Discuss] CliStrings

2017-10-19 Thread Bruce Schuchardt
+1 I thought we decided long ago to do this.  We also have LocalizedStrings.java and it looks like some folks are still adding new StringIDs to it as well. On 10/19/17 3:13 PM, Nick Reich wrote: +1 for moving those messages out of CliStrings if at all possible and placing them where they are

Re: [Discuss] CliStrings

2017-10-19 Thread Nick Reich
+1 for moving those messages out of CliStrings if at all possible and placing them where they are used. In my experiences with those strings, I have rarely if ever seen them reused across classes, so they really should belong in the class they are used by. On Thu, Oct 19, 2017 at 3:05 PM, Jared St

Re: [Discuss] CliStrings

2017-10-19 Thread Kirk Lund
I'm all for getting rid of CliStrings. That constant (or the raw string) belongs in CreateRegionCommand instead of in CliStrings. On Thu, Oct 19, 2017 at 3:05 PM, Jared Stewart wrote: > I wanted to kick off a discussion about the usage of CliStrings. For > those unfamiliar, it’s a java class th

[Discuss] CliStrings

2017-10-19 Thread Jared Stewart
I wanted to kick off a discussion about the usage of CliStrings. For those unfamiliar, it’s a java class that contains about ~3000 lines of String constants and has a javadoc explaining that it is an attempt at i18n localization. Does anyone know if this localization is actually implemented in

Re: [VOTE] Apache Geode release - 1.3.0 RC3

2017-10-19 Thread Dick Cavender
Made the config changes to Geode-release and triggered rebuilding last again to confirm. -Dick On Thu, Oct 19, 2017 at 9:53 AM, Dick Cavender wrote: > We'll look at the Jenkins config Dan. > > -Dick > > On Thu, Oct 19, 2017 at 9:03 AM, Dan Smith wrote: > >> +1 >> >> Build passed, release check

Commits without Jira tickets

2017-10-19 Thread Kirk Lund
Sorry I keep hitting "rebase and merge" on github instead of squashing PRs. I'm trying to remember to squash them! Because of this you'll see some crappy commits like this which should've been squashed: commit 674d4aed0cabc69e51aec3e3ba815bb170288484 (HEAD -> develop, origin/develop) Author: Kirk

Re: [VOTE] Apache Geode release - 1.3.0 RC3

2017-10-19 Thread Dick Cavender
We'll look at the Jenkins config Dan. -Dick On Thu, Oct 19, 2017 at 9:03 AM, Dan Smith wrote: > +1 > > Build passed, release check passed, examples are present, I don't see us > shipping jars we shouldn't. Looks good to me! > > BTW, even though the actual build passed, the jenkins job failed wi

Build failed in Jenkins: Geode-nightly-flaky #154

2017-10-19 Thread Apache Jenkins Server
See -- [...truncated 110.60 KB...] Download https://repo1.maven.org/maven2/io/swagger/swagger-annotations/1.5.10/swagger-annotations-1.5.10.jar Download https://repo1.maven.org/maven2

Re: [VOTE] Apache Geode release - 1.3.0 RC3

2017-10-19 Thread Dan Smith
+1 Build passed, release check passed, examples are present, I don't see us shipping jars we shouldn't. Looks good to me! BTW, even though the actual build passed, the jenkins job failed with the below error about archiving results. Who has access to fix this? BUILD SUCCESSFUL > > Total time: 15

Build failed in Jenkins: Geode-nightly #989

2017-10-19 Thread Apache Jenkins Server
See Changes: [github] GEODE-2563: fix flaky test (#942) [github] GEODE-3819: correctly set the result status code when building the re… [khowe] GEODE-3299: refactor functions to get Cache from FunctionContext [kho

Build failed in Jenkins: Geode-release #94

2017-10-19 Thread Apache Jenkins Server
See Changes: [jstewart] GEODE-3859: Simplify API for reading output from a GfshScript -- [...truncated 169.33 KB...] :geode-common:build :geode-common:distributedTest :geode-co