[GitHub] geode issue #668: GEODE-3306: Remove whitespace StringBuffers/nodes created ...

Github user darrenfoong commented on the issue: https://github.com/apache/geode/pull/668 Thanks Jared! Will find time to make the changes and get feedback on the mailing list. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] geode pull request #668: GEODE-3306: Remove whitespace StringBuffers/nodes c...

Github user darrenfoong commented on a diff in the pull request: https://github.com/apache/geode/pull/668#discussion_r132833299 --- Diff: geode-core/src/test/java/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.java --- @@ -111,10 +113,31 @@ public void testCacheX

Build failed in Jenkins: Geode-nightly-flaky #89

See Changes: [dschneider] GEODE-3435: Fix serialization test failure -- [...truncated 110.30 KB...] Download https://repo1.maven.org/maven2/com/fasterxml/jackson/module/

Build failed in Jenkins: Geode-nightly #921

See Changes: [klund] GEODE-3413: overhaul launcher and process classes and tests [kmiller] GEODE-3410 Doc update for gfsh query command changes [gzhou] GEODE-3304: when colocated child bucket is destroyed, it shoul

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #645 was SUCCESSFUL (with 2027 tests)

--- Spring Data GemFire > Nightly-ApacheGeode > #645 was successful. --- Scheduled 2029 tests in total. https://build.spring.io/browse/SGF-NAG-645/ -- This

[GitHub] geode pull request #711: GEODE-3436: revert all commands refactorings

GitHub user kirklund opened a pull request: https://github.com/apache/geode/pull/711 GEODE-3436: revert all commands refactorings Revert these commits to return precheckin to GREEN: commit d27f8b956de7d9c5d95ebdc68dfc67ee8b2d7b51 Author: YehEmily Date: Mon Aug 7 1

Re: [DISCUSS] New annotation to identify Functions whose class hierarchy spans multiple jar files

*@Jared*- actually, I should mention that *Spring* too provides other infrastructure support to inspect byte code for certain Annotation meta-data without needed to load classes. Although, *Spring* uses ASM [1] given FCS did not exist at that time. *Spring* definitely needed this from 2.5 and lat

Re: [DISCUSS] New annotation to identify Functions whose class hierarchy spans multiple jar files

*@Jared* - yes, makes sense. Thanks for the reference to FCS. I am familiar with it and I am also aware that Geode is starting to use this in other capacities. *Regarding name...* The one thing I dislike about the name "RegisterFunction" is it implies some action will be performed by Geode (in

Re: Management tests failing on develop

I tried to revert just a few of the commits. That didn't work so now I'm testing a branch where I've reverted all of the commits I pulled in yesterday. Hope to have that ready later this morning. On Fri, Aug 11, 2017 at 8:13 PM, Kirk Lund wrote: > I merged in 16 PRs today and precheckin was clea

Re: []DISCUSS] Using package names to identify public API's

On the flip side of internal vs. external APIs, I definitely feel there are many classes under "*.internal" packages that should be reviewed and made public. I realize it increases the surface area of maintainability and support for backwards compatibility, but anytime an application needs access

Re: Geode Native - All your globals are belong to us

Nice work Jacob and team! On Fri, Aug 11, 2017 at 1:40 PM, Udo Kohlmeyer wrote: > Awesome work!!! > > > On 8/11/17 13:23, Jacob Barrett wrote: > >> In case you missed the big commit recently, the Geode Native components >> has >> removed all globals.* >> >> The biggest win here is that we can mo