[GitHub] geode issue #597: Client protocol with develop, gated by a feature flag.

2017-06-22 Thread galen-pivotal
Github user galen-pivotal commented on the issue: https://github.com/apache/geode/pull/597 Added to excluded-classes.txt, hopefully this fixes it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

Build failed in Jenkins: Geode-nightly #874

2017-06-22 Thread Apache Jenkins Server
See Changes: [jiliao] GEODE-3104 : correct help string to use --include-locators [jiliao] GEODE-2861: Remove dead code [jiliao] GEODE-1958: Working on removing PasswordUtil and all related commands, [nnag] GEODE-2

Re: OQL rewriting

2017-06-22 Thread Jinmei Liao
SecurityManager and the old AccessControl can't work together. The postprocessor is supposed to cover field level security, but due to GEODE-2153, we need to enhance post-processor to include more information (either what field the query is accessing or the entire query string) in order to truly su

[GitHub] geode issue #567: GEODE-3051: Removing obsolete SSL handling in `AcceptorImp...

2017-06-22 Thread WireBaron
Github user WireBaron commented on the issue: https://github.com/apache/geode/pull/567 This work is being handled as part of a larger refactor effort. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] geode pull request #567: GEODE-3051: Removing obsolete SSL handling in `Acce...

2017-06-22 Thread WireBaron
Github user WireBaron closed the pull request at: https://github.com/apache/geode/pull/567 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

Re: Review Request 60348: GEODE-3103: GfshRule no longer clutters output

2017-06-22 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60348/ --- (Updated June 22, 2017, 11:20 p.m.) Review request for geode, Emily Yeh, Jared

Re: OQL rewriting

2017-06-22 Thread Kirk Lund
You cannot use SecurityManager AND AccessControl/Authenticator at the same time. It's either SecurityManager or the old callbacks but not both. The authorizeOperation callback is specific to OperationContext. OperationContext is deprecated in favor of ResourcePermission which reorganizes everythin

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #593 was SUCCESSFUL (with 1868 tests)

2017-06-22 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #593 was successful. --- Scheduled 1870 tests in total. https://build.spring.io/browse/SGF-NAG-593/ -- This

Re: OQL rewriting

2017-06-22 Thread John Blum
We should also keep in mind this may not be possible when using an actual, robust security framework like *Apache Shiro*, or *Shiro* may provide different callbacks/mechanisms/extensions. This should be taken into account in the "solution" since most sensible users will use a well-known, proven se

OQL rewriting

2017-06-22 Thread Michael Stolz
The old security framework had an authorizeOperation method that had enough information to be able to inspect and modify an OQL string before it would be executed. That whole framework is now deprecated, but I feel like it's a really powerful feature being able to modify OQL in such a way as to sup

[GitHub] geode pull request #576: Geode 2920, 2921, 2922, 2924

2017-06-22 Thread pdxrunner
Github user pdxrunner commented on a diff in the pull request: https://github.com/apache/geode/pull/576#discussion_r123578810 --- Diff: geode-core/src/main/java/org/apache/geode/management/CacheServerMXBean.java --- @@ -352,44 +352,44 @@ * * @param clientId ID of t

Re: Review Request 60348: GEODE-3103: GfshRule no longer clutters output

2017-06-22 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60348/#review178703 --- geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gf

Re: Review Request 60106: GEODE-3052 Restarting 2 locators within 1s of each other causes potential locator split brain

2017-06-22 Thread Bruce Schuchardt
> On June 22, 2017, 2:42 a.m., Hitesh Khamesra wrote: > > not sure you saw following commant, as I was having trouble with > > reviewboard. > > > > > > geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/locator/GMSLocator.java > > (Diff revision 2) > > 235 > >

[GitHub] geode issue #597: Client protocol with develop, gated by a feature flag.

2017-06-22 Thread galen-pivotal
Github user galen-pivotal commented on the issue: https://github.com/apache/geode/pull/597 I get the following error when running the full integration test suite: ``` org.apache.geode.codeAnalysis.AnalyzeSerializablesJUnitTest > testSerializables FAILED java.lang.Assert

[GitHub] geode pull request #589: GEODE-393: Providing cache for FunctionContext

2017-06-22 Thread jhuynh1
Github user jhuynh1 commented on a diff in the pull request: https://github.com/apache/geode/pull/589#discussion_r123553740 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/execute/FunctionContextImpl.java --- @@ -37,20 +38,25 @@ private String funct

[GitHub] geode pull request #589: GEODE-393: Providing cache for FunctionContext

2017-06-22 Thread jinmeiliao
Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/geode/pull/589#discussion_r123544960 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/execute/FunctionContextImpl.java --- @@ -37,20 +38,25 @@ private String fu

[GitHub] geode pull request #589: GEODE-393: Providing cache for FunctionContext

2017-06-22 Thread jinmeiliao
Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/geode/pull/589#discussion_r123544587 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/execute/FunctionContextImpl.java --- @@ -37,20 +38,25 @@ private String fu