[GitHub] incubator-geode pull request #298: [GEODE-1122] Fix Dependency on environmen...

2016-11-28 Thread davinash
Github user davinash closed the pull request at: https://github.com/apache/incubator-geode/pull/298 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] incubator-geode pull request #294: Properly close WebDriver for UITests

2016-11-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-geode/pull/294 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] incubator-geode issue #298: [GEODE-1122] Fix Dependency on environment varia...

2016-11-28 Thread davinash
Github user davinash commented on the issue: https://github.com/apache/incubator-geode/pull/298 This closes #298 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wish

[GitHub] incubator-geode pull request #294: Properly close WebDriver for UITests

2016-11-28 Thread jinmeiliao
Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/294#discussion_r89939851 --- Diff: geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/rules/ScreenshotOnFailureRule.java --- @@ -45,7 +45,9 @@ private void take

Re: Global scope regions

2016-11-28 Thread Kirk Lund
We could allow the User to specify either a --type or a combination of --data-policy and --scope but not all three. Apparently the introduction of RegionShortcut (and its use for --type) was supposed to simplify things. AttributesFactory was deprecated in favor of using shortcuts. The shortcuts co

Re: Global scope regions

2016-11-28 Thread Udo Kohlmeyer
I think we need to add --data-policy and --scope to GFSH. --Udo On 11/28/16 15:39, Kirk Lund wrote: Yep, the --type argument in gfsh matches the enum values of org.apache.geode.cache.RegionShortcut which doesn't include any shortcuts for global. On Mon, Nov 28, 2016 at 3:17 PM, Udo Kohlmeyer

Re: Global scope regions

2016-11-28 Thread Kirk Lund
Yep, the --type argument in gfsh matches the enum values of org.apache.geode.cache.RegionShortcut which doesn't include any shortcuts for global. On Mon, Nov 28, 2016 at 3:17 PM, Udo Kohlmeyer wrote: > I think it was never added. I think we keep on favoring shortcuts above > correct configurati

Re: Review Request 53685: GEODE-1955: properly disconnect gfsh session so that it won't leave heartbeat thread around to pollute other tests

2016-11-28 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53685/ --- (Updated Nov. 28, 2016, 11:27 p.m.) Review request for geode, Kevin Duling, Kir

Re: Global scope regions

2016-11-28 Thread Udo Kohlmeyer
I think it was never added. I think we keep on favoring shortcuts above correct configuration properties. --Udo On 11/28/16 15:15, Kirk Lund wrote: Looks like global regions cannot be created using GFSH. We should either add support for global scope to GFSH or remove global scope (and the Reg

Global scope regions

2016-11-28 Thread Kirk Lund
Looks like global regions cannot be created using GFSH. We should either add support for global scope to GFSH or remove global scope (and the RegionLock APIs). Does anyone know if global scope is officially deprecated? Or why it's not supported by GFSH? -Kirk

Re: JavaLaunchHelper warning when starting server

2016-11-28 Thread Udo Kohlmeyer
I think this is a problem with Java... I recall that this is a known issue in Java and nothing to worry about. On 11/28/16 14:02, Kirk Lund wrote: I've started seeing the following intermixed with GFSH output when starting servers on a Mac: objc[16455]: Class JavaLaunchHelper is implemented i

JavaLaunchHelper warning when starting server

2016-11-28 Thread Kirk Lund
I've started seeing the following intermixed with GFSH output when starting servers on a Mac: objc[16455]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.8.0_66.jdk/Contents/Home/jre/bin/java and /Library/Java/JavaVirtualMachines/jdk1.8.0_66.jdk/Contents/Home/

[GitHub] incubator-geode issue #282: GEODE-1740: Inconsistencies with concurrent clea...

2016-11-28 Thread pdxrunner
Github user pdxrunner commented on the issue: https://github.com/apache/incubator-geode/pull/282 This looks good. I'll pull it in as my first commit --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] incubator-geode issue #293: GEODE-1653: Executing a fire-and-forget function...

2016-11-28 Thread kirklund
Github user kirklund commented on the issue: https://github.com/apache/incubator-geode/pull/293 Some additional information on using Awaitility: Use a larger timeout value such as 60 seconds. If you use 1 second, then sometime the test is going to have a false failure when it

[GitHub] incubator-geode issue #283: GEODE-2098: Moved gfsh history file location fro...

2016-11-28 Thread kirklund
Github user kirklund commented on the issue: https://github.com/apache/incubator-geode/pull/283 I tried to pull this in but I get an error message about the branch not existing: fatal: Couldn't find remote ref feature/GEODE-2098 Looks like the pull request is still op

[GitHub] incubator-geode issue #290: GEODE-2092: Security examples should not be in t...

2016-11-28 Thread kjduling
Github user kjduling commented on the issue: https://github.com/apache/incubator-geode/pull/290 Confict fixed. Precheckin running. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] incubator-geode issue #297: GEODE-734: gfsh export stack-traces should not r...

2016-11-28 Thread metatype
Github user metatype commented on the issue: https://github.com/apache/incubator-geode/pull/297 Thanks for the contribution! However, I don't think we should require user input in order to gather stack traces. Quite often a user will automate collection (`gfsh export stack-traces ..

[GitHub] incubator-geode issue #290: GEODE-2092: Security examples should not be in t...

2016-11-28 Thread kjduling
Github user kjduling commented on the issue: https://github.com/apache/incubator-geode/pull/290 Merged in latest develop branch. Precheckin running. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no