[GitHub] incubator-geode pull request #291: [GEODE-1122] Fixed Dependency on environm...

Github user davinash commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/291#discussion_r88781685 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java --- @@ -1493,6 +1495,7 @@ publi

[GitHub] incubator-geode issue #291: [GEODE-1122] Fixed Dependency on environment var...

Github user davinash commented on the issue: https://github.com/apache/incubator-geode/pull/291 Thanks for Review @metatype --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] incubator-geode pull request #291: [GEODE-1122] Fixed Dependency on environm...

Github user davinash commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/291#discussion_r88781680 --- Diff: geode-assembly/src/test/java/org/apache/geode/management/internal/configuration/SharedConfigurationEndToEndDUnitTest.java --- @@ -146,6 +

[GitHub] incubator-geode pull request #291: [GEODE-1122] Fixed Dependency on environm...

Github user davinash commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/291#discussion_r88781673 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/AgentUtil.java --- @@ -52,7 +52,7 @@ public AgentUtil(String gemfireVersion)

Jenkins build is back to normal : Geode-nightly #658

See

[GitHub] incubator-geode pull request #291: [GEODE-1122] Fixed Dependency on environm...

Github user metatype commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/291#discussion_r88781178 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java --- @@ -1493,6 +1495,7 @@ publi

[GitHub] incubator-geode pull request #291: [GEODE-1122] Fixed Dependency on environm...

Github user metatype commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/291#discussion_r88781054 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/AgentUtil.java --- @@ -52,7 +52,7 @@ public AgentUtil(String gemfireVersion)

[GitHub] incubator-geode pull request #291: [GEODE-1122] Fixed Dependency on environm...

Github user metatype commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/291#discussion_r88781162 --- Diff: geode-assembly/src/test/java/org/apache/geode/management/internal/configuration/SharedConfigurationEndToEndDUnitTest.java --- @@ -146,6 +

[GitHub] incubator-geode pull request #291: [GEODE-1122] Fixed Dependency on environm...

GitHub user davinash opened a pull request: https://github.com/apache/incubator-geode/pull/291 [GEODE-1122] Fixed Dependency on environment variable GEMFIRE needs to be removed All Test Passing. You can merge this pull request into a Git repository by running: $ git pull https