Re: Review Request 53867: GEODE-2129 make pdxtype id random(not sequential)

2016-11-17 Thread Vishal Rao
Apologies if this is noise, but wouldn't using the hash code actually increase the likelihood of ID collisions? On Fri, Nov 18, 2016 at 6:11 AM, Hitesh Khamesra wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Review Request 53867: GEODE-2129 make pdxtype id random(not sequential)

2016-11-17 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53867/ --- Review request for geode, Bruce Schuchardt and Udo Kohlmeyer. Repository: geode

[GitHub] incubator-geode issue #288: GEODE-2092 - Security examples should not be in ...

2016-11-17 Thread kjduling
Github user kjduling commented on the issue: https://github.com/apache/incubator-geode/pull/288 I moved the examples in to geode-examples/utils/src/main/java/org/apache/geode/example/security/ so it looks like I misunderstood and jumped the gun. So, I'll undo that, and move them to

Review Request 53865: GEODE-2127 old client support service is not set up to handle arrays

2016-11-17 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53865/ --- Review request for geode, Hitesh Khamesra and Udo Kohlmeyer. Bugs: GEODE-2127

Review Request 53864: GEODE-2121 add DLockTest, MembershipTest, ClientServerTest, ClientSubscriptionTest and RestAPITest categories

2016-11-17 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53864/ --- Review request for geode, Hitesh Khamesra and Udo Kohlmeyer. Bugs: GEODE-2121

[GitHub] incubator-geode pull request #288: GEODE-2092 - Security examples should not...

2016-11-17 Thread kjduling
GitHub user kjduling opened a pull request: https://github.com/apache/incubator-geode/pull/288 GEODE-2092 - Security examples should not be in the product code Moved examples to geode-examples project Copied old Sample/Simple code to test packages as many tests rely on these cla

[GitHub] incubator-geode issue #287: GEODE-2112: Fix UITests failing due to insuffici...

2016-11-17 Thread jaredjstewart
Github user jaredjstewart commented on the issue: https://github.com/apache/incubator-geode/pull/287 Precheckin started --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[GitHub] incubator-geode pull request #287: GEODE-2112: Fix UITests failing due to in...

2016-11-17 Thread jaredjstewart
GitHub user jaredjstewart opened a pull request: https://github.com/apache/incubator-geode/pull/287 GEODE-2112: Fix UITests failing due to insufficient cleanup - Extracted setup of the Server and WebDriver for Pulse tests into JUnit Rules - Refactored UITests - Removed a

Re: Review Request 53857: GEODE-2095: Stabilize flaky tests

2016-11-17 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53857/ --- (Updated Nov. 17, 2016, 10:38 p.m.) Review request for geode, anilkumar gingade

Review Request 53857: GEODE-2095: Stabilize flaky tests

2016-11-17 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53857/ --- Review request for geode. Repository: geode Description --- Changed chec

Re: Review Request 53856: concurse is slower, so we need to wait longer for results

2016-11-17 Thread Jason Huynh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53856/#review156224 --- Should we rename this to IntegrationTest instead of JUnitTest (Not

Re: Review Request 53856: concurse is slower, so we need to wait longer for results

2016-11-17 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53856/#review156223 --- Fix it, then Ship it! geode-core/src/test/java/org/apache/geod

Review Request 53856: concurse is slower, so we need to wait longer for results

2016-11-17 Thread xiaojian zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53856/ --- Review request for geode, Darrel Schneider and Dan Smith. Bugs: geode-2120

Build failed in Jenkins: Geode-nightly #656

2016-11-17 Thread Apache Jenkins Server
See Changes: [adongre] GEODE-2098: Moved gfsh history file location from .gemfire to .geode [bschuchardt] GEODE-2073 CI Failure: [kmiller] GEODE-2114 Revise user and password options to gfsh connect [huynhja] GEODE-2100: Add new version