Re: [dpdk-dev] [PATCH] net/mlx5: fix multiple flow table hash list

2019-12-17 Thread Matan Azrad
flow table hash list conversion") > Cc: sta...@dpdk.org > > Reported-by: Zhike Wang > Signed-off-by: Xiaoyu Min Acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH] net/mlx5: fix item flag on GENEVE item validation

2019-12-18 Thread Matan Azrad
From: Dekel Peled > On validation of GENEVE item, the wrong flag is used. > This patch sets the correct bit in item_flags bitmap. > > Fixes: e59a5dbcfd07 ("net/mlx5: add flow match on GENEVE item") > Cc: sta...@dpdk.org > > Signed-off-by: Dekel Peled Acked-by: Matan Azrad

Re: [dpdk-dev] DPDK techboard minutes @18/12/2019

2019-12-22 Thread Matan Azrad
Hi > From: Ananyev, Konstantin > Minutes of Technical Board Meeting, 2019-12-18 > > Members Attending > - > -Bruce > -Ferruh > -Hemant > -Honnappa > -Jerin > -Kevin > -Konstantin (Chair) > -Maxime > -Olivier > -Stephen > -Thomas > > NOTE: The technical board meetings every second

[dpdk-dev] [PATCH v1 0/3] Introduce new class for vDPA device drivers

2019-12-25 Thread Matan Azrad
l be added to the vDPA class. Also, a vDPA device driver features list was added to vDPA documentation. Please review the features list and the series. Later on, I'm going to send the vDPA mlx5 driver. Thanks. Matan Azrad (3): drivers: introduce vDPA class doc: add vDPA feature table

[dpdk-dev] [PATCH v1 2/3] doc: add vDPA feature table

2019-12-25 Thread Matan Azrad
Add vDPA devices features table and explanation. Any vDPA driver can add its own supported features by ading a new ini file to the features directory in doc/guides/vdpadevs/features. Signed-off-by: Matan Azrad --- doc/guides/conf.py| 5 +++ doc/guides/vdpadevs/features

[dpdk-dev] [PATCH v1 1/3] drivers: introduce vDPA class

2019-12-25 Thread Matan Azrad
documentation. Signed-off-by: Matan Azrad --- doc/guides/index.rst | 1 + doc/guides/vdpadevs/index.rst | 13 + drivers/Makefile | 2 ++ drivers/meson.build | 1 + drivers/vdpa/Makefile | 8 drivers/vdpa/meson.build | 8 6

[dpdk-dev] [PATCH v1 3/3] drivers: move ifc driver to the vDPA class

2019-12-25 Thread Matan Azrad
A new vDPA class was recently introduced. IFC driver implements the vDPA operations, hence it should be moved to the vDPA class. Move it. Signed-off-by: Matan Azrad --- MAINTAINERS |6 +- doc/guides/nics/features/ifcvf.ini |8 - doc/guides/nics

Re: [dpdk-dev] [PATCH v2 1/3] eal: introduce structure marker typedefs

2019-12-26 Thread Matan Azrad
Hi From: Jerin Jacob > From: Jerin Jacob > > Introduce EAL typedef for structure 1B, 2B, 4B, 8B alignment marking and a > generic marker for a point in a structure. > > Signed-off-by: Jerin Jacob > --- > > v2: > - Changed __extension__ to RTE_STD_C11 (Thomas) > - Change "a point" to "any pl

Re: [dpdk-dev] [PATCH v2 1/3] eal: introduce structure marker typedefs

2020-01-02 Thread Matan Azrad
From: Jerin Jacob > On Thu, Dec 26, 2019 at 1:45 PM Matan Azrad > wrote: > > > > Hi > > > > From: Jerin Jacob > > > From: Jerin Jacob > > > > > > Introduce EAL typedef for structure 1B, 2B, 4B, 8B alignment marking > > > and a

Re: [dpdk-dev] [PATCH 2/2] net/mlx5: add IPv4/IPv6 DSCP rewrite action

2020-01-06 Thread Matan Azrad
Hi From: Suanming Mou > This commit add the IPv4/IPv6 DSCP rewrite actions to the PMD code. > > Supported actions: > RTE_FLOW_ACTION_TYPE_SET_IPV4_DSCP > RTE_FLOW_ACTION_TYPE_SET_IPV6_DSCP > > Signed-off-by: Suanming Mou > --- > drivers/net/mlx5/mlx5_flow.h| 6 +- > drivers/net/mlx5/mlx5

Re: [dpdk-dev] [PATCH] net/mlx5: fix metadata item endianness conversion

2020-01-06 Thread Matan Azrad
gt; bits of metadata the extra right shift is needed after endianness conversion > for little- endian hosts. > > Fixes: acfcd5c52f94 ("net/mlx5: update meta register matcher set") > Cc: sta...@dpdk.org > > Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH] net/mlx5: fix register c0 usage for metadata entities

2020-01-06 Thread Matan Azrad
y kernel the PMD can use upper or lower half of register c0. > This patch adds the missing support for upper half. > > Fixes: e554b672aa05 ("net/mlx5: support flow tag") > Cc: sta...@dpdk.org > > Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH] net/mlx5: fix matcher metadata register c0 field setup

2020-01-06 Thread Matan Azrad
mp |= data; > + MLX5_SET(fte_match_set_misc2, misc2_v, > metadata_reg_c_0, temp); > break; > case REG_C_1: > MLX5_SET(fte_match_set_misc2, misc2_m, > metadata_reg_c_1, mask); Raslan, please fix the typo in integration. Acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH] net/mlx5: fix ConnectX-4LX Tx burst routines set

2020-01-06 Thread Matan Azrad
acket Tx descriptors") > Cc: sta...@dpdk.org > > Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH] net/mlx5: fix legacy inline multi-packet performance

2020-01-06 Thread Matan Azrad
> and better performance. > > Fixes: 18a1c20044c0 ("net/mlx5: implement Tx burst template") > > Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH] net/mlx5: fix default mark copy flow

2020-01-06 Thread Matan Azrad
et/mlx5: add metadata register copy table") > > Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH v2 2/2] net/mlx5: add IPv4/IPv6 DSCP rewrite action

2020-01-06 Thread Matan Azrad
From: Suanming Mou > This commit add the IPv4/IPv6 DSCP rewrite actions to the PMD code. > > Supported actions: > RTE_FLOW_ACTION_TYPE_SET_IPV4_DSCP > RTE_FLOW_ACTION_TYPE_SET_IPV6_DSCP > > Signed-off-by: Suanming Mou Acked-by: Matan Azrad > --- > drivers/ne

Re: [dpdk-dev] [PATCH v1 0/3] Introduce new class for vDPA device drivers

2020-01-06 Thread Matan Azrad
Hi all Any comments? From: Matan Azrad > As discussed and as described in RFC "[RFC] net: new vdpa PMD for Mellanox > devices", new vDPA driver is going to be added for Mellanox devices - vDPA > mlx5 and more. > > The only vDPA driver now is the IFC driver that is

Re: [dpdk-dev] [PATCH v1 2/3] doc: add vDPA feature table

2020-01-08 Thread Matan Azrad
Hi all Thanks very much for the review. Please see below. From: Andrew Rybchenko > On 1/8/20 8:28 AM, Tiwei Bie wrote: > > On Tue, Jan 07, 2020 at 06:39:36PM +0100, Maxime Coquelin wrote: > >> On 12/25/19 4:19 PM, Matan Azrad wrote: > >>> Add vDPA devices

Re: [dpdk-dev] [PATCH v1 0/3] Introduce new class for vDPA device drivers

2020-01-08 Thread Matan Azrad
y "integrate eth_dev"? > Thanks, > Rosen > > > -Original Message- > > From: dev On Behalf Of Matan Azrad > > Sent: Tuesday, January 07, 2020 15:57 > > To: Matan Azrad ; Maxime Coquelin > > ; Bie, Tiwei ; Wang, > > Zhihong ; Wang, Xiao W &g

Re: [dpdk-dev] [PATCH v1 2/3] doc: add vDPA feature table

2020-01-08 Thread Matan Azrad
Hi Andrew From: Andrew Rybchenko > Sent: Wednesday, January 8, 2020 3:11 PM > To: Matan Azrad ; Tiwei Bie ; > Maxime Coquelin > Cc: Zhihong Wang ; Xiao Wang > ; Ferruh Yigit ; > dev@dpdk.org; Thomas Monjalon > Subject: Re: [dpdk-dev] [PATCH v1 2/3] doc: add vDPA feature t

Re: [dpdk-dev] [PATCH v1 2/3] doc: add vDPA feature table

2020-01-09 Thread Matan Azrad
From: Tiwei Bie > On Wed, Jan 08, 2020 at 10:42:48AM +0000, Matan Azrad wrote: > > Hi all > > > > Thanks very much for the review. > > Please see below. > > > > From: Andrew Rybchenko > > > On 1/8/20 8:28 AM, Tiwei Bie wrote: > > > &g

[dpdk-dev] [PATCH v2 0/3] Introduce new class for vDPA device drivers

2020-01-09 Thread Matan Azrad
l be added to the vDPA class. Also, a vDPA device driver features list was added to vDPA documentation. Please review the features list and the series. Later on, I'm going to send the vDPA mlx5 driver. Thanks. v2: Apply comments from Maxime Coquelin, Andrew Rybchenko and Tiwei Bie.

[dpdk-dev] [PATCH v2 1/3] drivers: introduce vDPA class

2020-01-09 Thread Matan Azrad
documentation. The management tree for vDPA drivers is git://dpdk.org/next/dpdk-next-virtio. Signed-off-by: Matan Azrad --- MAINTAINERS | 5 + doc/guides/index.rst | 1 + doc/guides/vdpadevs/index.rst | 13 + drivers/Makefile | 2 ++ drivers

[dpdk-dev] [PATCH v2 2/3] doc: add vDPA feature table

2020-01-09 Thread Matan Azrad
Add vDPA devices features table and explanation. Any vDPA driver can add its own supported features by ading a new ini file to the features directory in doc/guides/vdpadevs/features. Signed-off-by: Matan Azrad --- doc/guides/conf.py| 5 +++ doc/guides/vdpadevs/features

[dpdk-dev] [PATCH v2 3/3] drivers: move ifc driver to the vDPA class

2020-01-09 Thread Matan Azrad
A new vDPA class was recently introduced. IFC driver implements the vDPA operations, hence it should be moved to the vDPA class. Move it. Signed-off-by: Matan Azrad --- MAINTAINERS | 14 +- doc/guides/nics/features/ifcvf.ini |8 - doc/guides/nics

Re: [dpdk-dev] [PATCH v1 0/3] Introduce new class for vDPA device drivers

2020-01-09 Thread Matan Azrad
From: Xu, Rosen > > -Original Message- > > From: Thomas Monjalon > > Sent: Thursday, January 09, 2020 16:41 > > To: Xu, Rosen > > Cc: Matan Azrad ; Maxime Coquelin > > ; Bie, Tiwei ; Wang, > > Zhihong ; Wang, Xiao W > > ; Yigit, Ferru

Re: [dpdk-dev] [PATCH v2 3/3] drivers: move ifc driver to the vDPA class

2020-01-09 Thread Matan Azrad
Small typo inline. From: Matan Azrad > A new vDPA class was recently introduced. > > IFC driver implements the vDPA operations, hence it should be moved to > the vDPA class. > > Move it. > > Signed-off-by: Matan Azrad > --- > MAINTAINERS

Re: [dpdk-dev] [PATCH v2 3/3] drivers: move ifc driver to the vDPA class

2020-01-10 Thread Matan Azrad
From: Wang, Haiyue > > -Original Message- > > From: dev On Behalf Of Matan Azrad > > Sent: Friday, January 10, 2020 01:26 > > To: Matan Azrad ; Maxime Coquelin > > ; Bie, Tiwei ; Wang, > > Zhihong ; Wang, Xiao W > > > Cc: Yigit, Ferruh

Re: [dpdk-dev] [PATCH] net/mlx5: fix doorbell register offset type

2020-01-13 Thread Matan Azrad
"net/mlx5: control transmit doorbell register mapping") > Cc: sta...@dpdk.org > > Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad

[dpdk-dev] [PATCH v1 08/38] vdpa/mlx5: support queues number operation

2020-01-20 Thread Matan Azrad
Support get_queue_num operation to get the maximum number of queues supported by the device. This number comes from the DevX capabilities. Signed-off-by: Matan Azrad --- drivers/vdpa/mlx5/mlx5_vdpa.c | 54 ++- 1 file changed, 53 insertions(+), 1 deletion

[dpdk-dev] [PATCH v1 03/38] mlx5: share the mlx5 glue reference

2020-01-20 Thread Matan Azrad
glue initialization to be in common/mlx5 library to be initialized by its constractor only once. Signed-off-by: Matan Azrad --- drivers/common/mlx5/mlx5_common.c | 173 +- drivers/net/mlx5/Makefile | 3 - drivers/net/mlx5/meson.build | 4

[dpdk-dev] [PATCH v1 05/38] mlx5: share mlx5 devices information

2020-01-20 Thread Matan Azrad
Move the vendor information, vendor ID and device IDs from mlx5 PMD to the common mlx5 file. Signed-off-by: Matan Azrad --- drivers/common/mlx5/mlx5_common.h | 21 + drivers/net/mlx5/mlx5.h | 21 - drivers/net/mlx5/mlx5_txq.c | 1 + 3

[dpdk-dev] [PATCH v1 06/38] drivers: introduce mlx5 vDPA driver

2020-01-20 Thread Matan Azrad
objects directly by the FW. Hence, the common/mlx5 library is linked to the mlx5_vdpa driver. This driver will not be compiled by default due to the above dependencies. Register a new log type for this driver. Signed-off-by: Matan Azrad --- MAINTAINERS | 8

[dpdk-dev] [PATCH v1 01/38] net/mlx5: separate DevX commands interface

2020-01-20 Thread Matan Azrad
DevX commands. Replace the DevX commands log mechanism from the mlx5 driver log mechanism to the EAL log mechanism. Signed-off-by: Matan Azrad --- drivers/net/mlx5/mlx5.c | 1 + drivers/net/mlx5/mlx5.h | 219 +--- drivers/net/mlx5

[dpdk-dev] [PATCH v1 07/38] common/mlx5: expose vDPA DevX capabilities

2020-01-20 Thread Matan Azrad
Add the DevX capabilities for vDPA configuration and information of Mellanox devices. Signed-off-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 90 drivers/common/mlx5/mlx5_devx_cmds.h | 24 ++ drivers/common/mlx5/mlx5_prm.h | 45

[dpdk-dev] [PATCH v1 04/38] mlx5: share mlx5 PCI device detection

2020-01-20 Thread Matan Azrad
Move PCI detection by IB device from mlx5 PMD to the common code. Signed-off-by: Matan Azrad --- drivers/common/mlx5/Makefile| 2 +- drivers/common/mlx5/mlx5_common.c | 55 + drivers/common/mlx5/mlx5_common.h | 4

[dpdk-dev] [PATCH v1 09/38] vdpa/mlx5: support features get operations

2020-01-20 Thread Matan Azrad
Add support for get_features and get_protocol_features operations. Part of the features are reported by the DevX capabilities. Signed-off-by: Matan Azrad --- doc/guides/vdpadevs/features/mlx5.ini | 7 drivers/vdpa/mlx5/mlx5_vdpa.c | 66 +-- 2 files

[dpdk-dev] [PATCH v1 00/38] Introduce mlx5 vDPA driver

2020-01-20 Thread Matan Azrad
Steps: - Prepare net/mlx5 for code sharing. - Introduce new common lib for mlx5 devices. - Share code from net/mlx5 to common/mlx5. - Introduce vDPA driver for Mellanox devices. Matan Azrad (38): net/mlx5: separate DevX commands interface mlx5: prepare common library mlx5: share the mlx5

[dpdk-dev] [PATCH v1 10/38] common/mlx5: glue null memory region allocation

2020-01-20 Thread Matan Azrad
Add support for rdma-core API to allocate NULL MR. Signed-off-by: Matan Azrad --- drivers/common/mlx5/mlx5_glue.c | 13 + drivers/common/mlx5/mlx5_glue.h | 1 + 2 files changed, 14 insertions(+) diff --git a/drivers/common/mlx5/mlx5_glue.c b/drivers/common/mlx5/mlx5_glue.c index

[dpdk-dev] [PATCH v1 11/38] common/mlx5: support DevX indirect mkey creation

2020-01-20 Thread Matan Azrad
Add option to create an indirect mkey by the current mlx5_devx_cmd_mkey_create command. Align the net/mlx5 driver usage in the above command. Signed-off-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 43 ++-- drivers/common/mlx5/mlx5_devx_cmds.h | 12

[dpdk-dev] [PATCH v1 12/38] common/mlx5: glue event queue query

2020-01-20 Thread Matan Azrad
The event queue is managed only by the kernel. Add the rdma-core command in glue to query the kernel event queue details. Signed-off-by: Matan Azrad --- drivers/common/mlx5/mlx5_glue.c | 15 +++ drivers/common/mlx5/mlx5_glue.h | 2 ++ 2 files changed, 17 insertions(+) diff --git

[dpdk-dev] [PATCH v1 19/38] mlx5: share CQ entry check

2020-01-20 Thread Matan Azrad
The CQE has owner bit to indicate if it is in SW control or HW. Share a CQE check for all the mlx5 drivers. Signed-off-by: Matan Azrad --- drivers/common/mlx5/mlx5_common.h | 41 +++ drivers/net/mlx5/mlx5_rxtx.h | 39

[dpdk-dev] [PATCH v1 13/38] common/mlx5: glue event interrupt commands

2020-01-20 Thread Matan Azrad
-by: Matan Azrad --- drivers/common/mlx5/Makefile| 5 +++ drivers/common/mlx5/meson.build | 2 ++ drivers/common/mlx5/mlx5_glue.c | 79 + drivers/common/mlx5/mlx5_glue.h | 25 + 4 files changed, 111 insertions(+) diff --git a/drivers/common

[dpdk-dev] [PATCH v1 14/38] common/mlx5: glue UAR allocation

2020-01-20 Thread Matan Azrad
registers that control the HW operation. UAR mechanism is used to post execution or control requests to the HW. It is used by the HW to enforce protection and isolation between different processes. Add a glue command to allocate and free an UAR. Signed-off-by: Matan Azrad --- drivers/common/mlx5

[dpdk-dev] [PATCH v1 16/38] common/mlx5: glue VAR allocation

2020-01-20 Thread Matan Azrad
Virtio access region(VAR) is the UAR that allocated for virtio emulation access. Add rdma-core operations to allocate and free VAR. Signed-off-by: Matan Azrad --- drivers/common/mlx5/Makefile| 5 + drivers/common/mlx5/meson.build | 1 + drivers/common/mlx5/mlx5_glue.c | 26

[dpdk-dev] [PATCH v1 17/38] common/mlx5: add DevX virtio emulation commands

2020-01-20 Thread Matan Azrad
the I/O operation of this queue, according to its device type characteristics. Some of the virtio features can be supported according to the device capability, for example, TSO and checksum. Add virtio queue create, modify and query DevX commands. Signed-off-by: Matan Azrad --- drivers/common

[dpdk-dev] [PATCH v1 21/38] vdpa/mlx5: handle completions

2020-01-20 Thread Matan Azrad
HW. Signed-off-by: Matan Azrad --- drivers/common/mlx5/mlx5_prm.h | 4 ++ drivers/vdpa/mlx5/mlx5_vdpa.h| 24 drivers/vdpa/mlx5/mlx5_vdpa_cq.c | 129 +++ 3 files changed, 157 insertions(+) diff --git a/drivers/common/mlx5/mlx5_prm.h b/drivers

[dpdk-dev] [PATCH v1 20/38] vdpa/mlx5: prepare completion queues

2020-01-20 Thread Matan Azrad
to trigger the CQE events when a new CQE is posted. Signed-off-by: Matan Azrad --- drivers/vdpa/mlx5/Makefile | 1 + drivers/vdpa/mlx5/meson.build| 1 + drivers/vdpa/mlx5/mlx5_vdpa.h| 56 ++ drivers/vdpa/mlx5/mlx5_vdpa_cq.c | 154

[dpdk-dev] [PATCH v1 15/38] common/mlx5: add DevX command to create CQ

2020-01-20 Thread Matan Azrad
HW implements completion queues(CQ) used to post completion reports upon completion of work request. Used for Rx and Tx datapath. Add DevX command to create a CQ. Signed-off-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c| 57 drivers/common/mlx5

[dpdk-dev] [PATCH v1 23/38] vdpa/mlx5: support stateless offloads

2020-01-20 Thread Matan Azrad
reported by the device. Signed-off-by: Matan Azrad --- doc/guides/vdpadevs/features/mlx5.ini | 7 ++- drivers/vdpa/mlx5/mlx5_vdpa.c | 10 drivers/vdpa/mlx5/mlx5_vdpa.h | 10 drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 108 -- 4 files

[dpdk-dev] [PATCH v1 18/38] vdpa/mlx5: prepare memory regions

2020-01-20 Thread Matan Azrad
mlx5_vdpa_mem.c to manage all the MR related code in the driver. Signed-off-by: Matan Azrad --- drivers/vdpa/mlx5/Makefile| 4 +- drivers/vdpa/mlx5/meson.build | 3 +- drivers/vdpa/mlx5/mlx5_vdpa.c | 11 +- drivers/vdpa/mlx5/mlx5_vdpa.h | 60 +++ drivers/vdpa/mlx5

[dpdk-dev] [PATCH v1 24/38] common/mlx5: allow type configuration for DevX RQT

2020-01-20 Thread Matan Azrad
Allow virtio queue type configuration in the RQ table. The needed fields and configuration was added. Signed-off-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 1 + drivers/common/mlx5/mlx5_devx_cmds.h | 1 + drivers/common/mlx5/mlx5_prm.h | 5 +++-- 3 files changed, 5

[dpdk-dev] [PATCH v1 22/38] vdpa/mlx5: prepare virtio queues

2020-01-20 Thread Matan Azrad
configurations. This patch prepares the basic configurations needed by DevX commands to create a virtq. Add new file mlx5_vdpa_virtq.c to manage virtq operations. Signed-off-by: Matan Azrad --- drivers/vdpa/mlx5/Makefile | 1 + drivers/vdpa/mlx5/meson.build | 1 + drivers/vdpa/mlx5

[dpdk-dev] [PATCH v1 28/38] vdpa/mlx5: add basic steering configurations

2020-01-20 Thread Matan Azrad
Add a steering object to be managed by a new file mlx5_vdpa_steer.c. Allow promiscuous flow to scatter the device Rx packets to the virtio queues using RSS action. In order to allow correct RSS in L3 and L4, split the flow to 7 flows as required by the device. Signed-off-by: Matan Azrad

[dpdk-dev] [PATCH v1 27/38] common/mlx5: get DevX capability for max RQT size

2020-01-20 Thread Matan Azrad
In order to allow RQT size configuration which is limited to the correct maximum value, add log_max_rqt_size for DevX capability structure. Signed-off-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 2 ++ drivers/common/mlx5/mlx5_devx_cmds.h | 1 + 2 files changed, 3 insertions

[dpdk-dev] [PATCH v1 30/38] vdpa/mlx5: map doorbell

2020-01-20 Thread Matan Azrad
notification when a new event appears in kickfd by the guest and write 4 bytes to the HW doorbell space in the notification callback. Signed-off-by: Matan Azrad --- drivers/vdpa/mlx5/mlx5_vdpa.h | 3 ++ drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 84 - 2 files

[dpdk-dev] [PATCH v1 29/38] vdpa/mlx5: support queue state operation

2020-01-20 Thread Matan Azrad
Add support for set_vring_state operation. Using DevX API the virtq state can be changed as described in PRM: enable - move to ready state. disable - move to suspend state. Signed-off-by: Matan Azrad --- drivers/vdpa/mlx5/mlx5_vdpa.c | 23 ++- drivers

[dpdk-dev] [PATCH v1 26/38] common/mlx5: add DevX command to modify RQT

2020-01-20 Thread Matan Azrad
RQ table can be changed to support different list of queues. Add DevX command to modify DevX RQT object to point on new RQ list. Signed-off-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c| 47 + drivers/common/mlx5/mlx5_devx_cmds.h| 2

[dpdk-dev] [PATCH v1 32/38] vdpa/mlx5: support close and config operations

2020-01-20 Thread Matan Azrad
Support dev_conf and dev_conf operations. These operations allow vdpa traffic. Signed-off-by: Matan Azrad --- drivers/vdpa/mlx5/mlx5_vdpa.c | 51 +-- drivers/vdpa/mlx5/mlx5_vdpa.h | 1 + 2 files changed, 50 insertions(+), 2 deletions(-) diff --git a

[dpdk-dev] [PATCH v1 25/38] common/mlx5: add TIR fields constants

2020-01-20 Thread Matan Azrad
The DevX TIR object configuration should get L3 and L4 protocols expected to be forwarded by the TIR. Add the PRM constant values needed to configure the L3 and L4 protocols. Signed-off-by: Matan Azrad --- drivers/common/mlx5/mlx5_prm.h | 10 ++ 1 file changed, 10 insertions(+) diff

[dpdk-dev] [PATCH v1 31/38] vdpa/mlx5: support live migration

2020-01-20 Thread Matan Azrad
, dirty_bitmap_addr and dirty_bitmap_dump_enable. Modify VIRTIO_NET_Q object and move state to SUSPEND. Query VIRTIO_NET_Q and get hw_available_idx and hw_used_idx. Signed-off-by: Matan Azrad --- doc/guides/vdpadevs/features/mlx5.ini | 1 + drivers/vdpa/mlx5/Makefile

[dpdk-dev] [PATCH v1 33/38] mlx5: skip probing according to the vDPA mode

2020-01-20 Thread Matan Azrad
provided by the user: vdpa=1. Signed-off-by: Matan Azrad --- drivers/common/mlx5/Makefile| 2 +- drivers/common/mlx5/meson.build | 2 +- drivers/common/mlx5/mlx5_common.c | 36 + drivers/common/mlx5/mlx5_common.h

[dpdk-dev] [PATCH v1 37/38] common/mlx5: support ROCE disable through Netlink

2020-01-20 Thread Matan Azrad
driver. 4. mlx5_nl_enable_roce_set - to set the ROCE status. When the user changes the ROCE status, the IB device may disappear and appear again, so DPDK driver should wait for it and to restart itself. Signed-off-by: Matan Azrad --- drivers/common/mlx5/Makefile| 5

[dpdk-dev] [PATCH v1 36/38] mlx5: share Netlink commands

2020-01-20 Thread Matan Azrad
-off-by: Matan Azrad --- drivers/common/mlx5/Makefile|3 +- drivers/common/mlx5/meson.build |1 + drivers/common/mlx5/mlx5_common.c | 55 + drivers/common/mlx5/mlx5_common.h | 58 + drivers/common/mlx5/mlx5_nl.c

[dpdk-dev] [PATCH v1 34/38] net/mlx5: separate Netlink commands interface

2020-01-20 Thread Matan Azrad
to the mlx5_vlan.c. Rename all the Netlink commands and structure to use prefix mlx5_nl. Signed-off-by: Matan Azrad --- drivers/net/mlx5/mlx5.h | 72 +++-- drivers/net/mlx5/mlx5_nl.c | 149 +++ drivers/net/mlx5/mlx5_nl.h | 69

[dpdk-dev] [PATCH v1 38/38] vdpa/mlx5: disable ROCE

2020-01-20 Thread Matan Azrad
by sysfs which is like: echo 0 > /sys/bus/pci/devices/[pci]/roce_enable The IB device is matched again after ROCE disabling. Signed-off-by: Matan Azrad --- drivers/vdpa/mlx5/Makefile| 2 +- drivers/vdpa/mlx5/meson.build | 2 +- drivers/vdpa/mlx5/mlx5_vdpa.c |

[dpdk-dev] [PATCH v1 35/38] net/mlx5: reduce Netlink commands dependencies

2020-01-20 Thread Matan Azrad
one which uses it. Signed-off-by: Matan Azrad --- drivers/net/mlx5/mlx5.c| 10 +- drivers/net/mlx5/mlx5.h| 3 - drivers/net/mlx5/mlx5_ethdev.c | 49 -- drivers/net/mlx5/mlx5_mac.c| 14 +- drivers/net/mlx5/mlx5_nl.c | 329

[dpdk-dev] [PATCH] net/mlx5: fix clang 3.4.2 compilation

2020-01-22 Thread Matan Azrad
k support") Cc: sta...@dpdk.org Signed-off-by: Matan Azrad --- drivers/net/mlx5/mlx5_flow.c| 2 +- drivers/net/mlx5/mlx5_flow.h| 2 +- drivers/net/mlx5/mlx5_flow_dv.c | 12 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/driver

[dpdk-dev] [PATCH] net/mlx5: fix zero out UDP checksum in encap data

2020-01-22 Thread Matan Azrad
From: Eli Britstein The cited commit zeroed the UDP checksum for raw-encap case. Add the same handling for vxlan-encap case. Fixes: bf1d7d9a033a ("net/mlx5: zero out UDP checksum in encapsulation") Cc: sta...@dpdk.org Signed-off-by: Eli Britstein Acked-by: Matan Azrad --- driver

Re: [dpdk-dev] [PATCH 2/2] app/testpmd: fix invalid port detaching

2020-01-23 Thread Matan Azrad
Hi From: Yigit, Ferruh > On 11/12/2019 8:47 AM, Matan Azrad wrote: > > The port was not validated before detaching. > > > > Ignore port detach operation when the port is not valid. > > > > Fixes: f8e5baa2662d ("app/testpmd: check not detaching device twic

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] app/testpmd: fix invalid port detaching

2020-01-23 Thread Matan Azrad
Hi From: Ferruh Yigit > On 1/23/2020 2:05 PM, Matan Azrad wrote: > > Hi > > > > From: Yigit, Ferruh > >> On 11/12/2019 8:47 AM, Matan Azrad wrote: > >>> The port was not validated before detaching. > >>> > >>> Ignore p

Re: [dpdk-dev] [PATCH] app/testpmd: fix hotplug

2020-01-23 Thread Matan Azrad
Hi From: Ferruh Yigit > The 'port_id_is_invalid()' check in the 'detach_port_device()' is breaking the > hotplug support, since at that stage port will be closed and validity check > always fail [1] and removing the device is not really completed. > > But this cause the vfio request interrupt k

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] app/testpmd: fix invalid port detaching

2020-01-23 Thread Matan Azrad
Hi From: Ferruh Yigit > On 1/23/2020 3:29 PM, Matan Azrad wrote: > > > > Hi > > > > From: Ferruh Yigit > >> On 1/23/2020 2:05 PM, Matan Azrad wrote: > >>> Hi > >>> > >>> From: Yigit, Ferruh > >>>> On 11/

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] app/testpmd: fix invalid port detaching

2020-01-25 Thread Matan Azrad
Hi Ferruh From: Ferruh Yigit > On 1/23/2020 7:25 PM, Matan Azrad wrote: > > Hi > > > > From: Ferruh Yigit > >> On 1/23/2020 3:29 PM, Matan Azrad wrote: > >>> > >>> Hi > >>> > >>> From: Ferruh Yigit > >>>

Re: [dpdk-dev] [PATCH] net/mlx5: fix flow META item validation

2020-07-01 Thread Matan Azrad
r message will be issued. > > Fixes: 9bf26e1318 ("ethdev: move egress metadata to dynamic field") > Cc: viachesl...@mellanox.com > Cc: sta...@dpdk.org > > Signed-off-by: Shy Shyman Acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH] net/mlx5: fix flow META item validation

2020-07-01 Thread Matan Azrad
Done Get Outlook for Android<https://aka.ms/ghei36> From: Asaf Penso Sent: Wednesday, July 1, 2020 2:19:10 PM To: Matan Azrad Cc: Shy Shyman ; Raslan Darawsheh Subject: FW: [dpdk-dev] [PATCH] net/mlx5: fix flow META item validation Matan, can you plea

Re: [dpdk-dev] [PATCH v2 1/7] ethdev: introduce sample action for rte flow

2020-07-03 Thread Matan Azrad
Hi Jerin From: Jerin Jacob: > On Fri, Jul 3, 2020 at 12:13 AM Jiawei Wang wrote: > > > > When using full offload, all traffic will be handled by the HW, and > > directed to the requested vf or wire, the control application loses > > visibility on the traffic. > > So there's a need for an action

Re: [dpdk-dev] [PATCH v2 1/7] ethdev: introduce sample action for rte flow

2020-07-03 Thread Matan Azrad
From: Jerin Jacob > On Fri, Jul 3, 2020 at 8:25 PM Matan Azrad wrote: > > > > > > Hi Jerin > > Hi Matan, > > > > > From: Jerin Jacob: > > > On Fri, Jul 3, 2020 at 12:13 AM Jiawei Wang > wrote: > > > > > > > &g

Re: [dpdk-dev] [PATCH v2 1/7] ethdev: introduce sample action for rte flow

2020-07-04 Thread Matan Azrad
Hi all From: Jerin Jacob: > On Fri, Jul 3, 2020 at 8:57 PM Thomas Monjalon > wrote: > > > > 03/07/2020 17:08, Jerin Jacob: > > > On Fri, Jul 3, 2020 at 8:25 PM Matan Azrad > wrote: > > > > From: Jerin Jacob: > > > > > When adding overlap

Re: [dpdk-dev] [PATCH v2 1/7] ethdev: introduce sample action for rte flow

2020-07-04 Thread Matan Azrad
From: Jerin Jacob: > On Sun, Jul 5, 2020 at 12:56 AM Matan Azrad wrote: > > > > Hi all > > > > From: Jerin Jacob: > > > On Fri, Jul 3, 2020 at 8:57 PM Thomas Monjalon > > > wrote: > > > > > > > > 03/07/2020 17:08, Jerin Jac

Re: [dpdk-dev] [PATCH 1/4] vhost: inroduce operation to get vDPA queue stats

2020-04-16 Thread Matan Azrad
Hi Maxime Can you point on specific vendor specific counter I suggested? I think all of them come directly from virtio protocols. השג את Outlook עבור Android<https://aka.ms/ghei36> From: Maxime Coquelin Sent: Wednesday, April 15, 2020 5:36:59 PM To: Matan

Re: [dpdk-dev] [PATCH 2/4] vdpa/mlx5: support direct HW notifications

2020-04-26 Thread Matan Azrad
From: Maxime Coquelin > On 4/15/20 11:47 AM, Maxime Coquelin wrote: > > > > > > On 3/24/20 3:24 PM, Asaf Penso wrote: > >> From: Matan Azrad > >> > >> Add support for the next 2 callbacks: > >> get_vfio_device_fd and get_notify_area.

Re: [dpdk-dev] [PATCH 2/2] ethdev: allow unknown link speed

2020-04-26 Thread Matan Azrad
Hi From: Thomas Monjalon > When querying the link informations, the link status is a mandatory major > information. > Other boolean values are supposed to be accurate: > - duplex mode (half/full) > - negotiation (auto/fixed) > > This API update is making explicit that the link speed i

[dpdk-dev] [PATCH 1/3] vdpa/mlx5: manage virtqs by array

2020-04-26 Thread Matan Azrad
As a preparation to listen the virtqs status before the device is configured, manage the virtqs structures in array instead of list. Signed-off-by: Matan Azrad Acked-by: Viacheslav Ovsiienko --- drivers/vdpa/mlx5/mlx5_vdpa.c | 43 -- drivers/vdpa/mlx5

[dpdk-dev] [PATCH 0/3] vdpa/mlx5: recreate a virtq becoming enabled

2020-04-26 Thread Matan Azrad
. rebase. Matan Azrad (3): vdpa/mlx5: manage virtqs by array vdpa/mlx5: separate virtq stop vdpa/mlx5: recreate a virtq becoming enabled drivers/vdpa/mlx5/mlx5_vdpa.c | 47 +++ drivers/vdpa/mlx5/mlx5_vdpa.h | 54 +++-- drivers/vdpa/mlx5/mlx5_vdpa_lm.c| 57

[dpdk-dev] [PATCH 2/3] vdpa/mlx5: separate virtq stop

2020-04-26 Thread Matan Azrad
In live migration, before logging the virtq, the driver queries the virtq indexes after moving it to suspend mode. Separate this method to new function mlx5_vdpa_virtq_stop as a preparation for reusing. Signed-off-by: Matan Azrad Acked-by: Viacheslav Ovsiienko Reviewed-by: Maxime Coquelin

[dpdk-dev] [PATCH 3/3] vdpa/mlx5: recreate a virtq becoming enabled

2020-04-26 Thread Matan Azrad
The virtq configurations may be changed when it moves from disabled state to enabled state. Listen to the state callback even if the device is not configured. Recreate the virtq when it moves from disabled state to enabled state and when the device is configured. Signed-off-by: Matan Azrad

Re: [dpdk-dev] [PATCH] app/testpmd: support flow aging

2020-04-27 Thread Matan Azrad
Hi From: Ferruh Yigit > On 4/26/2020 8:23 AM, Bill Zhou wrote: > > > > > >> -Original Message- > >> From: Ferruh Yigit > >> Sent: Saturday, April 25, 2020 12:25 AM > >> To: Bill Zhou ; wenzhuo...@intel.com; > >> jingjing...@intel.com; bernard.iremon...@intel.com; Ori Kam > >> > >> Cc: de

Re: [dpdk-dev] [PATCH v4] ethdev: support flow aging

2020-04-30 Thread Matan Azrad
Hi Tom From: Tom Barbette > Great news! > > - I can understand why there is no timeout unit. But that's calling for user > nightmare. Eg I could only get from the code (and not from documentation > yet? ) of the following mlx5 driver patch that the value should be in tenth of > seconds. If I bui

Re: [dpdk-dev] [PATCH] net/mlx5: fix default rule do RSS regardless rxmode

2020-04-30 Thread Matan Azrad
From: Slava Ovsiienko > > -Original Message- > > From: Slava Ovsiienko > > Sent: Thursday, April 30, 2020 11:52 > > To: Xiaoyu Min ; Matan Azrad > > ; Shahaf Shuler > > Cc: dev@dpdk.org; sta...@dpdk.org > > Subject: RE: [PATCH] net/mlx5: fix

Re: [dpdk-dev] [PATCH v2] app/testpmd: support flow aging

2020-04-30 Thread Matan Azrad
Hi Ferruh From: Ferruh Yigit > On 4/30/2020 4:53 PM, Bill Zhou wrote: > > Currently, there is no way to check the aging event or to get the > > current aged flows in testpmd, this patch include those implements, it's > included: > > - Registering aging event when the testpmd application start, add

Re: [dpdk-dev] [PATCH v2] app/testpmd: support flow aging

2020-05-01 Thread Matan Azrad
Hi Ferruh From: Ferruh Yigit: > On 5/1/2020 7:51 AM, Matan Azrad wrote: > > Hi Ferruh > > > > From: Ferruh Yigit > >> On 4/30/2020 4:53 PM, Bill Zhou wrote: > >>> Currently, there is no way to check the aging event or to get the > >>> c

Re: [dpdk-dev] [PATCH v2] app/testpmd: support flow aging

2020-05-01 Thread Matan Azrad
From: Ferruh Yigit: > On 5/1/2020 12:28 PM, Matan Azrad wrote: > > > > Hi Ferruh > > > > From: Ferruh Yigit: > >> On 5/1/2020 7:51 AM, Matan Azrad wrote: > >>> Hi Ferruh > >>> > >>> From: Ferruh Yigit > >>>>

Re: [dpdk-dev] [PATCH v2] app/testpmd: support flow aging

2020-05-01 Thread Matan Azrad
From: Ferruh Yigit: > On 5/1/2020 1:45 PM, Matan Azrad wrote: > > > > > > From: Ferruh Yigit: > >> On 5/1/2020 12:28 PM, Matan Azrad wrote: > >>> > >>> Hi Ferruh > >>> > >>> From: Ferruh Yigit: > >>>>

Re: [dpdk-dev] [PATCH v2] eal/ppc: fix redefine bool type

2020-05-03 Thread Matan Azrad
From: Raslan Darawsheh > Hi, > > > -Original Message- > > From: David Christensen > > Sent: Thursday, April 30, 2020 10:41 PM > > To: Ori Kam ; Thomas Monjalon > > ; Matan Azrad ; Shahaf > Shuler > > ; Slava Ovsiienko ; > > Beilei X

Re: [dpdk-dev] [PATCH v3 0/2] net/mlx5: support flow aging

2020-05-03 Thread Matan Azrad
check and age-out event callback mechanism for mlx5 > driver. > > > Bill Zhou (2): > net/mlx5: modify ext-counter memory allocation > net/mlx5: support flow aging Series-acked-by: Matan Azrad > doc/guides/rel_notes/release_20_05.rst | 1 + > drivers/net/mlx5/mlx5.c

Re: [dpdk-dev] [PATCH v4] app/testpmd: support flow aging

2020-05-03 Thread Matan Azrad
command to list all aged flows, meanwhile, we can set parameter > to destroy it. > > Signed-off-by: Bill Zhou Acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH 2/2] net/mlx5: optimize performance for IPv4/IPv6 ethertype

2020-05-03 Thread Matan Azrad
Hi Eli Good optimization. Thanks. Please see comment below... From: Eli Britstein > The HW is optimized for IPv4/IPv6. For such cases avoid matching on > ethertype, and use ip_version field instead. > > Signed-off-by: Eli Britstein > Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/

Re: [dpdk-dev] [PATCH V2 0/2] net/mlx5: optimize performance for IPv4/IPv6

2020-05-03 Thread Matan Azrad
Series-acked-by: Matan Azrad > drivers/net/mlx5/mlx5_flow_dv.c | 91 > +++-- > 1 file changed, 69 insertions(+), 22 deletions(-) > > -- > 2.14.5

<    5   6   7   8   9   10   11   12   13   14   >