Re: [dpdk-dev] [PATCH 2/2] ethdev: make rte_eth_is_valid_owner_id return bool

2018-08-21 Thread Matan Azrad
From: Stephen Hemminger > Function is boolean so use that. Ethdev is not using bool type, see also: rte_eth_dev_is_valid_port rte_eth_dev_is_removed rte_eth_dev_pool_ops_supported I think it should be a full solution to all. > Signed-off-by: Stephen Hemminger > --- > lib/librte_ethdev/rte_

Re: [dpdk-dev] [PATCH v4] net/bonding: per-slave intermediate rx ring

2018-08-21 Thread Matan Azrad
Hi From: Chas Williams > This will need to be implemented for some of the other RX burst methods at > some point for other modes to see this performance improvement (with the > exception of active-backup). Yes, I think it should be done at least to bond_ethdev_rx_burst_8023ad_fast_queue (should

Re: [dpdk-dev] [PATCH v4] net/bonding: per-slave intermediate rx ring

2018-08-21 Thread Matan Azrad
Hi Chas From: Chas Williams > On Tue, Aug 21, 2018 at 6:56 AM Matan Azrad > wrote: > Hi > > From: Chas Williams > > This will need to be implemented for some of the other RX burst > > methods at some point for other modes to see this performance > > improvem

Re: [dpdk-dev] [PATCH 2/2] ethdev: make rte_eth_is_valid_owner_id return bool

2018-08-21 Thread Matan Azrad
Hi From: Stephen Hemminger > On Tue, 21 Aug 2018 10:20:43 + > Matan Azrad wrote: > > > From: Stephen Hemminger > > > Function is boolean so use that. > > > > Ethdev is not using bool type, see also: > > rte_eth_dev_is_valid_port > > rte_eth_d

Re: [dpdk-dev] [PATCH v3] ethdev: silence error message on rte_eth_dev_owner_unset

2018-08-21 Thread Matan Azrad
d owner id=%016"PRIx64"\n", > +owner_id); > } > > rte_spinlock_unlock(&rte_eth_dev_shared_data->ownership_lock); > -- > 2.18.0 > I think the title should be: ethdev: fix port ownership logs while adding the fixes commits (at list 2 because of the NOTICE change) and updating stable. Besides that, Acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH v4] net/bonding: per-slave intermediate rx ring

2018-08-22 Thread Matan Azrad
Hi Chas From: Chas Williams >On Tue, Aug 21, 2018 at 11:43 AM Matan Azrad <mailto:ma...@mellanox.com> wrote: >Hi Chas > >From: Chas Williams >> On Tue, Aug 21, 2018 at 6:56 AM Matan Azrad <mailto:ma...@mellanox.com> >> wrote: >> Hi >> >> Fro

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] net/bonding: per-slave intermediate rx ring

2018-08-22 Thread Matan Azrad
Hi Luca From: Luca Boccassi > On Wed, 2018-08-22 at 07:09 +0000, Matan Azrad wrote: > > Hi Chas > > > > From: Chas Williams > > > On Tue, Aug 21, 2018 at 11:43 AM Matan Azrad <mailto:matan@mellanox > > > .com> wrote: > > > Hi Chas > > &

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] net/bonding: per-slave intermediate rx ring

2018-08-23 Thread Matan Azrad
Hi From: Eric Kinzie > On Wed Aug 22 11:42:37 + 2018, Matan Azrad wrote: > > Hi Luca > > > > From: Luca Boccassi > > > On Wed, 2018-08-22 at 07:09 +, Matan Azrad wrote: > > > > Hi Chas > > > > > > > > From: Ch

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] net/bonding: per-slave intermediate rx ring

2018-08-26 Thread Matan Azrad
From: Chas Williams <3ch...@gmail.com> >On Thu, Aug 23, 2018 at 3:28 AM Matan Azrad <mailto:ma...@mellanox.com> wrote: >Hi > >From: Eric Kinzie >> On Wed Aug 22 11:42:37 + 2018, Matan Azrad wrote: >> > Hi Luca >> > >> > From: Luca

Re: [dpdk-dev] [PATCH 2/2] ethdev: make rte_eth_is_valid_owner_id return bool

2018-08-26 Thread Matan Azrad
From: Stephen Hemminger > On Tue, 21 Aug 2018 15:48:19 + > Matan Azrad wrote: > > > Hi > > > > From: Stephen Hemminger > > > On Tue, 21 Aug 2018 10:20:43 + > > > Matan Azrad wrote: > > > > > > >

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] net/bonding: per-slave intermediate rx ring

2018-08-27 Thread Matan Azrad
Hi Chas From: Chas Williams <3ch...@gmail.com> >On Sun, Aug 26, 2018 at 3:40 AM Matan Azrad <mailto:ma...@mellanox.com> wrote: > >From: Chas Williams <mailto:3ch...@gmail.com> >>On Thu, Aug 23, 2018 at 3:28 AM Matan Azrad >><mailto:mailto:ma...@mellan

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] net/bonding: per-slave intermediate rx ring

2018-08-28 Thread Matan Azrad
From: Chas Williams >On Mon, Aug 27, 2018 at 11:30 AM Matan Azrad <mailto:ma...@mellanox.com> wrote: >>>Because rings are generally quite efficient. >> >>But you are using a ring in addition to regular array management, it must >>hurt performance of the bon

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] net/bonding: per-slave intermediate rx ring

2018-08-29 Thread Matan Azrad
From: Chas Williams >On Tue, Aug 28, 2018 at 5:51 AM Matan Azrad <mailto:ma...@mellanox.com> wrote: > > >From: Chas Williams >>On Mon, Aug 27, 2018 at 11:30 AM Matan Azrad >><mailto:mailto:ma...@mellanox.com> wrote: > >>>>Because rings are ge

Re: [dpdk-dev] kernel binding of devices + hotplug

2018-04-17 Thread Matan Azrad
Hi Konstantin From: Ananyev, Konstantin, Tuesday, April 17, 2018 12:23 PM > To: Matan Azrad ; Richardson, Bruce > > Cc: Burakov, Anatoly ; Thomas Monjalon > ; dev@dpdk.org; pmati...@redhat.com; > david.march...@6wind.com; Guo, Jia ; > step...@networkplumber.org; f...@redhat

Re: [dpdk-dev] kernel binding of devices + hotplug

2018-04-22 Thread Matan Azrad
Hi Konstantin From: Ananyev, Konstantin, Tuesday, April 17, 2018 2:00 PM > Hi Matan, > > Hi Konstantin > > From: Ananyev, Konstantin, Tuesday, April 17, 2018 12:23 PM > > > > Actually you say that the whitelist\blacklist mechanism is not > > > > good enough > > > and the binding workarounds it. >

[dpdk-dev] [PATCH] net/bonding: fix slave activation simultaneously

2018-04-24 Thread Matan Azrad
recreation with the same name causes an error. Synchronize the critical section in the LSC callback using a special new spinlock. Fixes: 414b202343ce ("bonding: fix initial link status of slave") Fixes: a45b288ef21a ("bond: support link status polling") Cc: sta...@dpdk.org Signed

Re: [dpdk-dev] [dpdk-stable] [PATCH v1] net/vdev_netvsc: fix creating short name devices

2018-04-25 Thread Matan Azrad
From: Ferruh Yigit, Tuesday, April 24, 2018 5:20 PM > On 4/10/2018 4:39 PM, Matan Azrad wrote: > > It is OK for me. > > Converting this to explicit ack: > Acked-by: Matan Azrad > Ok, don't forget to remove the fixes line. > > Thanks. > > > > From:

Re: [dpdk-dev] [dpdk-stable] [PATCH v1] net/vdev_netvsc: fix creating short name devices

2018-04-25 Thread Matan Azrad
From: Ferruh Yigit, Wednesday, April 25, 2018 1:29 PM > On 4/25/2018 11:25 AM, Matan Azrad wrote: > > > > > > From: Ferruh Yigit, Tuesday, April 24, 2018 5:20 PM > >> On 4/10/2018 4:39 PM, Matan Azrad wrote: > >>> It is OK for me. > >> > &g

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/7] ethdev: fix port data reset timing

2018-04-25 Thread Matan Azrad
Hi all From: Ferruh Yigit, Thursday, April 19, 2018 2:08 PM > > But rte_eth_dev_release_port() is still broken because of this change, > > please check _rte_eth_dev_callback_process() which uses dev->data- > >port_id. The issue is that a DESTROY callback gets port_id=0 all the time, regardless t

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/7] ethdev: fix port data reset timing

2018-04-25 Thread Matan Azrad
Hi Ferruh From: Ferruh Yigit, Wednesday, April 25, 2018 3:54 PM > On 4/25/2018 1:16 PM, Matan Azrad wrote: > > Hi all > > > > From: Ferruh Yigit, Thursday, April 19, 2018 2:08 PM > >>> But rte_eth_dev_release_port() is still broken because o

Re: [dpdk-dev] [PATCH V20 4/4] app/testpmd: show example to handler hot unplug

2018-05-03 Thread Matan Azrad
Hi Jeff > From: Jeff Guo, Wednesday, April 18, 2018 4:38 PM > Use testpmd for example, to show how an application smoothly handle > failure when device being hot unplug. Once app detect the removal event, > the callback would be called, it first stop the packet forwarding, then stop > the > port,

[dpdk-dev] [PATCH 0/6] Testpmd: fix port hotplug

2018-05-03 Thread Matan Azrad
Fix somes Testpmd issues regarding port hot-plug. Matan Azrad (6): app/testpmd: fix valid ports prints app/testpmd: fix forward ports update app/testpmd: fix forward ports Rx flush app/testpmd: fix synchronic port hotplug app/testpmd: fix removed device link status asking app/testpmd

[dpdk-dev] [PATCH 1/6] app/testpmd: fix valid ports prints

2018-05-03 Thread Matan Azrad
port 0 only if it is valid as done for the rest of the ports. Fixes: af75078fece3 ("first public release") Fixes: b6ea6408fbc7 ("ethdev: store numa_node per device") Fixes: edab33b1c01d ("app/testpmd: support port hotplug") Cc: sta...@dpdk.org Signed-off-by: Matan Azr

[dpdk-dev] [PATCH 2/6] app/testpmd: fix forward ports update

2018-05-03 Thread Matan Azrad
allocate 0 memory for the streams. Skip the streams memory allocation if no forward ports are configured. Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings") Cc: sta...@dpdk.org Signed-off-by: Matan Azrad --- app/test-pmd/testpmd.c | 29 +--

[dpdk-dev] [PATCH 3/6] app/testpmd: fix forward ports Rx flush

2018-05-03 Thread Matan Azrad
. Move the new forward port setup to be done before the Rx queue flush. Fixes: 7741e4cf16c0 ("app/testpmd: VMDq and DCB updates") Cc: sta...@dpdk.org Signed-off-by: Matan Azrad --- app/test-pmd/testpmd.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/ap

[dpdk-dev] [PATCH 4/6] app/testpmd: fix synchronic port hotplug

2018-05-03 Thread Matan Azrad
the next packet forwarding start. Fixes: edab33b1c01d ("app/testpmd: support port hotplug") Cc: sta...@dpdk.org Signed-off-by: Matan Azrad --- app/test-pmd/testpmd.c | 29 + app/test-pmd/testpmd.h | 1 + 2 files changed, 30 insertions(+) diff --git a/ap

[dpdk-dev] [PATCH 6/6] app/testpmd: fix asynchronic port removal

2018-05-03 Thread Matan Azrad
estpmd: request device removal interrupt") Cc: sta...@dpdk.org Signed-off-by: Matan Azrad --- app/test-pmd/testpmd.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 33a9e96..2edf644 100644 --- a/app/test-pmd

[dpdk-dev] [PATCH 5/6] app/testpmd: fix removed device link status asking

2018-05-03 Thread Matan Azrad
stpmd: request device removal interrupt") Cc: sta...@dpdk.org Signed-off-by: Matan Azrad --- app/test-pmd/testpmd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 35f97f0..33a9e96 100644 --- a/app/test-pmd/testpmd.c +++ b/ap

Re: [dpdk-dev] [PATCH V20 4/4] app/testpmd: show example to handler hot unplug

2018-05-03 Thread Matan Azrad
Hi Guo From: Guo, Jia, Thursday, May 3, 2018 12:36 PM > hi, matan > > > On 5/3/2018 3:25 PM, Matan Azrad wrote: > > Hi Jeff > > > >> From: Jeff Guo, Wednesday, April 18, 2018 4:38 PM Use testpmd for > >> example, to show how an application smoothly

Re: [dpdk-dev] [PATCH v3] net/failsafe: fix probe cleanup

2018-05-08 Thread Matan Azrad
t; Cc: sta...@dpdk.org > > Signed-off-by: Raslan Darawsheh Acked-by: Matan Azrad > > --- > v2 changes: > Reword the commit log. > > v3 changes: > Reword the commit log. > --- > --- > drivers/net/failsafe/failsafe.c | 4 +++- > 1 file changed, 3 inserti

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] net/bonding: per-slave intermediate rx ring

2018-09-02 Thread Matan Azrad
Hi Luca\Chas From: Luca Boccassi > On Wed, 2018-08-29 at 15:20 +0000, Matan Azrad wrote: > > > > From: Chas Williams > > > On Tue, Aug 28, 2018 at 5:51 AM Matan Azrad <mailto:matan@mellanox. > > > com> wrote: > > > > > > > > >

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] net/bonding: per-slave intermediate rx ring

2018-09-11 Thread Matan Azrad
Hi Chas From: Chas Williams > On Sun, Sep 2, 2018 at 7:34 AM Matan Azrad wrote: > > > > Hi Luca\Chas > > > > From: Luca Boccassi > > > On Wed, 2018-08-29 at 15:20 +, Matan Azrad wrote: > > > > > > > > From: Chas Williams > >

Re: [dpdk-dev] [PATCH] net/bonding: propagate promiscous mode in mode 4

2018-09-11 Thread Matan Azrad
Hi Chas From: Chas Williams > On Mon, Aug 6, 2018 at 3:35 PM Matan Azrad > wrote: > > > > > > Hi Chas > > > > From: Chas Williams > > >On Mon, Aug 6, 2018 at 1:46 PM Matan Azrad > <mailto:ma...@mellanox.com> wrote: > > >Hi Chas >

Re: [dpdk-dev] [PATCH] net/bonding: propagate promiscous mode in mode 4

2018-09-13 Thread Matan Azrad
Hi Chas From: Chas Williams > On Wed, Sep 12, 2018 at 1:56 AM Matan Azrad > wrote: > > > > Hi Chas > > > > From: Chas Williams > > > On Mon, Aug 6, 2018 at 3:35 PM Matan Azrad > > > wrote: > > > > > > > > > > > &

Re: [dpdk-dev] [PATCH] net/bonding: propagate promiscous mode in mode 4

2018-09-16 Thread Matan Azrad
Hi Chas From: Chas Williams > On Thu, Sep 13, 2018 at 11:40 AM Matan Azrad > wrote: > > > > Hi Chas > > > > From: Chas Williams > > > On Wed, Sep 12, 2018 at 1:56 AM Matan Azrad > > > wrote: > > > > > > > > Hi Chas >

Re: [dpdk-dev] [PATCH] net/bonding: ensure fairness among slaves

2018-09-19 Thread Matan Azrad
well. > > Fixes: 2efb58cbab6e ("bond: new link bonding library") If it is a fix, why not to use a fix title? Maybe net/bonding: fix the slaves Rx fairness > Cc: sta...@dpdk.org > > Signed-off-by: Chas Williams Besides that: Acked-by: Mat

Re: [dpdk-dev] [PATCH 10/11] net/failsafe: fix sub-device ownership race

2018-05-09 Thread Matan Azrad
, May 09, 2018 at 11:43:36AM +0200, Thomas Monjalon wrote: > From: Matan Azrad > > There is time between the sub-device port probing by the sub-device PMD > to the sub-device port ownership taking by a fail-safe port. > > In this time, the port is available for the appl

Re: [dpdk-dev] [PATCH v2 10/11] net/failsafe: fix sub-device ownership race

2018-05-10 Thread Matan Azrad
Hi Andrew > From: Andrew Rybchenko > On 05/10/2018 01:43 AM, Thomas Monjalon wrote: > From: Matan Azrad > > There is time between the sub-device port probing by the sub-device PMD to > the sub-device port ownership taking by a fail-safe port. > > In this time, the p

Re: [dpdk-dev] [PATCH v5 12/16] net/vdev_netvsc: readlink inputs cannot be aliased

2018-05-13 Thread Matan Azrad
Hi Andy From: Andy Green > /home/agreen/projects/dpdk/drivers/net/vdev_netvsc/ Please replace "/home/agreen/projects/dpdk" in $DPDK_DIR, I think this is relevant for all the series. > vdev_netvsc.c:335:2:error: passing argument 2 to restrict- qualified parameter > aliases with argument 1 [-Werro

Re: [dpdk-dev] [PATCH v5 13/16] net/vdev_netvsc: 3 x strncpy misuse

2018-05-13 Thread Matan Azrad
Hi Andy From: Andy Green > Signed-off-by: Andy Green > Fixes: e7dc5d7becc5 ("net/vdev_netvsc: implement core functionality") > Cc: sta...@dpdk.org No need the fix line, it is just conversion. Actually the strlcpy was introduced later and the next commit should have it: c022cb400e92 ("convert sn

Re: [dpdk-dev] [PATCH] app/testpmd: fix print unused parameter name

2018-05-14 Thread Matan Azrad
t;devargs: rename legacy API") > Cc: sta...@dpdk.org Really minor : Missing empty line here. > Signed-off-by: Zhiyong Yang Acked-by: Matan Azrad > --- > app/test-pmd/testpmd.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/app/test-pmd/t

[dpdk-dev] [PATCH] net/mlx5: support MPLS-in-GRE and MPLS-in-UDP

2018-05-14 Thread Matan Azrad
Add support for MPLS over GRE and MPLS over UDP tunnel types as described in the next RFCs: 1. https://tools.ietf.org/html/rfc4023 2. https://tools.ietf.org/html/rfc7510 3. https://tools.ietf.org/html/rfc4385 Signed-off-by: Matan Azrad --- doc/guides/nics/mlx5.rst | 4 +- drivers/net/mlx5

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bonding: fix slave activation simultaneously

2018-05-15 Thread Matan Azrad
evice, and do not pretend to solve all the sync issues. > > On Mon, May 14, 2018 at 8:41 AM, Ferruh Yigit > wrote: > On 5/14/2018 12:45 PM, Doherty, Declan wrote: > > On 24/04/2018 12:29 PM, Matan Azrad wrote: > >> The bonding PMD decides to activate\deactivate its sl

Re: [dpdk-dev] [PATCH] net/mlx5: support MPLS-in-GRE and MPLS-in-UDP

2018-05-15 Thread Matan Azrad
Hi Nelio From: Nélio Laranjeiro > Hi Matan, > > I have a single comment, please see bellow, > > On Mon, May 14, 2018 at 01:41:20PM +0000, Matan Azrad wrote: > > Add support for MPLS over GRE and MPLS over UDP tunnel types as > > described in the next RFCs

[dpdk-dev] [PATCH v2] net/mlx5: support MPLS-in-GRE and MPLS-in-UDP

2018-05-15 Thread Matan Azrad
Add support for MPLS over GRE and MPLS over UDP tunnel types as described in the next RFCs: 1. https://tools.ietf.org/html/rfc4023 2. https://tools.ietf.org/html/rfc7510 3. https://tools.ietf.org/html/rfc4385 Signed-off-by: Matan Azrad --- doc/guides/nics/mlx5.rst | 4 +- drivers/net/mlx5

[dpdk-dev] [PATCH 2/2] net/failsafe: fix duplicate event registraton

2018-05-17 Thread Matan Azrad
When the fail-safe device is reconfigured, it attempts to register again for the sub-devices LSC and RMV events. Prevent an event registration if it is already done. Fixes: 598fb8aec6f6 ("net/failsafe: support device removal") Cc: sta...@dpdk.org Signed-off-by: Matan Azrad --- d

[dpdk-dev] [PATCH 1/2] net/failsafe: fix removed sub-device cleanup

2018-05-17 Thread Matan Azrad
of a different fail-safe device. Unregister the LSC and RMV callbacks for sub-devices which are not used. Fixes: 598fb8aec6f6 ("net/failsafe: support device removal") Cc: sta...@dpdk.org Signed-off-by: Matan Azrad --- drivers/net/failsafe/failsafe_ether.c | 22

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix pmd_test_exit function for vdevs

2018-05-18 Thread Matan Azrad
Hi all While this patch also applied I don't understand it. Is it mandatory for each PMD to free all its resources in dev_close()? Or it should be done by the rte_device remove function? If the resource cleanup should be done by the remove function I think it should be called for all the devices

[dpdk-dev] [PATCH] net/vdev_netvsc: fix automatic probing

2018-05-21 Thread Matan Azrad
devices names without the index. Fixes: 56252de779a6 ("net/vdev_netvsc: add automatic probing") Cc: sta...@dpdk.org Signed-off-by: Matan Azrad --- drivers/net/vdev_netvsc/vdev_netvsc.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/v

Re: [dpdk-dev] [PATCH] net/vdev_netvsc: fix automatic probing

2018-05-21 Thread Matan Azrad
From: Stephen Hemminger > On Mon, 21 May 2018 16:23:30 + > Matan Azrad wrote: > > > The vdev_netvsc driver allows an automatic probe in Hyper-V VM systems > > unless it was already specified by the EAL command line. > > > > The detection of a specified

Re: [dpdk-dev] [PATCH v2] bus/vdev: fix scope of device list lock

2018-05-21 Thread Matan Azrad
protecting the device list inside the bus driver. > > Fixes: 35f462839b69 ("bus/vdev: add lock on device list") > > Signed-off-by: Thomas Monjalon Tested-by: Matan Azrad

[dpdk-dev] [PATCH v2 1/2] net/failsafe: fix removed sub-device cleanup

2018-05-21 Thread Matan Azrad
evice of a different fail-safe device. Unregister the LSC and RMV callbacks for sub-devices which are not used. Fixes: 598fb8aec6f6 ("net/failsafe: support device removal") Cc: sta...@dpdk.org Signed-off-by: Matan Azrad --- drivers/net/failsafe/failsafe_ether.c | 22

[dpdk-dev] [PATCH v2 2/2] net/failsafe: fix duplicate event registration

2018-05-21 Thread Matan Azrad
When the fail-safe device is reconfigured, it attempts to register again for the sub-devices LSC and RMV events. Prevent an event registration if it is already done. Fixes: 598fb8aec6f6 ("net/failsafe: support device removal") Cc: sta...@dpdk.org Signed-off-by: Matan Azrad --- d

Re: [dpdk-dev] [PATCH v2 1/2] net/failsafe: fix removed sub-device cleanup

2018-05-22 Thread Matan Azrad
Hi Gaetan From: Gaëtan Rivet > Hello Matan, > > On Mon, May 21, 2018 at 07:48:03PM +0000, Matan Azrad wrote: > > The fail-safe PMD registers to RMV event for each removable sub-device > > port in order to cleanup the sub-device resources and switch the Tx > > sub

Re: [dpdk-dev] [PATCH v3] bus/vdev: replace device list lock by a recursive one

2018-05-22 Thread Matan Azrad
dev: add lock on device list") > > Suggested-by: Anatoly Burakov > Signed-off-by: Thomas Monjalon Tested-by: Matan Azrad > --- > v3: try recursive lock > WARNING: not yet tested! > --- > drivers/bus/vdev/vdev.c | 26 ++ > 1 file chang

Re: [dpdk-dev] [PATCH v2 1/2] net/failsafe: fix removed sub-device cleanup

2018-05-22 Thread Matan Azrad
From: Gaëtan Rivet > On Tue, May 22, 2018 at 10:19:14AM +0000, Matan Azrad wrote: > > Hi Gaetan > > > > From: Gaëtan Rivet > > > Hello Matan, > > > > > > On Mon, May 21, 2018 at 07:48:03PM +, Matan Azrad wrote: > > > > The fail-sa

[dpdk-dev] [PATCH v3 1/2] net/failsafe: fix removed sub-device cleanup

2018-05-22 Thread Matan Azrad
evice of a different fail-safe device. Unregister the LSC and RMV callbacks for sub-devices which are not used. Fixes: 598fb8aec6f6 ("net/failsafe: support device removal") Cc: sta...@dpdk.org Signed-off-by: Matan Azrad --- V2: Improve the commit log and add code comments for the new

[dpdk-dev] [PATCH v3 2/2] net/failsafe: fix duplicate event registration

2018-05-22 Thread Matan Azrad
When the fail-safe device is reconfigured, it attempts to register again for the sub-devices LSC and RMV events. Prevent an event registration if it is already done. Fixes: 598fb8aec6f6 ("net/failsafe: support device removal") Cc: sta...@dpdk.org Signed-off-by: Matan Azrad --- d

Re: [dpdk-dev] [PATCH] net/mlx5: fix GRE flow rule

2018-05-22 Thread Matan Azrad
Hi Yongseok From: Yongseok Koh > Creating a flow having pattern from the middle of a packet is allowed. For > example, > > testpmd> flow create 0 ingress pattern vxlan vni is 20 / end actions ... > > Device can parse GRE header but without proper support from library and > firmware (HAVE_IBV_

Re: [dpdk-dev] [PATCH] net/mlx5: fix GRE flow rule

2018-05-23 Thread Matan Azrad
Hi Yongseok + Steven From: Yongseok Koh > On Tue, May 22, 2018 at 10:36:43PM -0700, Matan Azrad wrote: > > Hi Yongseok > > > > From: Yongseok Koh > > > Creating a flow having pattern from the middle of a packet is > > > allowed. For example, >

Re: [dpdk-dev] [PATCH] net/mlx5: fix GRE flow rule

2018-05-23 Thread Matan Azrad
Hi Yongseok From: Yongseok Koh > On Wed, May 23, 2018 at 04:45:33AM -0700, Matan Azrad wrote: > > > > Hi Yongseok > > + Steven > > > > From: Yongseok Koh > > > On Tue, May 22, 2018 at 10:36:43PM -0700, Matan Azrad wrote: > > > > Hi Yongseok

Re: [dpdk-dev] [RFC] hot plug failure handle mechanism

2018-05-24 Thread Matan Azrad
Hi Guo Some questions. From: Guo Jia > As we know, hot plug is an importance feature whenever it use for the > datacenter device's fail-safe and consumption management , or use for the > dynamic deployment and SRIOV Live Migration in SDN/NFV, it could be bring > the higher flexibility and contin

Re: [dpdk-dev] [PATCH] net/bonding: don't clear active slave count

2018-06-06 Thread Matan Azrad
Hi Chas From: Chas Williams > From: "Charles (Chas) Williams" > > When the bond PMD is stopped, the active slave count is reset. > For 802.3ad mode this potentially leaks memory and clears state since a second > sequential activate_slave() will occur when the bond PMD is restarted and the > LSC

Re: [dpdk-dev] [PATCH v3 1/2] eal: add API to align integer to previous power of 2

2018-04-04 Thread Matan Azrad
Hi Pavan Shouldn't the new APIs be tagged with the experimental tag as agreed? Besides that, Acked-by: Matan Azrad From: Pavan Nikhilesh, Wednesday, April 4, 2018 1:16 PM > Add 32b and 64b API's to align the given integer to the previous power of 2. > > Signed-off-

Re: [dpdk-dev] [PATCH V18 4/4] app/testpmd: enable device hotplug monitoring

2018-04-04 Thread Matan Azrad
Hi all What do you think about adding the "--hotplug" parameter as a new EAL command line parameter? From: Tan, Jianfeng, Wednesday, April 4, 2018 6:23 AM > > -Original Message- > > From: Guo, Jia > > Sent: Tuesday, April 3, 2018 6:34 PM > > To: step...@networkplumber.org; Richardson, Br

Re: [dpdk-dev] [PATCH v3 1/2] eal: add API to align integer to previous power of 2

2018-04-04 Thread Matan Azrad
From: Pavan Nikhilesh, Wednesday, April 4, 2018 7:42 PM > Hi Matan, > > On Wed, Apr 04, 2018 at 04:10:36PM +0000, Matan Azrad wrote: > > Hi Pavan > > > > Shouldn't the new APIs be tagged with the experimental tag as agreed? > > Can't tag it experimen

Re: [dpdk-dev] [PATCH v3 1/2] eal: add API to align integer to previous power of 2

2018-04-04 Thread Matan Azrad
Hi Pavan From: Pavan Nikhilesh, Wednesday, April 4, 2018 8:52 PM > On Wed, Apr 04, 2018 at 05:11:22PM +0000, Matan Azrad wrote: > > > > > > From: Pavan Nikhilesh, Wednesday, April 4, 2018 7:42 PM > > > Hi Matan, > > > > > > On Wed, Apr 04, 2018 at

Re: [dpdk-dev] [PATCH v3 1/2] eal: add API to align integer to previous power of 2

2018-04-04 Thread Matan Azrad
Hi Pavan From: Pavan Nikhilesh, Wednesday, April 4, 2018 9:16 PM > Hi Matan, > > > > > Got you. > > Looks like you found issue here... > > The experimental tag probably should be in a root .h file. > > Probably, need a fix patch to move it for a different\new .h file. > > > > What do you think? >

Re: [dpdk-dev] [PATCH v3 1/2] eal: add API to align integer to previous power of 2

2018-04-04 Thread Matan Azrad
Hi Pavan From: Pavan Nikhilesh, Wednesday, April 4, 2018 9:36 PM > On Wed, Apr 04, 2018 at 06:23:19PM +0000, Matan Azrad wrote: > > Hi Pavan > > > > From: Pavan Nikhilesh, Wednesday, April 4, 2018 9:16 PM > > > Hi Matan, > > > > > > > >

Re: [dpdk-dev] [PATCH v4 10/20] eal/dev: implement device iteration

2018-04-09 Thread Matan Azrad
HI Gaetan From: Gaetan Rivet, Friday, March 30, 2018 12:24 AM > +/* '\0' forbidden in sym */ > +static const char * > +strfirstof(const char *str, > +const char *sym) > +{ > + const char *s; > + > + for (s = str; s[0] != '\0'; s++) { > + const char *c; > + > +

Re: [dpdk-dev] [PATCH v4 18/20] ethdev: register ether layer as a class

2018-04-09 Thread Matan Azrad
Hi Gaetan From: Gaetan Rivet, Friday, March 30, 2018 12:24 AM > Signed-off-by: Gaetan Rivet > --- > lib/Makefile | 2 +- > lib/librte_ether/Makefile| 3 +- > lib/librte_ether/rte_class_eth.c | 73 > > 3 files changed, 76 inse

Re: [dpdk-dev] [PATCH v4 18/20] ethdev: register ether layer as a class

2018-04-09 Thread Matan Azrad
Hi Gaetan From: Gaëtan Rivet, Monday, April 9, 2018 10:47 AM > Hi Matan, > > On Mon, Apr 09, 2018 at 07:41:58AM +0000, Matan Azrad wrote: > > Hi Gaetan > > > > From: Gaetan Rivet, Friday, March 30, 2018 12:24 AM > > > Signed-off-by: Gaetan

Re: [dpdk-dev] [PATCH v1] net/vdev_netvsc: fix creating short name devices

2018-04-10 Thread Matan Azrad
Hi Ophir From: Ophir Munk, Tuesday, April 10, 2018 10:20 AM > Prior to this commit the vdev_netvsc PMD was creating tap and failsafe > devices with long names, such as "net_tap_net_vdev_netvsc0" or > "net_failsafe_net_vdev_netvsc0". > Long names containing more than 32 characters may be rejected b

[dpdk-dev] [PATCH 1/3] net/vdev_netvsc: remove specified devices IP check

2018-04-10 Thread Matan Azrad
a...@dpdk.org Signed-off-by: Matan Azrad --- doc/guides/nics/vdev_netvsc.rst | 10 +++--- drivers/net/vdev_netvsc/vdev_netvsc.c | 2 +- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/doc/guides/nics/vdev_netvsc.rst b/doc/guides/nics/vdev_netvsc.rst index 55d130a..a2d49f4

[dpdk-dev] [PATCH 2/3] net/vdev_netvsc: add check for specifying by 1 way

2018-04-10 Thread Matan Azrad
driver initialization. Cc: sta...@dpdk.org Signed-off-by: Matan Azrad --- drivers/net/vdev_netvsc/vdev_netvsc.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/vdev_netvsc/vdev_netvsc.c b/drivers/net/vdev_netvsc/vdev_netvsc.c index d2c41a5..018ffae 100644 --- a/drivers/net

[dpdk-dev] [PATCH 0/3] vdev_netvsc: improve the device args parameters meaning

2018-04-10 Thread Matan Azrad
After some experience with the device running, it is better to change the meaning of the "force" parameter in whitelist mode. Matan Azrad (3): net/vdev_netvsc: remove specified devices IP check net/vdev_netvsc: add check for specifying by 1 way net/vdev_netvsc: prefer netvsc

[dpdk-dev] [PATCH 3/3] net/vdev_netvsc: prefer netvsc devices in scan

2018-04-10 Thread Matan Azrad
efore any non-netvsc device, even when the "force" parameter is set. Cc: sta...@dpdk.org Signed-off-by: Matan Azrad --- drivers/net/vdev_netvsc/vdev_netvsc.c | 122 ++ 1 file changed, 65 insertions(+), 57 deletions(-) diff --git a/drivers/net/vdev_netvs

Re: [dpdk-dev] [PATCH v1] net/vdev_netvsc: fix creating short name devices

2018-04-10 Thread Matan Azrad
e > devices with long names, such as "net_tap_net_vdev_netvsc0" or > "net_failsafe_net_vdev_netvsc0". > This commits creates tap and failsafe devices with short names such as > "net_tap_netvsc0" or "net_failsafe_netvsc0". > > > -Orig

Re: [dpdk-dev] [PATCH V19 4/4] app/testpmd: use auto handle for hotplug

2018-04-11 Thread Matan Azrad
Hi All From: Jeff Guo, Friday, April 6, 2018 1:57 PM > Use testpmd for example, to show how an application smoothly handle > failure when device be hot removal, and show how to auto bind kernal driver > to preparing attach device when device being hot insertion. I saw the kmod of old devices were

Re: [dpdk-dev] [PATCH V19 4/4] app/testpmd: use auto handle for hotplug

2018-04-13 Thread Matan Azrad
Hi Guo From: Guo, Jia, Friday, April 13, 2018 1:48 PM > hi matan > > > On 4/12/2018 1:31 PM, Matan Azrad wrote: > > Hi All > > > > From: Jeff Guo, Friday, April 6, 2018 1:57 PM > >> Use testpmd for example, to show how an application smoothly handle >

Re: [dpdk-dev] kernel binding of devices + hotplug

2018-04-14 Thread Matan Azrad
Hi all From: Burakov, Anatoly, Friday, April 13, 2018 8:41 PM > To: Bruce Richardson ; Thomas Monjalon > > Cc: dev@dpdk.org; pmati...@redhat.com; david.march...@6wind.com; > jia@intel.com; Matan Azrad ; > konstantin.anan...@intel.com; step...@networkplumber.org; > f...@re

Re: [dpdk-dev] [PATCH] net/bonding: fix link properties with autoneg

2018-04-16 Thread Matan Azrad
Hi Chas From: Chas Williams, Wednesday, February 14, 2018 12:55 AM > If a link is carrier down and using autonegotiation, then the PMD may not > have detected a speed yet. In this case the best we can do is ignore the link > speed and duplex since they aren't valid. Ok for this. > To be comple

Re: [dpdk-dev] kernel binding of devices + hotplug

2018-04-16 Thread Matan Azrad
Hi Guo From: Guo, Jia, Monday, April 16, 2018 12:26 PM > To: Matan Azrad ; Burakov, Anatoly > ; Bruce Richardson > ; Thomas Monjalon > Cc: dev@dpdk.org; pmati...@redhat.com; david.march...@6wind.com; > konstantin.anan...@intel.com; step...@networkplumber.org; > f...@redhat

Re: [dpdk-dev] kernel binding of devices + hotplug

2018-04-16 Thread Matan Azrad
Hi Bruce From: Bruce Richardson, Monday, April 16, 2018 11:32 AM > On Sat, Apr 14, 2018 at 08:10:28PM +0000, Matan Azrad wrote: > > Hi all > > > > From: Burakov, Anatoly, Friday, April 13, 2018 8:41 PM > > > To: Bruce Richardson ; Thomas Monjalon > > > >

Re: [dpdk-dev] kernel binding of devices + hotplug

2018-04-16 Thread Matan Azrad
Hi Stephen From: Stephen Hemminger, Monday, April 16, 2018 7:57 PM > On Mon, 16 Apr 2018 16:11:12 + > Matan Azrad wrote: > > > > If the device management is only managed in one place, i.e. not in > > > DPDK, then there is no conflict to manage. > > >

Re: [dpdk-dev] kernel binding of devices + hotplug

2018-04-16 Thread Matan Azrad
Hi Stephen From: Stephen Hemminger, Monday, April 16, 2018 8:19 PM > On Mon, 16 Apr 2018 17:10:09 + > Matan Azrad wrote: > > > Hi Stephen > > > > From: Stephen Hemminger, Monday, April 16, 2018 7:57 PM > > > On Mon, 16 Apr 2018 16:11:12 + > > &g

Re: [dpdk-dev] [PATCH] net/bonding: fix link properties with autoneg

2018-04-16 Thread Matan Azrad
Hi Chas From: Chas Williams, Monday, April 16, 2018 7:44 PM > On Mon, Apr 16, 2018 at 4:06 AM, Matan Azrad > wrote: > > Hi Chas > > > > From: Chas Williams, Wednesday, February 14, 2018 12:55 AM > >> If a link is carrier down and using autonegotiation, then the

Re: [dpdk-dev] [PATCH v5 10/11] ethdev: fix missing boolean values in flow command

2018-04-16 Thread Matan Azrad
Hi Adrien I think the title should be "app/testpmd: ..." ... From: Adrien Mazarguil, Monday, April 16, 2018 7:22 PM > Original implementation lacks the on/off toggle. > > This patch shows up as a fix because it has been a popular request ever since > the first DPDK release with the original impl

[dpdk-dev] [PATCH v3 0/8] Introduce virtual driver for Hyper-V/Azure platforms

2018-01-09 Thread Matan Azrad
es probing. - Adjusted documentation and semantics. - Replaced maintainer. Adrien Mazarguil (2): net/failsafe: fix invalid free net/failsafe: add "fd" parameter Matan Azrad (6): net/failsafe: support probed sub-devices getting net/vdev_netvsc: introduce Hyper-V platform driver net/vde

[dpdk-dev] [PATCH v3 1/8] net/failsafe: fix invalid free

2018-01-09 Thread Matan Azrad
From: Adrien Mazarguil rte_free() is not supposed to work with pointers returned by calloc(). Fixes: a0194d828100 ("net/failsafe: add flexible device definition") Cc: sta...@dpdk.org Cc: Gaetan Rivet Signed-off-by: Adrien Mazarguil --- drivers/net/failsafe/failsafe_args.c | 2 +- 1 file chan

[dpdk-dev] [PATCH v3 2/8] net/failsafe: add "fd" parameter

2018-01-09 Thread Matan Azrad
From: Adrien Mazarguil This parameter enables applications to provide device definitions through an arbitrary file descriptor number. Signed-off-by: Adrien Mazarguil Cc: Gaetan Rivet --- doc/guides/nics/fail_safe.rst | 9 drivers/net/failsafe/failsafe_args.c| 86 ++

[dpdk-dev] [PATCH v3 3/8] net/failsafe: support probed sub-devices getting

2018-01-09 Thread Matan Azrad
Previous fail-safe code didn't support getting probed sub-devices and failed when it tried to probe them. Skip fail-safe sub-device probing when it already was probed. Signed-off-by: Matan Azrad Cc: Gaetan Rivet --- doc/guides/nics/fail_safe.rst | 5 drivers/net/fai

[dpdk-dev] [PATCH v3 5/8] net/vdev_netvsc: implement core functionality

2018-01-09 Thread Matan Azrad
es to corresponding fail-safe instances. Signed-off-by: Adrien Mazarguil Signed-off-by: Matan Azrad --- doc/guides/nics/vdev_netvsc.rst | 70 + drivers/net/vdev_netvsc/Makefile | 4 + drivers/net/vdev_netvsc/vdev_netvsc.c | 544 +- 3 files changed

[dpdk-dev] [PATCH v3 4/8] net/vdev_netvsc: introduce Hyper-V platform driver

2018-01-09 Thread Matan Azrad
This patch lays the groundwork for this driver (draft documentation, copyright notices, code base skeleton and build system hooks). While it can be successfully compiled and invoked, it's an empty shell at this stage. Signed-off-by: Adrien Mazarguil Signed-off-by: Matan Azrad --- MAINTA

[dpdk-dev] [PATCH v3 6/8] net/vdev_netvsc: skip routed netvsc probing

2018-01-09 Thread Matan Azrad
NetVSC netdevices which are already routed should not be probed because they are used for management purposes by the HyperV. prevent routed netvsc devices probing. Signed-off-by: Raslan Darawsheh Signed-off-by: Matan Azrad --- doc/guides/nics/vdev_netvsc.rst | 2 +- drivers/net

[dpdk-dev] [PATCH v3 7/8] net/vdev_netvsc: add "force" parameter

2018-01-09 Thread Matan Azrad
This parameter allows specifying any non-NetVSC interface or routed NetVSC interfaces to use with tap sub-devices for development purposes. Signed-off-by: Adrien Mazarguil Signed-off-by: Matan Azrad --- doc/guides/nics/vdev_netvsc.rst | 5 + drivers/net/vdev_netvsc/vdev_netvsc.c

[dpdk-dev] [PATCH v3 8/8] net/vdev_netvsc: add automatic probing

2018-01-09 Thread Matan Azrad
"ignore" parameter to disable this auto-detection. Signed-off-by: Matan Azrad --- doc/guides/nics/vdev_netvsc.rst | 9 -- drivers/net/vdev_netvsc/vdev_netvsc.c | 55 +-- 2 files changed, 60 insertions(+), 4 deletions(-) diff --git a/doc/g

[dpdk-dev] [PATCH v4 0/6] Fail-safe\ethdev: fix removal handling lack

2018-01-10 Thread Matan Azrad
from fail-safe patch. No changes in ethdev\mlx patches. Matan Azrad (6): ethdev: add devop to check removal status net/mlx4: support a device removal check operation net/mlx5: support a device removal check operation ethdev: adjust APIs removal error report ethdev: adjust flow APIs r

[dpdk-dev] [PATCH v4 1/6] ethdev: add devop to check removal status

2018-01-10 Thread Matan Azrad
ately. Signed-off-by: Matan Azrad Acked-by: Thomas Monjalon --- lib/librte_ether/rte_ethdev.c | 28 +--- lib/librte_ether/rte_ethdev.h | 17 + lib/librte_ether/rte_ethdev_version.map | 7 +++ 3 files changed, 49 insertions(

[dpdk-dev] [PATCH v4 2/6] net/mlx4: support a device removal check operation

2018-01-10 Thread Matan Azrad
Add support to get removal status of mlx4 device. Signed-off-by: Matan Azrad --- drivers/net/mlx4/mlx4.c| 1 + drivers/net/mlx4/mlx4.h| 1 + drivers/net/mlx4/mlx4_ethdev.c | 20 3 files changed, 22 insertions(+) diff --git a/drivers/net/mlx4/mlx4.c b

<    1   2   3   4   5   6   7   8   9   10   >