Re: [dpdk-dev] [PATCH] ethdev: remove deprecated shared counter attribute

Hi Andrew Thank you for the big effort to adjust mlx5. I left some comments inside. If you feel it is too much, we can do a later patch to improve. Matan > From: Andrew Rybchenko > Indirect actions should be used to do shared counters. > > Signed-off-by: Andrew Rybchenko > --- > app/test-pmd

Re: [dpdk-dev] [PATCH v5 4/6] ethdev: remove jumbo offload flag

yev > Signed-off-by: Ferruh Yigit > Acked-by: Andrew Rybchenko > Reviewed-by: Rosen Xu > Acked-by: Somnath Kotur Acked-by: Matan Azrad For mlx4/5 PMDs.

Re: [dpdk-dev] [PATCH v4 1/6] ethdev: fix max Rx packet length

Hi Ferruh From: Ferruh Yigit > There is a confusion on setting max Rx packet length, this patch aims to > clarify it. > > 'rte_eth_dev_configure()' API accepts max Rx packet size via > 'uint32_t max_rx_pkt_len' field of the config struct 'struct > rte_eth_conf'. > > Also 'rte_eth_dev_set_mtu()

Re: [dpdk-dev] [PATCH v2] ethdev: remove deprecated shared counter attribute

From: Andrew Rybchenko > Indirect actions should be used to do shared counters. > > Signed-off-by: Andrew Rybchenko > Acked-by: Thomas Monjalon > Acked-by: Ajit Khaparde > Acked-by: Somnath Kotur > Acked-by: Ori Kam Acked-by: Matan Azrad for mlx5.

Re: [dpdk-dev] [PATCH 0/6] mlx5: some independent fixes

drivers/net/mlx5/mlx5.c | 4 +++- > drivers/net/mlx5/mlx5.h | 1 + > 4 files changed, 34 insertions(+), 12 deletions(-) Series-acked-by: Matan Azrad > -- > 2.25.1

Re: [dpdk-dev] [PATCH] regex/mlx5: fix RegEx probing error flow

t combined rule file") > Cc: sta...@dpdk.org > > Signed-off-by: Michael Baum Acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH] crypto/mlx5: support timestamp format

t; > Signed-off-by: Michael Baum Acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH] compress/mlx5: fix QP setup error flow

From: Michael Baum > Sent: Tuesday, August 31, 2021 11:40 PM > To: dev@dpdk.org > Cc: Matan Azrad ; sta...@dpdk.org > Subject: [PATCH] compress/mlx5: fix QP setup error flow > > The QP setup function allocates buffer for its opaque MR and register it into > MR structu

RE: [PATCH] net/mlx5: fix shared Rx queue config reuse

5: support shared Rx queue") > > Signed-off-by: Alexander Kozyrev Acked-by: Matan Azrad

RE: [PATCH v2] mlx5/testpmd: fix crash on quit with avail thresh enabled

e6ae ("app/testpmd: add host shaper command") > Cc: sta...@dpdk.org > > Signed-off-by: Spike Du Acked-by: Matan Azrad

RE: [PATCH 0/2] net/mlx5/hws: fix matcher clean up for FDB tables

ed. > > Erez Shitrit (2): > net/mlx5/hws: fix order of destroying default tables > net/mlx5/hws: fix disconnecting matcher > > drivers/net/mlx5/hws/mlx5dr_matcher.c | 35 > +++ > drivers/net/mlx5/hws/mlx5dr_table.c | 2 +- > 2 f

[PATCH] doc: improve event core description in vDPA mlx5

: Matan Azrad --- doc/guides/vdpadevs/mlx5.rst | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/doc/guides/vdpadevs/mlx5.rst b/doc/guides/vdpadevs/mlx5.rst index 9767fbe42d..3b5ce6df38 100644 --- a/doc/guides/vdpadevs/mlx5.rst +++ b/doc/guides/vdpadevs/mlx5.rst @@ -86,8

RE: [PATCH] common/mlx5: improve AES-XTS tweek capability check

th all the devices. > > Signed-off-by: Suanming Mou Acked-by: Matan Azrad

RE: [PATCH] net/mlx5/hws: fix incorrect dw_8_6_ext PRM offset

off-by: Alex Vesker > Reviewed-by: Erez Shitrit Acked-by: Matan Azrad

RE: [PATCH v2] net/mlx5: add stub functions to null drv ops

virtual function without basing > the > decision on a specific drv type. > > Signed-off-by: Asaf Penso Acked-by: Matan Azrad

[dpdk-dev] [RFC] drivers: introduce mlx5 crypto PMD

mlx5 DevX. This patch adds the PCI probing, basic functions, build files and log utility. Signed-off-by: Shiri Kuzin Acked-by: Matan Azrad --- MAINTAINERS | 4 + drivers/common/mlx5/mlx5_common.h | 1 + drivers/common/mlx5/mlx5_common_pci.c | 14 ++ drivers

Re: [dpdk-dev] [PATCH 1/5] common/mlx5: add timestamp format support to DevX

_f[0x11]; > + u8 reserved_at_f[0xB]; > + u8 ts_format[0x02]; > + u8 reserved_at_1c[0x4]; > u8 reserved_at_20[0x8]; > u8 user_index[0x18]; > u8 reserved_at_40[0x8]; > @@ -2157,7 +2186,9 @@ struct mlx5_ifc_sqc_bits { > u8 hairpin[0x1]; > u8 non_wire[0x1]; > u8 static_sq_wq[0x1]; > - u8 reserved_at_11[0xf]; > + u8 reserved_at_11[0x9]; > + u8 ts_format[0x02]; > + u8 reserved_at_1c[0x4]; > u8 reserved_at_20[0x8]; > u8 user_index[0x18]; > u8 reserved_at_40[0x8]; > @@ -2684,7 +2715,9 @@ struct mlx5_ifc_qpc_bits { > u8 log_rq_stride[0x3]; > u8 no_sq[0x1]; > u8 log_sq_size[0x4]; > - u8 reserved_at_55[0x6]; > + u8 reserved_at_55[0x3]; > + u8 ts_format[0x2]; > + u8 reserved_at_5a[0x1]; > u8 rlky[0x1]; > u8 ulp_stateless_offload_mode[0x4]; > u8 counter_set_id[0x8]; > -- > 2.28.0 Beside above, Acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH 2/5] net/mlx5: add timestamp format support

92 ("net/mlx5: support Tx hairpin queues") > Fixes: 15c3807e86ab ("common/mlx5: support DevX QP operations") > Cc: sta...@dpdk.org > > Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH 3/5] vdpa/mlx5: add timestamp format support

umem_id = eqp->umem_obj->umem_id; > attr.dbr_address = (1 << log_desc_n) * MLX5_WSEG_SIZE; > + attr.ts_format = > + priv->qp_ts_format == > MLX5_HCA_CAP_TIMESTAMP_FORMAT_FR ? > + MLX5_QPC_TIMESTAMP_FORMAT_FREE_RUNNING : > + MLX5_QPC_TIMESTAMP_FORMAT_DEFAULT; > eqp->sw_qp = mlx5_devx_cmd_create_qp(priv->ctx, &attr); > if (!eqp->sw_qp) { > DRV_LOG(ERR, "Failed to create SW QP(%u).", rte_errno); > -- > 2.28.0 Acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH 4/5] regex/mlx5: add timestamp format support

Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH 5/5] compress/mlx5: add timestamp format support

@dpdk.org > > Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH] net/mlx5: fix Rx metadata leftovers

n metadata mode. > > Fixes: 6c55b622a956 ("net/mlx5: set dynamic flow metadata in Rx queues") > Cc: sta...@dpdk.org > > Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH v2 1/4] net/mlx4: enable debug logs dynamically

ug > > Signed-off-by: Thomas Monjalon Acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH v2 2/4] common/mlx5: enable debug logs dynamically

all debug logs can be enabled at runtime with: > --log-level pmd.net.mlx5:debug > > Signed-off-by: Thomas Monjalon Acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH v2 3/4] common/mlx5: remove extra line feed in log messages

From: Thomas Monjalon > The macro DRV_LOG already includes a terminating line feed character > defined in PMD_DRV_LOG_. > The extra line feeds added in some messages are removed. > > Signed-off-by: Thomas Monjalon Acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH v2 4/4] net/mlx5: reduce log level of alignment message

From: Thomas Monjalon > Having to force an alignment does not impact the user, so it should not be a > warning. > The log level is reduced from warning to debug. > > Signed-off-by: Thomas Monjalon Acked-by: Matan Azrad

[dpdk-dev] [PATCH] cryptodev: support multiple cipher data-units

also, thus sizes are usually common and probably will be shared among different devices. Signed-off-by: Matan Azrad --- First patch on it was sent as RFC. This is first formal version, I updated according to comments on RFC discussions: - Use data-unit term instead of block. - Update cipher l

[dpdk-dev] [PATCH] cryptodev: formalize key wrap method in API

by the same API. Signed-off-by: Matan Azrad --- lib/librte_cryptodev/rte_crypto_sym.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/librte_cryptodev/rte_crypto_sym.h b/lib/librte_cryptodev/rte_crypto_sym.h index 5973e31..6aca2c7 100644 --- a/lib/librte_cryptodev/rte_crypto_sym.h

[dpdk-dev] [PATCH] vdpa/mlx5: improve interrupt management

FD mechanism. Signed-off-by: Matan Azrad Acked-by: Xueming Li --- doc/guides/vdpadevs/mlx5.rst| 8 +- drivers/vdpa/mlx5/mlx5_vdpa.c | 8 +- drivers/vdpa/mlx5/mlx5_vdpa.h | 8 +- drivers/vdpa/mlx5/mlx5_vdpa_event.c | 308 +++- 4 files

Re: [dpdk-dev] [PATCH v2 2/4] common/mlx5: enable debug logs dynamically

From: Thomas Monjalon > 17/03/2021 18:39, Ferruh Yigit: > > On 3/9/2021 9:48 AM, Thomas Monjalon wrote: > > > Most debug logs are using DRV_LOG(DEBUG,) but some were using > > > DEBUG(). > > > The macro DEBUG is doing nothing if not compiled with > > > RTE_LIBRTE_MLX5_DEBUG. > > > > > > As it is

Re: [dpdk-dev] [PATCH] net/mlx5: support RSS expansion for IPv6 GRE

> Fixes: f4b901a46aec ("net/mlx5: add flow GRE item") > Cc: sta...@dpdk.org > > Signed-off-by: Xiaoyu Min Acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH 1/2] [RFC]: ethdev: add pre-defined meter policy API

Hi Cristian Thank you for your important review! I agree with all your comments except one, please see inline. From: Dumitrescu, Cristian > Hi Li and Matan, > > Thank you for your proposal, some comments below. > > I am also adding Jerin and Hemant to this thread, as they also participated in >

Re: [dpdk-dev] [PATCH 2/2] [RFC]: ethdev: manage meter API object handles by the drivers

Hi Cristian From: Dumitrescu, Cristian > Hi Li and Matan, > > > -Original Message- > > From: Li Zhang > > Sent: Thursday, March 18, 2021 8:58 AM > > To: dek...@nvidia.com; or...@nvidia.com; viachesl...@nvidia.com; > > ma...@nvidia.com; shah...@nvidia.com; lir...@marvell.com; Singh, > > J

Re: [dpdk-dev] [PATCH 2/2] [RFC]: ethdev: manage meter API object handles by the drivers

Hi Ajit Looks like you agree with this RFC to move meter objects to be managed by PMD pointers. Thanks for the review! From: Ajit Khaparde > On Thu, Mar 25, 2021 at 1:21 AM Matan Azrad wrote: > > > > Hi Cristian > > > > From: Dumitrescu, Cri

Re: [dpdk-dev] [PATCH 2/2] [RFC]: ethdev: manage meter API object handles by the drivers

Hi Jerin Thanks for the review. PSB From: Jerin Jacob > On Thu, Mar 25, 2021 at 1:51 PM Matan Azrad wrote: > > > > Hi Cristian > > > > From: Dumitrescu, Cristian > > > Hi Li and Matan, > > > > > > > -Original Message- > >

Re: [dpdk-dev] [PATCH 1/2] [RFC]: ethdev: add pre-defined meter policy API

Hi Jerin Thanks for the review. PSB From: Jerin Jacob > On Thu, Mar 18, 2021 at 2:28 PM Li Zhang wrote: > > > > Currently, the flow meter policy does not support multiple actions per > > color; also the allowed action types per color are very limited. > > In addition, the policy cannot be pre-de

Re: [dpdk-dev] [PATCH 1/2] [RFC]: ethdev: add pre-defined meter policy API

From: Dumitrescu, Cristian > Hi Matan, > > > -Original Message- > > From: Matan Azrad > > Sent: Thursday, March 25, 2021 6:57 AM > > To: Dumitrescu, Cristian ; Li Zhang > > ; Dekel Peled ; Ori Kam > > ; Slava Ovsiienko ; Shahaf > &g

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: replace callback getting filter operations

RTE_ETH_FILTER_GET are removed. > The new driver callback flow_ops_get replaces filter_ctrl. > > Signed-off-by: Thomas Monjalon > Acked-by: Ajit Khaparde > Acked-by: Haiyue Wang > Acked-by: Rosen Xu > Acked-by: Hemant Agrawal Acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH 1/2] net/mlx5: fix shared inner RSS

sta...@dpdk.org > > Signed-off-by: Xiaoyu Min Acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH 2/2] net/mlx5: fix missing shared RSS hash types

both of > them could be set so they can share same slot in mlx5_rss_hash_fields, means > only one TIR will be created. > > Fixes: d2046c09aa64 ("net/mlx5: support shared action for RSS") > Cc: sta...@dpdk.org > > Signed-off-by: Xiaoyu Min Acked-by: Matan Azrad

RE: [PATCH v2] doc: announce transition to vDPA device name function

ryptodev_sym_session`` and >``rte_cryptodev_asym_session`` to remove unnecessary indirection between > session and the private data of session. An opaque pointer can be exposed > -- > 2.36.1 Acked-by: Matan Azrad

RE: [dpdk-dev] [PATCH 1/1] net/mlx5: fix memory leak when releasing a drop action

Hi Yunjian From: Yunjian Wang > When the memory for hrxq->action is allocated in mlx5_devx_hrxq_new(). Memory -> resources .. are > But it was not being freed when the drop action was released in > mlx5_devx_drop_action_destroy(). These cause a memory leak. > > Fixes: bc5bee028ebc ("net/mlx5: c

RE: [PATCH v2 0/6] mlx5: external RxQ support

rect DevX flag updating. > - Improve explanations in doc and comments. > - Remove teatpmd part. > Series-acked-by: Matan Azrad > Michael Baum (6): > common/mlx5: consider local functions as internal > common/mlx5: glue device and PD importation > common/mlx5: add remote PD a

Re: mlx5_pci Decompression Error

Hi Shafiqul Your compressed data for decompress OP doesn't include b-final bit in the last block. May point to memory issue: cutting/garbage... השג את ‏Outlook עבור Android‏ מאת: Shafiqul Abedin נשלח: יום חמישי, 3 במרץ 2022, 02:32 אל: d

RE: [PATCH v1] net/mlx5: fix meter creation default state

ixes: 444320186393 ("net/mlx5: support meter creation with policy") > Cc: sta...@dpdk.org > Signed-off-by: Rongwei Liu Acked-by: Matan Azrad

RE: [PATCH] net/mlx5: set correct CPU socket ID for mlx5_rxq_ctrl

ot created Interactive-mode > selected .. > Configuring Port 0 (socket 1) > Port 0: 0C:42:A1:ED:C1:20 > Configuring Port 1 (socket 1) > Port 1: 0C:42:A1:ED:C1:21 > Checking link statuses... > Done > > > Signed-off-by: Thinh Tran > Reviewed-by: David Christensen Acked-by: Matan Azrad

RE: [PATCH] net/mlx5: fix FD configuration for Rx interrupt

From: David Marchand > On Thu, Mar 10, 2022 at 6:04 PM Michael Baum > wrote: > > > > # strace -r -f ./dpdk-dir/v21.11/examples/dpdk-l3fwd-power > > > > --lcores > > > > 0@3,1@5 -a :82:00.0 --in-memory -- -p 0x1 -P --config '(0,0,1)' > > > > ... > > > > [pid 534983] 0.000348 epoll_wait(2

Re: [dpdk-dev] [EXT] [PATCH v3 01/15] drivers: introduce mlx5 crypto PMD

Hi Akhil Thanks for the review, I know it was too tied for you to review, so, I really appreciate.. From: Akhil Goyal > > diff --git a/drivers/crypto/mlx5/meson.build > > b/drivers/crypto/mlx5/meson.build new file mode 100644 index > > 00..fd00283665 > > --- /dev/null > > +++ b/drivers/c

Re: [dpdk-dev] [EXT] [PATCH v3 03/15] crypto/mlx5: support session operations

From: Akhil Goyal > > +static void > > +mlx5_crypto_sym_session_clear(struct rte_cryptodev *dev, > > + struct rte_cryptodev_sym_session *sess) { > > + struct mlx5_crypto_priv *priv = dev->data->dev_private; > > + struct mlx5_crypto_session *sess_private_data = >

Re: [dpdk-dev] [EXT] [PATCH v3 09/15] crypto/mlx5: adjust to the multiple data unit API

From: Akhil Goyal > > From: Shiri Kuzin > > > > In AES-XTS the data to be encrypted\decrypted does not have to be in > > multiples of 16B size, the unit of data is called data-unit. > > > > As a result of patch [1] a new field is added to the cipher > > capability, called dataunit_set, where th

Re: [dpdk-dev] [EXT] [PATCH v3 10/15] crypto/mlx5: add keytag device argument

EK > > (and the attached keytag) and will fail the operation if the keytags > > don't match. > > > > This commit adds the configuration of the keytag with devargs. > > > > Signed-off-by: Suanming Mou > > Signed-off-by: Matan Azrad > > --

Re: [dpdk-dev] [EXT] [PATCH v3 13/15] crypto/mlx5: add enqueue and dequeue operations

From: Akhil Goyal > > @@ -685,9 +919,8 @@ mlx5_crypto_pci_probe(struct rte_pci_driver > > *pci_drv, > > DRV_LOG(INFO, > > "Crypto device %s was created successfully.", ibv->name); > > crypto_dev->dev_ops = &mlx5_crypto_ops; > > - crypto_dev->dequeue_burst = NULL; >

Re: [dpdk-dev] [EXT] [PATCH v3 15/15] crypto/mlx5: set feature flags and capabilities

From: Akhil Goyal > > + > > +Overview > > + > > + > > +The device can provide disk encryption services, allowing data > > +encryption and decryption towards a disk. Having all > > +encryption/decryption operations done in a single device can reduce > > +cost and overheads of the > > rela

Re: [dpdk-dev] [EXT] [PATCH v3 15/15] crypto/mlx5: set feature flags and capabilities

From: Akhil Goyal > > > > +Supported NICs > > > > +-- > > > > + > > > > +* Mellanox\ |reg| ConnectX\ |reg|-6 200G MCX654106A-HCAT > (2x200G) > > > > + > > > > +Prerequisites > > > > +- > > > > + > > > > +- Mellanox OFED version: **5.3** > > > > + see :doc:`../../nics/mlx

Re: [dpdk-dev] [EXT] [PATCH v3 10/15] crypto/mlx5: add keytag device argument

t; > > > keytag is also supplied in the BSF as plaintext. The HW will > > > > decrypt the DEK (and the attached keytag) and will fail the > > > > operation if the keytags don't match. > > > > > > > > This commit

Re: [dpdk-dev] [EXT] [PATCH v3 09/15] crypto/mlx5: adjust to the multiple data unit API

> -Original Message- > From: Akhil Goyal > Sent: Sunday, May 9, 2021 12:19 PM > To: Matan Azrad ; dev@dpdk.org > Cc: Suanming Mou ; NBU-Contact-Thomas > Monjalon ; Shiri Kuzin > Subject: RE: [EXT] [PATCH v3 09/15] crypto/mlx5: adjust to the multiple data > unit

Re: [dpdk-dev] [EXT] [PATCH v3 03/15] crypto/mlx5: support session operations

> -Original Message- > From: Akhil Goyal > Sent: Sunday, May 9, 2021 12:21 PM > To: Matan Azrad ; dev@dpdk.org > Cc: Suanming Mou ; NBU-Contact-Thomas > Monjalon ; Shiri Kuzin > Subject: RE: [EXT] [PATCH v3 03/15] crypto/mlx5: support session operations >

Re: [dpdk-dev] [EXT] [PATCH v3 01/15] drivers: introduce mlx5 crypto PMD

> -Original Message- > From: Akhil Goyal > Sent: Sunday, May 9, 2021 12:33 PM > To: Matan Azrad ; dev@dpdk.org > Cc: Suanming Mou ; NBU-Contact-Thomas > Monjalon ; Shiri Kuzin > Subject: RE: [EXT] [PATCH v3 01/15] drivers: introduce mlx5 crypto PMD > >

Re: [dpdk-dev] [EXT] [PATCH v3 10/15] crypto/mlx5: add keytag device argument

From: Thomas Monjalon > 09/05/2021 10:31, Matan Azrad: > > > > From: Akhil Goyal > > > > From: Suanming Mou > > > > > > > > A keytag is a piece of data encrypted together with a DEK. > > > > > > > > When a DEK is refer

[dpdk-dev] [PATCH v4 00/14] drivers: introduce mlx5 crypto PMD

Add a new PMD for Nvidia devices- crypto PMD. The crypto PMD will be supported on Nvidia ConnectX6 The crypto PMD will add the support of encryption and decryption using the AES-XTS symmetric algorithm. The crypto PMD requires rdma-core and uses mlx5 DevX. v2: Add data-path part. v3: Rebase. v4

[dpdk-dev] [PATCH v4 01/14] drivers: introduce mlx5 crypto PMD

DevX. This patch adds the PCI probing, basic functions, build files and log utility. Signed-off-by: Shiri Kuzin Acked-by: Matan Azrad --- MAINTAINERS | 4 + drivers/common/mlx5/mlx5_common.h | 1 + drivers/common/mlx5/mlx5_common_pci.c | 14 ++ drivers

[dpdk-dev] [PATCH v4 02/14] crypto/mlx5: add DEK object management

destroyed in dev_close routine. Signed-off-by: Shiri Kuzin Acked-by: Matan Azrad --- drivers/crypto/mlx5/meson.build | 1 + drivers/crypto/mlx5/mlx5_crypto.c | 44 + drivers/crypto/mlx5/mlx5_crypto.h | 51 ++ drivers/crypto/mlx5/mlx5_crypto_dek.c | 136

[dpdk-dev] [PATCH v4 03/14] crypto/mlx5: add session operations

. Signed-off-by: Shiri Kuzin Acked-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_crypto.c | 120 +- 1 file changed, 117 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/mlx5/mlx5_crypto.c b/drivers/crypto/mlx5/mlx5_crypto.c index 2825f4192e..31d27245be 100644

[dpdk-dev] [PATCH v4 04/14] crypto/mlx5: add basic operations

-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_crypto.c | 46 +++ drivers/crypto/mlx5/mlx5_crypto.h | 1 + 2 files changed, 42 insertions(+), 5 deletions(-) diff --git a/drivers/crypto/mlx5/mlx5_crypto.c b/drivers/crypto/mlx5/mlx5_crypto.c index 31d27245be..c1ae012d15

[dpdk-dev] [PATCH v4 05/14] crypto/mlx5: add queue pairs operations

(ready to send). Added implementation for the release QP function to release all the QP resources. Added the ops structure that contains any operation which is supported by the cryptodev. Signed-off-by: Shiri Kuzin Acked-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_crypto.c | 124

[dpdk-dev] [PATCH v4 06/14] crypto/mlx5: add dev stop and start operations

From: Shiri Kuzin Add the dev_start function that is used to start a configured device. Add the dev_stop function that is used to stop a configured device. Both functions set the dev parameter as used and return 0. Signed-off-by: Shiri Kuzin Acked-by: Matan Azrad --- drivers/crypto/mlx5

[dpdk-dev] [PATCH v4 08/14] crypto/mlx5: create login object using DevX

means logout. Signed-off-by: Shiri Kuzin Acked-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_crypto.c | 103 ++ drivers/crypto/mlx5/mlx5_crypto.h | 7 ++ 2 files changed, 110 insertions(+) diff --git a/drivers/crypto/mlx5/mlx5_crypto.c b/drivers/crypto/mlx5

[dpdk-dev] [PATCH v4 07/14] crypto/mlx5: add memory region management

nd creates a MR using a system call. Add memory region cache management: - 2 level cache per queue-pair - no locks. - 1 shared cache between all the queues using a lock. Using this way, the MR key search per data-path address is optimized. Signed-off-by: Shiri Kuzin Acked-by: M

[dpdk-dev] [PATCH v4 09/14] crypto/mlx5: add keytag devarg

x27;t match. This commit adds the configuration of the keytag with devargs. Signed-off-by: Suanming Mou Signed-off-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_crypto.c | 50 +-- drivers/crypto/mlx5/mlx5_crypto.h | 3 +- 2 files changed, 30 insertions(+), 23 dele

[dpdk-dev] [PATCH v4 12/14] crypto/mlx5: add enqueue and dequeue operations

commit adds the enquue and dequeue operations and updates the WQE set segments accordingly. Signed-off-by: Suanming Mou Signed-off-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_crypto.c | 242 +- drivers/crypto/mlx5/mlx5_crypto.h | 3 + 2 files changed, 241 insertions

[dpdk-dev] [PATCH v4 13/14] crypto/mlx5: add statistic get and reset operations

From: Suanming Mou This commit adds mlx5 crypto statistic get and reset operations. Signed-off-by: Suanming Mou Signed-off-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_crypto.c | 39 --- 1 file changed, 36 insertions(+), 3 deletions(-) diff --git a/drivers/crypto

[dpdk-dev] [PATCH v4 11/14] crypto/mlx5: add WQE set initialization

. This commit initializes the fixed WQE set segments. Signed-off-by: Suanming Mou Signed-off-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_crypto.c | 83 +-- drivers/crypto/mlx5/mlx5_crypto.h | 10 +++- 2 files changed, 87 insertions(+), 6 deletions(-) diff --git a

[dpdk-dev] [PATCH v4 10/14] crypto/mlx5: add maximum segments devarg

will be supported for crypto operations. Signed-off-by: Suanming Mou Signed-off-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_crypto.c | 35 +++ drivers/crypto/mlx5/mlx5_crypto.h | 7 +++ 2 files changed, 38 insertions(+), 4 deletions(-) diff --git a/drivers/crypto

[dpdk-dev] [PATCH v4 14/14] crypto/mlx5: set feature flags and capabilities

From: Shiri Kuzin Add the supported capabilities to the crypto driver. Add supported feature flags. Add crypto driver documentation. Signed-off-by: Shiri Kuzin Signed-off-by: Matan Azrad --- doc/guides/cryptodevs/features/mlx5.ini | 37 ++ doc/guides/cryptodevs/index.rst | 1

Re: [dpdk-dev] [EXT] [PATCH v3 01/15] drivers: introduce mlx5 crypto PMD

From: Akhil Goyal > > > > > > +fmt_name = 'mlx5_crypto' > > > > > > +deps += ['common_mlx5', 'eal', 'cryptodev'] > > > > > > > > > > I don't see a reason for eal dependency. Do you really need it? > > > > > > > > See RTE_LOG_REGISTER. > > > > > > Compilation works fine even after removing this d

Re: [dpdk-dev] [EXT] [PATCH v3 03/15] crypto/mlx5: support session operations

From: Akhil Goyal > > > > > > +static void > > > > > > +mlx5_crypto_sym_session_clear(struct rte_cryptodev *dev, > > > > > > + struct rte_cryptodev_sym_session *sess) > > > > > > { > > > > > > + struct mlx5_crypto_priv *priv = dev->data->dev_private; > > > > > > +

Re: [dpdk-dev] [EXT] [PATCH v3 09/15] crypto/mlx5: adjust to the multiple data unit API

From: Akhil Goyal > > > > > Also set feature flag in the code and the documentation in this patch. > > > > > I see that you are setting all of them in a single patch in the end. > > > > > This is not correct. It should be added where the feature is > > > > > supported. > > > > > Please fix thi

Re: [dpdk-dev] [EXT] [PATCH v3 10/15] crypto/mlx5: add keytag device argument

operation if the keytags don't match. > > > > > > > > > > > > This commit adds the configuration of the keytag with devargs. > > > > > > > > > > > > Signed-off-by: Suanming Mou > > > > > > Signed-off-by: Matan

Re: [dpdk-dev] [EXT] [PATCH v3 15/15] crypto/mlx5: set feature flags and capabilities

From: Akhil Goyal > Hi Matan, > > > > > > +Prerequisites > > > > > > +- > > > > > > + > > > > > > +- Mellanox OFED version: **5.3** > > > > > > + see :doc:`../../nics/mlx5` guide for more Mellanox OFED details. > > > > > > > > > > Since the driver is by default compiled off due to t

Re: [dpdk-dev] [EXT] [PATCH v3 03/15] crypto/mlx5: support session operations

From: Akhil Goyal > > From: Akhil Goyal > > > > > > > > +static void > > > > > > > > +mlx5_crypto_sym_session_clear(struct rte_cryptodev *dev, > > > > > > > > + struct rte_cryptodev_sym_session > > > > > > > > *sess) { > > > > > > > > + struct mlx5_crypto_priv *pri

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix RSS expansion for NVGRE

ed-off-by: Jiawei Wang > Acked-by: Xiaoyu Min Acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH v1] net/mlx5: fix meter flow id

pdk.org > > Signed-off-by: Shun Hao Acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH] net/mlx5: fix counter offset detection

; discover code fail time to time. > > Fixes: 994829e695c0 ("net/mlx5: remove single counter container") > Cc: sta...@dpdk.org > > Signed-off-by: Suanming Mou Acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH v1] net/mlx5: fix meter cleaning in stop operation

er references in stop operation. > > Fixes: fc6ce56bba ("net/mlx5: prepare sub-policy for flow with meter") > > Signed-off-by: Li Zhang Acked-by: Matan Azrad

[dpdk-dev] [PATCH] vdpa/mlx5: fix device unplug

: 95276abaaf0a ("vdpa/mlx5: introduce Mellanox vDPA driver") Cc: sta...@dpdk.org Reported-by: Eli Britstein el...@nvidia.com Signed-off-by: Matan Azrad ma...@nvidia.com Tested-by: Eli Britstein el...@nvidia.com Acked-by: Xueming Li --- drivers/vdpa/mlx5/mlx5_vdpa.c | 2 ++ 1 file

[dpdk-dev] [PATCH v2] vdpa/mlx5: fix device unplug

: 95276abaaf0a ("vdpa/mlx5: introduce Mellanox vDPA driver") Cc: sta...@dpdk.org Reported-by: Eli Britstein Signed-off-by: Matan Azrad Tested-by: Eli Britstein Acked-by: Xueming Li --- drivers/vdpa/mlx5/mlx5_vdpa.c | 2 ++ 1 file changed, 2 insertions(+) v2: fix spelling and email fo

Re: [dpdk-dev] [PATCH 1/4] regex/mlx5: fix size of setup constants

From: Michael Baum > Sent: Tuesday, June 1, 2021 10:11 AM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Slava Ovsiienko ; > sta...@dpdk.org > Subject: [PATCH 1/4] regex/mlx5: fix size of setup constants > > The constant representing the size of the

Re: [dpdk-dev] [PATCH 2/4] compress/mlx5: fix constant size in QP creation

e pair operations") > Cc: sta...@dpdk.org > > Signed-off-by: Michael Baum Acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH 3/4] vdpa/mlx5: fix constant type in QP creation

eues") > Cc: sta...@dpdk.org > > Signed-off-by: Michael Baum Acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH 4/4] net/mlx5: fix constant type in MP allocation

et/mlx5: replace external mbuf shared memory") > Cc: sta...@dpdk.org > > Signed-off-by: Michael Baum Acked-by: Matan Azrad

[dpdk-dev] [PATCH] net/mlx5: fix aging counter deallocation

ction handle") Cc: sta...@dpdk.org Signed-off-by: Matan Azrad Acked-by: Bing Zhao --- drivers/net/mlx5/mlx5_flow_dv.c | 47 ++--- 1 file changed, 26 insertions(+), 21 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_

Re: [dpdk-dev] [PATCH] net/mlx5: fix switchdev mode recognition

. If this check succeeds the E- > Switch presence is considered as wrongly detected and overridden. > > Fixes: 30a86157f6d5 ("net/mlx5: support PF representor") > Cc: sta...@dpdk.org > > Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH] net/mlx5: fix receiving queue timestamp format

From: Slava Ovsiienko > Sent: Monday, June 14, 2021 4:53 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Matan Azrad > ; christian.ehrha...@canonical.com; Xueming(Steven) > Li ; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix receiving queue timestamp format > > The

Re: [dpdk-dev] [PATCH v1] net/mlx5: fix IPIP multi tunnel validation

". > > Fixes: 5e33bebdd8d3 ("net/mlx5: support IP-in-IP tunnel") > Cc: sta...@dpdk.org > > Signed-off-by: Lior Margalit > Acked-by: Ori Kam Acked-by: Matan Azrad

[dpdk-dev] [PATCH] net/mlx5: support the new VLAN matching fields

\QinQ limitations are listed in the driver document. [1] https://patches.dpdk.org/patch/80965/ Signed-off-by: Matan Azrad Acked-by: Dekel Peled Acked-by: Ori Kam --- doc/guides/nics/mlx5.rst | 24 +++-- doc/guides/rel_notes/release_20_11.rst | 3 + drivers/net/mlx5/mlx5_flow.c

Re: [dpdk-dev] [Patch v2] net/vdev_netvsc: prevent alarm loss on failed device probe

ge log: > v2: removed lock and flags, use counter to decide if alarm should be reset > > Cc: sta...@dpdk.org > Signed-off-by: Long Li I suggest the next title: net/vdev_netvsc: fix device probing error flow and the next fixes line: Fixes: e7dc5d7becc5 ("net/vdev_netvsc: implement

[dpdk-dev] [PATCH] net/mlx5: fix Tx queue start

to change the state from ready to ready what caused a failure in FW on the current state validation. Replace ready to ready command by reset to ready command in the Tx start API. Fixes: 161d103b231c ("net/mlx5: add queue start and stop") Cc: sta...@dpdk.org Signed-off-by: Matan Azrad

Re: [dpdk-dev] [PATCH] net/mlx4: fix glue library name

.richard...@intel.com > > Signed-off-by: Ali Alnubani Acked-by: Matan Azrad

[dpdk-dev] [PATCH 0/8] net/mlx5: support flow hit steering action

flow hit action common/mlx5: add definitions for ASO flow hit net/mlx5: support flow hit action for aging Matan Azrad (2): net/mlx5: optimize shared RSS action memory net/mlx5: support shared age action drivers/common/mlx5/linux/meson.build | 4 + drivers/common/mlx5/linux/mlx5_glue.c

[dpdk-dev] [PATCH 4/8] common/mlx5: add glue func create flow hit action

From: Dekel Peled Add glue function to create the flow hit action using DV API, if rdma-core support exists. Signed-off-by: Dekel Peled --- drivers/common/mlx5/linux/meson.build | 2 ++ drivers/common/mlx5/linux/mlx5_glue.c | 16 drivers/common/mlx5/linux/mlx5_glue.h | 3 +++

<    1   2   3   4   5   6   7   8   9   10   >