RE: [PATCH 1/5] net/mlx5/hws: add support for matching on bth_a bit

2023-10-09 Thread Matan Azrad
> RTE_FLOW_ITEM_TYPE_IB_BTH matches an InfiniBand base transport header. > We extend the match on the acknowledgment bit (BTH_A). > > Signed-off-by: Itamar Gozlan Series-acked-by: Matan Azrad > --- > drivers/net/mlx5/hws/mlx5dr_definer.c | 12 ++-- >

RE: [PATCH v2 1/2] common/mlx5: fix build disabling

2022-10-30 Thread Matan Azrad
s, so it will allow using > the > variable mlx5_config in future. > > Fixes: 22681deead3e ("net/mlx5/hws: enable hardware steering") > > Reported-by: Andrew Rybchenko > Signed-off-by: Thomas Monjalon > Tested-by: Andrew Rybchenko Acked-by: Matan Azrad

RE: [PATCH v2 2/2] common/mlx5: move Meson config initialization and check

2022-10-30 Thread Matan Azrad
t the top of > net/mlx5/hws/meson.build so HWS requirements are in the right context. > > Signed-off-by: Thomas Monjalon > Tested-by: Andrew Rybchenko Acked-by: Matan Azrad

RE: [PATCH] net/mlx5: enable flow aging action

2022-10-31 Thread Matan Azrad
> As the queue-based aging API has been integrated[1], the flow aging action > support in HWS steering code can be enabled now. > > [1]: > https://patchwork.dpdk.org/project/dpdk/cover/20221026214943.3686635- > 1-michae...@nvidia.com/ > > Signed-off-by: Suanming Mou Acked-by: Matan Azrad

RE: [PATCH] net/mlx5/hws: remove deprecated rte_atomic

2022-11-02 Thread Matan Azrad
> The use of rte_atomic functions is deprecated and is not required in HWS > code. HWS refcounts are used only during control and always under lock. > > Fixes: f8c8a6d8440d ("net/mlx5/hws: add action object") > Signed-off-by: Alex Vesker Acked-by: Matan Azrad

RE: [PATCH] net/mlx5/hws: fix memory leak on general pool db init

2023-01-26 Thread Matan Azrad
From: Alex Vesker > On elemend db init we allocated the element_manager which was unused > and not freed. > > Fixes: b4dd7bcb0dcbe ("net/mlx5/hws: add pool and buddy") > Signed-off-by: Alex Vesker > Reviewed-by: Erez Shitrit Acked-by: Matan Azrad

RE: [PATCH] net/mlx5: fix error CQE dumping for vectorized Rx burst

2023-02-06 Thread Matan Azrad
/mlx5: extend Rx completion with error handling") > Cc: sta...@dpdk.org > > Signed-off-by: Alexander Kozyrev Acked-by: Matan Azrad

RE: [PATCH] net/mlx5: ignore non-critical syndromes for Rx queue

2023-02-06 Thread Matan Azrad
USH_ERR. > Do not initiate a Rx queue reset in any other cases. > Skip all non-critical error CQEs and continue with packet processing. > > Fixes: 88c0733535 ("net/mlx5: extend Rx completion with error handling") > Cc: sta...@dpdk.org > > Signed-off-by: Alexander Kozyrev Acked-by: Matan Azrad

RE: [PATCH] net/mlx5: check compressed CQE opcode for an error

2023-02-06 Thread Matan Azrad
uot;) > Cc: sta...@dpdk.org > > Signed-off-by: Alexander Kozyrev Acked-by: Matan Azrad

RE: [v2 00/16] net/mlx5/hws: support range and partial hash matching

2023-02-06 Thread Matan Azrad
net/mlx5/hws: rename pattern cache object > net/mlx5/hws: cache definer for reuse Series-acked-by: Matan Azrad > drivers/common/mlx5/mlx5_prm.h | 53 +- > drivers/net/mlx5/hws/mlx5dr.h | 6 +- > drivers/net/mlx5/hws/mlx5dr_cmd.c | 72 ++- > drivers/

Re: [dpdk-dev] [PATCH] vdpa/mlx5: improve portability of thread naming

2021-04-26 Thread Matan Azrad
From: Thomas Monjalon > The function pthread_setname_np is non-portable, so it may be unavailable in > old glibc or other systems. > The function rte_thread_setname is workarounding portability issues. > > Signed-off-by: Thomas Monjalon Acked-by: Matan Azrad Thanks!

[dpdk-dev] [PATCH] examples/l2fwd-crypto: support cipher multiple data-unit

2021-04-26 Thread Matan Azrad
to be aligned to the defined data-unit. [1]: commit d014dddb2d69 ("cryptodev: support multiple cipher data-units") Signed-off-by: Matan Azrad --- .../sample_app_ug/l2_forward_crypto.rst | 7 ++- examples/l2fwd-crypto/main.c | 61 +++ 2 files c

[dpdk-dev] [PATCH v2 01/16] common/mlx5: remove redundant spaces in header file

2021-04-29 Thread Matan Azrad
and new lines from several structs, to align all structs in mlx5_prm.h to the same format. Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_prm.h | 334 +++-- 1 file changed, 155 insertions(+), 179 deletions(-) diff --git a/drivers/common

[dpdk-dev] [PATCH v2 00/16] mlx5 common part for crypto driver

2021-04-29 Thread Matan Azrad
The crypto PMD will be supported on Nvidia ConnectX6 The crypto PMD will add the support of encryption and decryption using the AES-XTS symmetric algorithm. The crypto PMD requires rdma-core and uses mlx5 DevX. This is the mlx5 common part that added support for DevX commands needed for crypto dr

[dpdk-dev] [PATCH v2 02/16] common/mlx5: update GENEVE TLV OPT obj name

2021-04-29 Thread Matan Azrad
From: Dekel Peled Rename MLX5_OBJ_TYPE_GENEVE_TLV_OPT as MLX5_GENERAL_OBJ_TYPE_GENEVE_TLV_OPT, to align with other general objects names. Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 2 +- drivers/common/mlx5/mlx5_prm.h | 4 ++-- 2 files

[dpdk-dev] [PATCH v2 03/16] common/mlx5: optimize read of general obj type caps

2021-04-29 Thread Matan Azrad
, and then extracting the required bits. Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5

[dpdk-dev] [PATCH v2 04/16] common/mlx5: add HCA cap for AES-XTS crypto

2021-04-29 Thread Matan Azrad
From: Dekel Peled Update the PRM structure and HCA capabilities reading, to include relevant capabilities for AES-XTS crypto. Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 3 +++ drivers/common/mlx5/mlx5_devx_cmds.h | 2 ++ drivers/common/mlx5

[dpdk-dev] [PATCH v2 06/16] common/mlx5: adjust DevX MKEY fields for crypto

2021-04-29 Thread Matan Azrad
From: Dekel Peled MKEY that will be used for crypto purposes must be created with crypto_en and remote access attributes. This patch adds support for them in the DevX MKEY context. Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 5 + drivers

[dpdk-dev] [PATCH v2 05/16] common/mlx5: support general object DEK create op

2021-04-29 Thread Matan Azrad
From: Dekel Peled Data Encryption Keys (DEKs) are the keys used for data encryption/decryption operations. Add reading of DEK support capability. Add function to create general object type DEK, using DevX API. Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- drivers/common/mlx5

[dpdk-dev] [PATCH v2 07/16] common/mlx5: fix cypto bsf attr

2021-04-29 Thread Matan Azrad
From: Suanming Mou This commit should be squash to crypto en commit. Signed-off-by: Suanming Mou --- drivers/common/mlx5/mlx5_devx_cmds.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5/mlx5_devx_cmds.c index 68a10b149a..7e3c8

[dpdk-dev] [PATCH v2 08/16] common/mlx5: support general obj IMPORT KEK create

2021-04-29 Thread Matan Azrad
capability. Add function to create general object type IMPORT_KEK, using DevX API. Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 50 drivers/common/mlx5/mlx5_devx_cmds.h | 13 drivers/common/mlx5/mlx5_prm.h | 18

[dpdk-dev] [PATCH v2 09/16] common/mlx5: support general obj CRYPTO LOGIN create

2021-04-29 Thread Matan Azrad
function to create general object type CRYPTO_LOGIN, using DevX API. Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 54 drivers/common/mlx5/mlx5_devx_cmds.h | 15 drivers/common/mlx5/mlx5_prm.h | 19

[dpdk-dev] [PATCH v2 10/16] common/mlx5: add crypto BSF struct and defines

2021-04-29 Thread Matan Azrad
From: Dekel Peled This patch adds the struct defining crypto BSF segment of UMR WQE, and the related value definitions and offsets. Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_prm.h | 66 ++ 1 file changed, 66 insertions

[dpdk-dev] [PATCH v2 11/16] common/mlx5: share hash list tool

2021-04-29 Thread Matan Azrad
Acked-by: Matan Azrad --- drivers/common/mlx5/linux/mlx5_common_os.c | 2 +- drivers/common/mlx5/linux/mlx5_nl.c | 2 +- drivers/common/mlx5/meson.build | 15 +- drivers/common/mlx5/mlx5_common.c| 2 +- drivers/common/mlx5/mlx5_common_devx.c | 2

[dpdk-dev] [PATCH v2 12/16] common/mlx5: share get ib device match function

2021-04-29 Thread Matan Azrad
. Signed-off-by: Shiri Kuzin Acked-by: Matan Azrad --- drivers/common/mlx5/linux/mlx5_common_os.c | 28 +++ drivers/common/mlx5/linux/mlx5_common_os.h | 5 drivers/common/mlx5/mlx5_common.h | 2 ++ drivers/common/mlx5/version.map| 1 + drivers/compress

[dpdk-dev] [PATCH v2 13/16] common/mlx5: support general obj CREDENTIAL create

2021-04-29 Thread Matan Azrad
Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 53 +++- drivers/common/mlx5/mlx5_devx_cmds.h | 17 +++-- drivers/common/mlx5/mlx5_prm.h | 23 drivers/common/mlx5/version.map | 1 + 4 files changed, 91 insertions(+), 3 deletions

[dpdk-dev] [PATCH v2 14/16] common/mlx5: add crypto register structs and defs

2021-04-29 Thread Matan Azrad
From: Dekel Peled Encryption key management requires use of several related registers. This patch adds the relevant structs and values, according to PRM definitions. Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_prm.h | 41 ++ 1

[dpdk-dev] [PATCH v2 15/16] common/mlx5: support register write access

2021-04-29 Thread Matan Azrad
From: Dekel Peled This patch adds support of write operation to NIC registers. Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 67 +++- drivers/common/mlx5/mlx5_devx_cmds.h | 4 ++ drivers/common/mlx5/version.map | 21

[dpdk-dev] [PATCH v2 16/16] common/mlx5: add UMR and RDMA write WQE defines

2021-04-29 Thread Matan Azrad
From: Suanming Mou This patch adds the struct defining UMR and RDMA write WQEs. Signed-off-by: Suanming Mou Signed-off-by: Matan Azrad --- drivers/common/mlx5/mlx5_prm.h | 187 + 1 file changed, 121 insertions(+), 66 deletions(-) diff --git a/drivers/common

[dpdk-dev] [PATCH v2 00/15] drivers: introduce mlx5 crypto PMD

2021-04-29 Thread Matan Azrad
Add a new PMD for Nvidia devices- crypto PMD. The crypto PMD will be supported on Nvidia ConnectX6 The crypto PMD will add the support of encryption and decryption using the AES-XTS symmetric algorithm. The crypto PMD requires rdma-core and uses mlx5 DevX. v2: Add data-path part. Shiri Kuzin (10

[dpdk-dev] [PATCH v2 01/15] drivers: introduce mlx5 crypto PMD

2021-04-29 Thread Matan Azrad
DevX. This patch adds the PCI probing, basic functions, build files and log utility. Signed-off-by: Shiri Kuzin Acked-by: Matan Azrad --- MAINTAINERS | 4 + drivers/common/mlx5/mlx5_common_pci.c | 14 ++ drivers/common/mlx5/mlx5_common_pci.h | 21 +- drivers

[dpdk-dev] [PATCH v2 02/15] crypto/mlx5: add DEK object management

2021-04-29 Thread Matan Azrad
destroyed in dev_close routine. Signed-off-by: Shiri Kuzin Acked-by: Matan Azrad --- drivers/crypto/mlx5/meson.build | 1 + drivers/crypto/mlx5/mlx5_crypto.c | 44 + drivers/crypto/mlx5/mlx5_crypto.h | 51 ++ drivers/crypto/mlx5/mlx5_crypto_dek.c | 136

[dpdk-dev] [PATCH v2 03/15] crypto/mlx5: support session operations

2021-04-29 Thread Matan Azrad
: Shiri Kuzin Acked-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_crypto.c | 96 ++- 1 file changed, 93 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/mlx5/mlx5_crypto.c b/drivers/crypto/mlx5/mlx5_crypto.c index e7c70c521f..c494ed00d1 100644 --- a/drivers

[dpdk-dev] [PATCH v2 04/15] crypto/mlx5: add basic operations

2021-04-29 Thread Matan Azrad
-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_crypto.c | 46 +++ drivers/crypto/mlx5/mlx5_crypto.h | 1 + 2 files changed, 42 insertions(+), 5 deletions(-) diff --git a/drivers/crypto/mlx5/mlx5_crypto.c b/drivers/crypto/mlx5/mlx5_crypto.c index c494ed00d1..cc11cabbea

[dpdk-dev] [PATCH v2 05/15] crypto/mlx5: support queue pairs operations

2021-04-29 Thread Matan Azrad
(ready to send). Added implementation for the release QP function to release all the QP resources. Added the ops structure that contains any operation which is supported by the cryptodev. Signed-off-by: Shiri Kuzin Acked-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_crypto.c | 124

[dpdk-dev] [PATCH v2 06/15] crypto/mlx5: add dev stop and start operations

2021-04-29 Thread Matan Azrad
From: Shiri Kuzin Add the dev_start function that is used to start a configured device. Add the dev_stop function that is used to stop a configured device. Both functions set the dev parameter as used and return 0. Signed-off-by: Shiri Kuzin Acked-by: Matan Azrad --- drivers/crypto/mlx5

[dpdk-dev] [PATCH v2 07/15] crypto/mlx5: add memory region management

2021-04-29 Thread Matan Azrad
nd creates a MR using a system call. Add memory region cache management: - 2 level cache per queue-pair - no locks. - 1 shared cache between all the queues using a lock. Using this way, the MR key search per data-path address is optimized. Signed-off-by: Shiri Kuzin Acked-by: M

[dpdk-dev] [PATCH v2 08/15] crypto/mlx5: create login object using DevX

2021-04-29 Thread Matan Azrad
means logout. Signed-off-by: Shiri Kuzin Acked-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_crypto.c | 103 ++ drivers/crypto/mlx5/mlx5_crypto.h | 7 ++ 2 files changed, 110 insertions(+) diff --git a/drivers/crypto/mlx5/mlx5_crypto.c b/drivers/crypto/mlx5

[dpdk-dev] [PATCH v2 09/15] crypto/mlx5: adjust to the multiple data unit API

2021-04-29 Thread Matan Azrad
From: Shiri Kuzin In AES-XTS the data to be encrypted\decrypted does not have to be in multiples of 16B size, the unit of data is called data-unit. As a result of patch [1] a new field is added to the cipher capability, called dataunit_set, where the devices can report the range of supported dat

[dpdk-dev] [PATCH v2 10/15] crypto/mlx5: add keytag device argument

2021-04-29 Thread Matan Azrad
x27;t match. This commit adds the configuration of the keytag with devargs. Signed-off-by: Suanming Mou Signed-off-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_crypto.c | 50 +-- drivers/crypto/mlx5/mlx5_crypto.h | 3 +- 2 files changed, 30 insertions(+), 23 dele

[dpdk-dev] [PATCH v2 11/15] crypto/mlx5: add maximum segments device argument

2021-04-29 Thread Matan Azrad
will be supported for crypto operations. Signed-off-by: Suanming Mou Signed-off-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_crypto.c | 35 +++ drivers/crypto/mlx5/mlx5_crypto.h | 7 +++ 2 files changed, 38 insertions(+), 4 deletions(-) diff --git a/drivers/crypto

[dpdk-dev] [PATCH v2 12/15] crypto/mlx5: add WQE set initialization

2021-04-29 Thread Matan Azrad
. This commit initializes the fixed WQE set segments. Signed-off-by: Suanming Mou Signed-off-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_crypto.c | 83 +-- drivers/crypto/mlx5/mlx5_crypto.h | 10 +++- 2 files changed, 87 insertions(+), 6 deletions(-) diff --git a

[dpdk-dev] [PATCH v2 13/15] crypto/mlx5: add enqueue and dequeue operations

2021-04-29 Thread Matan Azrad
commit adds the enquue and dequeue operations and updates the WQE set segments accordingly. Signed-off-by: Suanming Mou Signed-off-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_crypto.c | 243 +- drivers/crypto/mlx5/mlx5_crypto.h | 3 + 2 files changed, 241 insertions

[dpdk-dev] [PATCH v2 14/15] crypto/mlx5: add statistic get and reset operations

2021-04-29 Thread Matan Azrad
From: Suanming Mou This commit adds mlx5 crypto statistic get and reset operations. Signed-off-by: Suanming Mou Signed-off-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_crypto.c | 39 --- 1 file changed, 36 insertions(+), 3 deletions(-) diff --git a/drivers/crypto

[dpdk-dev] [PATCH v2 15/15] crypto/mlx5: set feature flags and capabilities

2021-04-29 Thread Matan Azrad
From: Shiri Kuzin Add the supported capabilities to the crypto driver. Add supported feature flags. Add crypto driver documentation. Signed-off-by: Shiri Kuzin Signed-off-by: Matan Azrad --- doc/guides/cryptodevs/features/mlx5.ini | 37 ++ doc/guides/cryptodevs/index.rst | 1

Re: [dpdk-dev] [PATCH v2 07/16] common/mlx5: fix cypto bsf attr

2021-04-29 Thread Matan Azrad
Hi Raslan See below , need to squash this to " common/mlx5: adjust DevX MKEY fields for crypto" The one below it...missed that, sorry. From: Matan Azrad > From: Suanming Mou > > This commit should be squash to crypto en commit. > > Signed-off-by: Suanming Mou >

Re: [dpdk-dev] [PATCH v2 00/15] drivers: introduce mlx5 crypto PMD

2021-05-02 Thread Matan Azrad
From: Matan Azrad > Add a new PMD for Nvidia devices- crypto PMD. > The crypto PMD will be supported on Nvidia ConnectX6 The crypto PMD will > add the support of encryption and decryption using the AES-XTS symmetric > algorithm. > The crypto PMD requires rdma-core and uses mlx

Re: [dpdk-dev] [PATCH v2 00/16] mlx5 common part for crypto driver

2021-05-02 Thread Matan Azrad
From: Matan Azrad > The crypto PMD will be supported on Nvidia ConnectX6 The crypto PMD will > add the support of encryption and decryption using the AES-XTS symmetric > algorithm. > The crypto PMD requires rdma-core and uses mlx5 DevX. > This is the mlx5 common part that ad

[dpdk-dev] [PATCH v2] vdpa/mlx5: improve interrupt management

2021-05-02 Thread Matan Azrad
FD mechanism. Signed-off-by: Matan Azrad Acked-by: Xueming Li --- doc/guides/vdpadevs/mlx5.rst| 8 +- drivers/vdpa/mlx5/mlx5_vdpa.c | 8 +- drivers/vdpa/mlx5/mlx5_vdpa.h | 8 +- drivers/vdpa/mlx5/mlx5_vdpa_event.c | 304 +++- 4 files changed

Re: [dpdk-dev] [PATCH] vdpa/mlx5: improve interrupt management

2021-05-02 Thread Matan Azrad
From: Maxime Coquelin > Hi Matan, > > On 4/11/21 11:07 AM, Thomas Monjalon wrote: > > 07/04/2021 08:49, Xia, Chenbo: > >>> Signed-off-by: Matan Azrad > >>> Acked-by: Xueming Li > >> > >> Patch applied to next-virtio/main with confli

Re: [dpdk-dev] [PATCH v2 12/16] common/mlx5: share get ib device match function

2021-05-04 Thread Matan Azrad
Hi Thomas From: Thomas Monjalon > 29/04/2021 17:43, Matan Azrad: > > From: Shiri Kuzin > > > > The get_ib_device_match function iterates over the list of ib devices > > returned by the get_device_list glue function and returns the ib > > device matching the pro

Re: [dpdk-dev] [PATCH v2 15/16] common/mlx5: support register write access

2021-05-04 Thread Matan Azrad
From: Thomas Monjalon > 29/04/2021 17:43, Matan Azrad: > > From: Dekel Peled > > > > This patch adds support of write operation to NIC registers. > > > > Signed-off-by: Dekel Peled > > Acked-by: Matan Azrad > > --- > > --- a/drivers/co

[dpdk-dev] [PATCH v3 00/15] mlx5 common part for crypto driver

2021-05-04 Thread Matan Azrad
The crypto PMD will be supported on Nvidia ConnectX6. The crypto PMD will add the support of encryption and decryption using the AES-XTS symmetric algorithm. The crypto PMD requires rdma-core and uses mlx5 DevX. This is the mlx5 common part that added support for DevX commands needed for crypto d

[dpdk-dev] [PATCH v3 01/15] common/mlx5: remove redundant spaces in header file

2021-05-04 Thread Matan Azrad
and new lines from several structs, to align all structs in mlx5_prm.h to the same format. Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_prm.h | 334 +++-- 1 file changed, 155 insertions(+), 179 deletions(-) diff --git a/drivers/common

[dpdk-dev] [PATCH v3 02/15] common/mlx5: update GENEVE TLV OPT obj name

2021-05-04 Thread Matan Azrad
From: Dekel Peled Rename MLX5_OBJ_TYPE_GENEVE_TLV_OPT as MLX5_GENERAL_OBJ_TYPE_GENEVE_TLV_OPT, to align with other general objects names. Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 2 +- drivers/common/mlx5/mlx5_prm.h | 4 ++-- 2 files

[dpdk-dev] [PATCH v3 03/15] common/mlx5: optimize read of general obj type caps

2021-05-04 Thread Matan Azrad
, and then extracting the required bits. Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5

[dpdk-dev] [PATCH v3 04/15] common/mlx5: add HCA cap for AES-XTS crypto

2021-05-04 Thread Matan Azrad
From: Dekel Peled Update the PRM structure and HCA capabilities reading, to include relevant capabilities for AES-XTS crypto. Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 3 +++ drivers/common/mlx5/mlx5_devx_cmds.h | 2 ++ drivers/common/mlx5

[dpdk-dev] [PATCH v3 05/15] common/mlx5: support general object DEK create op

2021-05-04 Thread Matan Azrad
Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 53 +++ drivers/common/mlx5/mlx5_devx_cmds.h | 17 + drivers/common/mlx5/mlx5_prm.h | 39 drivers/common/mlx5/version.map | 55 4 files

[dpdk-dev] [PATCH v3 06/15] common/mlx5: adjust DevX MKEY fields for crypto

2021-05-04 Thread Matan Azrad
From: Dekel Peled MKEY that will be used for crypto purposes must be created with crypto_en and remote access attributes. This patch adds support for them in the DevX MKEY context. Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 9

[dpdk-dev] [PATCH v3 07/15] common/mlx5: support general obj IMPORT KEK create

2021-05-04 Thread Matan Azrad
capability. Add function to create general object type IMPORT_KEK, using DevX API. Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 50 drivers/common/mlx5/mlx5_devx_cmds.h | 13 drivers/common/mlx5/mlx5_prm.h | 18

[dpdk-dev] [PATCH v3 08/15] common/mlx5: support general obj CRYPTO LOGIN create

2021-05-04 Thread Matan Azrad
function to create general object type CRYPTO_LOGIN, using DevX API. Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 54 drivers/common/mlx5/mlx5_devx_cmds.h | 15 drivers/common/mlx5/mlx5_prm.h | 19

[dpdk-dev] [PATCH v3 09/15] common/mlx5: add crypto BSF struct and defines

2021-05-04 Thread Matan Azrad
From: Dekel Peled This patch adds the struct defining crypto BSF segment of UMR WQE, and the related value definitions and offsets. Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_prm.h | 66 ++ 1 file changed, 66 insertions

[dpdk-dev] [PATCH v3 10/15] common/mlx5: share hash list tool

2021-05-04 Thread Matan Azrad
Acked-by: Matan Azrad --- drivers/common/mlx5/linux/mlx5_common_os.c | 2 +- drivers/common/mlx5/linux/mlx5_nl.c | 2 +- drivers/common/mlx5/meson.build | 15 +- drivers/common/mlx5/mlx5_common.c| 2 +- drivers/common/mlx5/mlx5_common_devx.c | 2

[dpdk-dev] [PATCH v3 11/15] common/mlx5: share get ib device match function

2021-05-04 Thread Matan Azrad
. Signed-off-by: Shiri Kuzin Acked-by: Matan Azrad --- drivers/common/mlx5/linux/mlx5_common_os.c | 28 +++ drivers/common/mlx5/linux/mlx5_common_os.h | 5 drivers/common/mlx5/mlx5_common.h | 1 + drivers/common/mlx5/version.map| 1 + drivers/compress

[dpdk-dev] [PATCH v3 12/15] common/mlx5: support general obj CREDENTIAL create

2021-05-04 Thread Matan Azrad
Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 53 +++- drivers/common/mlx5/mlx5_devx_cmds.h | 17 +++-- drivers/common/mlx5/mlx5_prm.h | 23 drivers/common/mlx5/version.map | 1 + 4 files changed, 91 insertions(+), 3 deletions

[dpdk-dev] [PATCH v3 13/15] common/mlx5: add crypto register structs and defs

2021-05-04 Thread Matan Azrad
From: Dekel Peled Encryption key management requires use of several related registers. This patch adds the relevant structs and values, according to PRM definitions. Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_prm.h | 41 ++ 1

[dpdk-dev] [PATCH v3 14/15] common/mlx5: support register write access

2021-05-04 Thread Matan Azrad
From: Dekel Peled This patch adds support of write operation to NIC registers. Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 67 +++- drivers/common/mlx5/mlx5_devx_cmds.h | 4 ++ drivers/common/mlx5/version.map | 1

[dpdk-dev] [PATCH v3 15/15] common/mlx5: add UMR and RDMA write WQE defines

2021-05-04 Thread Matan Azrad
From: Suanming Mou This patch adds the struct defining UMR and RDMA write WQEs. Signed-off-by: Suanming Mou Signed-off-by: Matan Azrad --- drivers/common/mlx5/mlx5_prm.h | 187 + 1 file changed, 121 insertions(+), 66 deletions(-) diff --git a/drivers/common

[dpdk-dev] [PATCH v3 00/15] drivers: introduce mlx5 crypto PMD

2021-05-04 Thread Matan Azrad
Add a new PMD for Nvidia devices- crypto PMD. The crypto PMD will be supported on Nvidia ConnectX6 The crypto PMD will add the support of encryption and decryption using the AES-XTS symmetric algorithm. The crypto PMD requires rdma-core and uses mlx5 DevX. v2: Add data-path part. v3: Rebase. Sh

[dpdk-dev] [PATCH v3 01/15] drivers: introduce mlx5 crypto PMD

2021-05-04 Thread Matan Azrad
DevX. This patch adds the PCI probing, basic functions, build files and log utility. Signed-off-by: Shiri Kuzin Acked-by: Matan Azrad --- MAINTAINERS | 4 + drivers/common/mlx5/mlx5_common.h | 1 + drivers/common/mlx5/mlx5_common_pci.c | 14 ++ drivers

[dpdk-dev] [PATCH v3 04/15] crypto/mlx5: add basic operations

2021-05-04 Thread Matan Azrad
-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_crypto.c | 46 +++ drivers/crypto/mlx5/mlx5_crypto.h | 1 + 2 files changed, 42 insertions(+), 5 deletions(-) diff --git a/drivers/crypto/mlx5/mlx5_crypto.c b/drivers/crypto/mlx5/mlx5_crypto.c index 32f5077066..cec21dbea7

[dpdk-dev] [PATCH v3 02/15] crypto/mlx5: add DEK object management

2021-05-04 Thread Matan Azrad
destroyed in dev_close routine. Signed-off-by: Shiri Kuzin Acked-by: Matan Azrad --- drivers/crypto/mlx5/meson.build | 1 + drivers/crypto/mlx5/mlx5_crypto.c | 44 + drivers/crypto/mlx5/mlx5_crypto.h | 51 ++ drivers/crypto/mlx5/mlx5_crypto_dek.c | 136

[dpdk-dev] [PATCH v3 05/15] crypto/mlx5: support queue pairs operations

2021-05-04 Thread Matan Azrad
(ready to send). Added implementation for the release QP function to release all the QP resources. Added the ops structure that contains any operation which is supported by the cryptodev. Signed-off-by: Shiri Kuzin Acked-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_crypto.c | 124

[dpdk-dev] [PATCH v3 03/15] crypto/mlx5: support session operations

2021-05-04 Thread Matan Azrad
: Shiri Kuzin Acked-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_crypto.c | 96 ++- 1 file changed, 93 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/mlx5/mlx5_crypto.c b/drivers/crypto/mlx5/mlx5_crypto.c index 2bdfb1a10f..32f5077066 100644 --- a/drivers

[dpdk-dev] [PATCH v3 06/15] crypto/mlx5: add dev stop and start operations

2021-05-04 Thread Matan Azrad
From: Shiri Kuzin Add the dev_start function that is used to start a configured device. Add the dev_stop function that is used to stop a configured device. Both functions set the dev parameter as used and return 0. Signed-off-by: Shiri Kuzin Acked-by: Matan Azrad --- drivers/crypto/mlx5

[dpdk-dev] [PATCH v3 08/15] crypto/mlx5: create login object using DevX

2021-05-04 Thread Matan Azrad
means logout. Signed-off-by: Shiri Kuzin Acked-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_crypto.c | 103 ++ drivers/crypto/mlx5/mlx5_crypto.h | 7 ++ 2 files changed, 110 insertions(+) diff --git a/drivers/crypto/mlx5/mlx5_crypto.c b/drivers/crypto/mlx5

[dpdk-dev] [PATCH v3 07/15] crypto/mlx5: add memory region management

2021-05-04 Thread Matan Azrad
nd creates a MR using a system call. Add memory region cache management: - 2 level cache per queue-pair - no locks. - 1 shared cache between all the queues using a lock. Using this way, the MR key search per data-path address is optimized. Signed-off-by: Shiri Kuzin Acked-by: M

[dpdk-dev] [PATCH v3 10/15] crypto/mlx5: add keytag device argument

2021-05-04 Thread Matan Azrad
x27;t match. This commit adds the configuration of the keytag with devargs. Signed-off-by: Suanming Mou Signed-off-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_crypto.c | 50 +-- drivers/crypto/mlx5/mlx5_crypto.h | 3 +- 2 files changed, 30 insertions(+), 23 dele

[dpdk-dev] [PATCH v3 09/15] crypto/mlx5: adjust to the multiple data unit API

2021-05-04 Thread Matan Azrad
From: Shiri Kuzin In AES-XTS the data to be encrypted\decrypted does not have to be in multiples of 16B size, the unit of data is called data-unit. As a result of patch [1] a new field is added to the cipher capability, called dataunit_set, where the devices can report the range of supported dat

[dpdk-dev] [PATCH v3 11/15] crypto/mlx5: add maximum segments device argument

2021-05-04 Thread Matan Azrad
will be supported for crypto operations. Signed-off-by: Suanming Mou Signed-off-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_crypto.c | 35 +++ drivers/crypto/mlx5/mlx5_crypto.h | 7 +++ 2 files changed, 38 insertions(+), 4 deletions(-) diff --git a/drivers/crypto

[dpdk-dev] [PATCH v3 12/15] crypto/mlx5: add WQE set initialization

2021-05-04 Thread Matan Azrad
. This commit initializes the fixed WQE set segments. Signed-off-by: Suanming Mou Signed-off-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_crypto.c | 83 +-- drivers/crypto/mlx5/mlx5_crypto.h | 10 +++- 2 files changed, 87 insertions(+), 6 deletions(-) diff --git a

[dpdk-dev] [PATCH v3 14/15] crypto/mlx5: add statistic get and reset operations

2021-05-04 Thread Matan Azrad
From: Suanming Mou This commit adds mlx5 crypto statistic get and reset operations. Signed-off-by: Suanming Mou Signed-off-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_crypto.c | 39 --- 1 file changed, 36 insertions(+), 3 deletions(-) diff --git a/drivers/crypto

[dpdk-dev] [PATCH v3 13/15] crypto/mlx5: add enqueue and dequeue operations

2021-05-04 Thread Matan Azrad
commit adds the enquue and dequeue operations and updates the WQE set segments accordingly. Signed-off-by: Suanming Mou Signed-off-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_crypto.c | 243 +- drivers/crypto/mlx5/mlx5_crypto.h | 3 + 2 files changed, 241 insertions

[dpdk-dev] [PATCH v3 15/15] crypto/mlx5: set feature flags and capabilities

2021-05-04 Thread Matan Azrad
From: Shiri Kuzin Add the supported capabilities to the crypto driver. Add supported feature flags. Add crypto driver documentation. Signed-off-by: Shiri Kuzin Signed-off-by: Matan Azrad --- doc/guides/cryptodevs/features/mlx5.ini | 37 ++ doc/guides/cryptodevs/index.rst | 1

Re: [dpdk-dev] [PATCH] net/mlx5/linux: fix missing firmware version copying

2021-05-06 Thread Matan Azrad
From: Kamil Vojanec > This patch fixes a bug where firmware version was not copied from > ibv_device_attr structure into mlx5_dev_attr structure, resulting in inability > to read firmware version. > > Signed-off-by: Kamil Vojanec Acked-by: Matan Azrad > --- > d

Re: [dpdk-dev] [PATCH] common/mlx5: fix Netlink port name attribute padding

2021-06-19 Thread Matan Azrad
res. > > Fixes: 30a86157f6d5 ("net/mlx5: support PF representor") > Cc: sta...@dpdk.org > > Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH v3] net/mlx5: add TCP and IPv6 to supported flow items list in Windows

2021-06-23 Thread Matan Azrad
Windows kernel driver WINOF2 > 2.70 to the mlx5 driver guide. > > Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH 1/3] regex/mlx5: fix memory region unregistration

2021-06-29 Thread Matan Azrad
From: Michael Baum > The issue can cause illegal physical address access while a huge-page A is > released and huge-page B is allocated on the same virtual address. > The old MR can be matched using the virtual address of huge-page B but the > HW will access the physical address of huge-page A w

Re: [dpdk-dev] [PATCH] net/mlx5: fix match MPLS over GRE with key

2021-07-01 Thread Matan Azrad
966138 / end actions queue index 1 / mark id 0xa / end > > Fixes: a7a0365565a4 ("net/mlx5: match GRE key and present bits") > Cc: sta...@dpdk.org > > Signed-off-by: Xiaoyu Min Acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH 3/3] net/bonding: start ethdev prior to setting 8023ad flow

2021-07-04 Thread Matan Azrad
From: Havlík Martin > Dne 2021-06-23 09:04, Min Hu (Connor) napsal: > > 在 2021/6/22 17:25, Martin Havlik 写道: > >> When dedicated queues are enabled, mlx5 PMD fails to install RTE > >> Flows if the underlying ethdev is not started: > >> bond_ethdev_8023ad_flow_set(267) - bond_ethdev_8023ad_flow_se

Re: [dpdk-dev] [PATCH] dmadev: introduce DMA device library

2021-07-04 Thread Matan Azrad
From: Chengwen Feng > This patch introduces 'dmadevice' which is a generic type of DMA > device. > > The APIs of dmadev library exposes some generic operations which can > enable configuration and I/O with the DMA devices. > Did you consider RTE_COMP_ALGO_NULL xform in compressdev library? >

Re: [dpdk-dev] [PATCH] dmadev: introduce DMA device library

2021-07-05 Thread Matan Azrad
Hi From: fengchengwen > On 2021/7/4 23:21, Matan Azrad wrote: > > > > > > From: Chengwen Feng > >> This patch introduces 'dmadevice' which is a generic type of DMA > >> device. > >> > >> The APIs of dmadev library exposes some

Re: [dpdk-dev] [PATCH] dmadev: introduce DMA device library

2021-07-06 Thread Matan Azrad
From: fengchengwen > On 2021/7/6 14:50, Matan Azrad wrote: > > Hi > > > > From: fengchengwen > >> On 2021/7/4 23:21, Matan Azrad wrote: > >>> > >>> > >>> From: Chengwen Feng > >>>> This patch introduces 'dma

Re: [dpdk-dev] [PATCH 0/3] MPLS RSS fixs

2021-07-06 Thread Matan Azrad
PLS over IP > net/mlx5: fix MPLS RSS expansion > net/mlx5: limit inner RSS expansion for MPLS Series-acked by Matan Azrad > drivers/net/mlx5/mlx5_flow.c| 31 +-- > drivers/net/mlx5/mlx5_flow_dv.c | 3 --- > 2 files changed, 21 insertions(+), 13 deletions(-) > > -- > 2.32.0

Re: [dpdk-dev] [PATCH 0/2] fix RSS expansion missing items

2021-07-07 Thread Matan Azrad
From: Xiaoyu Min > This patch set fixs the missing items in RSS expansion. > > Xiaoyu Min (2): > net/mlx5: fix missing RSS expandable items > net/mlx5: fix missing RSS expansion of IPv6 frag > Series-acked -by: Matan Azrad > drivers/net/mlx5/mlx5_flow.c | 10

Re: [PATCH v5 1/7] net/mlx5: add LWM support for Rxq

2022-06-08 Thread Matan Azrad
Series-acked-by: Matan Azrad mailto:ma...@nvidia.com>> קבל ‏Outlook עבור Android‏<https://aka.ms/AAb9ysg> From: Spike Du Sent: Tuesday, June 7, 2022 3:59:36 PM To: Matan Azrad ; Slava Ovsiienko ; Ori Kam ; NBU-Contact-Thomas Monjalon (EX

RE: [PATCH V2] vdpa/mlx5: return correct error code after rte_intr_instance_alloc failed

2022-06-15 Thread Matan Azrad
Hi Shiqi From: 835703...@qq.com <835703...@qq.com> > From: Shiqi Liu <835703...@qq.com> > > To Maxime, > I am so sorry too late to reply your comment.My name is Shiqi Liu. > I got stuck in how to reply the comment before.Now, it seenms to be > ok!Maybe there will be some mistakes I have taken ,

RE: [PATCH v7] app/testpmd: add Host Shaper command

2022-06-15 Thread Matan Azrad
ilable > descriptor threshold event. > > Signed-off-by: Spike Du Acked-by: Matan Azrad

RE: [PATCH] vdpa/mlx5: return correct error code after rte_intr_instance_alloc failed

2022-06-22 Thread Matan Azrad
Hi I put here again the comment the putted on another version of this commit. I saw it is already integrated but still not in master. But please look. From: Maxime Coquelin > Hi newsky647, > > On 6/12/22 16:09, 835703...@qq.com wrote: > > From: newsky647 <835703...@qq.com> > > > > After functi

RE: [PATCH 1/3] vdpa/mlx5: remove unnecessary null check

2022-06-23 Thread Matan Azrad
From: Stephen Hemminger > Found by nullfree.cocci. > > Signed-off-by: Stephen Hemminger Acked-by: Matan Azrad

  1   2   3   4   5   6   7   8   9   10   >