Re: [PATCH 0/3] argparse: improve handling of multi-instance args

2025-06-20 Thread Bruce Richardson
On Mon, Jun 16, 2025 at 11:49:40AM +0100, Bruce Richardson wrote: > Coverity (correctly) identified an issue[1] where, after the recent > rework[2], the internal flag, used by argparse to track what arguments > were previously encountered or not, was out of range for the type and no > longer having

[PATCH 1/2] net/mlx5/hws: recognize IPIP in definer layer

2025-06-20 Thread Junfeng Guo
Definers are HW objects that are used for matching, rte items are translated to definers, each definer holds the fields and bit-masks used for HW flow matching. This patch recognize IP-in-IP tunnel type in definer layer, including the following combinations: - IPv4 over IPv4 - IPv4 over IPv6 -

[PATCH 2/2] net/mlx5: support IPIP flow for all combinations

2025-06-20 Thread Junfeng Guo
IP-in-IP tunnel type includes the following combination: - IPv4 over IPv4 - IPv4 over IPv6 - IPv6 over IPv4 - IPv6 over IPv6 It's okay to have MLX5_FLOW_LAYER_IPIP flag when validate IPv6 item. And it's okay to have outer L3 layer as either IPv4 or IPv6 when setting the IP-in-IP tunnel item fl

[PATCH 0/2] Support IPIP Tunnel in NT2HWS and HWS

2025-06-20 Thread Junfeng Guo
This patchset support IPIP Tunnel in NT2HWS and HWS, including the following {IPv4 x IPv6} combinations: - IPv4 over IPv4 - IPv4 over IPv6 - IPv6 over IPv4 - IPv6 over IPv6 This feature cover both basic IPIP and IPIP over VXLAN Tunnel types. Junfeng Guo (2): net/mlx5/hws: recognize IPIP in

Re: [PATCH v1] event/dlb2: fixes names of DLB2 token pop enums

2025-06-20 Thread Jerin Jacob
On Fri, Jun 20, 2025 at 4:07 AM Pravin Pathak wrote: > > added RTE_PMD_DLB2_ prefix to dlb2 token pop mode enmus > to avoid name comflict. These enums are passed to public > API rte_pmd_dlb2_set_token_pop_mode(). > > Fixes: c667583d82f4 ("event/dlb2: add token pop API") > Cc: sta...@dpdk.org > > S

Re: [PATCH 2/2] common/cnxk: add null pointer checks

2025-06-20 Thread Jerin Jacob
On Fri, Jun 20, 2025 at 10:57 AM Rahul Bhansali wrote: > > Adds null pointer check before executing CPT instruction. > > Signed-off-by: Rahul Bhansali Add Fixes tag and start the commit with common/cnxk: fix ...

Re: [PATCH 07/10] tailq: fix cast macro for null pointer

2025-06-20 Thread Bruce Richardson
On Thu, Jun 19, 2025 at 09:10:33AM +0200, David Marchand wrote: > Doing arithmetics with the NULL pointer is undefined. > > Caught by UBSan: > > ../app/test/test_tailq.c:111:9: runtime error: > member access within null pointer of type 'struct rte_tailq_head' > > Fixes: f6b4f6c9c123 ("tail

Re: [PATCH 06/10] cmdline: fix highest bit port list parsing

2025-06-20 Thread Bruce Richardson
On Thu, Jun 19, 2025 at 09:10:32AM +0200, David Marchand wrote: > pl->map is a uint32_t. > > Caught by UBSan: > > ../lib/cmdline/cmdline_parse_portlist.c:27:17: runtime error: > left shift of 1 by 31 places cannot be represented in type 'int' > SUMMARY: UndefinedBehaviorSanitizer: undefined

Re: [PATCH 02/10] test/telemetry: fix test calling all commands

2025-06-20 Thread Bruce Richardson
On Thu, Jun 19, 2025 at 09:10:28AM +0200, David Marchand wrote: > This test was doing nothing as it could not find the telemetry client > script following the test suite rework. > > Caught while looking at UNH unit test logs: > > /root/workspace/Generic-Unit-Test-DPDK/dpdk/app/test/suites/test_te

[PATCH v3 2/7] lib/pmu: export only necessary arch headers

2025-06-20 Thread Tomasz Duszynski
Install only architecture specific headers to avoid header pollution. Signed-off-by: Tomasz Duszynski --- lib/pmu/meson.build | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/pmu/meson.build b/lib/pmu/meson.build index bcb6d10f1a..53013d0ed6 100644 --- a/lib/pmu

[PATCH v3 4/7] lib/pmu: use build system defined RTE_LIB_PMU macro

2025-06-20 Thread Tomasz Duszynski
RTE_LIB_PMU is defined by build system automatically if DPDK is build for Linux. Otherwise it's missing. That said all cases where conditional compilation is required can be handled without introducing other macros. Signed-off-by: Tomasz Duszynski --- lib/pmu/rte_pmu.h | 3 --- 1 file changed,

[PATCH v3 7/7] lib/pmu: fix out-of-bound access

2025-06-20 Thread Tomasz Duszynski
Make sure that out-of-bound access does not happen by saving one byte in buffer for NUL terminator. Fixes: a8926a65ad1d ("pmu: support Arm") Fixes: 960c43184c4d ("pmu: introduce library for reading PMU events") Cc: tduszyn...@marvell.com Signed-off-by: Tomasz Duszynski --- lib/pmu/pmu.c |

[PATCH v3 5/7] test/pmu: enable fast test

2025-06-20 Thread Tomasz Duszynski
DPDK test suite provides much broader architecture coverage than what can be tested locally so enable the test to help identify potential issues. Signed-off-by: Tomasz Duszynski --- app/test/test_pmu.c | 44 +--- 1 file changed, 41 insertions(+), 3 deletio

[PATCH v3 1/7] lib/pmu: quiesce rte_pmu_read deprecation warning in chkincs

2025-06-20 Thread Tomasz Duszynski
Add a dummy rte_pmu_read() definition for chkincs when ALLOW_EXPERIMENTAL_API is not defined to suppress warnings from use of experimental APIs in tracepoints. Fixes: 960c43184c4d ("pmu: introduce library for reading PMU events") Signed-off-by: Tomasz Duszynski --- lib/pmu/rte_pmu.h | 4 1

[PATCH v3 6/7] trace: add PMU

2025-06-20 Thread Tomasz Duszynski
In order to profile app, one needs to store significant amount of samples somewhere for an analysis later on. Since trace library supports storing data in a CTF format, lets take advantage of that and add a dedicated PMU tracepoint. Signed-off-by: Tomasz Duszynski --- MAINTAINERS

Re: [PATCH 03/10] test/mempool: fix test without stack driver

2025-06-20 Thread Andrew Rybchenko
On 6/19/25 10:10 AM, David Marchand wrote: In a minimal build, the mempool/stack driver is disabled. Separate the code specific to this external driver and rename unrelated variables. Signed-off-by: David Marchand Acked-by: Andrew Rybchenko

Re: [PATCH 05/10] cmdline: fix port list parsing

2025-06-20 Thread Bruce Richardson
On Thu, Jun 19, 2025 at 09:10:31AM +0200, David Marchand wrote: > Doing arithmetics with the NULL pointer is undefined. > > Caught by UBSan: > > ../lib/cmdline/cmdline_parse_portlist.c:40:19: runtime error: > applying non-zero offset 1 to null pointer > SUMMARY: UndefinedBehaviorSanitizer:

[PATCH v1 4/4] net/ntnic: add warning when sending on a stopped queue

2025-06-20 Thread Oleksandr Kolomeiets
When sending a burst of output packets on a stopped transmit queue, the packets are written to a memory mapped address. On queue start the packets are processed and transmitted by the NIC. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/ntnic_ethdev.c | 4 1 file changed, 4 insert

[PATCH] bus/pci: fix automatic interrupt type selection

2025-06-20 Thread priikone
Check if kernel returns 0 interrupt vectors and try another interrupt type in that case. Failing to check the vector count can select an interrupt type that's unusable. Signed-off-by: Pekka Riikonen --- drivers/bus/pci/linux/pci_vfio.c | 4 1 file changed, 4 insertions(+) diff --git a/dr

[PATCH v2] bus/pci: fix automatic interrupt type selection

2025-06-20 Thread Pekka Riikonen
Check if kernel returns 0 interrupt vectors and try another interrupt type in that case. Failing to check the vector count can select an interrupt type that's unusable. Signed-off-by: Pekka Riikonen --- drivers/bus/pci/linux/pci_vfio.c | 4 1 file changed, 4 insertions(+) diff --git a/dr

Re: [PATCH v1 1/1] memory: handle invalid socket ID's when allocating

2025-06-20 Thread Bruce Richardson
On Fri, Jun 20, 2025 at 02:30:23PM +0100, Anatoly Burakov wrote: > This issue was reported by static analysis. It is a false positive, > because both `rte_socket_count` and `rte_socket_id_by_idx` only report > information about physical sockets, and these specific calls are made > during EAL initia

[PATCH v1 1/1] memory: handle invalid socket ID's when allocating

2025-06-20 Thread Anatoly Burakov
This issue was reported by static analysis. It is a false positive, because both `rte_socket_count` and `rte_socket_id_by_idx` only report information about physical sockets, and these specific calls are made during EAL initialization, so no other sockets (i.e. external) could have been available,

[PATCH 3/3] test/crypto: fix RSA decrypt op validation

2025-06-20 Thread Gowrishankar Muthukrishnan
Following RSA encrypt op, same plaintext buffer is used as output buffer for decrypt op, hence comparing plaintext buffer against same buffer pointer in crypto op always succeed irrespective of whether decrypt op succeeds or not. This patch fixes this issue with a local buffer for crypto op. Fixes

[PATCH] net/iavf: fix VLAN offload strip flag

2025-06-20 Thread Amiya Ranjan Mohakud
For i40e kernel drivers which support either vlan(v1) or vlan(v2) VIRTCHNL OP,it will set strip on when setting filter on. But dpdk side will not change strip flag. To be consistent with dpdk side, explicitly disable strip again. Bugzilla ID:1725 Signed-off-by: Amiya Ranjan Mohakud --- drivers/

[DPDK/ethdev Bug 1729] RSS offload types are undocumented

2025-06-20 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1729 Bug ID: 1729 Summary: RSS offload types are undocumented Product: DPDK Version: 25.03 Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priorit

[PATCH v3 3/7] lib/pmu: reimplement per-arch ops as callbacks

2025-06-20 Thread Tomasz Duszynski
Replace static per-architecture ops with a callback-based ops structure. This makes architecture-specific PMU implementations more modular and easier to extend. Signed-off-by: Tomasz Duszynski --- lib/pmu/pmu.c | 17 + lib/pmu/pmu_arm64.c | 19 +-- lib/p

[PATCH v3 0/7] lib/pmu: cleanups and trace integration

2025-06-20 Thread Tomasz Duszynski
This series does some cleanup and refactoring around the rc1 code like: trimming unused headers, switching to callbacks for per-arch handling, and adding trace support. It also re-enables existing base test to help catch reported issues on some architectures. v3: - do not export __rte_pmu_trace_

[PATCH 1/3] crypto/openssl: include private exponent in RSA session

2025-06-20 Thread Gowrishankar Muthukrishnan
If private exponent is available, it should be included within RSA session as per RFC 8017 (A.1.2). OpenSSL 1.1.1 implementation rely on this private exponent, to implicitly reject invalid cipher. Hence, check if it is available for session and include it. Fixes: 3e9d6bd447fb ("crypto/openssl: add

Re: [PATCH 04/10] eal: fix plugin dir walk

2025-06-20 Thread Bruce Richardson
On Thu, Jun 19, 2025 at 09:10:30AM +0200, David Marchand wrote: > For '.' and '..' directories (or any short file name), > a out of bound issue occurs. > > Caught by UBSan: > > EAL: Detected shared linkage of DPDK > ../lib/eal/common/eal_common_options.c:420:15: runtime error: index -2 > ou

[PATCH v1 0/4] net/ntnic: implement start, stop and deferred start for Rx/Tx queues

2025-06-20 Thread Oleksandr Kolomeiets
This patchset includes: * feature start/stop queues on HW layer. * feature deferred start for queues. * Improvement for memory mappings when IOMMU is unoptimized. * Improvement for logging Oleksandr Kolomeiets (4): net/ntnic: implement start/stop for Rx/Tx queue

[PATCH v1 2/4] net/ntnic: implement deferred start for Rx/Tx queues

2025-06-20 Thread Oleksandr Kolomeiets
Handle rx_deferred_start and tx_deferred_start flags during configuration done in rx_queue_setup and tx_queue_setup, so that marked queues do not start with dev_start. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/dbsconfig/ntnic_dbsconfig.c | 46 +++ drivers/net/ntni

[PATCH v1 1/4] net/ntnic: implement start/stop for Rx/Tx queues

2025-06-20 Thread Oleksandr Kolomeiets
The following functions exported by the driver were stubs which merely changed the status flags: * rx_queue_start * rx_queue_stop * tx_queue_start * tx_queue_stop Proper implementation was added to control queues's state. Signed-off-by: Oleksandr Kolomeiets --- drivers/n

[PATCH v1 3/4] net/ntnic: unmap DMA during queue release

2025-06-20 Thread Oleksandr Kolomeiets
Perform unmapping in a default container, which is used by queues. Handle multiple mappings when IOMMU is unoptimized. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/ntos_drv.h | 1 + drivers/net/ntnic/ntnic_ethdev.c | 26 -- drivers/net/ntnic/ntni

RTE_ETH_RSS_IP support by Intel NIC drivers

2025-06-20 Thread Morten Brørup
Don't the Intel i40e and e1000 drivers support RSS on IP addresses [1]? It looks like they do, but don't report it. For i40e: Accepted: 0x2288 FRAG_IPV4 NONFRAG_IPV4_OTHER FRAG_IPV6 NONFRAG_IPV6_OTHER Unsupported: 0x8104 IPV4 IPV6 IPV6_EX For e1000: Accepted: 0x8104 IPV4 IPV6 IPV6_EX Unsupported:

Re: RTE_ETH_RSS_IP support by Intel NIC drivers

2025-06-20 Thread Bruce Richardson
On Fri, Jun 20, 2025 at 12:24:24PM +0200, Morten Brørup wrote: > Don't the Intel i40e and e1000 drivers support RSS on IP addresses [1]? > It looks like they do, but don't report it. > > For i40e: > Accepted: 0x2288 FRAG_IPV4 NONFRAG_IPV4_OTHER FRAG_IPV6 NONFRAG_IPV6_OTHER > Unsupported: 0x8104 IP

[PATCH 2/3] test/crypto: fix RSA test vector as per RFC 8017

2025-06-20 Thread Gowrishankar Muthukrishnan
As per RFC 8017 (A.1.2), RSA private key should be represented with both exponent and CRT forms of data for inter operability. Fixes: a379799cbaaf ("test/crypto: add RSA key type CRT") Cc: sta...@dpdk.org Signed-off-by: Gowrishankar Muthukrishnan --- app/test/test_cryptodev_asym.c |

Re: release candidate 25.07-rc1

2025-06-20 Thread Thinh Tran
IBM - Power Systems Testing DPDK v25.07-rc1-8-gdbeb8ae8d0 * Basic PF on Mellanox: No issue found * Performance: not tested. * OS:- RHEL 9.5 kernel: 5.14.0-503.11.1.el9_5.ppc64le with gcc version 11.5.0 20240719 (Red Hat 11.5.0-2) Systems tested: - LPARs on IBM Power10 CHRP IBM,9105-22

[PATCH] net/iavf: fix VLAN offload strip flag

2025-06-20 Thread Amiya Ranjan Mohakud
For i40e kernel drivers which support either vlan(v1) or vlan(v2) VIRTCHNL OP,it will set strip on when setting filter on. But dpdk side will not change strip flag. To be consistent with dpdk side, explicitly disable strip again. Bugzilla ID:1725 Cc: sta...@dpdk.org Signed-off-by: Amiya Ranja