[PATCH 1/2] ci: treat warning as error for MSVC builds in GHA

2025-06-10 Thread David Marchand
Some trivial builds warnings with MSVC were missed as those were not treated as errors. Signed-off-by: David Marchand --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 1e289979e3..e5

[PATCH 2/2] test/lcore: fix build with MSVC

2025-06-10 Thread David Marchand
MSVC warns about atomic qualifier: ../app/test/test_per_lcore.c(101): error C2220: the following warning is treated as an error ../app/test/test_per_lcore.c(101): warning C4090: 'function': different '_Atomic' qualifiers Fixes: 7c37826c2b87 ("test/lcore: fix race in per-lcore test"

RE: [EXTERNAL] Re: [PATCH v2 1/1] ethdev: add support to provide link type

2025-06-10 Thread Sunil Kumar Kori
> On Fri, 6 Jun 2025 11:54:52 +0200 > Morten Brørup wrote: > > > > From: sk...@marvell.com [mailto:sk...@marvell.com] > > > Sent: Friday, 6 June 2025 11.28 > > > > > > From: Sunil Kumar Kori > > > > > > Adding link type parameter to provide the type of port like twisted > > > pair, fibre etc. >

[PATCH v2 8/8] net/r8169: update HW configuration for 8127

2025-06-10 Thread Howard Wang
Signed-off-by: Howard Wang --- drivers/net/r8169/base/rtl8127.c | 44 --- drivers/net/r8169/base/rtl8127_mcu.c | 109 --- drivers/net/r8169/r8169_hw.h | 2 +- drivers/net/r8169/r8169_phy.c| 1 - 4 files changed, 80 insertions(+), 76 deletio

[PATCH v2 0/8] net/r8169: support more cards

2025-06-10 Thread Howard Wang
This patch series includes the following updates: Add support for the RTL8168 1G NIC series. Add support for the RTL8127 10G NIC. Add support for the RTL8125CP NIC. Update hardware configuration for RTL8125 and RTL8126. Howard Wang (8): net/r8169: add support for RTL8168 series net/r8169: upd

Re: [PATCH] doc/linux_gsg: update recommended compiler versions

2025-06-10 Thread Thomas Monjalon
08/04/2025 19:18, Bruce Richardson: > Rather than specifying a minimum compiler version, update the docs to > recommend a particular compiler version. In other words, earlier > versions may work, but are not officially supported, or may give reduced > functionality. [...] > +GCC (version 8.0+ r

Re: [PATCH] uapi: update to 6.15 for vduse.h

2025-06-10 Thread Maxime Coquelin
Hi Stephen, On 6/9/25 3:41 AM, Stephen Hemminger wrote: Use the header as produced by the kernel: $ make headers_install We use the header as produced by our import script (devtools/linux- uapi.sh) as defined in the contribution guidelines and approved by the tech and gov boards. I'm fine w

[v3 07/10] net/dpaa: add Tx rate limiting DPAA PMD API

2025-06-10 Thread vanshika . shukla
From: Vinod Pullabhatla Add support to set Tx rate on DPAA platform through PMD APIs Signed-off-by: Vinod Pullabhatla Signed-off-by: Vanshika Shukla --- .mailmap | 1 + drivers/net/dpaa/dpaa_flow.c | 87 +++- drivers/net/dpaa/fmlib/

[v3 08/10] net/dpaa: add devargs for enabling err packets on main queue

2025-06-10 Thread vanshika . shukla
From: Vanshika Shukla Currently, error queue is mapped to the Rx queue and enabled by default. This patch adds the devargs to control the err packets on main queue. Also, in VSP mode the error queue should be disabled because the error packets from kernel are diverted to the Rx queue/err queue ca

[v3 09/10] bus/dpaa: improve DPAA cleanup

2025-06-10 Thread vanshika . shukla
From: Gagandeep Singh This patch addresses DPAA driver issues with the introduction of rte_eal_cleanup, which caused driver-specific destructors to fail due to memory cleanup. To resolve this, we remove the driver destructor and relocate the code to the bus cleanup function. So, this patch also

[v3 10/10] bus/dpaa: optimize qman enqueue check

2025-06-10 Thread vanshika . shukla
From: Hemant Agrawal This patch improves data access during qman enequeue ring check. Signed-off-by: Jun Yang Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/base/qbman/bman.c | 19 ++--- drivers/bus/dpaa/base/qbman/qman.c | 41 - drivers/bus/dpaa/incl

[v3 02/10] bus/dpaa: add FMan node

2025-06-10 Thread vanshika . shukla
From: Jun Yang Add FMan node(s) and associate FMan to it's interface(port). This method describes FMan attributes and avoid accessing FMan from port directly. Logically, something like IEEE 1588 is FMan global resource, which is in range of 0xF_E000–0xF_EFFF. Port specific resource is in range of

[v3 03/10] bus/dpaa: enhance DPAA SoC version

2025-06-10 Thread vanshika . shukla
From: Jun Yang Provide internal API to identify DPAA1 SoC version instead of accessing global variable directly. Signed-off-by: Jun Yang --- drivers/bus/dpaa/base/qbman/qman.c | 9 +++--- drivers/bus/dpaa/bus_dpaa_driver.h | 9 +++--- drivers/bus/dpaa/dpaa_bus.c| 48 +

[v3 01/10] bus/dpaa: avoid using same structure and variable name

2025-06-10 Thread vanshika . shukla
From: Hemant Agrawal rte_dpaa_bus was being used as structure and variable name both. Signed-off-by: Jun Yang Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/dpaa_bus.c | 56 ++--- 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/drivers/bus/d

[v3 00/10] DPAA specific fixes

2025-06-10 Thread vanshika . shukla
From: Vanshika Shukla This series includes fixes for NXP DPAA drivers. V3: Fixed compilation errors for "bus/dpaa: optimize qman enqueue check" patch. V2: Handled review comments and checkpatch warnings Gagandeep Singh (1): bus/dpaa: improve DPAA cleanup Hemant Agrawal (2): bus/dpaa: avoid

[v3 04/10] bus/dpaa: optimize bman acquire/release

2025-06-10 Thread vanshika . shukla
From: Jun Yang 1) Reduce byte swap between big endian and little endian. 2) Reduce ci(cache invalid) access by 128bit R/W instructions. These methods improve ~10% buffer acquire/release performance. Signed-off-by: Jun Yang --- drivers/bus/dpaa/base/qbman/bman.c | 149 -

[v3 06/10] mempool/dpaa: adjust pool element for LS1043A errata

2025-06-10 Thread vanshika . shukla
From: Jun Yang Adjust every element of pool by populate callback. 1) Make sure start DMA address is aligned with 16B. 2) For buffer across 4KB boundary, make sure start DMA address is aligned with 256B. Signed-off-by: Jun Yang --- drivers/mempool/dpaa/dpaa_mempool.c | 145 ++

[v3 05/10] mempool/dpaa: fast acquire and release

2025-06-10 Thread vanshika . shukla
From: Jun Yang Use new BMan APIs to improve performance and support burst release. Improve release performance ~90% by burst release. Signed-off-by: Jun Yang --- drivers/mempool/dpaa/dpaa_mempool.c | 85 - drivers/mempool/dpaa/dpaa_mempool.h | 2 +- 2 files changed

Re: [PATCH 0/4] BSD PCI Fixes

2025-06-10 Thread Thomas Monjalon
06/05/2025 19:40, Jake Freeland: > Hi there, > > The following patchset includes a number of fixes I've made over the > past year relating to the PCI driver. Most of these changes target > the FreeBSD platform. > > Let me know if you have any feedback. Thanks. > > Jake Freeland (4): > bus/pci:

Re: [PATCH dpdk] net: fix IPv4 compat and mapped checks

2025-06-10 Thread Thomas Monjalon
24/02/2025 15:47, Robin Jarry: > The RFC states that the first 96 bits should be compared, not the first > 32 bits. > > Add unit tests to ensure this works. > > Cc: sta...@dpdk.org > Fixes: 3d6d85f58c1c ("net: add utilities for well known IPv6 address types") > Reported-by: Junxiao Shi > Closes:

[PATCH v2 3/8] net/r8169: add support for RTL8127

2025-06-10 Thread Howard Wang
Signed-off-by: Howard Wang --- doc/guides/nics/r8169.rst |5 +- drivers/net/r8169/base/rtl8125a.c |8 +- drivers/net/r8169/base/rtl8125a.h |1 - drivers/net/r8169/base/rtl8125a_mcu.c | 17 +- drivers/net/r8169/base/rtl8125b.c |5 +- drivers/net/r8169

[PATCH v2 4/8] net/r8169: remove cmac feature for RTL8125AP

2025-06-10 Thread Howard Wang
Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_dash.c | 23 +++ drivers/net/r8169/r8169_dash.h | 1 + 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/net/r8169/r8169_dash.c b/drivers/net/r8169/r8169_dash.c index 0da7e07283..a225af7e27 100644 -

[PATCH v2 7/8] net/r8169: add support for RTL8127ATF serdes interface

2025-06-10 Thread Howard Wang
Signed-off-by: Howard Wang --- drivers/net/r8169/meson.build| 1 + drivers/net/r8169/r8169_ethdev.h | 3 + drivers/net/r8169/r8169_fiber.c | 201 +++ drivers/net/r8169/r8169_fiber.h | 42 +++ drivers/net/r8169/r8169_hw.c | 93 +- drivers

[PATCH 8/8] net/r8169: update HW configuration for 8127

2025-06-10 Thread Howard Wang
Signed-off-by: Howard Wang --- drivers/net/r8169/base/rtl8127.c | 44 --- drivers/net/r8169/base/rtl8127_mcu.c | 109 --- drivers/net/r8169/r8169_hw.h | 2 +- drivers/net/r8169/r8169_phy.c| 1 - 4 files changed, 80 insertions(+), 76 deletio

[PATCH v2 6/8] net/r8169: add support for RTL8125CP

2025-06-10 Thread Howard Wang
Signed-off-by: Howard Wang --- drivers/net/r8169/base/rtl8125cp.c | 73 drivers/net/r8169/base/rtl8125cp_mcu.c | 78 ++ drivers/net/r8169/base/rtl8125cp_mcu.h | 10 drivers/net/r8169/meson.build | 2 + drivers/net/r8169/r8169_com

[PATCH v2 5/8] net/r8169: add RTL8127AP dash support

2025-06-10 Thread Howard Wang
Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_dash.c | 1 + drivers/net/r8169/r8169_hw.c | 32 ++-- drivers/net/r8169/r8169_phy.c | 34 ++ 3 files changed, 13 insertions(+), 54 deletions(-) diff --git a/drivers/net/r8169/r8

Re: [PATCH 1/2] power/intel_uncore: fix crash closing uninitialized driver

2025-06-10 Thread Thomas Monjalon
21/05/2025 15:06, Kevin Laatz: > On 15/05/2025 17:58, Bruce Richardson wrote: > > When the power_intel_uncore_autotest unit test is run as an unprivileged > > user which cannot init the power library, it crashes the unit test > > binary due to calling "rte_power_uncore_exit" after the first test ca

Re: [PATCH v2] examples/l3fwd: adjust Tx burst size based on Rx burst

2025-06-10 Thread fengchengwen
On 2025/6/10 14:42, huangdengdui wrote: > > On 2025/6/9 23:21, Stephen Hemminger wrote: >> On Mon, 9 Jun 2025 09:58:27 + >> Sivaprasad Tummala wrote: >> >>> Previously, the TX burst size was fixed at 256, leading to performance >>> degradation in certain scenarios. >>> >>> This patch introduc

Re: [PATCH v5] net: fix GTP packet parsing

2025-06-10 Thread Thomas Monjalon
03/06/2025 14:06, Dengdui Huang: > After parsing the GTP packet header, the next protocol type should > be converted from RTE_GTP_TYPE_IPV4/IPV6 to RTE_ETHER_TYPE_IPV4/IPV6. > Otherwise, the next protocol cannot be parsed. > > Bugzilla ID: 1672 > Fixes: 64ed7f854cf4 ("net: add tunnel packet type p

Re: Error with --no-huge when compiled with -fsanitize=address from gcc 15

2025-06-10 Thread Robin Jarry
+Anatoly and Ferruh in direct address. Robin Jarry, May 15, 2025 at 12:32: > I recently updated to Fedora 42 that comes with GCC 15. > > When building with -fsanitize=address (libasan.so.8), it seems that > the --no-huge mode (along with --no-shconf) fails at initialization for > some obscure reas

[PATCH v2] doc/linux_gsg: update recommended compiler versions

2025-06-10 Thread Bruce Richardson
Rather than specifying a minimum compiler version, update the docs to recommend a particular compiler version. In other words, earlier versions may work, but are not officially supported, or may give reduced functionality. Since we don't require that many version-specific features, recommend the c

Re: [PATCH 0/4] more unnecessary function pointer

2025-06-10 Thread Thomas Monjalon
11/03/2025 17:04, Bruce Richardson: > On Tue, Mar 11, 2025 at 08:51:28AM -0700, Stephen Hemminger wrote: > > A few more cases where there is unnecessary deref (*) on > > function pointers. > > > > Stephen Hemminger (4): > > raw/ifpga: remove unnecessary deref of function pointers > > crypto/io

[PATCH v6 1/4] dev: hide driver export macros

2025-06-10 Thread David Marchand
The macros for tagging/exporting informations about a driver do not need to be exported in the public API. Move this to driver only header. Signed-off-by: David Marchand --- lib/eal/include/dev_driver.h | 41 lib/eal/include/rte_dev.h| 41

[PATCH v6 0/4] allow pmdinfo to be inserted and parsed using MSVC

2025-06-10 Thread David Marchand
This is a rework of Andre v5, trying to hide the ugly details in a driver only macro not exposed publicly. -- David Marchand Changes since v5: - moved details in dev_driver.h, - renamed RTE_INCLUDE as RTE_PMD_EXPORT_SYMBOL, Andre Muezerie (3): dev: export driver information with MSVC build

Re: [PATCH v7 0/7] latencystats: cleanup

2025-06-10 Thread Thomas Monjalon
13/02/2025 22:20, Stephen Hemminger: > Latencystats uses unnecessary floating point and is inaccurate if the number > of cycles per ns is not an integral value. Cleanup the code and add > more tests as well. > > v7 - rebase and drop already merged VLA patch Sorry I missed it, and it requires anot

[PATCH v6 4/4] usertools: enable pmdinfo with MSVC

2025-06-10 Thread David Marchand
From: Andre Muezerie Script usertools\dpdk-pmdinfo.py was enhanced to also be able to parse symbols from sections in PE images. Signed-off-by: Andre Muezerie --- usertools/dpdk-pmdinfo.py | 53 +++ 1 file changed, 43 insertions(+), 10 deletions(-) diff --gi

Re: [PATCH 00/12] Fixes and supports for Wangxun NICs

2025-06-10 Thread Stephen Hemminger
On Fri, 6 Jun 2025 16:01:05 +0800 Jiawen Wu wrote: > Fix some bugs and improve flow filters. > > Jiawen Wu (12): > net/txgbe: support flow filter for VF > net/txgbe: refactor FDIR filter to improve functionality > net/txgbe: fix reserved extra FDIR headroom > net/txgbe: support RSS offl

[PATCH v3 0/8] net/r8169: support more cards

2025-06-10 Thread Howard Wang
This patch series includes the following updates: Add support for the RTL8168 1G NIC series. Add support for the RTL8127 10G NIC. Add support for the RTL8125CP NIC. Update hardware configuration for RTL8125 and RTL8126. Howard Wang (8): net/r8169: add support for RTL8168 series net/r8169: upd

[PATCH v4 3/6] net/intel: add TxPP Support for E830

2025-06-10 Thread Soumyadeep Hore
Add support for Tx Time based queues. This is used to schedule packets based on Tx timestamp. Signed-off-by: Soumyadeep Hore --- drivers/net/intel/common/tx.h | 14 ++ drivers/net/intel/ice/base/ice_lan_tx_rx.h | 4 + drivers/net/intel/ice/ice_ethdev.c | 3 +- drivers/n

[PATCH v4 6/6] doc: announce TxPP support for E830 adapters

2025-06-10 Thread Soumyadeep Hore
E830 adapters currently support Tx Time based queues. Signed-off-by: Soumyadeep Hore --- doc/guides/nics/ice.rst | 18 ++ 1 file changed, 18 insertions(+) diff --git a/doc/guides/nics/ice.rst b/doc/guides/nics/ice.rst index 77985ae5a2..f284c78290 100644 --- a/doc/guides/nics/ice

[PATCH v4 5/6] net/intel: add AVX512 Support for TxPP

2025-06-10 Thread Soumyadeep Hore
Tx Time based queues are supported using AVX512 vector. Signed-off-by: Soumyadeep Hore --- drivers/net/intel/ice/ice_rxtx_vec_avx512.c | 198 +++- 1 file changed, 197 insertions(+), 1 deletion(-) diff --git a/drivers/net/intel/ice/ice_rxtx_vec_avx512.c b/drivers/net/intel/ice/i

[PATCH v4 2/6] net/intel: add read clock feature in ICE

2025-06-10 Thread Soumyadeep Hore
Adding eth_ice_read_clock() feature to get current time for scheduling Packets based on Tx time. Signed-off-by: Soumyadeep Hore --- drivers/net/intel/ice/ice_ethdev.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/net/intel/ice/ice_ethdev.c b/drivers/net/intel/ice/ic

[PATCH v4 1/6] net/intel: update E830 Tx Time Queue Context Structure

2025-06-10 Thread Soumyadeep Hore
From: Paul Greenwalt Updated the Tx Time Queue Context Structure to align with HAS. Signed-off-by: Soumyadeep Hore Signed-off-by: Paul Greenwalt --- drivers/net/intel/ice/base/ice_common.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/net

[PATCH v4 0/6] Add TxPP Support for E830

2025-06-10 Thread Soumyadeep Hore
Added TxPP support for E830 adapters. --- v2: - Fixed Compilation warnings --- v3: - Fixed further Compilation warnings (uinitialised one) --- v4 - Addressed Bruce's comments --- Paul Greenwalt (1): net/intel: update E830 Tx Time Queue Context Structure Soumyadeep Hore (5): net/intel: add read

[PATCH v4 4/6] net/intel: add AVX2 Support for TxPP

2025-06-10 Thread Soumyadeep Hore
Tx Time based queues are supported using AVX2 vector. Signed-off-by: Soumyadeep Hore --- drivers/net/intel/ice/ice_rxtx_vec_avx2.c | 127 +++- drivers/net/intel/ice/ice_rxtx_vec_common.h | 25 2 files changed, 151 insertions(+), 1 deletion(-) diff --git a/drivers/net/int

[PATCH v3 3/8] net/r8169: add support for RTL8127

2025-06-10 Thread Howard Wang
RTL8127 is Realtek 10 Gigabit Ethernet Controller. Signed-off-by: Howard Wang --- doc/guides/nics/r8169.rst |5 +- drivers/net/r8169/base/rtl8125a.c |8 +- drivers/net/r8169/base/rtl8125a.h |1 - drivers/net/r8169/base/rtl8125a_mcu.c | 17 +- drivers/net/r81

[PATCH v3 4/8] net/r8169: remove cmac feature for RTL8125AP

2025-06-10 Thread Howard Wang
Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_dash.c | 23 +++ drivers/net/r8169/r8169_dash.h | 1 + 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/net/r8169/r8169_dash.c b/drivers/net/r8169/r8169_dash.c index 0da7e07283..a225af7e27 100644 -

[PATCH v3 7/8] net/r8169: add support for RTL8127ATF serdes interface

2025-06-10 Thread Howard Wang
Signed-off-by: Howard Wang --- drivers/net/r8169/meson.build| 1 + drivers/net/r8169/r8169_ethdev.h | 3 + drivers/net/r8169/r8169_fiber.c | 201 +++ drivers/net/r8169/r8169_fiber.h | 42 +++ drivers/net/r8169/r8169_hw.c | 93 +- drivers

[PATCH v3 6/8] net/r8169: add support for RTL8125CP

2025-06-10 Thread Howard Wang
Signed-off-by: Howard Wang --- drivers/net/r8169/base/rtl8125cp.c | 73 drivers/net/r8169/base/rtl8125cp_mcu.c | 78 ++ drivers/net/r8169/base/rtl8125cp_mcu.h | 10 drivers/net/r8169/meson.build | 2 + drivers/net/r8169/r8169_com

[PATCH v3 8/8] net/r8169: update HW configuration for 8127

2025-06-10 Thread Howard Wang
Update RTL8127's PHY configuration and MAC MCU setting. Signed-off-by: Howard Wang --- drivers/net/r8169/base/rtl8127.c | 44 --- drivers/net/r8169/base/rtl8127_mcu.c | 109 --- drivers/net/r8169/r8169_hw.h | 2 +- drivers/net/r8169/r8169_phy.c

[PATCH v3 5/8] net/r8169: add RTL8127AP dash support

2025-06-10 Thread Howard Wang
Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_dash.c | 1 + drivers/net/r8169/r8169_hw.c | 32 ++-- drivers/net/r8169/r8169_phy.c | 34 ++ 3 files changed, 13 insertions(+), 54 deletions(-) diff --git a/drivers/net/r8169/r8

Re: [PATCH 00/12] Fixes and supports for Wangxun NICs

2025-06-10 Thread Stephen Hemminger
On Fri, 6 Jun 2025 16:01:05 +0800 Jiawen Wu wrote: > Fix some bugs and improve flow filters. > > Jiawen Wu (12): > net/txgbe: support flow filter for VF > net/txgbe: refactor FDIR filter to improve functionality > net/txgbe: fix reserved extra FDIR headroom > net/txgbe: support RSS offl

[DPDK/meson Bug 1721] failed to compile DPDK

2025-06-10 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1721 Bug ID: 1721 Summary: failed to compile DPDK Product: DPDK Version: 24.07 Hardware: x86 OS: Windows Status: UNCONFIRMED Severity: critical Priority: Nor

RE: [PATCH v4] build: reduce use of AVX compiler flags

2025-06-10 Thread Varghese, Vipin
[Public] Hi Bruce, Snipped > > > > > > > > > > Hi Bruce, we have reviewed this internally and tested the same. > > > > > We would like > > > > your thought for the following. > > > > > > > > > > - Before patch: we were directly setting AVX512 falgs for F, BW, > > > > > DQ, VL > > > > > - new pat

Re: [PATCH v4] build: reduce use of AVX compiler flags

2025-06-10 Thread Bruce Richardson
On Tue, Jun 10, 2025 at 02:52:24PM +, Varghese, Vipin wrote: > [Public] > > Snipped > > > > > > > In above log I get `2 instances of march`; logs `-march=native -mrtm > > > -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-format- > > truncation -Wno-address-of-packed-member - > > DRTE_LOG_D

[PATCH 2/2] uapi: update headers to 6.15 kernel

2025-06-10 Thread Stephen Hemminger
The header contents does not change, but version and wrapper ifdef does change. Signed-off-by: Stephen Hemminger --- kernel/linux/uapi/linux/vduse.h | 6 +++--- kernel/linux/uapi/version | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/kernel/linux/uapi/linux/vduse.h

Re: [PATCH v6 4/4] usertools: enable pmdinfo with MSVC

2025-06-10 Thread Robin Jarry
David Marchand, Jun 10, 2025 at 12:09: > From: Andre Muezerie > > Script usertools\dpdk-pmdinfo.py was enhanced to also be able to parse > symbols from sections in PE images. > > Signed-off-by: Andre Muezerie > --- Acked-by: Robin Jarry

[PATCH] eal: handle sysconf() negative return value

2025-06-10 Thread Morten Brørup
Coverity reports some defects, where the root cause seems to be negative return value from sysconf() not being handled. rte_mem_page_size() has been updated to handle negative return value from sysconf(_SC_PAGESIZE). All other functions calling sysconf(_SC_PAGESIZE) directly have been updated to

Re: [PATCH v4] build: reduce use of AVX compiler flags

2025-06-10 Thread Bruce Richardson
On Tue, Jun 10, 2025 at 01:02:12PM +, Varghese, Vipin wrote: > [Public] > > Hi Bruce, > > Snipped > > > > > > > > > > > > > Hi Bruce, we have reviewed this internally and tested the same. > > > > > > We would like > > > > > your thought for the following. > > > > > > > > > > > > - Before pat

Re: [PATCH v1 2/8] net/r8169: update HW configurations for 8125 and 8126

2025-06-10 Thread Stephen Hemminger
On Tue, 10 Jun 2025 14:22:35 +0800 Howard Wang wrote: > Signed-off-by: Howard Wang > --- > drivers/net/r8169/base/rtl8125b.c |4 + > drivers/net/r8169/base/rtl8125bp_mcu.c | 172 +-- > drivers/net/r8169/base/rtl8125d.c | 99 +- > drivers/net/r8169/base/rtl8125d_mcu.c | 1471 ++

DPDK Release Status Meeting 2025-06-10

2025-06-10 Thread Mcnamara, John
Release status meeting minutes 2025-06-10 = Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens Participants: * ARM * Intel * Marvell * Microsoft * Nvidia * Red Hat Release Dates - The following are the proposed working date

[PATCH v8 5/7] latencystats: enforce that unused callback function is NULL

2025-06-10 Thread Stephen Hemminger
ISO C does not allow casting function pointer to void *. Resolve by enforcing the reserved argument. The user_cb argument for rte_latencystats_init() was not implemented, and had to be NULL anyway. The log type is local to this function and therefore can be local to this file. Signed-off-by: Step

[PATCH v8 3/7] latencystats: fix log messages

2025-06-10 Thread Stephen Hemminger
All messages occur because of an error should be at log level NOTICE or above. Do not break log messages across lines. Reword message for the case where getting info about a port fails and it is skipped. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff --- lib/latencystats/rte_latencys

RE: [PATCH v4] build: reduce use of AVX compiler flags

2025-06-10 Thread Varghese, Vipin
[Public] Snipped > > > > In above log I get `2 instances of march`; logs `-march=native -mrtm > > -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-format- > truncation -Wno-address-of-packed-member - > DRTE_LOG_DEFAULT_LOGTYPE=pmd.net.i40e -DCC_AVX512_SUPPORT - > march=skylake-avx512`. > > > >

[RFC PATCH dpdk] fib6: implement RCU rule reclamation

2025-06-10 Thread Robin Jarry
Currently, for the TRIE algorithm (actually, it should be called DIR-24-8-8-8-8-8-8-8-8-8-8-8-8), the tbl8 group is freed even though the readers might be using the tbl8 group entries. The freed tbl8 group can be reallocated quickly. As a result, lookup may be performed incorrectly. To address tha

[PATCH] doc: add release note entry for EAL lcores flag

2025-06-10 Thread Bruce Richardson
Add an entry in the release notes about the "-l" flag now being the same as the "--lcores" flag. Refer to the GSG for examples. Fixes: 1ea3833e9c4e ("eal: merge corelist and core mapping options") Signed-off-by: Bruce Richardson --- doc/guides/rel_notes/release_25_07.rst | 8 1 file ch

RE: [PATCH v4] build: reduce use of AVX compiler flags

2025-06-10 Thread Varghese, Vipin
[AMD Official Use Only - AMD Internal Distribution Only] > -Original Message- > From: Bruce Richardson > Sent: Tuesday, June 10, 2025 8:37 PM > To: Varghese, Vipin > Cc: dev@dpdk.org; Song, Keesang > Subject: Re: [PATCH v4] build: reduce use of AVX compiler flags > > Caution: This messa

RE: [PATCH v3 3/6] net/intel: add TxPP Support for E830

2025-06-10 Thread Hore, Soumyadeep
-Original Message- From: Richardson, Bruce Sent: 09 June 2025 20:09 To: Hore, Soumyadeep Cc: dev@dpdk.org; Singh, Aman Deep ; Subbarao, Manoj Kumar Subject: Re: [PATCH v3 3/6] net/intel: add TxPP Support for E830 On Sun, Jun 08, 2025 at 11:32:20AM +, Soumyadeep Hore wrote: > Ad

Re: [PATCH v17 0/4] add support for self monitoring

2025-06-10 Thread Tomasz Duszynski
Hi Thomas, Thanks for taking the time to merge the code and for the detailed update. Cleanup and fixes you've done - appreciated. I'm working on resolving remaining issues.

Re: [EXTERNAL] [PATCH v8] graph: mcore: optimize graph search

2025-06-10 Thread Thomas Monjalon
> > In the function __rte_graph_mcore_dispatch_sched_node_enqueue, use a > > slower loop to search for the graph, modify the search logic to record the > > result of the first search, and use this record for subsequent searches to > > improve search speed. > > In the function __rte_graph_mcore_dis

[PATCH v8 4/7] latencystats: update include files

2025-06-10 Thread Stephen Hemminger
Include what is used here. Signed-off-by: Stephen Hemminger --- lib/latencystats/rte_latencystats.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/lib/latencystats/rte_latencystats.c b/lib/latencystats/rte_latencystats.c index 50043aea72..1e176492f8 100

[PATCH v8 0/7] latencystats: cleanup and floating point fixes

2025-06-10 Thread Stephen Hemminger
Latencystats uses unnecessary floating point and is inaccurate if the number of cycles per ns is not an integral value. Cleanup the code and add more tests as well. v8 - rebase to 25.07-rc1 Stephen Hemminger (7): latencystats: handle fractional cycles per ns latencystats: do not use floating

[PATCH v8 6/7] latencystats: add metric for number of samples

2025-06-10 Thread Stephen Hemminger
Keeping track of the number of samples is useful when doing debug and testing to make sure that samples are actually happening. Signed-off-by: Stephen Hemminger --- lib/latencystats/rte_latencystats.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/lib/l

[PATCH 1/2] devtools/linux-uapi: conform to kernel headers install

2025-06-10 Thread Stephen Hemminger
The Linux kernel has an existing script to sanitize headers which uses more steps to clean up the header file. Make the DPDK header import script use the same regular expression. The kernel script is GPL-2.0 so ok. Not necessary for current vduse.h header only but useful if more headers are added

[PATCH 0/2] uapi: script and header update

2025-06-10 Thread Stephen Hemminger
Make the script do what "make headers install" does and update existing headers. Stephen Hemminger (2): devtools/linux-uapi: conform to kernel headers install uapi: update headers to 6.15 kernel devtools/linux-uapi.sh | 16 ++-- kernel/linux/uapi/linux/vduse.h | 6 +++--

[PATCH v8 2/7] latencystats: do not use floating point

2025-06-10 Thread Stephen Hemminger
The cycle counts do not need to be stored as floating point. Instead keep track of latency in cycles, and convert to nanoseconds when read. Use scaled math with exponential Weighted Moving Average weight of .25 to avoid use of floating point for that. The average latency took too long to "warm up

[PATCH v8 1/7] latencystats: handle fractional cycles per ns

2025-06-10 Thread Stephen Hemminger
The TSC frequency is not always an integral number of nanoseconds. For examples, cycles per nanoseconds on my test system is 2.8. Fix by using floating point where needed and calculate value once. Signed-off-by: Stephen Hemminger --- lib/latencystats/rte_latencystats.c | 17 ++--- 1

[PATCH v6 3/4] buildtools: embed driver information with MSVC

2025-06-10 Thread David Marchand
From: Andre Muezerie The archiver tool from the MSVC toolset is lib.exe. It has different parameters then it's GNU counterpart "ar". buildtools\meson.build was updated to use lib.exe when MSVC compiler is used. This is to allow the code to be built without requiring GNU "ar" to be installed in t

[PATCH v6 2/4] dev: export driver information with MSVC

2025-06-10 Thread David Marchand
From: Andre Muezerie DPDK uses GCC attribute "used" through macro __rte_used to indicate that a variable not referenced in the code should be assumed being used and therefore not be optimized away. This technique is used to embed information in the binaries, by having crafted information stored i

Re: [PATCH] net/ixgbe: fix unexpected data in the xstats info

2025-06-10 Thread Bruce Richardson
On Tue, Jun 10, 2025 at 01:42:25PM +0800, Kaiwen Deng wrote: > E610 device does not support MACsec. > > This commit will excluding MACsec stats from the xstats info > display for E610 device. > > Fixes: b35d309710fe ("net/ixgbe: add MACsec offload") > Cc: sta...@dpdk.org > Since E610 wasn't aro

[PATCH v8 7/7] test: update to latencystats tests

2025-06-10 Thread Stephen Hemminger
No need for loop and memset() here. Just use structure initialization. Remove unnecessary initializations. Look at the number of samples, min, max and average numbers to make sure they look correct. Forward for longer to make sure multiple samples are taken. Signed-off-by: Stephen Hemminger ---

Re: [PATCH] net/ixgbe: fix unexpected data in the xstats info

2025-06-10 Thread Bruce Richardson
On Tue, Jun 10, 2025 at 12:12:29PM +0100, Bruce Richardson wrote: > On Tue, Jun 10, 2025 at 01:42:25PM +0800, Kaiwen Deng wrote: > > E610 device does not support MACsec. > > > > This commit will excluding MACsec stats from the xstats info > > display for E610 device. > > > > Fixes: b35d309710fe (

RE: [PATCH v3 2/6] net/intel: add read clock feature in ICE

2025-06-10 Thread Hore, Soumyadeep
The similar implementation is done in igc driver. Currently we don't read time from device. We read the system time and send it out based on the burst calculations. The mechanism is same in kernel drivers too. On Sun, Jun 08, 2025 at 11:32:19AM +, Soumyadeep Hore wrote: > Adding eth_ice_read

Re: [PATCH v6 2/4] dev: export driver information with MSVC

2025-06-10 Thread David Marchand
On Tue, Jun 10, 2025 at 12:10 PM David Marchand wrote: > > From: Andre Muezerie > > DPDK uses GCC attribute "used" through macro __rte_used to indicate > that a variable not referenced in the code should be assumed being > used and therefore not be optimized away. This technique is used to embed

Re: [PATCH v12 0/7] add feature arc in rte_graph

2025-06-10 Thread Thomas Monjalon
> Nitin Saxena (7): > graph: add API to override node process function > graph: add feature arc registrations > graph: add feature arc init APIs > graph: add feature enable/disable APIs > ip4: add ip4 output feature arc > app/graph: add custom feature nodes for ip4 output arc > test/g

[PATCH v3 3/3] argparse: use enums to remove max-value defines in lists

2025-06-10 Thread Bruce Richardson
The use of lists of #defines with _MAX entries at the end causes issues for ABI compatibility as those MAX values often leak through to applications and can cause issues when changed. We can rework the code to increase type safety by splitting the flags field and using enums for each set of values

[PATCH v3 2/3] argparse: make argparse EAL-args compatible

2025-06-10 Thread Bruce Richardson
The argparse library was missing two key features which made it unsuitable for use by EAL or any program wanting similar behaviour. 1. It didn't stop parsing arguments when it hit a "--" character 2. It never returned the number of arguments parsed Fix both these issues - the latter is a change t

[PATCH v3 1/3] argparse: add support for string and boolean args

2025-06-10 Thread Bruce Richardson
Sometimes we don't want to parse the string at all, when doing arg parsing, and just save it off for later. Add support for that. Also, rather than assuming boolean values have to be the same size as uint8 (or some other size), add an explicitly type for that - which also allows checking for true/

[PATCH v3 0/3] argparse additions and rework

2025-06-10 Thread Bruce Richardson
This patchset is based off the work to adjust how we do argument parsing inside EAL. To enable argparse to be effectively used for EAL, we have new features and some changes in the first two patches, which are relatively small - though are ABI/API affecting. These add support for saving off string

Re: [PATCH v1 0/5] Update ixgbe base code

2025-06-10 Thread Bruce Richardson
On Mon, Jun 09, 2025 at 11:25:33AM +0100, Anatoly Burakov wrote: > Update IXGBE base code snapshot to version 2025-06-04. > > Aleksandr Loktionov (1): > net/ixgbe: remove PTP by PHY cap > > Anatoly Burakov (1): > net/ixgbe: update README > > Jedrzej Jagielski (1): > net/ixgbe: add VF mailb

RE: [PATCH v5 0/3] lcore options cleanup

2025-06-10 Thread Varghese, Vipin
[Public] Snipped > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > 27/05/2025 17:29, Bruce Richardson: > > This patchset performs some basic cleanup of EAL lcore arguments > > before any more serious w

RE: [PATCH v3 3/6] net/intel: add TxPP Support for E830

2025-06-10 Thread Hore, Soumyadeep
On Sun, Jun 08, 2025 at 11:32:20AM +, Soumyadeep Hore wrote: > Add support for Tx Time based queues. This is used to schedule packets > based on Tx timestamp. > > Signed-off-by: Soumyadeep Hore Some initial review comments inline below. /Bruce > --- > drivers/net/intel/common/tx.h

Re: [PATCH v2] common/mlx5: use intrinsics instead of inline assembly

2025-06-10 Thread Raslan Darawsheh
Hi, On 04/06/2025 5:15 PM, Andre Muezerie wrote: When compiling with MSVC the errors below are hit because msvc does not support inline assembly: 1) ../drivers/common/mlx5/mlx5_common.c(86): warning C4013: '__asm__' undefined; assuming extern returning int ../drivers/common/mlx5/mlx5_comm

Re: [PATCH v2] net/mlx5: fix hypervisor detection in VLAN workaround

2025-06-10 Thread Raslan Darawsheh
Hi, On 06/12/2024 4:26 PM, Viacheslav Ovsiienko wrote: The mlx5 PMD provides a specific workaround for the VMware ESXi hypervisor, enabling on-demand routing configuration to virtual machines. This workaround activates when the device type is a Virtual Function and either an ESXi hypervisor is

Re: [PATCH] net/mlx5: fix flag non-template rule cleanup

2025-06-10 Thread Raslan Darawsheh
Hi, On 05/06/2025 1:07 PM, Junfeng Guo wrote: Set the flag nt_rule to be FALSE whenever the flow rule is created through template API. This would ensure that this flow is always treated as template API flow after mlx5_ipool_malloc without being zeroing via memset. Otherwise, some tables or tem

[DPDK/eventdev Bug 1720] failure in event_vector_adapter_autotest

2025-06-10 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1720 Bug ID: 1720 Summary: failure in event_vector_adapter_autotest Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: critical

Re: [PATCH] net/mlx5: avoid setting kernel MTU if not needed

2025-06-10 Thread Raslan Darawsheh
Hi, On 28/05/2025 12:36 PM, Maxime Coquelin wrote: This patch checks whether the Kernel MTU has the same value as the requested one at port configuration time, and skip setting it if it is the same. Doing this, we can avoid the application to require NET_ADMIN capability, as in v23.11. Fixes:

Re: [PATCH v2] doc/guides: Mention needed kernel option for mlx5

2025-06-10 Thread Raslan Darawsheh
Hi, On 06/03/2025 11:09 PM, Jaromír Smrček wrote: On some kernels (Debian 6.6, 6.9 and 6.10 tested), there is a missing option for "TC recirculation" that prevents MLX5 driver to include CONFIG_MLX5_CLS_ACT in the compilation, thus preventing PF1 from properly working in multiport-eswitch mode.

Re: [EXTERNAL] [PATCH v2] examples/l3fwd: adjust Tx burst size based on Rx burst

2025-06-10 Thread Pavan Nikhilesh Bhagavatula
>Previously, the TX burst size was fixed at 256, leading to performance >degradation in certain scenarios. > >This patch introduces logic to set the TX burst size to match the >configured RX burst size (--burst option, default 32, max 512) >for better efficiency. > >Fixes: d5c4897ecfb2 ("examples/l