From: Zerun Fu
In the previous firmware load command logic, the driver doesn't send
the PF ID to the BSP, so the BSP can't process the DMA address correctly,
and this will lead to DMA mapping errors in memory read/write operations
when using multiple PF firmware.
Fix this by sending the PF ID to
When compiling with MSVC the error below pops up:
../app/test/test_ipfrag.c(39): error C2466:
cannot allocate an array of constant size 0
../app/test/test_ipfrag.c(157): warning C4034: sizeof returns 0
../app/test/test_ipfrag.c(160): warning C4034: sizeof returns 0
The fix is to simplify the
Compiling with MSVC logs the warnings below, which result in
build error:
../app/test/test_hash_readwrite.c(73): warning C4476: 'printf' :
unknown type field character ''' in format specifier
../app/test/test_hash_readwrite.c(75): warning C4474: 'printf' :
too many arguments passed for for
There are two lines that were using VLAs, which are not supported by
MSVC.
1)
../lib/rcu/rte_rcu_qsbr.c:326:12: warning: variable length array used [-Wvla]
326 | char data[dq->esize];
| ^
2)
../lib/rcu/rte_rcu_qsbr.c:389:12: warning: variable length array
On Wed, Mar 05, 2025 at 10:23:49PM +0100, David Marchand wrote:
> For versioning symbols:
> - MSVC uses pragmas on the function symbol,
> - GNU linker uses special asm directives,
>
> To accommodate both GNU linker and MSVC linker, introduce new macros for
> versioning functions that will surround
I accidentally sent the last version (v9) with an incorrect git name, but the
commits are signed correctly. Will this be an issue or should I upload a new
version with the correct name?
From: Pavan Nikhilesh
SKIP_FILES should include the path of the file.
Update the regex to match the path.
Fixes: dd88f51a5725 ("devtools: forbid DPDK API in cnxk base driver")
Signed-off-by: Pavan Nikhilesh
---
devtools/checkpatches.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
di
On Fri, Feb 7, 2025 at 4:04 PM Andre Muezerie
wrote:
>
> Macro __SIZEOF_LONG__ is not standardized and MSVC does not define it.
> Therefore the errors below are seen with MSVC:
>
> ../lib/mldev/mldev_utils_scalar.c(465): error C2065:
> '__SIZEOF_LONG__': undeclared identifier
> ../lib/mldev/ml
For versioning symbols:
- MSVC uses pragmas on the symbol,
- GNU linker uses special asm directives,
To accommodate both GNU linker and MSVC linker, introduce new macros for
exporting and versioning symbols that will surround the whole function.
This has the advantage of hiding all the ugly detai
Rather than maintain a file in parallel of the code, symbols to be
exported can be marked with a token.
The build framework then generates map files in a format that can satisfy
GNU linker.
Apply those macros to lib/net as an example.
Documentation is missing.
Converting from .map to Windows expo
By default (and if no $HOME/.ccache directory exists), Ubuntu 22.04 ccache
stores its data in $HOME/.cache/ccache.
As a result, since the switch to Ubuntu 22.04, ccache has not been
functional.
Set the ccache directory to the location cached in GHA.
Note: ccache is working with the Fedora contain
On Tue, Feb 4, 2025 at 2:24 AM Andre Muezerie
wrote:
>
> Variable "success" was not being initialized and there was a code
> path where the last do/while loop in __rte_stack_lf_pop_elems
> looked at the value of this variable before it was set to any.
>
> Compiling with msvc resulted in stack_lf_a
The patch converts include files with DPDK API to RUST and binds new
RUST API files info dpdklib package.
The RUST dpdklib files and DPDK libraries build from C sources
allow creation of DPDK application in RUST.
RUST DPDK application must specify the `dpdklib` package as
dependency in Cargo.toml
On Wed, Feb 26, 2025 at 10:21 PM Andre Muezerie
wrote:
>
> Meson.build files were refactored to add MSVC support for the AVX2
> instruction set with MSVC: Top level variable cc_avx2_flags was created
> and set according to the compiler used. It is used in lower level
> directories.
>
> Andre Mueze
On Fri, Feb 28, 2025 at 11:03 PM Andre Muezerie
wrote:
> @@ -14,9 +59,8 @@ if is_linux or cc.get_id() == 'gcc'
> endif
> endif
>
> -cc_avx512_flags = ['-mavx512f', '-mavx512vl', '-mavx512dq', '-mavx512bw']
> -cc_has_avx512 = false
> -target_has_avx512 = false
> +cc_avx2_flags = ['-mavx2']
I
On Fri, Feb 28, 2025 at 11:03 PM Andre Muezerie
wrote:
>
> In preparation to add better MSVC support, existing common code was
> moved up.
>
> A split was added which in future will call an MSVC specific meson.build
> file:
>
> if is_ms_compiler
> subdir_done()
> endif
>
> Signed-off-by: Andre
On Tue, Mar 4, 2025 at 11:50 AM Bruce Richardson
wrote:
>
> On Mon, Mar 03, 2025 at 12:47:54PM -0800, Andre Muezerie wrote:
> > Updated meson.build to use common variable cc_avx512_flags for
> > msvc and avoiding code duplication for other compilers.
> >
> > Signed-off-by: Andre Muezerie
> > ---
On Thu, Mar 06, 2025 at 01:50:20PM +0100, David Marchand wrote:
> For versioning symbols:
> - MSVC uses pragmas on the symbol,
> - GNU linker uses special asm directives,
>
> To accommodate both GNU linker and MSVC linker, introduce new macros for
> exporting and versioning symbols that will surro
On Thu, Mar 06, 2025 at 01:59:34PM +0100, David Marchand wrote:
> On Wed, Feb 19, 2025 at 2:40 AM Andre Muezerie
> wrote:
> >
> > When compiling with MSVC the error below shows up due to function
> > versioning:
> >
> > ../lib/net/rte_net_crc.c(418): error C2061: syntax error:
> > identifier '
> -Original Message-
> From: Luka Jankovic
> Sent: Thursday, March 6, 2025 1:46 PM
> To: Luka Jankovic
> Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula ;
> Jerin Jacob ; Mattias Rönnblom
>
> Subject: [EXTERNAL] Re: [PATCH v9 0/3] eventdev: atomic tests to test-eventdev
> app
>
> I acc
Add an atomic atq test to the test-eventdev app. The test works
in the same way as atomic queue, the difference being that only one
queue capable of all types for both stages.
Signed-off-by: Luka Jankovic
Tested-by: Pavan Nikhilesh
---
app/test-eventdev/meson.build |1 +
app
Add atomic tests to the test-eventdev app which correspond to the order
tests but use exclusively atomic queues.
The test detects if port maintenance is required, and so they are compatible
with event devices such as the distributed software eventdev.
To verify atomicity, a spinlock is used for e
> From: Gregory Etelson
> Sent: Thursday, March 6, 2025 1:37 PM
> To: dev@dpdk.org
> Cc: getel...@nvidia.com ; tho...@monjalon.net
> ; mkash...@nvidia.com ; Richardson,
> Bruce
> Subject: [PATCH] rust: support DPDK API
Cool, I like this subject, great!
> The patch converts include files with
On Thu, Mar 6, 2025 at 3:34 PM David Marchand wrote:
>
> By default (and if no $HOME/.ccache directory exists), Ubuntu 22.04 ccache
> stores its data in $HOME/.cache/ccache.
> As a result, since the switch to Ubuntu 22.04, ccache has not been
> functional.
>
> Set the ccache directory to the locat
06/03/2025 16:25, pbhagavat...@marvell.com:
> From: Pavan Nikhilesh
>
> SKIP_FILES should include the path of the file.
> Update the regex to match the path.
Can you please also check this one:
-v SKIP_FILES='osdep.h$'
Is it really working without the full path?
Changes the checksum offload testing suite to use layer 4
destination ports as packet verification IDs.
Signed-off-by: Dean Marx
---
dts/tests/TestSuite_checksum_offload.py | 130 ++--
1 file changed, 77 insertions(+), 53 deletions(-)
diff --git a/dts/tests/TestSuite_checksu
Currently, the unified packet and checksum offload test suites
use a random MAC destination address as a way to find sent
packets in testpmd verbose output. However, this does not work
for certain NICs that change the MAC address prior to reception.
The new verification involves setting a random UD
Remove capability requirement from checksum offload test suite
that was not required to run the test cases.
Signed-off-by: Dean Marx
---
dts/tests/TestSuite_checksum_offload.py | 1 -
1 file changed, 1 deletion(-)
diff --git a/dts/tests/TestSuite_checksum_offload.py
b/dts/tests/TestSuite_check
> Subject: Re: [PATCH] net/mana: avoid the use of variable length array
>
> On Tue, Mar 04, 2025 at 04:37:32PM -0800, lon...@linuxonhyperv.com wrote:
> > From: Long Li
> >
> > The pathname can be defined as name[MAX_PATH]. This makes the driver
> > compilable using MSVC.
> >
> > Signed-off-by: Lo
> rx/tx offload:
>
> 1.Dean has rebased this series but is running into a bug with the capability
> check test parser returning no flags. He confirmed from running the steps
> manually that the flags we expect are being reported by testpmd.
>
> 2. Dean please provide a summary to Luca so there is
On Mon, Mar 3, 2025 at 9:25 PM Andre Muezerie
wrote:
>
> Updated meson.build to use common variables cc_has_avx512 and
> cc_avx512_flags.
>
> Signed-off-by: Andre Muezerie
> Acked-by: Bruce Richardson
Applied, thanks.
--
David Marchand
> 06/03/2025 16:25, pbhagavat...@marvell.com:
> > From: Pavan Nikhilesh
> >
> > SKIP_FILES should include the path of the file.
> > Update the regex to match the path.
>
> Can you please also check this one:
> -v SKIP_FILES='osdep.h$'
> Is it really working without the full path?
>
Sure,
Changes the unified packet testing suite to use layer 4
destination ports as packet verification IDs.
Signed-off-by: Dean Marx
---
dts/tests/TestSuite_uni_pkt.py | 106 -
1 file changed, 51 insertions(+), 55 deletions(-)
diff --git a/dts/tests/TestSuite_uni_pkt.p
28/02/2025 01:15, fengchengwen:
> Reviewed-by: Chengwen Feng
>
> On 2025/2/27 21:27, Bruce Richardson wrote:
> > When running without IOMMU for address translation, i.e. IOVAs are
> > physical rather than virtual addresses, we need to translate the
> > pointers to IOVAs for the completion API tes
19/02/2025 19:45, Stephen Hemminger:
> On Tue, 18 Feb 2025 12:58:28 +0100
> Thierry Herbelot wrote:
>
> > 'width' and 'offset' are input parameters when dumping the register
> > info of an Ethernet device. They should be copied in the new request
> > before calling the device callback function.
>
Hi Dean/Nick,
Luca said this morning he is starting to look at Ethertype and rx/tx
offload testsuites. At the CI meeting I gave him an overview of what you
both had learned about these so there isn't double work. My summary:
Ethertype:
1.TPID/VLAN filtering works only on Mellanox NICs and we don
Up to now MSVC has being used with the default mode, which uses SSE2
instructions for scalar floating-point and vector calculations.
https://learn.microsoft.com/en-us/cpp/build/reference/arch-x64?view=msvc-170
This patchset allows users to specify the CPU for which the generated
code should be opt
> -Original Message-
> From: Stephen Hemminger
> Sent: Thursday, 20 February 2025 20:33
> To: Shani Peretz
> Cc: dev@dpdk.org; Tyler Retzlaff ; Parav Pandit
> ; Xueming Li ; Nipun Gupta
> ; Nikhil Agarwal ; Hemant
> Agrawal ; Sachin Saxena
> ; Rosen Xu ; Chenbo Xia
> ; Tomasz Duszynski ;
> 06/03/2025 16:25, pbhagavat...@marvell.com:
> > From: Pavan Nikhilesh
> >
> > SKIP_FILES should include the path of the file.
> > Update the regex to match the path.
> >
> > Fixes: dd88f51a5725 ("devtools: forbid DPDK API in cnxk base driver")
> >
> > Signed-off-by: Pavan Nikhilesh
> > ---
> >
A new DPDK release candidate is ready for testing:
https://git.dpdk.org/dpdk/tag/?id=v25.03-rc2
There are 251 new patches in this snapshot.
Release notes:
https://doc.dpdk.org/guides/rel_notes/release_25_03.html
Most significant changes are in multiple drivers.
Please test and r
This patchset allows users to specify the CPU for which the generated
code should be optimized for by passing the CPU name.
MSVC does not provide this functionality natively, so logic was
added. This additional logic relies on a table which stores instruction
set availability (like AXV512F) for di
Hi,
Thank you very much for the patch.
Could you please regenerate the patch and resend?
CI job for checking patches fails, because it seems that patch is corrupted:
http://mails.dpdk.org/archives/test-report/2025-January/844526.html
It appears that spaces are missing at the beginning of diff li
06/03/2025 16:25, pbhagavat...@marvell.com:
> From: Pavan Nikhilesh
>
> SKIP_FILES should include the path of the file.
> Update the regex to match the path.
>
> Fixes: dd88f51a5725 ("devtools: forbid DPDK API in cnxk base driver")
>
> Signed-off-by: Pavan Nikhilesh
> ---
> - -v SK
On Tue, Mar 4, 2025 at 4:51 PM David Marchand wrote:
>
> We face some random failures accessing dpdk.org git when running GHA.
> Point at GitHub hosted mirror.
>
> Cc: sta...@dpdk.org
>
> Signed-off-by: David Marchand
Applied, thanks.
--
David Marchand
From: Pavan Nikhilesh
SKIP_FILES should include the path of the file along with the name.
Update the regex to match the entire path.
Fixes: dd88f51a5725 ("devtools: forbid DPDK API in cnxk base driver")
Fixes: 2b843cac232e ("drivers: use per line logging in helpers")
Signed-off-by: Pavan Nikhil
22/02/2025 03:08, fengchengwen:
> Acked-by: Chengwen Feng
>
> On 2025/2/19 22:23, Konstantin Ananyev wrote:
> > This change addresses the CID 455328: Uninitialized variables (UNINIT).
> > Strictly speaking right now it should never happen, as role_mask is not
> > zero. But that might change in f
46 matches
Mail list logo
