[PATCH v12 0/7] Lcore variables

2024-10-15 Thread Mattias Rönnblom
This patch set introduces a new API for static per-lcore id data allocation. Please refer to the API documentation for both a rationale for this new API, and a comparison to the alternatives available. The question on how to best allocate static per-lcore memory has been up several times on the

[PATCH v12 1/7] eal: add static per-lcore memory allocation facility

2024-10-15 Thread Mattias Rönnblom
Introduce DPDK per-lcore id variables, or lcore variables for short. An lcore variable has one value for every current and future lcore id-equipped thread. The primary use case is for statically allocating small, frequently-accessed data structures, for which one instance should exist for each l

[PATCH v12 6/7] service: keep per-lcore state in lcore variable

2024-10-15 Thread Mattias Rönnblom
Replace static array of cache-aligned structs with an lcore variable, to slightly benefit code simplicity and performance. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Konstantin Ananyev Acked-by: Chengwen Feng Acked-by: Stephen Hemminger -- PATCH v7: * Update to match

[PATCH v12 5/7] power: keep per-lcore state in lcore variable

2024-10-15 Thread Mattias Rönnblom
Replace static array of cache-aligned structs with an lcore variable, to slightly benefit code simplicity and performance. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Konstantin Ananyev Acked-by: Chengwen Feng Acked-by: Stephen Hemminger -- PATCH v6: * Update FOREACH

[PATCH v12 7/7] eal: keep per-lcore power intrinsics state in lcore variable

2024-10-15 Thread Mattias Rönnblom
Keep per-lcore power intrinsics state in a lcore variable to reduce cache working set size and avoid any CPU next-line-prefetching causing false sharing. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Konstantin Ananyev Acked-by: Chengwen Feng Acked-by: Stephen Hemminger --

[PATCH v12 3/7] eal: add lcore variable performance test

2024-10-15 Thread Mattias Rönnblom
Add basic micro benchmark for lcore variables, in an attempt to assure that the overhead isn't significantly greater than alternative approaches, in scenarios where the benefits aren't expected to show up (i.e., when plenty of cache is available compared to the working set size of the per-lcore dat

[PATCH v12 2/7] eal: add lcore variable functional tests

2024-10-15 Thread Mattias Rönnblom
Add functional test suite to exercise the API. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Chengwen Feng Acked-by: Stephen Hemminger -- PATCH v6: * Update FOREACH invocations to match new API. RFC v5: * Adapt tests to reflect the removal of the GET() and SET() macro

[PATCH v12 4/7] random: keep PRNG state in lcore variable

2024-10-15 Thread Mattias Rönnblom
Replace keeping PRNG state in a RTE_MAX_LCORE-sized static array of cache-aligned and RTE_CACHE_GUARDed struct instances with keeping the same state in a more cache-friendly lcore variable. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Konstantin Ananyev Acked-by: Chengwen F

Re: [PATCH v11 1/7] eal: add static per-lcore memory allocation facility

2024-10-15 Thread Mattias Rönnblom
On 2024-10-15 08:41, Mattias Rönnblom wrote: On 2024-10-14 10:17, Morten Brørup wrote: +/** + * Get pointer to lcore variable instance with the specified lcore id. + * + * @param lcore_id + *   The lcore id specifying which of the @c RTE_MAX_LCORE value + *   instances should be accessed.

[v7 00/15] NXP DMA driver fixes and Enhancements

2024-10-15 Thread Gagandeep Singh
V7 changes: * remove rte_panic from driver code. V6 changes: * fix array bound compilation warning with GCC 11.4 V5 changes: * typos and doc compilation fixed V4 changes: * rebased series to latest commit and patches reduced. V3 changes: * fix 32 bit compilation issue V2 changes: * fix compila

[v7 02/15] dma/dpaa2: refactor driver code

2024-10-15 Thread Gagandeep Singh
From: Jun Yang refactor the driver code with changes in: - multiple HW queues - SMA single copy and SG copy - silent mode Signed-off-by: Jun Yang --- doc/guides/dmadevs/dpaa2.rst |8 + drivers/dma/dpaa2/dpaa2_qdma.c | 2200 drivers/dma/dpaa2/dpaa2

[v7 03/15] bus/fslmc: enhance the qbman dq storage logic

2024-10-15 Thread Gagandeep Singh
From: Jun Yang Multiple DQ storages are used among multiple cores, the single dq storage of first union is leak if multiple storages are allocated. It does not make sense to keep the single dq storage of union, remove it and reuse the first dq storage of multiple storages for this case. Signed-o

[v7 04/15] dma/dpaa2: add short FD support

2024-10-15 Thread Gagandeep Singh
From: Jun Yang Short FD can be used for single transfer scenario which shows higher performance than FLE. 1) Save index context in FD att field for short and FLE(NonSG). 2) Identify FD type by att of FD. 3) Force 48 bits address for source address and fle according to spec. Signed-off-by: Jun Ya

[v7 01/15] dma/dpaa2: configure route by port by PCIe port param

2024-10-15 Thread Gagandeep Singh
From: Jun Yang struct { uint64_t coreid : 4; /**--rbp.sportid / rbp.dportid*/ uint64_t pfid : 8; /**--rbp.spfid / rbp.dpfid*/ uint64_t vfen : 1; /**--rbp.svfa / rbp.dvfa*/ uint64_t vfid : 16; /**--rbp.svfid / rbp.dvfid*/ . } pcie; Signed-off-by: Jun Ya

[v7 06/15] dma/dpaa2: change the DMA copy return value

2024-10-15 Thread Gagandeep Singh
From: Jun Yang The return value of DMA copy/sg copy should be index of descriptor copied in success. Signed-off-by: Jun Yang --- drivers/dma/dpaa2/dpaa2_qdma.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/dma/dpaa2/dpaa2_qdma.c b/drivers/dma/dpaa2

[v7 05/15] dma/dpaa2: limit the max descriptor number

2024-10-15 Thread Gagandeep Singh
From: Jun Yang For non-SG format, the index is saved in FD with DPAA2_QDMA_FD_ATT_TYPE_OFFSET(13) bits width. The max descriptor number of ring is power of 2, so the eventual max number is: ((1 << DPAA2_QDMA_FD_ATT_TYPE_OFFSET) / 2) Signed-off-by: Jun Yang --- drivers/dma/dpaa2/dpaa2_qdma.h |

[v7 07/15] dma/dpaa2: move the qdma header to common place

2024-10-15 Thread Gagandeep Singh
From: Jun Yang Include rte_pmd_dpaax_qdma.h instead of rte_pmd_dpaa2_qdma.h and change code accordingly. Signed-off-by: Jun Yang --- doc/api/doxy-api-index.md | 2 +- doc/api/doxy-api.conf.in | 2 +- drivers/common/dpaax/meson.build | 3 +- drivers/

[v7 08/15] dma/dpaa: refactor driver

2024-10-15 Thread Gagandeep Singh
From: Jun Yang This patch refactor the DPAA DMA driver code with changes: - HW descriptors rename and update with details. - update qdma engine and queue structures - using rte_ring APIs for enqueue and dequeue. Signed-off-by: Jun Yang Signed-off-by: Gagandeep Singh --- drivers/dma/dpaa/dp

[v7 11/15] dma/dpaa: add workaround for ERR050757

2024-10-15 Thread Gagandeep Singh
From: Jun Yang ERR050757 on LS104x indicates: For outbound PCIe read transactions, a completion buffer is used to store the PCIe completions till the data is passed back to the initiator. At most 16 outstanding transactions are allowed and maximum read request is 256 bytes. The completion buffer

[v7 10/15] dma/dpaa: add silent mode support

2024-10-15 Thread Gagandeep Singh
From: Jun Yang add silent mode support. Signed-off-by: Jun Yang Signed-off-by: Gagandeep Singh --- drivers/dma/dpaa/dpaa_qdma.c | 46 drivers/dma/dpaa/dpaa_qdma.h | 1 + 2 files changed, 42 insertions(+), 5 deletions(-) diff --git a/drivers/dma/dpaa/dpaa

[v7 12/15] dma/dpaa: qdma stall workaround for ERR050265

2024-10-15 Thread Gagandeep Singh
From: Jun Yang Non-prefetchable read setting in the source descriptor may be required for targets other than local memory. Prefetchable read setting will offer better performance for misaligned transfers in the form of fewer transactions and should be set if possible. This patch also fixes QDMA s

[v7 09/15] dma/dpaa: support burst capacity API

2024-10-15 Thread Gagandeep Singh
From: Jun Yang This patch improves the dpaa qdma driver and adds dpaa_qdma_burst_capacity API which returns the remaining space in the descriptor ring. Signed-off-by: Jun Yang Signed-off-by: Gagandeep Singh --- drivers/dma/dpaa/dpaa_qdma.c | 10 ++ 1 file changed, 10 insertions(+) di

[v7 14/15] dma/dpaa: add DMA error checks

2024-10-15 Thread Gagandeep Singh
From: Jun Yang add user configurable DMA error checks. Signed-off-by: Jun Yang Signed-off-by: Gagandeep Singh --- doc/guides/dmadevs/dpaa.rst | 6 ++ drivers/dma/dpaa/dpaa_qdma.c | 135 ++- drivers/dma/dpaa/dpaa_qdma.h | 42 ++ drivers/net/d

Re: [PATCH v5 9/9] net/zxdh: add zxdh dev configure ops

2024-10-15 Thread Stephen Hemminger
On Tue, 15 Oct 2024 13:44:35 +0800 Junlong Wang wrote: > provided zxdh dev configure ops for queue > check,reset,alloc resources,etc. > > Signed-off-by: Junlong Wang These build failures need to be addressed. Probably as simple as adding struct bar_msg_header msg_header = { 0 };

Re: [PATCH v5 0/6] Stage-Ordered API and other extensions for ring library

2024-10-15 Thread Stephen Hemminger
On Tue, 15 Oct 2024 14:01:05 +0100 Konstantin Ananyev wrote: > From: Konstantin Ananyev > > NOTE UPFRONT: this version is still not ready for merging. > Missing items: > - ARM/PPC tests passing > - PG update > > v4 -> v5 > - fix public API/doc comments from Jerin > - update devtools/build-dict

Re: [PATCH v1 00/18] net/r8169: add r8169 pmd to dpdk

2024-10-15 Thread Stephen Hemminger
On Tue, 15 Oct 2024 11:09:10 +0800 Howard Wang wrote: > R8169 pmd supports Realtek 2.5G and 5G ethernet nics. > > Howard Wang (18): > net/r8169: add PMD driver skeleton > net/r8169: add logging structure > net/r8169: add hardware registers access routines > net/r8169: implement core logi

Re: [PATCH v5 0/6] Stage-Ordered API and other extensions for ring library

2024-10-15 Thread Stephen Hemminger
On Tue, 15 Oct 2024 14:01:05 +0100 Konstantin Ananyev wrote: > From: Konstantin Ananyev > > NOTE UPFRONT: this version is still not ready for merging. > Missing items: > - ARM/PPC tests passing > - PG update > > v4 -> v5 > - fix public API/doc comments from Jerin > - update devtools/build-dict

RE: [PATCH] mbuf: add transport mode ESP packet type

2024-10-15 Thread Dariusz Sosnowski
> -Original Message- > From: Alexander Kozyrev > Sent: Thursday, August 22, 2024 17:32 > To: dev@dpdk.org > Cc: Dariusz Sosnowski ; Ori Kam ; > nithind1...@gmail.com; olivier.m...@6wind.com; NBU-Contact-Thomas > Monjalon (EXTERNAL) ; Matan Azrad > ; jer...@marvell.com; rbhans...@marvell.co

Re: [PATCH v1 15/18] net/r8169: impelment MTU configuration

2024-10-15 Thread Stephen Hemminger
On Tue, 15 Oct 2024 11:09:25 +0800 Howard Wang wrote: > +static int > +rtl_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) > +{ > + struct rte_eth_dev_info dev_info; > + struct rtl_adapter *adapter = RTL_DEV_PRIVATE(dev); > + struct rtl_hw *hw = &adapter->hw; > + int ret; > +

Re: [PATCH 02/20] event/cnxk: add CN20K specific device probe

2024-10-15 Thread Stephen Hemminger
On Thu, 3 Oct 2024 18:52:19 +0530 wrote: > From: Pavan Nikhilesh > > Add platform specific event device probe and remove, also add > event device info get function. > > Signed-off-by: Pavan Nikhilesh > --- > doc/guides/eventdevs/cnxk.rst | 30 + > doc/guides/rel_notes/releas

[PATCH v2 0/5] updates for net/ice driver

2024-10-15 Thread Bruce Richardson
This patchset contains a set of updates for the ice driver, a number of which are in the area of the "rte_tm" APIs for Tx scheduling. These patches were previously submitted as part of a larger set[1], but separating them out here for easier review and merge ahead of the more substantial changes f

[PATCH v2 3/5] net/ice: add option to choose DDP package file

2024-10-15 Thread Bruce Richardson
The "Dynamic Device Personalization" package is loaded at initialization time by the driver, but the specific package file loaded depends upon what package file is found first by searching through a hard-coded list of firmware paths. To enable greater control over the package loading, we can add a

[PATCH v2 2/5] net/ice: improve Tx scheduler graph output

2024-10-15 Thread Bruce Richardson
The function to dump the TX scheduler topology only adds to the chart nodes connected to TX queues or for the flow director VSI. Change the function to work recursively from the root node and thereby include all scheduler nodes, whether in use or not, in the dump. Also, improve the output of the T

[PATCH v2 4/5] net/ice: add option to download scheduler topology

2024-10-15 Thread Bruce Richardson
The DDP package file being loaded at init time may contain an alternative Tx Scheduler topology in it. Add driver option to load this topology at init time. Signed-off-by: Bruce Richardson --- V2: use uint8_t rather than int for boolean flag for consistency. --- drivers/net/ice/base/ice_ddp.c |

[PATCH v2 5/5] net/ice: limit the number of queues to sched capabilities

2024-10-15 Thread Bruce Richardson
Rather than assuming that each VSI can hold up to 256 queue pairs, or the reported device limit, query the available nodes in the scheduler tree to check that we are not overflowing the limit for number of child scheduling nodes at each level. Do this by multiplying max_children for each level beyo

[PATCH v2 1/5] net/ice: detect stopping a flow-director queue twice

2024-10-15 Thread Bruce Richardson
If the flow-director queue is stopped at some point during the running of an application, the shutdown procedure for the port issues an error as it tries to stop the queue a second time, and fails to do so. We can eliminate this error by setting the tail-register pointer to NULL on stop, and checki

Re: [PATCH v1 12/18] net/r8169: implement Tx path

2024-10-15 Thread Stephen Hemminger
On Tue, 15 Oct 2024 08:30:19 -0700 Stephen Hemminger wrote: > On Tue, 15 Oct 2024 11:09:22 +0800 > Howard Wang wrote: > > > +rtl_tx_queue_release_mbufs(struct rtl_tx_queue *txq) > > +{ > > + int i; > > + > > + PMD_INIT_FUNC_TRACE(); > > + > > + if (txq != NULL) { > > + if (txq->

Re: [PATCH v5 9/9] net/zxdh: add zxdh dev configure ops

2024-10-15 Thread Stephen Hemminger
On Tue, 15 Oct 2024 13:44:35 +0800 Junlong Wang wrote: > diff --git a/drivers/net/zxdh/meson.build b/drivers/net/zxdh/meson.build > index 9aec47e68f..cde96d8111 100644 > --- a/drivers/net/zxdh/meson.build > +++ b/drivers/net/zxdh/meson.build > @@ -14,8 +14,9 @@ if not dpdk_conf.has('RTE_ARCH_X86_

Re: [PATCH v10 1/2] power: introduce PM QoS API on CPU wide

2024-10-15 Thread Stephen Hemminger
On Tue, 15 Oct 2024 17:41:39 +0800 "lihuisong (C)" wrote: > Hi Stephen, > > Can you take a look at this reply so as to send out the next version ASAP? > Thanks.😁 > > /Huisong > 在 2024/10/14 20:19, lihuisong (C) 写道: The biggest issue is that lcore is not the same as cpu as far as kernel is con

[PATCH v2 1/5] net/mlx5/hws: introduce new matcher type

2024-10-15 Thread Alexander Kozyrev
From: Hamdan Igbaria introduce STE array matcher, where this matcher can only be isolated under a parent table and not chained to the table matchers chain. Signed-off-by: Hamdan Igbaria --- drivers/net/mlx5/hws/mlx5dr.h | 13 +- drivers/net/mlx5/hws/mlx5dr_debug.c | 12 +- dr

[PATCH v2 3/5] net/mlx5: create array ste matcher

2024-10-15 Thread Alexander Kozyrev
Create an array STE matcher for a template table in case of insertion by index with pattern is selected. Packets will be matched on a pattern at the index. This table is isolated from any other tables in a group. That means packets missed the rule won't go to a lower priority tables, but proceed wi

[PATCH v2 5/5] net/mlx5: implement jump to table index action

2024-10-15 Thread Alexander Kozyrev
Implement RTE_FLOW_ACTION_TYPE_JUMP_TO_TABLE_INDEX action. Create the hardware steering jump to matcher action, associated with the template matcher. Use this action and provide the rule index as an offset in the matcher. Note that it is only supported by the isolated matcher, i.e. the table insert

[PATCH v2 2/5] net/mlx5/hws: introduce jump to matcher action

2024-10-15 Thread Alexander Kozyrev
From: Hamdan Igbaria Introduce jump to matcher action, this action will allow jumping to another matcher. For now this jump restricted to STE array matchers and matchers of size 1. Signed-off-by: Hamdan Igbaria --- drivers/net/mlx5/hws/mlx5dr.h| 29 ++ drivers/net/mlx5/hws/mlx5

[PATCH v2 4/5] net/mlx5: add flow rule insertion by index with pattern

2024-10-15 Thread Alexander Kozyrev
Implement rte_flow_async_create_by_index_with_pattern() function. Rework the driver implementation to reduce code duplication by providing a single flow insertion routine, that can be called with different parameters depending on the insertion type. Signed-off-by: Alexander Kozyrev --- drivers/n

Re: [v3 5/5] raw/gdtc: add support for dequeue operation

2024-10-15 Thread Patrick Robb
It looks like this did not get processed correctly by patchwork, or there is an issue with the patchfiles. https://patchwork.dpdk.org/project/dpdk/list/?series=&submitter=&state=&q=gdtc&archive=&delegate= Can you resubmit? It was not picked up by 3/4 of the CI labs. On Mon, Oct 14, 2024 at 4:16 

Re: [v3 5/5] raw/gdtc: add support for dequeue operation

2024-10-15 Thread Patrick Robb
Sorry, I should have flagged that the series is called "untitled series #" which is why I think there is a problem with how the series was submitted.

[PATCH 2/3] bitset: fix build for GCC without experimental API

2024-10-15 Thread David Marchand
For a reason similar to the change on bitops header, hide bitset implementation relying on experimental API. Fixes: 99a1197647d8 ("eal: add bitset type") Signed-off-by: David Marchand --- lib/eal/include/rte_bitset.h | 123 +++ 1 file changed, 123 insertions(+)

[PATCH 3/3] buildtools/chkincs: check headers with stable API only

2024-10-15 Thread David Marchand
An exported header should be usable w/ and w/o ALLOW_EXPERIMENTAL_API so that an application that only wants stable API may include it. Plus, the widely common case is that an application will not use internal API. Cover those cases but keep the original test. Signed-off-by: David Marchand ---

RE: [PATCH 1/3] bitops: fix build for GCC without experimental API

2024-10-15 Thread Morten Brørup
> From: David Marchand [mailto:david.march...@redhat.com] > Sent: Tuesday, 15 October 2024 14.11 > > Building OVS against current DPDK fails with following warnings: > > In file included from .../ovs/dpdk-dir/include/rte_memory.h:18, > from .../ovs/dpdk-dir/include/rte_ring_core.

RE: [PATCH 2/3] bitset: fix build for GCC without experimental API

2024-10-15 Thread Morten Brørup
> From: David Marchand [mailto:david.march...@redhat.com] > Sent: Tuesday, 15 October 2024 14.11 > > For a reason similar to the change on bitops header, hide bitset > implementation relying on experimental API. > > Fixes: 99a1197647d8 ("eal: add bitset type") > > Signed-off-by: David Marchand

[PATCH v5 6/6] test: add stress test suite

2024-10-15 Thread Konstantin Ananyev
From: Konstantin Ananyev Add a new test suite which purpose is to run 'stress' tests: main purpose is put a pressure to dpdk sync algorithms to flag their misbehaving/slowdown/etc. Right now it consists from just 2 test-cases: meson test --suite stress-tests --list DPDK:stress-tests / ring_stress

[PATCH v5 5/6] app/test: add unit tests for soring API

2024-10-15 Thread Konstantin Ananyev
From: Konstantin Ananyev Add both functional and stess test-cases for soring API. Stress test serves as both functional and performance test of soring enqueue/dequeue/acquire/release operations under high contention (for both over committed and non-over committed scenarios). Signed-off-by: Eimea

[PATCH v5 2/6] ring: make copying functions generic

2024-10-15 Thread Konstantin Ananyev
From: Konstantin Ananyev Note upfront: that change doesn't introduce any functional or performance changes. It is just a code-reordering for: - improve code modularity and re-usability - ability in future to re-use the same code to introduce new functionality There is no real need for enqueue_

[PATCH v5 4/6] ring/soring: introduce Staged Ordered Ring

2024-10-15 Thread Konstantin Ananyev
From: Konstantin Ananyev Staged-Ordered-Ring (SORING) provides a SW abstraction for 'ordered' queues with multiple processing 'stages'. It is based on conventional DPDK rte_ring, re-uses many of its concepts, and even substantial part of its code. It can be viewed as an 'extension' of rte_ring fu

[PATCH v5 0/6] Stage-Ordered API and other extensions for ring library

2024-10-15 Thread Konstantin Ananyev
From: Konstantin Ananyev NOTE UPFRONT: this version is still not ready for merging. Missing items: - ARM/PPC tests passing - PG update v4 -> v5 - fix public API/doc comments from Jerin - update devtools/build-dict.sh (Stephen) - fix MSVC warnings - introduce new test-suite for meson (stress) wit

[PATCH v5 1/6] ring: common functions for 'move head' ops

2024-10-15 Thread Konstantin Ananyev
From: Konstantin Ananyev Note upfront: that change doesn't introduce any functional or performance changes. It is just a code-reordering for: - code deduplication - ability in future to re-use the same code to introduce new functionality For each sync mode corresponding move_prod_head() and mo

[PATCH v5 3/6] ring: make dump function more verbose

2024-10-15 Thread Konstantin Ananyev
From: Eimear Morrissey The current rte_ring_dump function uses the generic rte_ring_headtail structure to access head/tail positions. This is incorrect for the RTS case where the head is stored in a different offset in the union of structs. Switching to a separate function for each sync type allo

[RFC v2 00/10] eventdev: remove single-event enqueue and dequeue

2024-10-15 Thread Mattias Rönnblom
Remove the single-event enqueue and dequeue functions from the eventdev "ops" struct, to reduce complexity, leaving performance unaffected. This ABI change has been announced as a DPDK deprication notice, originally scheduled for DPDK 23.11. Mattias Rönnblom (10): event/dsw: remove single event

[RFC v2 04/10] event/octeontx: remove single event enqueue and dequeue

2024-10-15 Thread Mattias Rönnblom
Signed-off-by: Mattias Rönnblom --- drivers/event/octeontx/ssovf_evdev.h | 1 - drivers/event/octeontx/ssovf_worker.c | 40 +++ 2 files changed, 4 insertions(+), 37 deletions(-) diff --git a/drivers/event/octeontx/ssovf_evdev.h b/drivers/event/octeontx/ssovf_evdev.h in

[RFC v2 10/10] eventdev: remove single event enqueue and dequeue

2024-10-15 Thread Mattias Rönnblom
Remove the single event enqueue and dequeue, since they did not provide any noticable performance benefits. This is a change of the ABI, previously announced as a deprecation notice. These functions were not directly called by the application, so the API remains unaffected. Signed-off-by: Mattias

[RFC v2 02/10] event/dlb2: remove single event enqueue and dequeue

2024-10-15 Thread Mattias Rönnblom
Signed-off-by: Mattias Rönnblom -- RFCv2: * Remove unused function. (Stephen Hemminger) --- drivers/event/dlb2/dlb2.c | 40 ++- 1 file changed, 2 insertions(+), 38 deletions(-) diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c index 09e4107

[RFC v2 01/10] event/dsw: remove single event enqueue and dequeue

2024-10-15 Thread Mattias Rönnblom
Signed-off-by: Mattias Rönnblom --- drivers/event/dsw/dsw_evdev.c | 2 -- drivers/event/dsw/dsw_evdev.h | 2 -- drivers/event/dsw/dsw_event.c | 12 3 files changed, 16 deletions(-) diff --git a/drivers/event/dsw/dsw_evdev.c b/drivers/event/dsw/dsw_evdev.c index 1df3121b21..e819412

[RFC v2 07/10] event/dpaa2: remove single event enqueue and dequeue

2024-10-15 Thread Mattias Rönnblom
Signed-off-by: Mattias Rönnblom -- RFC v2: * Remove unused functions. --- drivers/event/dpaa2/dpaa2_eventdev.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c index f0b2c7de99..6c8ed3ff6b 100644 --

[RFC v2 06/10] event/dpaa: remove single event enqueue and dequeue

2024-10-15 Thread Mattias Rönnblom
Signed-off-by: Mattias Rönnblom --- drivers/event/dpaa/dpaa_eventdev.c | 27 ++- 1 file changed, 2 insertions(+), 25 deletions(-) diff --git a/drivers/event/dpaa/dpaa_eventdev.c b/drivers/event/dpaa/dpaa_eventdev.c index 85ccb586ef..853cc1ecf9 100644 --- a/drivers/event/

[RFC v2 08/10] event/opdl: remove single event enqueue and dequeue

2024-10-15 Thread Mattias Rönnblom
Signed-off-by: Mattias Rönnblom --- drivers/event/opdl/opdl_evdev.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/event/opdl/opdl_evdev.c b/drivers/event/opdl/opdl_evdev.c index 25853166bf..ffa65ef930 100644 --- a/drivers/event/opdl/opdl_evdev.c +++ b/drivers/event/opdl/opdl_evdev.

[RFC v2 03/10] event/cnxk: remove single event enqueue and dequeue

2024-10-15 Thread Mattias Rönnblom
Signed-off-by: Mattias Rönnblom --- drivers/event/cnxk/cn10k_eventdev.c | 2 -- drivers/event/cnxk/cn10k_worker.c | 49 + drivers/event/cnxk/cn10k_worker.h | 9 -- drivers/event/cnxk/cn9k_eventdev.c | 1 - drivers/event/cnxk/cn9k_worker.c| 26 +-

[RFC v2 05/10] event/sw: remove single event enqueue and dequeue

2024-10-15 Thread Mattias Rönnblom
Signed-off-by: Mattias Rönnblom --- drivers/event/sw/sw_evdev.c| 2 -- drivers/event/sw/sw_evdev.h| 2 -- drivers/event/sw/sw_evdev_worker.c | 12 3 files changed, 16 deletions(-) diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c index 7913bc54

[RFC v2 09/10] event/skeleton: remove single event enqueue and dequeue

2024-10-15 Thread Mattias Rönnblom
Signed-off-by: Mattias Rönnblom -- RFC v2: * Remove unused functions. --- drivers/event/skeleton/skeleton_eventdev.c | 29 -- 1 file changed, 29 deletions(-) diff --git a/drivers/event/skeleton/skeleton_eventdev.c b/drivers/event/skeleton/skeleton_eventdev.c index 848b3be

Re: [RFC 00/10] eventdev: remove single-event enqueue and dequeue

2024-10-15 Thread Mattias Rönnblom
On 2024-10-15 19:07, Stephen Hemminger wrote: On Tue, 15 Oct 2024 10:49:33 +0200 Mattias Rönnblom wrote: Remove the single-event enqueue and dequeue functions from the eventdev "ops" struct, to reduce complexity, leaving performance unaffected. This ABI change has been announced as a DPDK dep

Re: [PATCH v13 1/7] eal: add static per-lcore memory allocation facility

2024-10-15 Thread Mattias Rönnblom
On 2024-10-15 12:13, Morten Brørup wrote: +void * +rte_lcore_var_alloc(size_t size, size_t align) +{ + /* Having the per-lcore buffer size aligned on cache lines +* assures as well as having the base pointer aligned on cache +* size assures that aligned offsets also translat

[PATCH v5 2/2] dts: checksum offload test suite

2024-10-15 Thread Dean Marx
test suite for verifying layer 3/4 checksum offload features on poll mode driver. Signed-off-by: Dean Marx --- dts/framework/config/conf_yaml_schema.json | 3 +- dts/tests/TestSuite_checksum_offload.py| 274 + 2 files changed, 276 insertions(+), 1 deletion(-) create mo

[PATCH v5 0/2] dts: port over checksum offload suite

2024-10-15 Thread Dean Marx
Port over checksum hardware offload testing suite from old DTS. The suite verifies the ability of the PMD to recognize whether an incoming packet has valid or invalid L4/IP checksum values. - v1: * In the original test plan, there were two Tx checksum test cases. I removed them due to the

[PATCH v5 1/2] dts: add csum HW offload to testpmd shell

2024-10-15 Thread Dean Marx
Add csum_set_hw method to testpmd shell class. Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 58 +++ 1 file changed, 58 insertions(+) diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework/remote_session/testpmd_shell.py index

[RFC 07/10] event/dpaa2: remove single event enqueue and dequeue

2024-10-15 Thread Mattias Rönnblom
Signed-off-by: Mattias Rönnblom --- drivers/event/dpaa2/dpaa2_eventdev.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c index f0b2c7de99..5ea179c988 100644 --- a/drivers/event/dpaa2/dpaa2_eventdev.c +++ b/drivers/e

[RFC 00/10] eventdev: remove single-event enqueue and dequeue

2024-10-15 Thread Mattias Rönnblom
Remove the single-event enqueue and dequeue functions from the eventdev "ops" struct, to reduce complexity, leaving performance unaffected. This ABI change has been announced as a DPDK deprication notice, originally scheduled for DPDK 23.11. Mattias Rönnblom (10): event/dsw: remove single event

[RFC 06/10] event/dpaa: remove single event enqueue and dequeue

2024-10-15 Thread Mattias Rönnblom
Signed-off-by: Mattias Rönnblom --- drivers/event/dpaa/dpaa_eventdev.c | 27 ++- 1 file changed, 2 insertions(+), 25 deletions(-) diff --git a/drivers/event/dpaa/dpaa_eventdev.c b/drivers/event/dpaa/dpaa_eventdev.c index 85ccb586ef..853cc1ecf9 100644 --- a/drivers/event/

[RFC 04/10] event/octeontx: remove single event enqueue and dequeue

2024-10-15 Thread Mattias Rönnblom
Signed-off-by: Mattias Rönnblom --- drivers/event/octeontx/ssovf_evdev.h | 1 - drivers/event/octeontx/ssovf_worker.c | 40 +++ 2 files changed, 4 insertions(+), 37 deletions(-) diff --git a/drivers/event/octeontx/ssovf_evdev.h b/drivers/event/octeontx/ssovf_evdev.h in

[RFC 08/10] event/opdl: remove single event enqueue and dequeue

2024-10-15 Thread Mattias Rönnblom
Signed-off-by: Mattias Rönnblom --- drivers/event/opdl/opdl_evdev.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/event/opdl/opdl_evdev.c b/drivers/event/opdl/opdl_evdev.c index 25853166bf..ffa65ef930 100644 --- a/drivers/event/opdl/opdl_evdev.c +++ b/drivers/event/opdl/opdl_evdev.

[RFC 01/10] event/dsw: remove single event enqueue and dequeue

2024-10-15 Thread Mattias Rönnblom
Signed-off-by: Mattias Rönnblom --- drivers/event/dsw/dsw_evdev.c | 2 -- drivers/event/dsw/dsw_evdev.h | 2 -- drivers/event/dsw/dsw_event.c | 12 3 files changed, 16 deletions(-) diff --git a/drivers/event/dsw/dsw_evdev.c b/drivers/event/dsw/dsw_evdev.c index 1df3121b21..e819412

[RFC 05/10] event/sw: remove single event enqueue and dequeue

2024-10-15 Thread Mattias Rönnblom
Signed-off-by: Mattias Rönnblom --- drivers/event/sw/sw_evdev.c| 2 -- drivers/event/sw/sw_evdev.h| 2 -- drivers/event/sw/sw_evdev_worker.c | 12 3 files changed, 16 deletions(-) diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c index 7913bc54

[RFC 10/10] eventdev: remove single event enqueue and dequeue

2024-10-15 Thread Mattias Rönnblom
Remove the single event enqueue and dequeue, since they did not provide any noticable performance benefits. This is a change of the ABI, previously announced as a deprecation notice. These functions were not directly called by the application, so the API remains unaffected. Signed-off-by: Mattias

[RFC 03/10] event/cnxk: remove single event enqueue and dequeue

2024-10-15 Thread Mattias Rönnblom
Signed-off-by: Mattias Rönnblom --- drivers/event/cnxk/cn10k_eventdev.c | 2 -- drivers/event/cnxk/cn10k_worker.c | 49 + drivers/event/cnxk/cn10k_worker.h | 9 -- drivers/event/cnxk/cn9k_eventdev.c | 1 - drivers/event/cnxk/cn9k_worker.c| 26 +-

[RFC 02/10] event/dlb2: remove single event enqueue and dequeue

2024-10-15 Thread Mattias Rönnblom
Signed-off-by: Mattias Rönnblom --- drivers/event/dlb2/dlb2.c | 33 ++--- 1 file changed, 2 insertions(+), 31 deletions(-) diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c index 09e4107824..e4400b1bc2 100644 --- a/drivers/event/dlb2/dlb2.c +++ b/driv

[RFC 09/10] event/skeleton: remove single event enqueue and dequeue

2024-10-15 Thread Mattias Rönnblom
Signed-off-by: Mattias Rönnblom --- drivers/event/skeleton/skeleton_eventdev.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/event/skeleton/skeleton_eventdev.c b/drivers/event/skeleton/skeleton_eventdev.c index 848b3be82c..5da8229871 100644 --- a/drivers/event/skeleton/skeleton_

RE: [PATCH v14 1/4] lib: add generic support for reading PMU events

2024-10-15 Thread Tomasz Duszynski
>> Add support for programming PMU counters and reading their values in >> runtime bypassing kernel completely. >> >> This is especially useful in cases where CPU cores are isolated i.e >> run dedicated tasks. In such cases one cannot use standard perf >> utility without sacrificing latency and per

Re: [PATCH v11 1/7] eal: add static per-lcore memory allocation facility

2024-10-15 Thread Mattias Rönnblom
On 2024-10-15 09:39, Morten Brørup wrote: From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] Sent: Tuesday, 15 October 2024 09.11 On 2024-10-15 08:41, Mattias Rönnblom wrote: On 2024-10-14 10:17, Morten Brørup wrote: Please remove the _VALUE suffix. You changed your mind? I'm missing t

Re: [PATCH dpdk v3 2/2] ethdev: fix potential race in telemetry endpoints

2024-10-15 Thread David Marchand
On Mon, Oct 14, 2024 at 9:33 PM Robin Jarry wrote: > > While invoking telemetry commands (which may happen at any time, out of > control of the application), an application thread may concurrently > add/remove ports. The telemetry callbacks may then access partially > initialized/uninitialised eth

[PATCH v7] examples/ptpclient: add frequency adjustment

2024-10-15 Thread Mingjin Ye
This patch adds PI servo controller to support frequency adjustment API for IEEE1588 PTP. For example, the command for starting ptpclient with PI controller is: dpdk-ptpclient -a :81:00.0 -c 1 -n 3 -- -T 0 -p 0x1 -c 1 Signed-off-by: Simei Su Signed-off-by: Wenjun Wu Signed-off-by: Mingjin Y

RE: [EXTERNAL] Re: [PATCH v14 4/4] eal: add PMU support to tracing library

2024-10-15 Thread Tomasz Duszynski
>-Original Message- >From: David Marchand >Sent: Friday, October 11, 2024 3:29 PM >To: Tomasz Duszynski >Cc: Jerin Jacob ; Sunil Kumar Kori ; >Tyler Retzlaff >; ruifeng.w...@arm.com; >bruce.richard...@intel.com; dev@dpdk.org; >konstantin.v.anan...@yandex.ru; mattias.ronnb...@ericsson

[PATCH] net/dpaa/fmlib: remove new line char from the logs

2024-10-15 Thread Hemant Agrawal
This patch remove the new line char from several logs in the fmlib base driver. Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/fmlib/fm_ext.h | 21 +++-- drivers/net/dpaa/fmlib/fm_lib.c | 76 - drivers/net/dpaa/fmlib/fm_vsp.c | 20 - 3 files change

[PATCH 1/3] bitops: fix build for GCC without experimental API

2024-10-15 Thread David Marchand
Building OVS against current DPDK fails with following warnings: In file included from .../ovs/dpdk-dir/include/rte_memory.h:18, from .../ovs/dpdk-dir/include/rte_ring_core.h:29, from .../ovs/dpdk-dir/include/rte_ring.h:37, from .../ovs/dpdk-dir/i

[PATCH 0/3] Enhance headers check

2024-10-15 Thread David Marchand
We currently check that exported headers are fine with -DALLOW_EXPERIMENTAL_API and -DALLOW_INTERNAL_API. Such a check won't catch issues like the one fixed in patch 1, where OVS compilation is broken by the additional of experimental API in a header commonly included in other parts of DPDK. Idea

Re: [PATCH v10 0/2] power: introduce PM QoS interface

2024-10-15 Thread lihuisong (C)
在 2024/10/14 23:27, Stephen Hemminger 写道: On Thu, 12 Sep 2024 10:38:10 +0800 Huisong Li wrote: The deeper the idle state, the lower the power consumption, but the longer the resume time. Some service are delay sensitive and very except the low resume time, like interrupt packet receiving mod

Re: [PATCH dpdk v3 2/2] ethdev: fix potential race in telemetry endpoints

2024-10-15 Thread David Marchand
On Mon, Oct 14, 2024 at 10:01 PM Stephen Hemminger wrote: > > On Mon, 14 Oct 2024 21:32:37 +0200 > Robin Jarry wrote: > > > While invoking telemetry commands (which may happen at any time, out of > > control of the application), an application thread may concurrently > > add/remove ports. The tel

Re: [PATCH 1/5] build: increase minimum meson version to 0.57

2024-10-15 Thread Robin Jarry
Bruce Richardson, Sep 20, 2024 at 14:57: In order to work around some deprecated functions in meson, we need to increase meson version. Increasing to 0.57 to also gain support for other useful features for us in DPDK. Changes of interest to DPDK include: * Use get_external_property instead of ge

Re: [PATCH 5/5] build: replace deprecated meson function

2024-10-15 Thread Robin Jarry
Bruce Richardson, Sep 20, 2024 at 14:57: The meson function "get_cross_property" is deprecated in meson 0.58 and should be replaced by "get_external_property". Signed-off-by: Bruce Richardson --- Reviewed-by: Robin Jarry

Re: [PATCH 2/5] build: remove version check on compiler links function

2024-10-15 Thread Robin Jarry
Bruce Richardson, Sep 20, 2024 at 14:57: The "compiler.links()" function meson documentation [1] is a little unclear, in a casual reading implies that the function was new in 0.60 meson release. In fact, it is only enhanced as described in that release, but is present earlier. As such, we can rem

Re: [PATCH 4/5] build: use version file support from meson

2024-10-15 Thread Robin Jarry
Bruce Richardson, Sep 20, 2024 at 14:57: Rather than having to use run_command to shell out and read the VERSION file for the DPDK version, we can use the support added directly to meson in version 0.57. Signed-off-by: Bruce Richardson --- Reviewed-by: Robin Jarry

Re: [PATCH 3/5] build: remove unnecessary version checks

2024-10-15 Thread Robin Jarry
Bruce Richardson, Sep 20, 2024 at 14:57: Since minimum meson version is now 0.57 we can remove all version checks for versions lower than that. Signed-off-by: Bruce Richardson --- Reviewed-by: Robin Jarry

Re: [PATCH v10 1/2] power: introduce PM QoS API on CPU wide

2024-10-15 Thread lihuisong (C)
Hi Stephen, Can you take a look at this reply so as to send out the next version ASAP? Thanks.😁 /Huisong 在 2024/10/14 20:19, lihuisong (C) 写道: Hi Stephen, 在 2024/10/13 9:10, Stephen Hemminger 写道: On Thu, 12 Sep 2024 10:38:11 +0800 Huisong Li wrote: + +PM QoS +-- + +The deeper the idle

  1   2   >