[v6 00/15] NXP DMA driver fixes and Enhancements

2024-10-14 Thread Gagandeep Singh
V6 changes: * fix array bound compilation warning with GCC 11.4 V5 changes: * typos and doc compilation fixed V4 changes: * rebased series to latest commit and patches reduced. V3 changes: * fix 32 bit compilation issue V2 changes: * fix compilation issue on ubuntu 22.04 Hemant Agrawal (1):

[v6 01/15] dma/dpaa2: configure route by port by PCIe port param

2024-10-14 Thread Gagandeep Singh
From: Jun Yang struct { uint64_t coreid : 4; /**--rbp.sportid / rbp.dportid*/ uint64_t pfid : 8; /**--rbp.spfid / rbp.dpfid*/ uint64_t vfen : 1; /**--rbp.svfa / rbp.dvfa*/ uint64_t vfid : 16; /**--rbp.svfid / rbp.dvfid*/ . } pcie; Signed-off-by: Jun Ya

[v6 04/15] dma/dpaa2: add short FD support

2024-10-14 Thread Gagandeep Singh
From: Jun Yang Short FD can be used for single transfer scenario which shows higher performance than FLE. 1) Save index context in FD att field for short and FLE(NonSG). 2) Identify FD type by att of FD. 3) Force 48 bits address for source address and fle according to spec. Signed-off-by: Jun Ya

[v6 03/15] bus/fslmc: enhance the qbman dq storage logic

2024-10-14 Thread Gagandeep Singh
From: Jun Yang Multiple DQ storages are used among multiple cores, the single dq storage of first union is leak if multiple storages are allocated. It does not make sense to keep the single dq storage of union, remove it and reuse the first dq storage of multiple storages for this case. Signed-o

[v6 05/15] dma/dpaa2: limit the max descriptor number

2024-10-14 Thread Gagandeep Singh
From: Jun Yang For non-SG format, the index is saved in FD with DPAA2_QDMA_FD_ATT_TYPE_OFFSET(13) bits width. The max descriptor number of ring is power of 2, so the eventual max number is: ((1 << DPAA2_QDMA_FD_ATT_TYPE_OFFSET) / 2) Signed-off-by: Jun Yang --- drivers/dma/dpaa2/dpaa2_qdma.h |

[v6 14/15] dma/dpaa: add DMA error checks

2024-10-14 Thread Gagandeep Singh
From: Jun Yang add user configurable DMA error checks. Signed-off-by: Jun Yang Signed-off-by: Gagandeep Singh --- doc/guides/dmadevs/dpaa.rst | 6 ++ drivers/dma/dpaa/dpaa_qdma.c | 135 ++- drivers/dma/dpaa/dpaa_qdma.h | 42 ++ drivers/net/d

[v6 15/15] bus/dpaa: add port bmi stats

2024-10-14 Thread Gagandeep Singh
From: Hemant Agrawal Add BMI statistics and fixing the existing extended statistics Signed-off-by: Hemant Agrawal Signed-off-by: Gagandeep Singh --- drivers/bus/dpaa/base/fman/fman_hw.c | 65 +++- drivers/bus/dpaa/include/fman.h | 4 +- drivers/bus/dpaa/include/f

[v6 11/15] dma/dpaa: add workaround for ERR050757

2024-10-14 Thread Gagandeep Singh
From: Jun Yang ERR050757 on LS104x indicates: For outbound PCIe read transactions, a completion buffer is used to store the PCIe completions till the data is passed back to the initiator. At most 16 outstanding transactions are allowed and maximum read request is 256 bytes. The completion buffer

[v6 13/15] dma/dpaa: add Scatter Gather support

2024-10-14 Thread Gagandeep Singh
From: Jun Yang Support copy_sg operation for scatter gather. Signed-off-by: Jun Yang Signed-off-by: Gagandeep Singh --- drivers/dma/dpaa/dpaa_qdma.c | 55 drivers/dma/dpaa/dpaa_qdma.h | 10 ++- 2 files changed, 64 insertions(+), 1 deletion(-) diff --g

[v6 12/15] dma/dpaa: qdma stall workaround for ERR050265

2024-10-14 Thread Gagandeep Singh
From: Jun Yang Non-prefetchable read setting in the source descriptor may be required for targets other than local memory. Prefetchable read setting will offer better performance for misaligned transfers in the form of fewer transactions and should be set if possible. This patch also fixes QDMA s

[v6 02/15] dma/dpaa2: refactor driver code

2024-10-14 Thread Gagandeep Singh
From: Jun Yang refactor the driver code with changes in: - multiple HW queues - SMA single copy and SG copy - silent mode Signed-off-by: Jun Yang --- doc/guides/dmadevs/dpaa2.rst |8 + drivers/dma/dpaa2/dpaa2_qdma.c | 2200 drivers/dma/dpaa2/dpaa2

[v6 08/15] dma/dpaa: refactor driver

2024-10-14 Thread Gagandeep Singh
From: Jun Yang This patch refactor the DPAA DMA driver code with changes: - HW descriptors rename and update with details. - update qdma engine and queue structures - using rte_ring APIs for enqueue and dequeue. Signed-off-by: Jun Yang Signed-off-by: Gagandeep Singh --- drivers/dma/dpaa/dp

[v6 10/15] dma/dpaa: add silent mode support

2024-10-14 Thread Gagandeep Singh
From: Jun Yang add silent mode support. Signed-off-by: Jun Yang Signed-off-by: Gagandeep Singh --- drivers/dma/dpaa/dpaa_qdma.c | 46 drivers/dma/dpaa/dpaa_qdma.h | 1 + 2 files changed, 42 insertions(+), 5 deletions(-) diff --git a/drivers/dma/dpaa/dpaa

[v6 07/15] dma/dpaa2: move the qdma header to common place

2024-10-14 Thread Gagandeep Singh
From: Jun Yang Include rte_pmd_dpaax_qdma.h instead of rte_pmd_dpaa2_qdma.h and change code accordingly. Signed-off-by: Jun Yang --- doc/api/doxy-api-index.md | 2 +- doc/api/doxy-api.conf.in | 2 +- drivers/common/dpaax/meson.build | 3 +- drivers/

[v6 09/15] dma/dpaa: support burst capacity API

2024-10-14 Thread Gagandeep Singh
From: Jun Yang This patch improves the dpaa qdma driver and adds dpaa_qdma_burst_capacity API which returns the remaining space in the descriptor ring. Signed-off-by: Jun Yang Signed-off-by: Gagandeep Singh --- drivers/dma/dpaa/dpaa_qdma.c | 10 ++ 1 file changed, 10 insertions(+) di

[v6 06/15] dma/dpaa2: change the DMA copy return value

2024-10-14 Thread Gagandeep Singh
From: Jun Yang The return value of DMA copy/sg copy should be index of descriptor copied in success. Signed-off-by: Jun Yang --- drivers/dma/dpaa2/dpaa2_qdma.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/dma/dpaa2/dpaa2_qdma.c b/drivers/dma/dpaa2

Re: [PATCH v3 02/12] baseband/acc: fix soft output bypass RM

2024-10-14 Thread Maxime Coquelin
On 10/9/24 23:12, Hernan Vargas wrote: Removing soft output bypass RM capability due to VRB2 device limitations. Fixes: b49fe052f9cd ("baseband/acc: add FEC capabilities for VRB2 variant") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas --- drivers/baseband/acc/rte_vrb_pmd.c | 7 +++

Re: [PATCH v3 03/12] baseband/acc: queue allocation refactor

2024-10-14 Thread Maxime Coquelin
On 10/9/24 23:12, Hernan Vargas wrote: Refactor to manage queue memory per operation more flexibly for VRB devices. Signed-off-by: Hernan Vargas --- drivers/baseband/acc/acc_common.h | 5 + drivers/baseband/acc/rte_vrb_pmd.c | 214 - 2 files changed, 157 in

RE: [PATCH v10 2/2] examples/l3fwd-power: add PM QoS configuration

2024-10-14 Thread Konstantin Ananyev
> > Add PM QoS configuration to declease the delay after sleep in case of > > entering deeper idle state. > > > > Signed-off-by: Huisong Li > > Acked-by: Morten Brørup > > --- > > examples/l3fwd-power/main.c | 24 > > 1 file changed, 24 insertions(+) > > > > diff --git

[PATCH v11 1/7] eal: add static per-lcore memory allocation facility

2024-10-14 Thread Mattias Rönnblom
Introduce DPDK per-lcore id variables, or lcore variables for short. An lcore variable has one value for every current and future lcore id-equipped thread. The primary use case is for statically allocating small, frequently-accessed data structures, for which one instance should exist for each l

[PATCH v11 2/7] eal: add lcore variable functional tests

2024-10-14 Thread Mattias Rönnblom
Add functional test suite to exercise the API. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Chengwen Feng Acked-by: Stephen Hemminger -- PATCH v6: * Update FOREACH invocations to match new API. RFC v5: * Adapt tests to reflect the removal of the GET() and SET() macro

[PATCH v11 7/7] eal: keep per-lcore power intrinsics state in lcore variable

2024-10-14 Thread Mattias Rönnblom
Keep per-lcore power intrinsics state in a lcore variable to reduce cache working set size and avoid any CPU next-line-prefetching causing false sharing. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Konstantin Ananyev Acked-by: Chengwen Feng Acked-by: Stephen Hemminger --

[PATCH v11 6/7] service: keep per-lcore state in lcore variable

2024-10-14 Thread Mattias Rönnblom
Replace static array of cache-aligned structs with an lcore variable, to slightly benefit code simplicity and performance. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Konstantin Ananyev Acked-by: Chengwen Feng Acked-by: Stephen Hemminger -- PATCH v7: * Update to match

[PATCH v11 3/7] eal: add lcore variable performance test

2024-10-14 Thread Mattias Rönnblom
Add basic micro benchmark for lcore variables, in an attempt to assure that the overhead isn't significantly greater than alternative approaches, in scenarios where the benefits aren't expected to show up (i.e., when plenty of cache is available compared to the working set size of the per-lcore dat

[PATCH v11 4/7] random: keep PRNG state in lcore variable

2024-10-14 Thread Mattias Rönnblom
Replace keeping PRNG state in a RTE_MAX_LCORE-sized static array of cache-aligned and RTE_CACHE_GUARDed struct instances with keeping the same state in a more cache-friendly lcore variable. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Konstantin Ananyev Acked-by: Chengwen F

[PATCH v11 5/7] power: keep per-lcore state in lcore variable

2024-10-14 Thread Mattias Rönnblom
Replace static array of cache-aligned structs with an lcore variable, to slightly benefit code simplicity and performance. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Konstantin Ananyev Acked-by: Chengwen Feng Acked-by: Stephen Hemminger -- PATCH v6: * Update FOREACH

[PATCH v11 0/7] Lcore variables

2024-10-14 Thread Mattias Rönnblom
This patch set introduces a new API for static per-lcore id data allocation. Please refer to the API documentation for both a rationale for this new API, and a comparison to the alternatives available. The adoption of this API would affect many different DPDK modules, but the author updated onl

RE: [PATCH v2 1/6] eal: add static per-lcore memory allocation facility

2024-10-14 Thread Morten Brørup
> From: Jerin Jacob [mailto:jerinjac...@gmail.com] > Sent: Wednesday, 18 September 2024 12.12 > > On Thu, Sep 12, 2024 at 8:52 PM Jerin Jacob > wrote: > > > > On Thu, Sep 12, 2024 at 7:11 PM Morten Brørup > wrote: > > > > > > > From: Jerin Jacob [mailto:jerinjac...@gmail.com] > > > > Sent: Thurs

Re: [dpdk-dev] [PATCH 1/2] mk: fix build for clang 4

2024-10-14 Thread Bruce Richardson
On Fri, Oct 11, 2024 at 08:20:12PM +0200, Morten Brørup wrote: > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Friday, 11 October 2024 19.48 > > > > On Fri, 11 Oct 2024 19:36:08 +0200 > > Morten Brørup wrote: > > > > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf

Re: [PATCH] Revert "build: disable gcc 10 zero-length-bounds warning"

2024-10-14 Thread Kevin Traynor
On 11/10/2024 18:57, Stephen Hemminger wrote: > The zero length array warning can be re-enabled. > The zero length marker fields are now removed by > commit 9e152e674c77 ("mbuf: remove marker fields") > in DPDK 24.03. > > This reverts commit cfacbcb5a23bc26cb913528c372adddabbb33ca1. > > Signed-of

RE: [PATCH v10 2/2] examples/l3fwd-power: add PM QoS configuration

2024-10-14 Thread Konstantin Ananyev
> Add PM QoS configuration to declease the delay after sleep in case of > entering deeper idle state. > > Signed-off-by: Huisong Li > Acked-by: Morten Brørup > --- > examples/l3fwd-power/main.c | 24 > 1 file changed, 24 insertions(+) > > diff --git a/examples/l3fwd-

Re:[PATCH] raw/gdtc: introduce gdtc raw device driver

2024-10-14 Thread Yong Zhang
Hi ALL, To avoid confusion with net/zxdh, raw/zxdh is renamed to raw/gdtc. Thanks

RE: [PATCH v10 1/2] power: introduce PM QoS API on CPU wide

2024-10-14 Thread Konstantin Ananyev
> The deeper the idle state, the lower the power consumption, but the longer > the resume time. Some service are delay sensitive and very except the low > resume time, like interrupt packet receiving mode. > > And the "/sys/devices/system/cpu/cpuX/power/pm_qos_resume_latency_us" sysfs > interface

RE: [PATCH] raw/gdtc: introduce gdtc raw device driver

2024-10-14 Thread Morten Brørup
Dear Yong Zhang, Please refrain from sending patches to the DPDK Technical Board (techbo...@dpdk.org ). If there is a conflict or issue with patch, which cannot be resolved on the DPDK Developer mailing list (dev@dpdk.org ), the topic can

Re: [PATCH v3 00/12] acc baseband PMD fix and updates for 24.11

2024-10-14 Thread Maxime Coquelin
On 10/9/24 23:12, Hernan Vargas wrote: This series targets 24.11. v3: Updated code with community recommendations. Added 2 commits for rte_free refactor and clean up of VRB1 capabilities. v2: Rebased to the latest next-baseband-for-main which includes needed rte_bbdev lib updates. v1: It inc

Re: [PATCH] vhost: promote max queue setting API to stable

2024-10-14 Thread Maxime Coquelin
On 10/9/24 15:00, Maxime Coquelin wrote: This patch promotes the rte_vhost_driver_set_max_queue_num API to stable. Signed-off-by: Maxime Coquelin --- lib/vhost/rte_vhost.h | 4 lib/vhost/version.map | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) Applied to next-virtio/fo

[PATCH v5 2/3] graph: add node error counters

2024-10-14 Thread pbhagavatula
From: Pavan Nikhilesh Add node fastpath error counters advertised during node registration. Add support for retrieving/printing stats for node specific errors using rte_graph_cluster_stats_get(). Add `rte_node_error_increment` API to increment node specific error counters. Signed-off-by: Pavan N

[PATCH v5 0/3] Introduce node-specific errors in graph library

2024-10-14 Thread pbhagavatula
From: Pavan Nikhilesh Introduce the ability for nodes to advertise error counters during registration and increment them during the node process function in the graph library. This enhancement allows for better error tracking and debugging capabilities within the graph framework. The number of

[PATCH v5 3/3] node: add error stats for ip4 nodes

2024-10-14 Thread pbhagavatula
From: Pavan Nikhilesh Add error counters for ip4 LPM lookup failures in ip4_lookup node. Add reassembly failure error counter for ip4 reassembly node. Signed-off-by: Pavan Nikhilesh Acked-by: Kiran Kumar K --- lib/node/ip4_lookup.c | 9 + lib/node/ip4_lookup_neon.h | 5 + lib

[v3 04/43] net/dpaa2: add support to dump dpdmux counters

2024-10-14 Thread vanshika . shukla
From: Hemant Agrawal This patch add supports to dump dpdmux counters as they are required to identify the reasons for packet drop in dpdmux. Signed-off-by: Hemant Agrawal Signed-off-by: Rohit Raj --- drivers/net/dpaa2/dpaa2_mux.c | 84 +++ drivers/net/dpaa2/rte

[v3 05/43] bus/fslmc: change dpcon close as internal symbol

2024-10-14 Thread vanshika . shukla
From: Hemant Agrawal This patch marks dpcon_close API as internal symbol and also adds it into version map file Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/mc/fsl_dpcon.h | 3 ++- drivers/bus/fslmc/version.map| 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/driv

[v3 06/43] bus/fslmc: add close API to close DPAA2 device

2024-10-14 Thread vanshika . shukla
From: Rohit Raj Add rte_fslmc_close API to close all the DPAA2 devices while closing the DPDK application. Signed-off-by: Rohit Raj --- drivers/bus/fslmc/bus_fslmc_driver.h | 3 + drivers/bus/fslmc/fslmc_bus.c| 13 drivers/bus/fslmc/fslmc_vfio.c | 87 +++

[v3 01/43] net/dpaa2: enhance Tx scatter-gather mempool

2024-10-14 Thread vanshika . shukla
From: Jun Yang Create TX SG pool only for primary process and lookup this pool in secondary process. Signed-off-by: Jun Yang --- drivers/net/dpaa2/dpaa2_ethdev.c | 46 +++- 1 file changed, 33 insertions(+), 13 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_ethde

[v3 07/43] net/dpaa2: dpdmux: add support for CVLAN

2024-10-14 Thread vanshika . shukla
From: Vanshika Shukla This patch adds the support for DPDMUX_METHOD_C_VLAN_MAC method which implements DPDMUX based on C-VLAN and MAC address. Signed-off-by: Vanshika Shukla --- drivers/net/dpaa2/dpaa2_mux.c | 59 +-- drivers/net/dpaa2/mc/fsl_dpdmux.h | 18 +

[v3 02/43] net/dpaa2: support PTP packet one-step timestamp

2024-10-14 Thread vanshika . shukla
From: Vanshika Shukla This patch adds PTP one-step timestamping support. dpni_set_single_step_cfg() MC API is utilized with offset provided to insert correction time on frame. Signed-off-by: Vanshika Shukla --- drivers/net/dpaa2/dpaa2_ethdev.c | 61 +++ drivers/net

[v3 03/43] net/dpaa2: add proper MTU debugging print

2024-10-14 Thread vanshika . shukla
From: Apeksha Gupta This patch add proper debug info for check information of max-pkt-len and configured params. also store MTU Signed-off-by: Apeksha Gupta Signed-off-by: Jun Yang --- drivers/net/dpaa2/dpaa2_ethdev.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/d

[v3 00/43] DPAA2 specific patches

2024-10-14 Thread vanshika . shukla
From: Vanshika Shukla This series includes: -> Fixes and enhancements for NXP DPAA2 drivers. -> Upgrade with MC version 10.37 -> Enhancements in DPDMUX code -> Fixes for coverity issues reported V2 changes: Fixed the broken compilation for clang in: "net/dpaa2: dpdmux single flow/multipl

[v3 08/43] bus/fslmc: upgrade with MC version 10.37

2024-10-14 Thread vanshika . shukla
From: Gagandeep Singh This patch upgrades the MC version compaitbility to 10.37 Signed-off-by: Gagandeep Singh Signed-off-by: Apeksha Gupta --- doc/guides/platform/dpaa2.rst | 4 +- drivers/bus/fslmc/mc/dpio.c | 94 - drivers/bus/fslmc/mc/fsl_dpcon.h

[v3 10/43] net/dpaa2: update DPNI link status method

2024-10-14 Thread vanshika . shukla
From: Brick Yang If SFP module is not connected to the port and flow control is configured using flow control API, link will show DOWN even after connecting the SFP module and fiber cable. This issue cannot be reproduced if only SFP module is connected and fiber cable is disconnected before conf

[v3 14/43] bus/fslmc: enhance MC VFIO multiprocess support

2024-10-14 Thread vanshika . shukla
From: Jun Yang MC VFIO is not registered into RTE VFIO. Primary process registers MC vfio mp action for secondary process to request. VFIO/Container handlers are provided via CMSG. Primary process is responsible to connect MC VFIO group to container. In addition, MC VFIO code is refactored accor

[v3 13/43] bus/fslmc: get MC VFIO group FD directly

2024-10-14 Thread vanshika . shukla
From: Jun Yang Get vfio group fd directly from file system instead of from RTE API to avoid conflicting with PCIe VFIO. FSL MC VFIO should have it's own logic which doe NOT depend on RTE VFIO. Signed-off-by: Jun Yang --- drivers/bus/fslmc/fslmc_vfio.c | 88 ++ d

[v3 09/43] net/dpaa2: support link state for eth interfaces

2024-10-14 Thread vanshika . shukla
From: Rohit Raj This patch add support to update the duplex value along with link status and link speed after setting the link UP. Signed-off-by: Rohit Raj --- drivers/net/dpaa2/dpaa2_ethdev.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/net/dpaa

[v3 12/43] bus/fslmc: improve BMAN buffer acquire

2024-10-14 Thread vanshika . shukla
From: Jun Yang Ignore reserved bits of BMan acquire response number. Signed-off-by: Jun Yang --- drivers/bus/fslmc/qbman/qbman_portal.c | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/drivers/bus/fslmc/qbman/qbman_portal.c b/drivers/bus/fslmc/q

[v3 11/43] net/dpaa2: add new PMD API to check dpaa platform version

2024-10-14 Thread vanshika . shukla
From: Jun Yang This patch add support to check the DPAA platform type from the applications. Signed-off-by: Jun Yang --- drivers/net/dpaa2/dpaa2_ethdev.c | 16 +--- drivers/net/dpaa2/dpaa2_flow.c| 5 ++--- drivers/net/dpaa2/rte_pmd_dpaa2.h | 4 drivers/net/dpaa2/version

[v3 16/43] bus/fslmc: dynamic IOVA mode configuration

2024-10-14 Thread vanshika . shukla
From: Jun Yang IOVA mode should not be configured with CFLAGS because 1) User can perform "--iova-mode" to configure IOVA. 2) IOVA mode is determined by negotiation between multiple devices. Eal is in VA mode only when all devices support VA mode. Hence: 1) Remove RTE_LIBRTE_DPAA2_USE_PHYS_IO

[v3 20/43] bus/fslmc: fix invalid error FD code

2024-10-14 Thread vanshika . shukla
From: Rohit Raj Since error code was being set to 0 in case of error which is a valid fd, it caused memory leak issue. This issue have been fixed by changing zero to a valid non fd error. CID: 26661848 Signed-off-by: Rohit Raj --- drivers/bus/fslmc/fslmc_vfio.c | 19 ++- 1 file

[v3 18/43] bus/fslmc: create dpaa2 device with it's object

2024-10-14 Thread vanshika . shukla
From: Jun Yang Create dpaa2 device with object instead of object ID. Assign each dpaa2 object with it's container. Signed-off-by: Jun Yang --- drivers/bus/fslmc/bus_fslmc_driver.h | 39 drivers/bus/fslmc/fslmc_vfio.c | 3 +- drivers/bus/fslmc/portal/dpaa

[v3 15/43] bus/fslmc: free VFIO group FD in case of add group failure

2024-10-14 Thread vanshika . shukla
From: Rohit Raj Free vfio_group_fd if add group fails to avoid ersource leak NXP coverity-id: 26661846 Signed-off-by: Rohit Raj --- drivers/bus/fslmc/fslmc_vfio.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/bus/fslmc/fslmc_vfio.c b/drivers/bus/fslmc/fslmc_v

[v3 19/43] bus/fslmc: fix coverity issue

2024-10-14 Thread vanshika . shukla
From: Rohit Raj Fix Issues reported by coverity (NXP Internal Coverity) Signed-off-by: Rohit Raj --- drivers/bus/fslmc/qbman/qbman_debug.c | 49 +-- 1 file changed, 32 insertions(+), 17 deletions(-) diff --git a/drivers/bus/fslmc/qbman/qbman_debug.c b/drivers/bus/fslm

[v3 17/43] bus/fslmc: remove VFIO IRQ mapping

2024-10-14 Thread vanshika . shukla
From: Jun Yang Remove unused GITS translator VFIO mapping. Signed-off-by: Jun Yang --- drivers/bus/fslmc/fslmc_vfio.c | 50 -- 1 file changed, 50 deletions(-) diff --git a/drivers/bus/fslmc/fslmc_vfio.c b/drivers/bus/fslmc/fslmc_vfio.c index 4437028470..99f2bca

[v3 21/43] bus/fslmc: change qbman eq desc from d to desc

2024-10-14 Thread vanshika . shukla
From: Rohit Raj Change qbman_eq_desc name to avoid redefining same variable. Signed-off-by: Rohit Raj --- drivers/bus/fslmc/qbman/qbman_portal.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/bus/fslmc/qbman/qbman_portal.c b/drivers/bus/fslmc/qbman/qbman_porta

[v3 27/43] net/dpaa2: frame attribute flags parser

2024-10-14 Thread vanshika . shukla
From: Jun Yang FAF parser extracts are used to identify protocol type instead of extracts of previous protocol' type. FAF starts from offset 2 to include user defined flags which will be used for soft protocol distribution. Signed-off-by: Jun Yang --- drivers/net/dpaa2/dpaa2_flow.c | 475 +

[v3 29/43] net/dpaa2: protocol inside tunnel distribution

2024-10-14 Thread vanshika . shukla
From: Jun Yang Control flow by protocols inside tunnel. The tunnel flow items applied by application are in order from outer to inner. The inner items start from tunnel item, something like vxlan, GRE etc. For example: flow create 0 ingress pattern ipv4 / vxlan / ipv6 / end actions pf /

[v3 25/43] net/dpaa2: dump Rx parser result

2024-10-14 Thread vanshika . shukla
From: Jun Yang export DPAA2_PRINT_RX_PARSER_RESULT=1 is used to dump RX parser result and frame attribute flags generated by hardware parser and soft parser. The parser results are converted to big endian described in RM. The areas set by soft parser are dump as well. Signed-off-by: Jun Yang --

[v3 26/43] net/dpaa2: enhancement of raw flow extract

2024-10-14 Thread vanshika . shukla
From: Jun Yang Support combination of RAW extract and header extracts. RAW extract can start from any absolute offset. TBD: relative offset support. To support relative offset of previous L3 protocol item, extracts should be expanded to identify if the frame is: vlan or none-vlan. To support re

[v3 28/43] net/dpaa2: add VXLAN distribution support

2024-10-14 Thread vanshika . shukla
From: Jun Yang Extracts from vxlan header for distribution. The vxlan header is set by soft parser code in soft parser context located from offset 43 of parser results: vxlan protocol is identified by vxlan bit of frame attribute flags. The parser result extracts are added for this functionali

[v3 30/43] net/dpaa2: eCPRI support by parser result

2024-10-14 Thread vanshika . shukla
From: Jun Yang Soft parser extracts ECPRI header and message to specified areas of parser result. Flow is classified according to the ECPRI extracts from praser result. This implementation supports ECPRI over ethernet/vlan/UDP and various types/messages combinations. Signed-off-by: Jun Yang ---

[v3 23/43] net/dpaa2: change miss flow ID macro name

2024-10-14 Thread vanshika . shukla
From: Rohit Raj Remove miss flow id macro name to DPNI_FS_MISS_DROP since its conflicting with enum. Also, set default miss flow id to 0. Signed-off-by: Rohit Raj --- drivers/net/dpaa2/dpaa2_flow.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2

[v3 22/43] bus/fslmc: introduce VFIO DMA mapping API for fslmc

2024-10-14 Thread vanshika . shukla
From: Jun Yang Declare rte_fslmc_vfio_mem_dmamap and rte_fslmc_vfio_mem_dmaunmap in bus_fslmc_driver.h for external usage. Signed-off-by: Jun Yang --- drivers/bus/fslmc/bus_fslmc_driver.h | 7 ++- drivers/bus/fslmc/fslmc_bus.c| 2 +- drivers/bus/fslmc/fslmc_vfio.c

[v3 41/43] net/dpaa2: support VLAN traffic splitting

2024-10-14 Thread vanshika . shukla
From: Vanshika Shukla This patch adds support for adding rules in DPDMUX to split VLAN traffic based on VLAN ids. Signed-off-by: Vanshika Shukla --- drivers/net/dpaa2/dpaa2_mux.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/net/dpaa2/dpaa2_mux.c b/drivers/n

[v3 37/43] net/dpaa2: check IOVA before sending MC command

2024-10-14 Thread vanshika . shukla
From: Jun Yang Convert VA to IOVA and check IOVA before sending parameter to MC. Invalid IOVA of parameter sent to MC will cause system stuck and not be recovered unless power reset. IOVA is not checked in data path because: 1) MC is not involved and error can be recovered. 2) IOVA check impacts

[v3 34/43] net/dpaa2: add flow support for IPsec AH and ESP

2024-10-14 Thread vanshika . shukla
From: Jun Yang Support AH/ESP flow with SPI field. Signed-off-by: Jun Yang --- drivers/net/dpaa2/dpaa2_flow.c | 528 - 1 file changed, 385 insertions(+), 143 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_flow.c b/drivers/net/dpaa2/dpaa2_flow.c index 7207547

[v3 32/43] net/dpaa2: check if Soft parser is loaded

2024-10-14 Thread vanshika . shukla
From: Jun Yang Access sp instruction area to check if sp is loaded. Signed-off-by: Jun Yang Signed-off-by: Vanshika Shukla --- drivers/net/dpaa2/dpaa2_ethdev.c | 4 ++ drivers/net/dpaa2/dpaa2_ethdev.h | 2 + drivers/net/dpaa2/dpaa2_flow.c | 88 3 files cha

[v3 33/43] net/dpaa2: soft parser flow verification

2024-10-14 Thread vanshika . shukla
From: Jun Yang Add flow supported by soft parser to verification list. Signed-off-by: Jun Yang --- drivers/net/dpaa2/dpaa2_flow.c | 84 +- 1 file changed, 51 insertions(+), 33 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_flow.c b/drivers/net/dpaa2/dpaa2_fl

[v3 31/43] net/dpaa2: add GTP flow support

2024-10-14 Thread vanshika . shukla
From: Jun Yang Configure gtp flow to support RSS and FS. Check FAF of parser result to identify GTP frame. Signed-off-by: Jun Yang --- drivers/net/dpaa2/dpaa2_flow.c | 170 ++--- 1 file changed, 137 insertions(+), 33 deletions(-) diff --git a/drivers/net/dpaa2/dpaa

[v3 35/43] net/dpaa2: fix memory corruption in TM

2024-10-14 Thread vanshika . shukla
From: Gagandeep Singh driver was reserving memory in an array for 8 queues only, but it can support many more queues configuration. This patch fixes the memory corruption issue by defining the queue array with correct size. Fixes: 72100f0dee21 ("net/dpaa2: support level 2 in traffic management"

[v3 36/43] net/dpaa2: support software taildrop

2024-10-14 Thread vanshika . shukla
From: Gagandeep Singh Add software based taildrop support. Signed-off-by: Gagandeep Singh --- drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 2 +- drivers/net/dpaa2/dpaa2_rxtx.c | 24 +++- 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/drivers/bus/fslm

[v3 39/43] net/dpaa2: store drop priority in mbuf

2024-10-14 Thread vanshika . shukla
From: Apeksha Gupta store drop priority in mbuf from fd. Signed-off-by: Sachin Saxena Signed-off-by: Apeksha Gupta --- drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 1 + drivers/net/dpaa2/dpaa2_rxtx.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/bus/fslmc/portal/dpaa2_hw

[v3 38/43] net/dpaa2: improve DPDMUX error behavior settings

2024-10-14 Thread vanshika . shukla
From: Sachin Saxena compatible with MC v10.36 or later Signed-off-by: Sachin Saxena --- drivers/net/dpaa2/dpaa2_mux.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_mux.c b/drivers/net/dpaa2/dpaa2_mux.c index f4b8d481af..13de7d5783 10064

[v3 43/43] net/dpaa2: dpdmux single flow/multiple rules support

2024-10-14 Thread vanshika . shukla
From: Jun Yang Support multiple extractions as well as hardware descriptions instead of hard code. Signed-off-by: Jun Yang --- drivers/net/dpaa2/dpaa2_ethdev.h | 1 + drivers/net/dpaa2/dpaa2_flow.c | 22 -- drivers/net/dpaa2/dpaa2_mux.c| 395 --- dr

[v3 42/43] net/dpaa2: add support for C-VLAN and MAC

2024-10-14 Thread vanshika . shukla
From: Vanshika Shukla This patch adds the support for DPDMUX_METHOD_C_VLAN_MAC method which implements DPDMUX based on C-VLAN and MAC address. Signed-off-by: Vanshika Shukla --- drivers/net/dpaa2/dpaa2_mux.c | 2 +- drivers/net/dpaa2/mc/fsl_dpdmux.h | 16 2 files changed,

[v3 40/43] net/dpaa2: add API to get endpoint name

2024-10-14 Thread vanshika . shukla
From: Jun Yang Export API in rte_pmd_dpaa2.h Signed-off-by: Jun Yang --- drivers/net/dpaa2/dpaa2_ethdev.c | 24 drivers/net/dpaa2/dpaa2_ethdev.h | 4 drivers/net/dpaa2/rte_pmd_dpaa2.h | 3 +++ drivers/net/dpaa2/version.map | 1 + 4 files changed, 32 inser

Re: [PATCH v10 1/2] power: introduce PM QoS API on CPU wide

2024-10-14 Thread lihuisong (C)
Hi Stephen, 在 2024/10/13 9:10, Stephen Hemminger 写道: On Thu, 12 Sep 2024 10:38:11 +0800 Huisong Li wrote: + +PM QoS +-- + +The deeper the idle state, the lower the power consumption, but the longer +the resume time. Some service are delay sensitive and very except the low +resume time, l

[DPDK/core Bug 1558] 10 second timeout is too short to pass tests on RISC-V devices.

2024-10-14 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1558 Kevin Traynor (ktray...@redhat.com) changed: What|Removed |Added CC||ktray...@redhat.com

Re: [PATCH v2] doc: announce single-event enqueue/dequeue ABI change

2024-10-14 Thread David Marchand
On Mon, Oct 14, 2024 at 9:19 AM Jerin Jacob wrote: > On Sun, Oct 13, 2024 at 12:27 PM Mattias Rönnblom > wrote: > > > > On 2024-10-11 16:42, David Marchand wrote: > > > On Wed, Jul 5, 2023 at 1:18 PM Mattias Rönnblom > > > wrote: > > >> > > >> Announce the removal of the single-event enqueue an

[PATCH v6 0/3] Introduce node-specific xstats in graph library

2024-10-14 Thread pbhagavatula
From: Pavan Nikhilesh Introduce the ability for nodes to advertise xstats counters during registration and increment them during the node process function in the graph library. This enhancement allows for better stats tracking and debugging capabilities within the graph framework. The number of

Re: [PATCH v11 7/7] eal: keep per-lcore power intrinsics state in lcore variable

2024-10-14 Thread Stephen Hemminger
On Mon, 14 Oct 2024 09:43:48 +0200 Mattias Rönnblom wrote: > Keep per-lcore power intrinsics state in a lcore variable to reduce > cache working set size and avoid any CPU next-line-prefetching causing > false sharing. > > Signed-off-by: Mattias Rönnblom > Acked-by: Morten Brørup > Acked-by: K

Re: [RFC PATCH] build: automatically report minimum meson version

2024-10-14 Thread Patrick Robb
It seems like a good addition that meson.build and /.ci/linux-setup.sh are automatically in sync now. That's one less thing that someone has to "just remember" when increasing the meson minimum version. I will flag on the other thread (increasing the meson version) when UNH's scripts are updated t

Re: [PATCH] ip_frag: support IPv6 reassembly with extensions

2024-10-14 Thread Vignesh Purushotham Srinivas
-Original Message- From: Konstantin Ananyev To: vignesh.purushotham.srini...@ericsson.com , konstantin.v.anan...@yandex.ru Cc: dev@dpdk.org Subject: RE: [PATCH] ip_frag: support IPv6 reassembly with extensions Date: Tue, 17 Sep 2024 18:07:25 + > > +/* > > + * Function to crawl throu

[PATCH v6 1/3] graph: add support for node specific xstats

2024-10-14 Thread pbhagavatula
From: Pavan Nikhilesh Add ability for Nodes to advertise xstat counters during registration and increment them in fastpath. Add support for retrieving/printing stats for node specific xstats using rte_graph_cluster_stats_get(). Add `rte_node_xstat_increment` API to increment node specific xstat c

[PATCH v6 3/3] node: add xstats for ip4 nodes

2024-10-14 Thread pbhagavatula
From: Pavan Nikhilesh Add xstat counters for ip4 LPM lookup failures in ip4_lookup node. Add reassembly failure xstat counter for ip4 reassembly node. Signed-off-by: Pavan Nikhilesh Acked-by: Kiran Kumar K --- lib/node/ip4_lookup.c | 9 + lib/node/ip4_lookup_neon.h | 5 + lib

Re: [EXTERNAL] Re: [PATCH v4 4/5] node: add error stats for ip4 lookup node

2024-10-14 Thread Jerin Jacob
On Fri, Oct 11, 2024 at 10:51 PM Pavan Nikhilesh Bhagavatula wrote: > > > > > -Original Message- > > From: Robin Jarry > > Sent: Friday, October 11, 2024 3:19 PM > > To: Pavan Nikhilesh Bhagavatula ; Jerin Jacob > > ; Nithin Kumar Dabilpuram > > ; Kiran Kumar Kokkilagadda > > ; zhirun

Re: [PATCH v2] doc: announce single-event enqueue/dequeue ABI change

2024-10-14 Thread Jerin Jacob
On Sun, Oct 13, 2024 at 12:27 PM Mattias Rönnblom wrote: > > On 2024-10-11 16:42, David Marchand wrote: > > On Wed, Jul 5, 2023 at 1:18 PM Mattias Rönnblom > > wrote: > >> > >> Announce the removal of the single-event enqueue and dequeue > >> operations from the eventdev ABI. > >> > >> Signed-off

[PATCH v5] fib: network byte order IPv4 lookup

2024-10-14 Thread Vladimir Medvedkin
Previously when running rte_fib_lookup IPv4 addresses must have been in host byte order. This patch adds a new flag RTE_FIB_FLAG_LOOKUP_BE that can be passed on fib create, which will allow to have IPv4 in network byte order on lookup. Signed-off-by: Vladimir Medvedkin --- app/test/test_fib.c

[DPDK/ethdev Bug 1561] BNX2X: Jumbo frames not working on NetXtreme II BCM57810

2024-10-14 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1561 Kevin Traynor (ktray...@redhat.com) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC

RE: [EXTERNAL] Re: [PATCH v5 0/3] Introduce node-specific errors in graph library

2024-10-14 Thread Pavan Nikhilesh Bhagavatula
> Hi Pavan, > > I am resending my review here. It seems you didn't get it. > > , Oct 14, 2024 at 13:58: > > From: Pavan Nikhilesh > > > > > > Introduce the ability for nodes to advertise error counters during > > registration and increment them during the node process function in > > the graph l

Re: [PATCH] test/bitops: check worker lcore availability

2024-10-14 Thread David Marchand
On Sun, Oct 13, 2024 at 8:53 AM Mattias Rönnblom wrote: > > On 2024-10-11 17:25, David Marchand wrote: > > Coverity is not able to understand that having 2 lcores means that > > rte_get_next_lcore(-1, 0, 1) can't return RTE_MAX_LCORE. > > Add an assert. > > > > Coverity issue: 445382, 445383, 4453

Re: [PATCH] bitops: fix issue in parallel atomic tests

2024-10-14 Thread Mattias Rönnblom
On 2024-10-14 16:16, David Marchand wrote: On Sun, Oct 13, 2024 at 5:37 PM Morten Brørup wrote: I'm far from sure it's a compiler bug. Just look at the base rate: how often does the code you just wrote fail because of a bug in your code, and how often is the root cause to be found in the compi

[PATCH v5 1/5] graph: add feature arc support

2024-10-14 Thread Nitin Saxena
add feature arc to allow dynamic steering of packets across graph nodes based on protocol features enabled on incoming or outgoing interface Signed-off-by: Nitin Saxena --- doc/guides/rel_notes/release_24_11.rst | 10 + lib/graph/graph_feature_arc.c| 1236 ++

[PATCH v5 4/5] test/graph_feature_arc: add functional tests

2024-10-14 Thread Nitin Saxena
Added functional unit test case for verifying feature arc control plane and fast path APIs How to run: $ echo "graph_feature_arc_autotest" | ./bin/dpdk-test Signed-off-by: Nitin Saxena --- app/test/meson.build |1 + app/test/test_graph_feature_arc.c | 1410 +

<    1   2   3   >