[v3 1/2] app/proc-info: add memory heap dump

2024-10-10 Thread Gagandeep Singh
This patch add the malloc heap dump support in proc-info memory dump option. Signed-off-by: Gagandeep Singh Acked-by: Hemant Agrawal --- app/proc-info/main.c | 5 + 1 file changed, 5 insertions(+) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index b672aaefbe..9e26b5cf3b 100644

RE: [EXTERNAL] Re: [PATCH v13 4/4] eal: add PMU support to tracing library

2024-10-10 Thread Tomasz Duszynski
>On Wed, 9 Oct 2024 14:50:02 +0200 >Morten Brørup wrote: > >> > From: Tomasz Duszynski [mailto:tduszyn...@marvell.com] >> > Sent: Wednesday, 9 October 2024 13.23 >> > >> > +PMU tracepoint >> > +-- >> > + >> > +Performance monitoring unit (PMU) event values can be read from >> > hardwar

Re: [PATCH v7 00/16] Fix allocation bugs and prevent future ones

2024-10-10 Thread David Marchand
On Tue, Oct 8, 2024 at 6:50 PM Stephen Hemminger wrote: > > On Fri, 4 Oct 2024 16:57:16 +0200 > David Marchand wrote: > > > > > > > It seems v7 lost the last patch that was introducing and using the > > > annotations in rte_malloc. > > > Was there an issue with this patch, or is it just a series

Re: [PATCH v12 1/7] buildtools/chkincs: relax C linkage requirement

2024-10-10 Thread Mattias Rönnblom
On 2024-10-06 17:58, Robin Jarry wrote: Mattias Rönnblom, Oct 06, 2024 at 16:17: I think you need to change run_command() to custom_target(). I was thinking of this patch to be much simpler as follows: I started off with a shell script, but I switched to Python when I wanted to strip off comm

Re: [PATCH v6 7/7] vhost: optimize memcpy routines when cc memcpy is used

2024-10-10 Thread Mattias Rönnblom
On 2024-10-09 23:25, Morten Brørup wrote: +#if defined(RTE_USE_CC_MEMCPY) && defined(RTE_ARCH_X86_64) +static __rte_always_inline void +pktcpy(void *restrict in_dst, const void *restrict in_src, size_t len) +{ A comment describing why batch_copy_elem.dst and src point to 16 byte aligned data w

Re: [PATCH v4 2/3] net/ice: add frequency adjustment support for PTP

2024-10-10 Thread Bruce Richardson
On Thu, Oct 10, 2024 at 09:32:20AM +, Mingjin Ye wrote: > Add ice support for new ethdev API to adjust frequency for IEEE1588 > PTP. Also, this patch reworks code for converting software update > to hardware update. > > Signed-off-by: Simei Su > Signed-off-by: Mingjin Ye > --- Hi Simei, Min

Re: [PATCH v6 7/7] vhost: optimize memcpy routines when cc memcpy is used

2024-10-10 Thread Mattias Rönnblom
On 2024-10-09 23:57, Stephen Hemminger wrote: On Fri, 20 Sep 2024 12:27:16 +0200 Mattias Rönnblom wrote: +#if defined(RTE_USE_CC_MEMCPY) && defined(RTE_ARCH_X86_64) +static __rte_always_inline void +pktcpy(void *restrict in_dst, const void *restrict in_src, size_t len) +{ + void *dst = _

[PATCH v4 2/3] net/ice: add frequency adjustment support for PTP

2024-10-10 Thread Mingjin Ye
Add ice support for new ethdev API to adjust frequency for IEEE1588 PTP. Also, this patch reworks code for converting software update to hardware update. Signed-off-by: Simei Su Signed-off-by: Mingjin Ye --- doc/guides/nics/ice.rst | 15 +++ drivers/net/ice/ice_ethdev.c | 177

[PATCH v4 1/3] ethdev: add frequency adjustment API

2024-10-10 Thread Mingjin Ye
This patch adds freq adjustment API for PTP high accuracy. Signed-off-by: Simei Su Signed-off-by: Mingjin Ye --- v2: rte_eth_timesync_adjust_freq marked as experimental --- v3: Add more description for API. --- doc/guides/nics/features.rst | 4 ++- doc/guides/rel_notes/release_24_11.

[PATCH v4 3/3] examples/ptpclient: add frequency adjustment

2024-10-10 Thread Mingjin Ye
This patch adds PI servo controller to support frequency adjustment API for IEEE1588 PTP. For example, the command for starting ptpclient with PI controller is: dpdk-ptpclient -a :81:00.0 -c 1 -n 3 -- -T 0 -p 0x1 -c 1 Signed-off-by: Simei Su Signed-off-by: Wenjun Wu Signed-off-by: Mingjin Y

[PATCH v4 0/3] add frequency adjustment support for PTP

2024-10-10 Thread Mingjin Ye
[1/3] ethdev: add frequency adjustment API [2/3] net/ice: add frequency adjustment support for PTP [3/3] examples/ptpclient: add frequency adjustment --- v2: rte_eth_timesync_adjust_freq marked as experimental. --- v3: Add more description for API. --- v4: Documentation for adding a ptpclient. Min

[PATCH] eal/windows: define standard file numbers

2024-10-10 Thread Bruce Richardson
The macros for STD*_FILENO are missing on windows. Add defines for them to the DPDK-local unistd.h file. Signed-off-by: Bruce Richardson --- lib/eal/windows/include/unistd.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/lib/eal/windows/include/unistd.h b/lib/eal/windows/includ

Re: [PATCH] eal: fix device unregister for event registered with device_name NULL

2024-10-10 Thread David Marchand
On Thu, Jul 18, 2024 at 9:37 PM wrote: > > From: Malcolm Bumgardner > > In the device event unregister code, it unconditionally remove all > callbacks which are registered with device_name set to NULL. This results > in many callbacks uncorrectly removed. > > Fix this by only removing callbacks w

Re: [PATCH v12 1/7] buildtools/chkincs: relax C linkage requirement

2024-10-10 Thread Bruce Richardson
On Thu, Oct 10, 2024 at 12:24:25PM +0200, Mattias Rönnblom wrote: > On 2024-10-06 17:58, Robin Jarry wrote: > > Mattias Rönnblom, Oct 06, 2024 at 16:17: > > > > I think you need to change run_command() to custom_target(). I > > > > was thinking of this patch to be much simpler as follows: > > > >

Re: [PATCH v7 1/7] eal: add static per-lcore memory allocation facility

2024-10-10 Thread Mattias Rönnblom
On 2024-10-10 00:15, Morten Brørup wrote: From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] Sent: Wednesday, 18 September 2024 10.26 Introduce DPDK per-lcore id variables, or lcore variables for short. An lcore variable has one value for every current and future lcore id-equipped th

Re: [PATCH] eal: increase max file descriptor for secondary process device

2024-10-10 Thread David Marchand
On Thu, Sep 5, 2024 at 6:22 PM Stephen Hemminger wrote: > > The TAP and XDP driver both are limited to only 8 queues when > because of the small limit imposed by EAL. Increase the limit > now since this release allows changing ABI. > > Signed-off-by: Stephen Hemminger Applied, thanks. -- Davi

Re: [PATCH v12 6/7] eal: add unit tests for atomic bit access functions

2024-10-10 Thread David Marchand
On Fri, Sep 20, 2024 at 12:57 PM Mattias Rönnblom wrote: > + static int \ > + run_parallel_test_and_modify ## size(void *arg) \ > + { \ > + str

Re: [PATCH] eal/windows: define standard file numbers

2024-10-10 Thread Dmitry Kozlyuk
2024-10-10 10:54 (UTC+0100), Bruce Richardson: > The macros for STD*_FILENO are missing on windows. Add defines for them > to the DPDK-local unistd.h file. > > Signed-off-by: Bruce Richardson > --- > lib/eal/windows/include/unistd.h | 11 +++ > 1 file changed, 11 insertions(+) > > diff

[PATCH v3] fib: network byte order IPv4 lookup

2024-10-10 Thread Vladimir Medvedkin
Previously when running rte_fib_lookup IPv4 addresses must have been in host byte order. This patch adds a new flag RTE_FIB_FLAG_LOOKUP_BE that can be passed on fib create, which will allow to have IPv4 in network byte order on lookup. Signed-off-by: Vladimir Medvedkin --- app/test/test_fib.c

Re: [PATCH v2] fib: network byte order IPv4 lookup

2024-10-10 Thread Medvedkin, Vladimir
Hi David, On 09/10/2024 11:56, David Marchand wrote: On Wed, Oct 9, 2024 at 11:51 AM David Marchand wrote: Hi Vladimir, On Tue, Oct 8, 2024 at 7:16 PM Vladimir Medvedkin wrote: diff --git a/lib/fib/dir24_8_avx512.c b/lib/fib/dir24_8_avx512.c index 43dba28cfb..edd802abe4 100644 --- a/lib/fib

Re: [PATCH v2 1/2] fib: implement RCU rule reclamation

2024-10-10 Thread Medvedkin, Vladimir
Hi Stephen, Thanks for the review, I'll address your comments in v3 On 08/10/2024 19:28, Stephen Hemminger wrote: On Tue, 8 Oct 2024 17:55:23 + Vladimir Medvedkin wrote: + if ((tbl8_idx == -ENOSPC) && dp->dq != NULL) { Better to either drop the parenthesis here, or put it on both

[PATCH v3 1/2] fib: implement RCU rule reclamation

2024-10-10 Thread Vladimir Medvedkin
Currently, for DIR24-8 algorithm, the tbl8 group is freed even though the readers might be using the tbl8 group entries. The freed tbl8 group can be reallocated quickly. As a result, lookup may be performed incorrectly. To address that, RCU QSBR is integrated for safe tbl8 group reclamation. Sign

[PATCH v3 2/2] test/fib: add RCU functional tests

2024-10-10 Thread Vladimir Medvedkin
Add positive and negative tests for API rte_fib_rcu_qsbr_add. Also test FIB library behavior when RCU QSBR is enabled. Signed-off-by: Vladimir Medvedkin --- app/test/test_fib.c | 209 1 file changed, 209 insertions(+) diff --git a/app/test/test_fib.c

[PATCH v3 00/50] Provide: flow filter init API, Enable virtual queues, fix ntnic issues for release 24.07

2024-10-10 Thread Serhii Iliushyk
The list of updates provided by the patchset: * Update the supported version of the FPGA to 9563.55.49 * Fix Coverity issues * Fix issues related to release 24.07 * Extended and fixed the implementation of the logging * Added NT flow filter init API * Added NT flow backend initializatio

[PATCH v3 02/50] net/ntnic: fix coverity issues:

2024-10-10 Thread Serhii Iliushyk
From: Danylo Vodopianov CI founc couple coverity problems which were fixed in this commit. CID 440550, 440551, 440545, 440553, 440552, 440547: Null pointer dereferences (REVERSE_INULL) These issues were fixed by reworking variable NULL checking and adding NULL checking before var using. CID 44

[PATCH v3 01/50] net/ntnic: update NT NiC PMD driver with FPGA version

2024-10-10 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets Update base FPGA files to the new version(39->49) Fix code style problems Update documentation Signed-off-by: Oleksandr Kolomeiets --- v2 * Update release notes --- doc/guides/rel_notes/release_24_11.rst| 3 ++ drivers/net/ntnic/meson.build

[PATCH v3 04/50] net/ntnic: remove extra calling of the API for release port

2024-10-10 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets During rte_eth_dev_close execution, eth_dev_close function exported by ntnic is called, followed by a call to rte_eth_dev_release_port. Since there is no possible returns between the calls, calling rte_eth_dev_release_port from eth_dev_close is redundant and error-pron

[PATCH v3 25/50] net/ntnic: add Tx Packet Editor (TPE) flow module

2024-10-10 Thread Serhii Iliushyk
The TX Packet Editor is a software abstraction module, that keeps track of the handful of FPGA modules that are used to edit packets in the TX pipeline. Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/include/hw_mod_backend.h| 27 ++ drivers/net/ntnic/include/hw_mod_tpe_v3.h | 126

[PATCH v3 21/50] net/ntnic: add copier (Tx CPY) flow module

2024-10-10 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The TX Copy module writes data to packet fields based on the lookup performed by the FLM module. This is used for NAT and can support other actions based on the RTE action MODIFY_FIELD. Signed-off-by: Oleksandr Kolomeiets --- v3 * Remove newline characters from logs.

[PATCH v3 29/50] net/ntnic: add key match (KM) FPGA module

2024-10-10 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Key Matcher module checks the values of individual fields of a packet. It supports both exact match which is implemented with a CAM, and wildcards which is implemented with a TCAM. Signed-off-by: Oleksandr Kolomeiets --- v3 * Remove newline characters from logs. *

[PATCH v3 31/50] net/ntnic: add hasher (HSH) FPGA module

2024-10-10 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Hasher module calculates a configurable hash value to be used internally by the FPGA. The module support both Toeplitz and NT-hash. Signed-off-by: Oleksandr Kolomeiets --- v3 * Remove newline characters from logs. * Modify macros according to new logging and fix b

[PATCH v3 26/50] net/ntnic: add base init and deinit of the NT flow API

2024-10-10 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets Add basic API for initialization resources required by flow filter API Signed-off-by: Oleksandr Kolomeiets --- v3 * Remove newline characters from logs. --- drivers/net/ntnic/include/flow_api.h | 82 ++ drivers/net/ntnic/include/flow_api_engine.h | 4

[PATCH v3 24/50] net/ntnic: add replacer (Tx RPL) flow module

2024-10-10 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The TX Replacer module can replace a range of bytes in a packet. The replacing data is stored in a table in the module and will often contain tunnel data. Signed-off-by: Oleksandr Kolomeiets --- v3 * Remove newline characters from logs. --- drivers/net/ntnic/meson.bu

[PATCH v3 23/50] net/ntnic: add insert (Tx INS) flow module

2024-10-10 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets he TX Inserter module injects zeros into an offset of a packet, effectively expanding the packet. Signed-off-by: Oleksandr Kolomeiets --- v3 * Remove newline characters from logs. --- drivers/net/ntnic/meson.build | 1 + .../nthw/flow_api/flow_backen

[PATCH v3 33/50] net/ntnic: add slicer (SLC LR) FPGA module

2024-10-10 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Slicer for Local Retransmit module can cut of the head a packet before the packet leaves the FPGA RX pipeline. This is used when the TX pipeline is configured to add a new head in the packet. Signed-off-by: Oleksandr Kolomeiets --- v3 * Remove newline characters f

Re: [PATCH v2] maintainers: update for dts

2024-10-10 Thread Thomas Monjalon
09/10/2024 19:50, Stephen Hemminger: > On Wed, 9 Oct 2024 12:19:32 -0400 > Patrick Robb wrote: > > > Paul and Patrick have been appointed as the new dts maintainers. > > Updating the MAINTAINERS file to reflect this. > > > > Signed-off-by: Patrick Robb > > Signed-off-by: Paul Szczepanek > >

Re: [PATCH 03/10] net/nfp: simplify some function parameters

2024-10-10 Thread Stephen Hemminger
On Thu, 10 Oct 2024 17:17:09 +0800 Chaoyong He wrote: > Refactor to the logic of initialize process to simplify some function > parameters, both for primary and secodary process. > > Signed-off-by: Chaoyong He > Reviewed-by: Long Wu > Reviewed-by: Peng Zhang Acked-by: Stephen Hemminger

Re: [PATCH 08/10] net/nfp: fix problem caused by FEC set

2024-10-10 Thread Stephen Hemminger
On Thu, 10 Oct 2024 17:17:14 +0800 Chaoyong He wrote: > The return value of 'nfp_eth_set_fec()' is three ways, the original > logic considered it as two ways wrongly. > > Fixes: 37bd1b843a20 ("net/nfp: support setting FEC mode") > Cc: zerun...@corigine.com > Cc: sta...@dpdk.org > > Signed-off-b

Re: [PATCH 05/10] net/nfp: fix problem caused by configure function

2024-10-10 Thread Stephen Hemminger
On Thu, 10 Oct 2024 17:17:11 +0800 Chaoyong He wrote: > The return value of 'nfp_eth_set_configured()' is three ways, the > original logic considered it as two ways wrongly. > > Fixes: 61d4008fe6bb ("net/nfp: support setting link up/down") > Cc: sta...@dpdk.org > > Signed-off-by: Chaoyong He >

Re: [PATCH 07/10] net/nfp: fix problem caused by commit end function

2024-10-10 Thread Stephen Hemminger
On Thu, 10 Oct 2024 17:17:13 +0800 Chaoyong He wrote: > The return value of 'nfp_eth_config_commit_end()' is three ways, the > original logic considered it as two ways wrongly. > > Fixes: 68aa35373a94 ("net/nfp: support setting pause frame switch mode") > Cc: zerun...@corigine.com > Cc: sta...@d

Re: [PATCH v9 1/7] eal: add static per-lcore memory allocation facility

2024-10-10 Thread Stephen Hemminger
On Thu, 10 Oct 2024 18:17:56 +0200 Mattias Rönnblom wrote: > On 2024-10-10 17:54, Stephen Hemminger wrote: > > On Thu, 10 Oct 2024 16:21:59 +0200 > > Mattias Rönnblom wrote: > > > >> Introduce DPDK per-lcore id variables, or lcore variables for short. > >> > >> An lcore variable has one value

Re: [PATCH v3 04/26] config: add separate defines for max Rx and Tx queues

2024-10-10 Thread Bruce Richardson
On Thu, Oct 10, 2024 at 09:27:27AM -0700, Stephen Hemminger wrote: > On Tue, 10 Sep 2024 10:54:37 +0800 > fengchengwen wrote: > > > On 2024/8/14 18:49, Bruce Richardson wrote: > > > Rather than having a single define for maximum queues per ethernet port, > > > we can set the max values for Rx que

[PATCH v2] hash: separate param checks in hash create func

2024-10-10 Thread Niall Meade
Separated name, entries and key_len parameter checks in rte_hash_create(). Also made the error messages more informative/verbose to help with debugging. Also added myself to the mailing list. Signed-off-by: Niall Meade --- v2: * change hash log messages to be one line I had name set to NULL in

RE: rte_ring move head question for machines with relaxed MO (arm/ppc)

2024-10-10 Thread Konstantin Ananyev
> > > > > 1. rte_ring_generic_pvt.h: > > > > > = > > > > > > > > > > pseudo-c-code //related > > > > > armv8 instructions > > > > > > > > > > --

Re: [PATCH] net/nfb: fix use after free

2024-10-10 Thread Thomas Monjalon
10/10/2024 19:17, David Marchand: > On Thu, Oct 10, 2024 at 7:16 PM Thomas Monjalon wrote: > > > > With the annotations added to the allocation functions, > > more issues are detected at compilation time: > > > > nfb_rx.c:133:28: error: pointer 'rxq' used after 'rte_free' > > > > It is fixed by mo

Re: [PATCH v3] dts: add VLAN methods to testpmd shell

2024-10-10 Thread Patrick Robb
Applied to next-dts, thanks!

Re: [PATCH v2] hash: separate param checks in hash create func

2024-10-10 Thread Stephen Hemminger
On Thu, 10 Oct 2024 16:46:02 + Niall Meade wrote: > diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c > index 577b5839d3..2569f7d977 100644 > --- a/lib/hash/rte_cuckoo_hash.c > +++ b/lib/hash/rte_cuckoo_hash.c > @@ -190,11 +190,17 @@ rte_hash_create(const struct rte_hash_pa

Re: [PATCH 1/2] net/bonding: standard the log message

2024-10-10 Thread Stephen Hemminger
On Mon, 24 Jun 2024 10:03:54 +0800 Chaoyong He wrote: > From: Long Wu > > According to the check rules in the patch check script, > drivers and libraries must use the logging framework. > > So standard the log message of bonding driver by using > the logging framework. > > Signed-off-by: Long

Re: [PATCH 2/2] net/bonding: add command to set dedicated queue size

2024-10-10 Thread Stephen Hemminger
On Mon, 24 Jun 2024 10:03:55 +0800 Chaoyong He wrote: > diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c > b/drivers/net/bonding/rte_eth_bond_8023ad.c > index 06c21ebe6d..c19645aa4f 100644 > --- a/drivers/net/bonding/rte_eth_bond_8023ad.c > +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c >

Re: [PATCH v1] net/ice: updated 24.07 recommended matching list

2024-10-10 Thread Stephen Hemminger
On Thu, 1 Aug 2024 16:18:41 +0800 hailinx wrote: > Signed-off-by: hailinx > --- > doc/guides/nics/ice.rst | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/doc/guides/nics/ice.rst b/doc/guides/nics/ice.rst > index ae975d19ad..59ed8e6808 100644 > --- a/doc/guides/nics/ice.rst > +++ b/

Re: [PATCH v1] net/i40e: updated 24.07 recommended matching list

2024-10-10 Thread Stephen Hemminger
On Thu, 1 Aug 2024 16:19:02 +0800 hailinx wrote: > Signed-off-by: hailinx > --- > doc/guides/nics/i40e.rst | 4 > 1 file changed, 4 insertions(+) > > diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst > index ca6caa0cff..d4c9790d47 100644 > --- a/doc/guides/nics/i40e.rst >

[PATCH v2] dts: fix verify argument in set forward mode

2024-10-10 Thread Dean Marx
Fix optional verify argument in set_forward_mode method in testpmd shell class. Bugzilla ID: 1410 Fixes: fc0f7dc47ee3 ("dts: add testpmd shell params") Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) d

Re: [PATCH v2] dts: fix verify argument in set forward mode

2024-10-10 Thread Patrick Robb
Reviewed-by: Patrick Robb

Re: [PATCH] net/nfb: fix use after free

2024-10-10 Thread David Marchand
On Thu, Oct 10, 2024 at 7:16 PM Thomas Monjalon wrote: > > With the annotations added to the allocation functions, > more issues are detected at compilation time: > > nfb_rx.c:133:28: error: pointer 'rxq' used after 'rte_free' > > It is fixed by moving the assignment before freeing the parent poin

Re: [PATCH v3] vfio: combine container_create and group_bind

2024-10-10 Thread Stephen Hemminger
On Wed, 3 Jul 2024 19:59:43 +0800 "BillXiang" wrote: > From: BillXiang > > For multi-devices in one group we can only create and bind to one > container. With this new function, device driver does not need to > save the binding info additionally between different devices. > > Signed-off-by: B

[PATCH v7 0/2] dts: mac filter port to new dts

2024-10-10 Thread Nicholas Pratte
v7: * adjusted commit messages to be more associative with the main branch Nicholas Pratte (2): dts: add methods for setting mac and multicast addresses dts: mac filter test suite refactored for new dts dts/framework/config/conf_yaml_schema.json| 3 +- dts/framework/remote_sessio

[PATCH v7 1/2] dts: add methods for setting mac and multicast addresses

2024-10-10 Thread Nicholas Pratte
New methods have been added to TestPMDShell in order to produce the mac filter's individual test cases: - set_mac_addr - set_multicast_mac_addr set_mac_addr and set_multicast_addr were created for the mac filter test suite, enabling users to both add or remove mac and multicast addresses based o

[PATCH v7 2/2] dts: mac filter test suite refactored for new dts

2024-10-10 Thread Nicholas Pratte
The mac address filter test suite, whose test cases are based on old DTS's test cases, has been refactored to interface with the new DTS framework. The test suite assesses the behavior of ethdev api calls as it relates to mac address filtering using TestPMD. Specific test cases have been designed

Re: [PATCH 1/1] buildtools: remove absolute paths from pc file

2024-10-10 Thread Bruce Richardson
On Wed, Oct 09, 2024 at 11:44:12AM -0700, Stephen Hemminger wrote: > On Sun, 7 Jan 2024 07:41:36 -0800 > Srikanth Yalavarthi wrote: > > > When linking with non-versioned libraries, absolute paths > > of the libraries are added to libdpdk.pc. This patch replaces > > the absolute path with correct

Re: [PATCH 4/5] net/ice: add option to download scheduler topology

2024-10-10 Thread Bruce Richardson
On Wed, Oct 09, 2024 at 10:49:00AM -0700, Stephen Hemminger wrote: > On Wed, 9 Oct 2024 18:08:21 +0100 > Bruce Richardson wrote: > > > diff --git a/drivers/net/ice/ice_ethdev.h b/drivers/net/ice/ice_ethdev.h > > index 2781362d04..76310f2c99 100644 > > --- a/drivers/net/ice/ice_ethdev.h > > +++ b

[PATCH v2 1/4] eal: add bitset type

2024-10-10 Thread David Marchand
From: Mattias Rönnblom Introduce a set of functions and macros that operate on sets of bits, kept in arrays of 64-bit words. RTE bitset is designed for bitsets which are larger than what fits in a single machine word (i.e., 64 bits). For very large bitsets, the API may be a more appropriate cho

[PATCH v2 3/4] service: use multi-word bitset to represent service flags

2024-10-10 Thread David Marchand
From: Mattias Rönnblom Use a multi-word bitset to track which services are mapped to which lcores, allowing the RTE_SERVICE_NUM_MAX compile-time constant to be > 64. Replace array-of-bytes service-currently-active flags with a more compact multi-word bitset-based representation, reducing memory

[PATCH v2 2/4] bitset: add atomic functions

2024-10-10 Thread David Marchand
From: Mattias Rönnblom Extend the bitset API with atomic versions of the most basic bitset operations. Signed-off-by: Mattias Rönnblom Acked-by: Tyler Retzlaff --- app/test/test_bitset.c | 44 +++ lib/eal/include/rte_bitset.h | 143 +++ 2 files c

[PATCH v2 4/4] event/dsw: add support for larger port count

2024-10-10 Thread David Marchand
From: Mattias Rönnblom Switch from using an open-coded, single-word bitset to using to represent which event ports are linked to a particular event queue. Besides the cleaner code, this also allow the user to extend the maximum port count beyond 64, by means of changing an "event_dev.h" Signed

[PATCH v2 0/4] Add bitset type

2024-10-10 Thread David Marchand
v1 did not go through the CI. Resending this series after rebasing and doing some coding style changes. -- David Marchand Mattias Rönnblom (4): eal: add bitset type bitset: add atomic functions service: use multi-word bitset to represent service flags event/dsw: add support for larger

Re: [PATCH v2] app/testpmd: show output of commands read from file

2024-10-10 Thread David Marchand
Hello Bruce, Ferruh, On Tue, Oct 8, 2024 at 3:33 AM Ferruh Yigit wrote: > > On 10/4/2024 5:56 AM, Ferruh Yigit wrote: > > On 8/22/2024 11:41 AM, Bruce Richardson wrote: > >> Testpmd supports the "--cmdline-file" parameter to read a set of initial > >> commands from a file. However, the only indic

[PATCH v3 28/50] net/ntnic: add categorizer (CAT) FPGA module

2024-10-10 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Categorizer module’s main purpose is to is select the behavior of other modules in the FPGA pipeline depending on a protocol check. Signed-off-by: Oleksandr Kolomeiets --- v3 * Remove newline characters from logs. * Modify macros accrdind to new logging and fix br

[PATCH v3 34/50] net/ntnic: add packet descriptor builder (PDB) FPGA module

2024-10-10 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Packet Description Builder module creates packet meta-data for example virtio-net headers. Signed-off-by: Oleksandr Kolomeiets --- v3 * Remove newline characters from logs. * Modify macros according to new logging and fix braces --- drivers/net/ntnic/include/hw_m

[PATCH v3 37/50] net/ntnic: add basic queue operations

2024-10-10 Thread Serhii Iliushyk
From: Danylo Vodopianov Adds support for queue configure, start, stop, release. The internal macro and functions of ntnic were also added and initialized. Signed-off-by: Danylo Vodopianov --- v3 * Remove newline characters from logs. --- doc/guides/nics/features/ntnic.ini | 1 + drivers/ne

[PATCH v3 32/50] net/ntnic: add queue select (QSL) FPGA module

2024-10-10 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Queue Selector module directs packets to a given destination which includes host queues, physical ports, exceptions paths, and discard. Signed-off-by: Oleksandr Kolomeiets --- v3 * Remove newline characters from logs. * Modify macros according to new logging and f

[PATCH v3 35/50] net/ntnic: add Tx Packet Editor (TPE) FPGA module

2024-10-10 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The TX Packet Editor is a software abstraction module, that keeps track of the handful of FPGA modules that are used to edit packets in the TX pipeline. Signed-off-by: Oleksandr Kolomeiets --- v3 * Remove newline characters from logs. * Modify macros according to new

[PATCH v3 30/50] net/ntnic: add flow matcher (FLM) FPGA module

2024-10-10 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Flow Matcher module is a high-performance stateful SDRAM lookup and programming engine which supported exact match lookup in line-rate of up to hundreds of millions of flows. Signed-off-by: Oleksandr Kolomeiets --- v3 * Remove newline characters from logs. * Modif

[PATCH v3 27/50] net/ntnic: add base init and deinit the NT flow backend

2024-10-10 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets Add basic implementation of the NT flow backend API Signed-off-by: Oleksandr Kolomeiets --- v3 * Remove newline characters from logs. --- drivers/net/ntnic/include/flow_api.h | 3 + drivers/net/ntnic/include/flow_api_engine.h | 5 ++ drivers/net/ntnic/i

[PATCH v3 50/50] net/ntnic: add functions for retrieving and managing packets

2024-10-10 Thread Serhii Iliushyk
From: Danylo Vodopianov Implemented functionality for retrieving received packets from virtual queues, supporting both SPLIT_RING and PACKED_RING types. Updated sg_ops structure to include the new packet retrieval functions. Signed-off-by: Danylo Vodopianov --- v2 * fix issue(Title underline t

[PATCH v3 1/2] power: enable CPPC support in power library

2024-10-10 Thread Wathsala Vithanage
Power library already supports Linux CPPC driver. Enable its use and fix the name of the CPPC driver name. Signed-off-by: Wathsala Vithanage Reviewed-by: Dhruv Tripathi --- lib/power/power_cppc_cpufreq.c | 2 +- lib/power/rte_power_pmd_mgmt.c | 11 ++- 2 files changed, 7 insertions(+),

Re: [PATCH v7 3/7] eal: add lcore variable performance test

2024-10-10 Thread Mattias Rönnblom
On 2024-10-09 22:46, Morten Brørup wrote: From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] Sent: Wednesday, 18 September 2024 10.26 A few corrections to a comment. Besides that, Acked-by: Morten Brørup +/* + * The potential performance benefit of lcore variables compared to +

[PATCH v3 2/2] power: detect supported driver

2024-10-10 Thread Wathsala Vithanage
Check if the frequency scaling driver is supported before attempting to initialize. Signed-off-by: Wathsala Vithanage Reviewed-by: Dhruv Tripathi --- lib/power/power_acpi_cpufreq.c | 6 ++ lib/power/power_amd_pstate_cpufreq.c | 6 ++ lib/power/power_cppc_cpufreq.c | 6 ++

RE: [PATCH dpdk v2 00/16] IPv6 APIs overhaul

2024-10-10 Thread Konstantin Ananyev
> > As discussed recently [1], here is a first draft of the IPv6 APIs rework. The > API change was announced before the 24.07 release [2]. This series is intended > for 24.11. > > [1] http://inbox.dpdk.org/dev/d2sr8t1h39cj.jrqfi6jeh...@redhat.com/ > [2] > https://git.dpdk.org/dpdk/commit/?id=8

Re: [PATCH] maintainers: update ena maintainers list

2024-10-10 Thread Thomas Monjalon
02/10/2024 10:22, shaib...@amazon.com: > From: Shai Brandes > > Added a new ena team member. > > @@ -663,6 +663,7 @@ M: Shai Brandes > M: Evgeny Schemeilin > M: Ron Beider > M: Amit Bernstein > +M: Yosef Raisman > M: Wajeeh Atrash Do you really want all your team members be listed her

RE: [PATCH v9 00/17] Use malloc function attribute to uncover bugs

2024-10-10 Thread Wathsala Wathawana Vithanage
> Subject: [PATCH v9 00/17] Use malloc function attribute to uncover bugs > > Recent versions of GCC have some additional function attributes that can help > with DPDK performance and stability. > > The alloc_align attribute tells the compiler what the alignment of the > allocation > will be, an

RE: [PATCH dpdk v2 16/16] ipv6: add function to check ipv6 version

2024-10-10 Thread Konstantin Ananyev
> This is a slow path version to verify the version field in IPv6 headers. > > Signed-off-by: Robin Jarry > --- > > Notes: > v2: new patch > > app/test/test_net_ipv6.c | 16 > lib/net/rte_ip6.h| 17 + > 2 files changed, 33 insertions(+) > > diff

Re: [PATCH v9 1/7] eal: add static per-lcore memory allocation facility

2024-10-10 Thread Stephen Hemminger
On Thu, 10 Oct 2024 16:21:59 +0200 Mattias Rönnblom wrote: > Introduce DPDK per-lcore id variables, or lcore variables for short. > > An lcore variable has one value for every current and future lcore > id-equipped thread. > > The primary use case is for statically allocating > small, frequent

[PATCH v9 0/7] Lcore variables

2024-10-10 Thread Mattias Rönnblom
This patch set introduces a new API for static per-lcore id data allocation. Please refer to the API documentation for both a rationale for this new API, and a comparison to the alternatives available. The adoption of this API would affect many different DPDK modules, but the author updated onl

[PATCH v9 4/7] random: keep PRNG state in lcore variable

2024-10-10 Thread Mattias Rönnblom
Replace keeping PRNG state in a RTE_MAX_LCORE-sized static array of cache-aligned and RTE_CACHE_GUARDed struct instances with keeping the same state in a more cache-friendly lcore variable. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Konstantin Ananyev Acked-by: Chengwen F

[PATCH v9 3/7] eal: add lcore variable performance test

2024-10-10 Thread Mattias Rönnblom
Add basic micro benchmark for lcore variables, in an attempt to assure that the overhead isn't significantly greater than alternative approaches, in scenarios where the benefits aren't expected to show up (i.e., when plenty of cache is available compared to the working set size of the per-lcore dat

[PATCH v9 5/7] power: keep per-lcore state in lcore variable

2024-10-10 Thread Mattias Rönnblom
Replace static array of cache-aligned structs with an lcore variable, to slightly benefit code simplicity and performance. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Konstantin Ananyev Acked-by: Chengwen Feng Acked-by: Stephen Hemminger -- PATCH v6: * Update FOREACH

[PATCH v9 6/7] service: keep per-lcore state in lcore variable

2024-10-10 Thread Mattias Rönnblom
Replace static array of cache-aligned structs with an lcore variable, to slightly benefit code simplicity and performance. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Konstantin Ananyev Acked-by: Chengwen Feng Acked-by: Stephen Hemminger -- PATCH v7: * Update to match

[PATCH v9 7/7] eal: keep per-lcore power intrinsics state in lcore variable

2024-10-10 Thread Mattias Rönnblom
Keep per-lcore power intrinsics state in a lcore variable to reduce cache working set size and avoid any CPU next-line-prefetching causing false sharing. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Konstantin Ananyev Acked-by: Chengwen Feng Acked-by: Stephen Hemminger --

[PATCH v9 1/7] eal: add static per-lcore memory allocation facility

2024-10-10 Thread Mattias Rönnblom
Introduce DPDK per-lcore id variables, or lcore variables for short. An lcore variable has one value for every current and future lcore id-equipped thread. The primary use case is for statically allocating small, frequently-accessed data structures, for which one instance should exist for each l

[PATCH v9 2/7] eal: add lcore variable functional tests

2024-10-10 Thread Mattias Rönnblom
Add functional test suite to exercise the API. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Chengwen Feng Acked-by: Stephen Hemminger -- PATCH v6: * Update FOREACH invocations to match new API. RFC v5: * Adapt tests to reflect the removal of the GET() and SET() macro

[PATCH v3 05/50] net/ntnic: extend and fix logging implementation

2024-10-10 Thread Serhii Iliushyk
From: Danylo Vodopianov Add suffixes logging Fix the issue with the configuration log level for a specific module Fix extended debug logging 3-letter abbreviation for log type Update documentation new log modules were added Log level in functions that initialize feature operations

[PATCH v3 06/50] net/ntnic: add flow filter init API

2024-10-10 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets Add high-level interfaces for the initialization of the flow filter. Signed-off-by: Oleksandr Kolomeiets --- v2 * Update release notes v3 * Remove new line characters from logs --- doc/guides/rel_notes/release_24_11.rst| 1 + drivers/net/ntnic/adapter/nt4ga_adap

[PATCH v3 08/50] net/ntnic: add flow backend initialization API

2024-10-10 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets Add high-level interfaces for the initialization of the backend. Signed-off-by: Oleksandr Kolomeiets --- v2 * Update release notes v3 * Remove newline characters from logs. --- doc/guides/rel_notes/release_24_11.rst| 1 + drivers/net/ntnic/include/flow_api.h

[PATCH v3 09/50] net/ntnic: add flow backend deinitialization API

2024-10-10 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets Add high-level interfaces for the deinitialization of the backend. Signed-off-by: Oleksandr Kolomeiets --- v3 * Remove newline characters from logs. --- drivers/net/ntnic/include/flow_api.h | 7 ++- drivers/net/ntnic/include/flow_filter.h | 1 +

[PATCH v3 03/50] net/ntnic: update documentation

2024-10-10 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets Add forgotten feature to the documentation (ntnic.ini) Signed-off-by: Oleksandr Kolomeiets --- doc/guides/nics/features/ntnic.ini | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/nics/features/ntnic.ini b/doc/guides/nics/features/ntnic.ini index 0a7481

[PATCH v3 07/50] net/ntnic: add flow filter deinitialization API

2024-10-10 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets Add high-level interfaces for the deinitialization of the flow filter. Signed-off-by: Oleksandr Kolomeiets --- v3 * Remove newline characters from logs. --- drivers/net/ntnic/adapter/nt4ga_adapter.c | 17 + drivers/net/ntnic/ntnic_mod_reg.h |

[PATCH v3 44/50] net/ntnic: add functions for availability monitor management

2024-10-10 Thread Serhii Iliushyk
From: Danylo Vodopianov Implemented functions to configure and manage availability monitor data. Added functions to set and flush availability monitor data. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/dbsconfig/ntnic_dbsconfig.c | 61 +++- drivers/net/ntnic/include/ntnic_dbs.h

[PATCH v3 43/50] net/ntnic: add split-queue support

2024-10-10 Thread Serhii Iliushyk
From: Danylo Vodopianov Split-queue support was added. Internal structures were enhanced with additional managmnet fields. Implement a managed virtual queue function based on the queue type and configuration parameters. DBS control registers were added. Signed-off-by: Danylo Vodopianov ---

[PATCH v3 45/50] net/ntnic: used writer data handling functions

2024-10-10 Thread Serhii Iliushyk
From: Danylo Vodopianov Introduced functions to set and flush RX and TX used writer data. Added support for setting shadow data with functions for guest physical address, host ID, queue size, packed, interrupt enable, vector, and ISTK for RX and TX. Implemented set_rx_used_writer_data and set_t

[PATCH v3 49/50] net/ntnic: add functions for releasing virt queues

2024-10-10 Thread Serhii Iliushyk
From: Danylo Vodopianov Implemented handler busy states and shutdowns of hardware queues. Added functionality for releasing RX and TX virtual queue resources, managed and releasing packets back into the availability ring. Updated sg_ops structure to include new queue management functions. Sign

<    1   2   3   >