[PATCH v2 26/50] net/ntnic: add base init and deinit of the NT flow API

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets Add basic API for initialization resources required by flow filter API Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/flow_api.h | 82 ++ drivers/net/ntnic/include/flow_api_engine.h | 43 +++ drivers/net/ntnic/include/hw_mod_backen

[PATCH v2 22/50] net/ntnic: add checksum update (CSU) flow module

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Checksum Update module updates the checksums of packets that has been modified in any way. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/meson.build | 1 + .../nthw/flow_api/flow_backend/flow_backend.c | 13 .../ntnic/nthw/flow_f

[PATCH v2 27/50] net/ntnic: add base init and deinit the NT flow backend

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets Add basic implementation of the NT flow backend API Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/flow_api.h | 3 + drivers/net/ntnic/include/flow_api_engine.h | 5 ++ drivers/net/ntnic/include/hw_mod_backend.h| 12 drivers/

RE: [PATCH v2 1/4] power: refactor core power management library

2024-10-07 Thread Tummala, Sivaprasad
[AMD Official Use Only - AMD Internal Distribution Only] Hi Stephen, > -Original Message- > From: Stephen Hemminger > Sent: Monday, August 26, 2024 8:56 PM > To: Tummala, Sivaprasad > Cc: david.h...@intel.com; anatoly.bura...@intel.com; jer...@marvell.com; > radu.nico...@intel.com; gak.

[PATCH v2 13/50] net/ntnic: add flow matcher (FLM) flow module

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Flow Matcher module is a high-performance stateful SDRAM lookup and programming engine which supported exact match lookup in line-rate of up to hundreds of millions of flows. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mod_backend.h|

[PATCH v2 19/50] net/ntnic: add header field update (HFU) flow module

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Header Field Update module updates protocol fields if the packets have been changed, for example length fields and next protocol fields. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/meson.build | 1 + .../nthw/flow_api/flow_backend/f

[PATCH v2 16/50] net/ntnic: add queue select (QSL) flow module

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Queue Selector module directs packets to a given destination which includes host queues, physical ports, exceptions paths, and discard. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mod_backend.h| 18 ++ drivers/net/ntnic/include/hw_mo

[PATCH v2 20/50] net/ntnic: add RPP local retransmit (RPP LR) flow module

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The RX Packet Process for Local Retransmit module can add bytes in the FPGA TX pipeline, which is needed when the packet increases in size. Note, this makes room for packet expansion, but the actual expansion is done by the modules. Signed-off-by: Oleksandr Kolomeiets

[PATCH v2 15/50] net/ntnic: add hasher (HSH) flow module

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Hasher module calculates a configurable hash value to be used internally by the FPGA. The module support both Toeplitz and NT-hash. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mod_backend.h| 16 ++ drivers/net/ntnic/include/hw_mod_hs

[PATCH v2 21/50] net/ntnic: add copier (Tx CPY) flow module

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The TX Copy module writes data to packet fields based on the lookup performed by the FLM module. This is used for NAT and can support other actions based on the RTE action MODIFY_FIELD. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/meson.build

[PATCH v2 17/50] net/ntnic: add slicer (SLC LR) flow module

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Slicer for Local Retransmit module can cut of the head a packet before the packet leaves the FPGA RX pipeline. This is used when the TX pipeline is configured to add a new head in the packet. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mo

[PATCH v2 09/50] net/ntnic: add flow backend deinitialization API

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets Add high-level interfaces for the deinitialization of the backend. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/flow_api.h | 7 ++- drivers/net/ntnic/include/flow_filter.h | 1 + drivers/net/ntnic/include/hw_mod_backend.h

Re: [dpdk-dev] [PATCH 10/10] net/bonding: fix configuration assignment overflow

2024-10-07 Thread lihuisong (C)
Hi Stephen, Thanks for your review this series again. 在 2024/10/4 0:03, Stephen Hemminger 写道: On Mon, 19 Apr 2021 21:34:49 +0800 "Min Hu (Connor)" wrote: From: Chengchang Tang The expression may cause an overflow. This patch fix the codeDEX static check warning "INTEGER_OVERFLOW". Fixes

Re: [PATCH RESEND v7 0/5] app/testpmd: support multiple process attach and detach port

2024-10-07 Thread lihuisong (C)
Hi Thomas and Ferruh, We've discussed it on and off a few times, and we've reached some consensus. They've been going through more than 2 years😅 Can you have a look at this series again? If we really don't need it, I will drop it from my upstreaming list. /Huisong 在 2024/9/29 13:52, Huisong Li

Re: [PATCH v4 1/1] dmadev: support priority configuration

2024-10-07 Thread fengchengwen
Hi, Sorry to reply now, because I just got back from our National Day vacation. >From the commit it seem confused about the dmadev and HW channel, Current one >dmadev is corresponding a HW channel if its a hardware device. So I suggest try not to mention HW channel, but the dmadev or DMA device.

答复: [PATCH v2] r8125: add r8125 ethernet poll mode driver

2024-10-07 Thread 王颢
Dear Stephen, I am currently in the process of merging r8125 (for 2.5G) and r8126 (for 5G). Ultimately, we will have r8169 supporting both 2.5G and 5G. As you may have already seen from some patches, r8169 has been split into several smaller patches. We are still working on adjusting the format

Re: [PATCH v2] doc: reword sample app guides

2024-10-07 Thread fengchengwen
Hi Nandini, For dma.rst, there are two minor comments, with that fixed, please add: Acked-by: Chengwen Feng Thanks On 2024/10/7 7:45, Nandini Persad wrote: > I have reviewed these sections for grammar/clarity > and made small modifications to the formatting of sections > to adhere to a template

Re: [PATCH v2 1/3] net: add thread-safe crc api

2024-10-07 Thread Ferruh Yigit
On 10/1/2024 7:11 PM, Arkadiusz Kusztal wrote: > The current net CRC API is not thread-safe, this patch > solves this by adding another, thread-safe API functions. > This API is also safe to use across multiple processes, > yet with limitations on max-simd-bitwidth, which will be checked only by >

Re: [PATCH 09/10] ethdev: check return value from rte_eth_dev_info_get

2024-10-07 Thread Ferruh Yigit
On 10/4/2024 5:21 PM, Stephen Hemminger wrote: > The mac compare must check return value from rte_eth_dev_info_get > before using the dev_info information. > > Signed-off-by: Stephen Hemminger > Acked-by: Ferruh Yigit

Re: [PATCH 02/10] net/memif: check return value from rte_eth_dev_info_get

2024-10-07 Thread Ferruh Yigit
On 10/4/2024 5:21 PM, Stephen Hemminger wrote: > Handle errors from rte_eth_dev_info_get in the same manner > as other places in this file. > > Signed-off-by: Stephen Hemminger > Acked-by: Ferruh Yigit

Re: [PATCH 10/10] ethdev: require checking results of info_get functions

2024-10-07 Thread Ferruh Yigit
On 10/4/2024 5:21 PM, Stephen Hemminger wrote: > With functions that return a data structure, the application must > check the return value since the data structure contents will > be undefined in case of error. > > Signed-off-by: Stephen Hemminger > Acked-by: Ferruh Yigit

Re:[PATCH] raw/zxdh: introduce zxdh raw device driver

2024-10-07 Thread Yong Zhang
Hi thomas, I hope this message finds you well. I initially submitted the zxdh rawdev driver on June 12th, and the final version was submitted on August 12th. Since then, I have not received any feedback from the community. I would appreciate it if you could provide any suggestions for modific

Re: [PATCH v2 0/3] app/testpmd: improve sse based macswap

2024-10-07 Thread Ferruh Yigit
On 10/4/2024 6:08 AM, Ferruh Yigit wrote: > On 8/21/2024 3:38 PM, Vipin Varghese wrote: >> Goal of the patch series is to improve SSE macswap on x86_64 by >> reducing the stalls in backend engine. Original implementation of >> the SSE-mac-swap makes loop call to multiple load, shuffle & store. >> >

Re: [PATCH v2] app/testpmd: show output of commands read from file

2024-10-07 Thread Ferruh Yigit
On 10/4/2024 5:56 AM, Ferruh Yigit wrote: > On 8/22/2024 11:41 AM, Bruce Richardson wrote: >> Testpmd supports the "--cmdline-file" parameter to read a set of initial >> commands from a file. However, the only indication that this has been >> done successfully on startup is a single-line message, n

Re: [PATCH 2/2] ethdev: fix race on ports for telemetry commands

2024-10-07 Thread lihuisong (C)
在 2024/10/2 23:57, David Marchand 写道: While invoking telemetry commands (which may happen at any time, out of control of the application), an application thread may concurrently add/remove ports. The telemetry callbacks may then access partially initialised/uninitialised ethdev data. Reuse the

[DPDK/ethdev Bug 1560] "net_txgbe" is unable to retrieve all statistical information correctly through telemetry.

2024-10-07 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1560 Bug ID: 1560 Summary: "net_txgbe" is unable to retrieve all statistical information correctly through telemetry. Product: DPDK Version: 24.07 Hardware: All OS: All

Re: [PATCH] raw/zxdh: introduce zxdh raw device driver

2024-10-07 Thread Stephen Hemminger
On Tue, 8 Oct 2024 09:18:44 +0800 Yong Zhang wrote: > Hi thomas, > > I hope this message finds you well. > I initially submitted the zxdh rawdev driver on June 12th, and the final > version was submitted on August 12th. Since then, I have not received any > feedback from the community. > I

[DPDK/ethdev Bug 1534] Transmit errors with iavf VF using SR-IOV on VM

2024-10-07 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1534 junya@anritsu.com changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

Re: [PATCH v2] r8125: add r8125 ethernet poll mode driver

2024-10-07 Thread Stephen Hemminger
On Wed, 12 Jun 2024 17:51:45 +0800 Howard Wang wrote: > r8125 is for Realtek 2.5 Gigabit Ethernet NICs. > > Signed-off-by: Howard Wang > --- To echo what Ferruh mentioned. 1. Break the driver into more easily reviewed pieces. 2. Run checkpatch, there are lots of style problems still in both

Re: [RFC 0/4] ethdev: rework config restore

2024-10-07 Thread Ferruh Yigit
On 10/7/2024 10:27 AM, Konstantin Ananyev wrote: > > >>> External email: Use caution opening links or attachments >>> >>> >>> On 9/18/2024 10:21 AM, Dariusz Sosnowski wrote: Hi all, We have been working on optimizing the latency of calls to rte_eth_dev_start(), on ports spawne

Re: [RFC v1] raw/ntb: add support for 6th Gen Intel Xeon

2024-10-07 Thread Stephen Hemminger
On Fri, 8 Dec 2023 16:07:59 +0800 Junfeng Guo wrote: > Add support for the 6th Gen Intel Xeon Scalable processors. Note that NTB > devices within the 6th Gen Intel Xeon compliant to PCIe 5.0 spec. > > Signed-off-by: Junfeng Guo I would combine the 5th and 6th patches together in new version.

Re: [PATCH v6 1/1] eal/unix: allow creating thread with real-time priority

2024-10-07 Thread Stephen Hemminger
On Fri, 27 Oct 2023 10:08:52 +0200 Thomas Monjalon wrote: > When adding an API for creating threads, > the real-time priority has been forbidden on Unix. > > There is a known issue with ring behaviour, > but it should not be completely forbidden. > > Real-time thread can block some kernel threa

[PATCH v2 03/50] net/ntnic: update documentation

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets Add forgotten feature to the documentation (ntnic.ini) Signed-off-by: Oleksandr Kolomeiets --- doc/guides/nics/features/ntnic.ini | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/nics/features/ntnic.ini b/doc/guides/nics/features/ntnic.ini index 0a7481

[PATCH v2 00/50] Provide: flow filter init API, Enable virtual queues, fix ntnic issues for release 24.07

2024-10-07 Thread Serhii Iliushyk
The list of updates provided by the patchset: * Update the supported version of the FPGA to 9563.55.49 * Fix Coverity issues * Fix issues related to release 24.07 * Extended and fixed the implementation of the logging * Added NT flow filter init API * Added NT flow backend initializatio

[PATCH v2 07/50] net/ntnic: add flow filter deinitialization API

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets Add high-level interfaces for the deinitialization of the flow filter. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/adapter/nt4ga_adapter.c | 17 + drivers/net/ntnic/ntnic_mod_reg.h | 1 + 2 files changed, 18 insertions(+) diff

[PATCH v2 01/50] net/ntnic: update NT NiC PMD driver with FPGA version

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets Update base FPGA files to the new version(39->49) Fix code style problems Update documentation Signed-off-by: Oleksandr Kolomeiets --- v2 * Update release notes --- doc/guides/rel_notes/release_24_11.rst| 3 ++ drivers/net/ntnic/meson.build

[PATCH v2 06/50] net/ntnic: add flow filter init API

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets Add high-level interfaces for the initialization of the flow filter. Signed-off-by: Oleksandr Kolomeiets --- v2 * Update release notes --- doc/guides/rel_notes/release_24_11.rst| 1 + drivers/net/ntnic/adapter/nt4ga_adapter.c | 18 ++ drivers/net

[PATCH v2 08/50] net/ntnic: add flow backend initialization API

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets Add high-level interfaces for the initialization of the backend. Signed-off-by: Oleksandr Kolomeiets --- v2 * Update release notes --- doc/guides/rel_notes/release_24_11.rst| 1 + drivers/net/ntnic/include/flow_api.h | 2 ++ drivers/net/ntnic/inclu

[PATCH v2 04/50] net/ntnic: remove extra calling of the API for release port

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets During rte_eth_dev_close execution, eth_dev_close function exported by ntnic is called, followed by a call to rte_eth_dev_release_port. Since there is no possible returns between the calls, calling rte_eth_dev_release_port from eth_dev_close is redundant and error-pron

[PATCH v2 47/50] net/ntnic: update FPGA registeris related to DBS

2024-10-07 Thread Serhii Iliushyk
DBS - DVIO Buffer System Signed-off-by: Serhii Iliushyk --- .../supported/nthw_fpga_9563_055_049_.c | 184 +- 1 file changed, 183 insertions(+), 1 deletion(-) diff --git a/drivers/net/ntnic/nthw/supported/nthw_fpga_9563_055_049_.c b/drivers/net/ntnic/nthw/supported/nt

[PATCH v2 44/50] net/ntnic: add functions for availability monitor management

2024-10-07 Thread Serhii Iliushyk
From: Danylo Vodopianov Implemented functions to configure and manage availability monitor data. Added functions to set and flush availability monitor data. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/dbsconfig/ntnic_dbsconfig.c | 61 +++- drivers/net/ntnic/include/ntnic_dbs.h

[PATCH v2 46/50] net/ntnic: add descriptor reader data handling functions

2024-10-07 Thread Serhii Iliushyk
From: Danylo Vodopianov Added functions for setting and flushing RX and TX descriptor reader data. Implemented internal strcutres to update shadow structures with guest physical address, host ID, queue size, header, and packed status. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/dbs

[PATCH v2 42/50] net/ntnic: add init for virt queues in the DBS

2024-10-07 Thread Serhii Iliushyk
From: Danylo Vodopianov DBS (DVIO Buffer System) module controls the scatter-gather buffer system that let's the host CPU interact with packets. Macros and Definitions: Defined constants for queue management and polling speeds. Data Structures: Added structures and arrays for RX and TX queue ma

[PATCH v2 48/50] net/ntnic: virtqueue setup managed packed-ring was added

2024-10-07 Thread Serhii Iliushyk
From: Danylo Vodopianov Structures were enhanced with PACKED virtqueue fields. Managed function was extended with packed ring configuration and initialization support. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/dbsconfig/ntnic_dbsconfig.c | 191 +- drivers/net/ntnic

[PATCH v2 50/50] net/ntnic: add functions for retrieving and managing packets

2024-10-07 Thread Serhii Iliushyk
From: Danylo Vodopianov Implemented functionality for retrieving received packets from virtual queues, supporting both SPLIT_RING and PACKED_RING types. Updated sg_ops structure to include the new packet retrieval functions. Signed-off-by: Danylo Vodopianov --- v2 * fix issue(Title underline t

[PATCH v2 49/50] net/ntnic: add functions for releasing virt queues

2024-10-07 Thread Serhii Iliushyk
From: Danylo Vodopianov Implemented handler busy states and shutdowns of hardware queues. Added functionality for releasing RX and TX virtual queue resources, managed and releasing packets back into the availability ring. Updated sg_ops structure to include new queue management functions. Sign

Re: [PATCH v4 0/6] refine argparse library

2024-10-07 Thread Stephen Hemminger
On Mon, 18 Mar 2024 11:18:32 + Chengwen Feng wrote: > I found a couple of issues when I revisited the argparse_autotest > output, so got this patchset. > > Chengwen Feng (6): > argparse: refine error message > argparse: remove dead code > argparse: replace flag enum with marco > argp

Re: [PATCH v2] net/mlx5: fix incorrect rx/tx descriptor limitations in rte_eth_dev_info

2024-10-07 Thread Stephen Hemminger
On Wed, 19 Jun 2024 01:56:42 +0300 Igor Gutorov wrote: > Currently, `rte_eth_dev_info.rx_desc_lim.nb_max` as well as > `rte_eth_dev_info.tx_desc_lim.nb_max` shows 65535 as the limit, > which results in a few problems: > > * It is an incorrect value > * Allocating an RX queue and passing `rx_desc

Re: [PATCH] checkpatches: verify in-reply-to header when possible

2024-10-07 Thread Stephen Hemminger
On Fri, 5 Jul 2024 17:35:33 +0200 Robin Jarry wrote: > When using checkpatches.sh locally, verify that there is an In-Reply-To > header when the patch is a respin (i.e. v2, v3, etc.). This is currently > only enforced by the upstream CI but cannot be verified locally. > > This cannot be verifie

Re: [PATCH] checkpatches: verify in-reply-to header when possible

2024-10-07 Thread Robin Jarry
Stephen Hemminger, Oct 07, 2024 at 22:41: + && echo "$subject" | grep -qi 'v[2-9].*\]' \ Your regex won't work for v10 etc. Good catch. I'll send a v2.

Re: [RFC PATCH] app/test: allow passing a parameter string to autotests

2024-10-07 Thread Stephen Hemminger
On Fri, 15 Dec 2023 13:06:56 + Bruce Richardson wrote: > Sometimes it can be nice to have autotests which can take a parameter, > or can be tweaked in some ways, e.g. adjust the number of iterations, or > the burst size used in the test. Currently there is no way to do so - > all test paramet

Re: [PATCH v2 0/3] make struct parameters constant in rte_tm APIs

2024-10-07 Thread Ferruh Yigit
On 10/7/2024 4:22 PM, Stephen Hemminger wrote: > On Mon, 7 Oct 2024 12:49:04 +0100 > Bruce Richardson wrote: > >> For functions for creating profiles, shapers and hierarchy nodes, make >> the parameter structure pointer a pointer to a const object. This >> guarantees to the user that the struct

Re: [PATCH] net/gve: fix refill logic causing memory corruption

2024-10-07 Thread Ferruh Yigit
On 10/4/2024 2:05 AM, Joshua Washington wrote: > There is a seemingly mundane error in the RX refill path which can lead > to major issues and ultimately program crashing. > > This error occurs as part of an edge case where the exact number of > buffers the refill causes the ring to wrap around to

Re: [PATCH 1/5] config/riscv: add flag for using Zbc extension

2024-10-07 Thread Stanisław Kardach
On Mon, Oct 7, 2024 at 5:20 PM Stephen Hemminger wrote: > > On Mon, 7 Oct 2024 10:14:22 +0200 > Stanisław Kardach wrote: > > > > > > > > > > > Please do not add more config options via compile flags. > > > > > It makes it impossible for distros to ship one version. > > That is a problem with RISC

Re: [PATCH] raw/zxdh: introduce zxdh raw device driver

2024-10-07 Thread zhang.yong25
>> Hi thomas,>>>> I hope this message finds you well.>> I initially >> submitted the zxdh rawdev driver on June 12th, and the final version was >> submitted on August 12th. Since then, I have not received any feedback from >> the community.>> I would appreciate it if you could provide any su

Re: [PATCH 2/2] ethdev: fix race on ports for telemetry commands

2024-10-07 Thread David Marchand
On Tue, Oct 8, 2024 at 4:09 AM lihuisong (C) wrote: > > > 在 2024/10/2 23:57, David Marchand 写道: > > While invoking telemetry commands (which may happen at any time, > > out of control of the application), an application thread may > > concurrently add/remove ports. > > The telemetry callbacks may

Re: [dpdk-dev] [PATCH v2] drivers: fix build issues with redundant newline changes

2024-10-07 Thread David Marchand
On Mon, Oct 7, 2024 at 2:41 PM wrote: > > From: Jerin Jacob > > Certain section of the code in net/mvpp2 and ml/cnxk is enabled only > when all depended library dependences where meet. > Fixing those build errors. > > Fixes: f665790a5dba ("drivers: remove redundant newline from logs") > > Signed-

Re: [PATCH v9 0/6] Introduce event pre-scheduling

2024-10-07 Thread Jerin Jacob
On Tue, Oct 8, 2024 at 3:14 AM wrote: > > From: Pavan Nikhilesh > > Event pre-scheduling improves scheduling performance by assigning events > to event ports in advance when dequeues are issued. > This series introduces various types and levels of pre-scheduling to the > eventdev library. > > pre

RE: [PATCH v2 2/4] power: refactor uncore power management library

2024-10-07 Thread Tummala, Sivaprasad
[AMD Official Use Only - AMD Internal Distribution Only] Hi Lihuisong, > -Original Message- > From: lihuisong (C) > Sent: Tuesday, August 27, 2024 6:33 PM > To: Tummala, Sivaprasad > Cc: dev@dpdk.org; david.h...@intel.com; anatoly.bura...@intel.com; > radu.nico...@intel.com; jer...@marv

<    1   2