Re: kni: check abi version between kmod and lib

2022-04-24 Thread Stephen Coleman
execuse me, one of the Windows check is failing but I didn't find where's the build log, nor to determine whether it is related. > KNI ioctl functions copy data from userspace lib, and this interface > of kmod is not compatible indeed. If the user use incompatible rte_kni.ko > bad things happen: s

[PATCH v3] kni: check abi version between kmod and lib

2022-04-24 Thread youcai
KNI ioctl functions copy data from userspace lib, and this interface of kmod is not compatible indeed. If the user use incompatible rte_kni.ko bad things happen: sometimes various fields contain garbage value, sometimes it cause a kmod soft lockup. Some common distros ship their own rte_kni.ko, so

Re: kni: check abi version between kmod and lib

2022-04-22 Thread Stephen Coleman
thanks for your replies I'm aware that kernel guidelines propose ascending ioctl numbers to max out compatibility, but this will not work with dpdk, especially our case here. If you look into kni_net.c you'll see the module is actually internally depending on the memory layout of mbuf and a few o

Re: kni: check abi version between kmod and lib

2022-04-22 Thread Ray Kinsella
Stephen Hemminger writes: > On Thu, 21 Apr 2022 11:40:00 -0400 > Ray Kinsella wrote: > >> Stephen Hemminger writes: >> >> > On Thu, 21 Apr 2022 12:38:26 +0800 >> > Stephen Coleman wrote: >> > >> >> KNI ioctl functions copy data from userspace lib, and this interface >> >> of kmod is not c

[PATCH v2] kni: check abi version between kmod and lib

2022-04-21 Thread youcai
KNI ioctl functions copy data from userspace lib, and this interface of kmod is not compatible indeed. If the user use incompatible rte_kni.ko bad things happen: sometimes various fields contain garbage value, sometimes it cause a kmod soft lockup. Some common distros ship their own rte_kni.ko, so

Re: kni: check abi version between kmod and lib

2022-04-21 Thread Stephen Hemminger
On Thu, 21 Apr 2022 11:40:00 -0400 Ray Kinsella wrote: > Stephen Hemminger writes: > > > On Thu, 21 Apr 2022 12:38:26 +0800 > > Stephen Coleman wrote: > > > >> KNI ioctl functions copy data from userspace lib, and this interface > >> of kmod is not compatible indeed. If the user use incompat

Re: kni: check abi version between kmod and lib

2022-04-21 Thread Ray Kinsella
Stephen Hemminger writes: > On Thu, 21 Apr 2022 12:38:26 +0800 > Stephen Coleman wrote: > >> KNI ioctl functions copy data from userspace lib, and this interface >> of kmod is not compatible indeed. If the user use incompatible rte_kni.ko >> bad things happen: sometimes various fields contain

Re: kni: check abi version between kmod and lib

2022-04-21 Thread Stephen Hemminger
On Thu, 21 Apr 2022 12:38:26 +0800 Stephen Coleman wrote: > KNI ioctl functions copy data from userspace lib, and this interface > of kmod is not compatible indeed. If the user use incompatible rte_kni.ko > bad things happen: sometimes various fields contain garbage value, > sometimes it cause a

Re: kni: check abi version between kmod and lib

2022-04-21 Thread Ray Kinsella
Stephen Coleman writes: > KNI ioctl functions copy data from userspace lib, and this interface > of kmod is not compatible indeed. If the user use incompatible rte_kni.ko > bad things happen: sometimes various fields contain garbage value, > sometimes it cause a kmod soft lockup. > > Some commo

kni: check abi version between kmod and lib

2022-04-20 Thread Stephen Coleman
KNI ioctl functions copy data from userspace lib, and this interface of kmod is not compatible indeed. If the user use incompatible rte_kni.ko bad things happen: sometimes various fields contain garbage value, sometimes it cause a kmod soft lockup. Some common distros ship their own rte_kni.ko, so