Thanks, applied to next-dts.
Hi Dean. This looks good to me, though I agree Luca's point about
show_port_info_all() is compelling. We are enforcing the paired topology
today but may not always.
I don't view it as something which should block the testsuite, but this is
worth tracking. Can you make a Bugzilla ticket for this, a
Add set multicast function for changing allmulticast mode
within testpmd shell.
Signed-off-by: Dean Marx
---
dts/framework/remote_session/testpmd_shell.py | 24 +++
1 file changed, 24 insertions(+)
diff --git a/dts/framework/remote_session/testpmd_shell.py
b/dts/framework/remot
Add set multicast function for changing allmulticast mode
within testpmd shell.
Signed-off-by: Dean Marx
---
dts/framework/remote_session/testpmd_shell.py | 24 +++
1 file changed, 24 insertions(+)
diff --git a/dts/framework/remote_session/testpmd_shell.py
b/dts/framework/remot
added set multicast function for changing allmulticast mode within testpmd.
Signed-off-by: Dean Marx
---
dts/framework/remote_session/testpmd_shell.py | 46 +++
1 file changed, 46 insertions(+)
diff --git a/dts/framework/remote_session/testpmd_shell.py
b/dts/framework/remote_se
Hi Dean,
Apologies again for having replied to the wrong email thread. I'll copy
my comments here. And thank you again for your contribution
On 24/07/2024 20:21, Dean Marx wrote:
added set multicast function for changing allmulticast mode within testpmd.
Signed-off-by: Dean Marx
---
dts/f
Hi Dean, thank you for your work.
On 08/07/2024 20:08, Dean Marx wrote:
+def set_multicast_all(self, on: bool, verify: bool = True):
+"""Turns multicast mode on/off for the specified port.
+
+Args:
+on: If :data:`True`, turns multicast mode on, otherwise turns off
added set multicast function for changing allmulticast mode within testpmd.
Signed-off-by: Dean Marx
---
dts/framework/remote_session/testpmd_shell.py | 46 +++
1 file changed, 46 insertions(+)
diff --git a/dts/framework/remote_session/testpmd_shell.py
b/dts/framework/remote_se
On Mon, Jul 15, 2024 at 12:00 PM Dean Marx wrote:
>
> added set multicast function for changing allmulticast mode within testpmd.
>
> Signed-off-by: Dean Marx
> ---
I still think this patch would benefit from my above comments about
modifying the method signatures and using show_port_info_all(),
added set multicast function for changing allmulticast mode within testpmd.
Signed-off-by: Dean Marx
---
dts/framework/remote_session/testpmd_shell.py | 46 +++
1 file changed, 46 insertions(+)
diff --git a/dts/framework/remote_session/testpmd_shell.py
b/dts/framework/remote_se
On Mon, Jul 8, 2024 at 3:19 PM Dean Marx wrote:
>
> added set multicast function for changing allmulticast mode within testpmd.
>
> Signed-off-by: Dean Marx
> ---
> dts/framework/remote_session/testpmd_shell.py | 46 +++
> 1 file changed, 46 insertions(+)
>
> diff --git a/dts/fra
added set multicast function for changing allmulticast mode within testpmd.
Signed-off-by: Dean Marx
---
dts/framework/remote_session/testpmd_shell.py | 46 +++
1 file changed, 46 insertions(+)
diff --git a/dts/framework/remote_session/testpmd_shell.py
b/dts/framework/remote_se
added set multicast function for changing allmulticast mode within testpmd.
Signed-off-by: Dean Marx
---
dts/framework/remote_session/testpmd_shell.py | 46 +++
1 file changed, 46 insertions(+)
diff --git a/dts/framework/remote_session/testpmd_shell.py
b/dts/framework/remote_se
added set multicast function for changing allmulticast mode within testpmd.
Signed-off-by: Dean Marx
---
dts/framework/remote_session/testpmd_shell.py | 46 +++
1 file changed, 46 insertions(+)
diff --git a/dts/framework/remote_session/testpmd_shell.py
b/dts/framework/remote_se
14 matches
Mail list logo
