Re: Risk of rte_ether_addr_copy() causing bugs

2024-11-04 Thread Bruce Richardson
On Mon, Nov 04, 2024 at 08:15:00AM -0800, Stephen Hemminger wrote: > On Mon, 4 Nov 2024 13:11:02 +0100 > Morten Brørup wrote: > > > Unlike memcpy() and other copy functions, rte_ether_addr_copy() takes the > > destination as the second parameter. > > > > Not following well established conventio

Re: Risk of rte_ether_addr_copy() causing bugs

2024-11-04 Thread Stephen Hemminger
On Mon, 4 Nov 2024 13:11:02 +0100 Morten Brørup wrote: > Unlike memcpy() and other copy functions, rte_ether_addr_copy() takes the > destination as the second parameter. > > Not following well established conventions adds a high risk of causing bugs > in the applications/libraries/drivers; it

Risk of rte_ether_addr_copy() causing bugs

2024-11-04 Thread Morten Brørup
Unlike memcpy() and other copy functions, rte_ether_addr_copy() takes the destination as the second parameter. Not following well established conventions adds a high risk of causing bugs in the applications/libraries/drivers; it is likely that developers expect copy() functions to take paramete