Re: [PATCH v2] dts: fix devbind initialization bug

2025-06-17 Thread Patrick Robb
On Tue, Jun 17, 2025 at 11:18 AM Luca Vizzarro wrote: > Looks good to me. just a small nit: > > On 16/06/2025 19:38, Dean Marx wrote: > > +test_run.ctx.topology.setup() > > +self.test_run.ctx.topology.configure_ports("sut", "dpdk") > > no need to do `self.` here. Outside of this:

Re: [PATCH v2] dts: fix devbind initialization bug

2025-06-17 Thread Luca Vizzarro
Looks good to me. just a small nit: On 16/06/2025 19:38, Dean Marx wrote: +test_run.ctx.topology.setup() +self.test_run.ctx.topology.configure_ports("sut", "dpdk") no need to do `self.` here. Outside of this: Reviewed-by: Luca Vizzarro

Re: [PATCH v2] dts: fix devbind initialization bug

2025-06-16 Thread Patrick Robb
Thanks, looks good and I gave it a testrun on some XL710. I'm going to include the Slack summary of the bugs for clarity on the v2: Bugs: 1. topology setup is called before DPDKRuntimeEnvironment setup, but DPDKRuntimeEnvironment setup is required for topology setup, so the ordering needs to be r

Re: [PATCH v2] dts: fix devbind initialization bug

2025-06-16 Thread Patrick Robb
Recheck-request: iol-intel-Functional