RE: [PATCH] mbuf: de-inline sanity checking a reinitialized mbuf

2025-07-19 Thread Ivan Malov
Hi Morten, On Sat, 19 Jul 2025, Morten Brørup wrote: From: Morten Brørup [mailto:m...@smartsharesystems.com] Sent: Saturday, 19 July 2025 12.23 Sanity checking a reinitialized mbuf (a.k.a. raw mbuf) has been refactored to follow the same design pattern as sanity checking a normal mbuf, and now

RE: [RFC PATCH 0/5] Introduce mempool object new debug capabilities

2025-07-19 Thread Morten Brørup
> From: Morten Brørup [mailto:m...@smartsharesystems.com] > Sent: Monday, 7 July 2025 14.11 > > > From: Shani Peretz [mailto:shper...@nvidia.com] > > Sent: Monday, 7 July 2025 07.45 > > > > > From: Stephen Hemminger > > > Sent: Monday, 16 June 2025 18:30 > > > > > > On Mon, 16 Jun 2025 10:29:05 +

RE: [PATCH] mbuf: de-inline sanity checking a reinitialized mbuf

2025-07-19 Thread Morten Brørup
> From: Morten Brørup [mailto:m...@smartsharesystems.com] > Sent: Saturday, 19 July 2025 12.23 > > Sanity checking a reinitialized mbuf (a.k.a. raw mbuf) has been > refactored > to follow the same design pattern as sanity checking a normal mbuf, and > now depends on RTE_LIBRTE_MBUF_DEBUG instead o

Re: [PATCH 0/4] rework mlx5 guide

2025-07-18 Thread Thomas Monjalon
18/07/2025 00:05, Thomas Monjalon: > The main mlx5 doc (for net driver) is improved > with better explanations, better organization, better readability, > and will be a better skeleton for future detailed explanations. > > Maayan Kashani (1): > doc: add testpmd command examples in mlx5 guide >

Re: [PATCH 0/4] rework mlx5 guide

2025-07-18 Thread Thomas Monjalon
18/07/2025 17:36, Stephen Hemminger: > Looks better, it would be good to look at the table of contents > (right column in html) to see if could be better in complex document > like this. Yes I've paid attention to the table of contents. Thanks for the suggestions below. > For example the Usage, d

Re: [PATCH v2] net/intel: deprecate some SSE paths

2025-07-18 Thread Kevin Traynor
On 18/07/2025 17:13, Bruce Richardson wrote: > On Fri, Jul 18, 2025 at 05:05:45PM +0100, Kevin Traynor wrote: >> On 18/07/2025 16:19, Bruce Richardson wrote: >>> On Fri, Jul 18, 2025 at 04:03:17PM +0100, Kevin Traynor wrote: On 03/07/2025 15:31, Ciara Loftus wrote: > The SSE rx and tx path

Re: [RFC PATCH v3 2/2] dts: add PMD RSS testsuite

2025-07-18 Thread Dean Marx
On Fri, Jul 18, 2025 at 11:05 AM Thomas Wilks wrote: > > Port over the rss_key_update, pmd_rss_reta and pmd_rss_hash > test suites from old DTS into one file including all of the > helper functions that are required by all of the test suites > to work. > > The rss_key_update test cases verify that

Re: [RFC PATCH v3 0/2] dts: add RSS functions and test suite

2025-07-18 Thread Ivan Malov
A quick follow-up: I now see that 'self.queue' is in fact a misnomer for an array of queues and not a single queue index specification. It would be better to name it 'queues'. But the issue stands: this array differs from GLOBAL table. As far as I can tell from reading documentation for action 'r

Re: [RFC PATCH v3 0/2] dts: add RSS functions and test suite

2025-07-18 Thread Ivan Malov
Hi Thomas, On Fri, 18 Jul 2025, Thomas Wilks wrote: Hi all, This is v3 of the RSS test suites which has been rebased onto the latest patches. I’m also requesting comments and some help with an issue where the packet RSS queue and the predicted RSS queue differ when running on ConnectX-6 NICs

[DPDK/DTS Bug 1755] Re-evaluate the link requirement decorators on all testsuites/testcases

2025-07-18 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1755 Bug ID: 1755 Summary: Re-evaluate the link requirement decorators on all testsuites/testcases Product: DPDK Version: 25.03 Hardware: All OS: All Status

Re: [PATCH net] net/vmxnet3: fix mapping of mempools to queues

2025-07-18 Thread Ronak Doshi
On Wed, Jul 9, 2025 at 2:47 PM Ronak Doshi wrote: > > Index bitmask variable used was uint8_t, too small for bitmask with > 9 or more queues. This patch changes it to uint16_t for now, to be > same as in the Vmxnet3_MemoryRegion structure. This way txQueues > can be lesser than rxQueues and have c

Re: [PATCH v2] net/intel: deprecate some SSE paths

2025-07-18 Thread Bruce Richardson
On Fri, Jul 18, 2025 at 05:05:45PM +0100, Kevin Traynor wrote: > On 18/07/2025 16:19, Bruce Richardson wrote: > > On Fri, Jul 18, 2025 at 04:03:17PM +0100, Kevin Traynor wrote: > >> On 03/07/2025 15:31, Ciara Loftus wrote: > >>> The SSE rx and tx paths will be removed from the i40e, iavf and ice >

Re: [PATCH v2] net/intel: deprecate some SSE paths

2025-07-18 Thread Kevin Traynor
On 18/07/2025 16:19, Bruce Richardson wrote: > On Fri, Jul 18, 2025 at 04:03:17PM +0100, Kevin Traynor wrote: >> On 03/07/2025 15:31, Ciara Loftus wrote: >>> The SSE rx and tx paths will be removed from the i40e, iavf and ice >>> drivers in the 25.11 release. Each of these drivers have faster vecto

Re: [PATCH 0/4] rework mlx5 guide

2025-07-18 Thread Stephen Hemminger
On Fri, 18 Jul 2025 00:05:40 +0200 Thomas Monjalon wrote: > The main mlx5 doc (for net driver) is improved > with better explanations, better organization, better readability, > and will be a better skeleton for future detailed explanations. > > Maayan Kashani (1): > doc: add testpmd command e

Re: [PATCH 3/4] doc: rework mlx5 guide per features

2025-07-18 Thread Stephen Hemminger
On Fri, 18 Jul 2025 00:05:43 +0200 Thomas Monjalon wrote: > The documentation for net mlx5 is reworded and re-organized. > Design, configuration, requirements and limitations > are grouped per features for easier reading. > > New details are added, and more will come later. >

Re: [PATCH v2] net/intel: deprecate some SSE paths

2025-07-18 Thread Bruce Richardson
On Fri, Jul 18, 2025 at 04:03:17PM +0100, Kevin Traynor wrote: > On 03/07/2025 15:31, Ciara Loftus wrote: > > The SSE rx and tx paths will be removed from the i40e, iavf and ice > > drivers in the 25.11 release. Each of these drivers have faster vector > > paths (AVX2 and AVX-512) which have featur

Re: [PATCH] net/mlx5: document IP fragment matching limitations

2025-07-18 Thread Stephen Hemminger
On Fri, 18 Jul 2025 13:51:56 +0200 Dariusz Sosnowski wrote: > NVIDIA NICs do not support matching on packet headers appearing > after IP header if the received packet is an IP fragment. > This patch updates the relevant documentation. > > Bugzilla ID: 1417 > > Signed-off-by: Dariusz Sosnowski

Re: [PATCH v2] net/intel: deprecate some SSE paths

2025-07-18 Thread Kevin Traynor
On 03/07/2025 15:31, Ciara Loftus wrote: > The SSE rx and tx paths will be removed from the i40e, iavf and ice > drivers in the 25.11 release. Each of these drivers have faster vector > paths (AVX2 and AVX-512) which have feature parity with the soon to be > removed SSE paths. In environments where

Re: [PATCH v3 0/9] rework EAL argument parsing

2025-07-18 Thread Bruce Richardson
On Fri, Jul 18, 2025 at 03:33:46PM +0100, Bruce Richardson wrote: > When processing cmdline arguments in DPDK, we always do so with very > little context. So, for example, when processing the "-l" flag, we have > no idea whether there will be later a --proc-type=secondary flag. We > have all sorts

Re: [PATCH] build: remove obsolete compiler checks

2025-07-18 Thread David Marchand
On Fri, Jul 18, 2025 at 3:06 PM Bruce Richardson wrote: > > On Fri, Jul 18, 2025 at 02:45:48PM +0200, David Marchand wrote: > > On Fri, Jul 18, 2025 at 2:14 PM Bruce Richardson > > wrote: > > > diff --git a/drivers/net/virtio/meson.build > > > b/drivers/net/virtio/meson.build > > > index d3caa3a

Re: [RFC PATCH] doc: clarify VLAN and QinQ stripping behaviour

2025-07-18 Thread Dean Marx
On Fri, Jul 18, 2025 at 4:23 AM Bruce Richardson wrote: > > On Thu, Jul 17, 2025 at 05:03:13PM -0400, Dean Marx wrote: > > I've created a v1 of a QinQ test suite around the set of test cases > > discussed earlier (which is not set in stone, and I expect it to > > change significantly across many f

Re: [PATCH] build: remove obsolete compiler checks

2025-07-18 Thread Bruce Richardson
On Fri, Jul 18, 2025 at 02:45:48PM +0200, David Marchand wrote: > On Fri, Jul 18, 2025 at 2:14 PM Bruce Richardson > wrote: > > diff --git a/drivers/net/virtio/meson.build b/drivers/net/virtio/meson.build > > index d3caa3a3b4..a9ff87e863 100644 > > --- a/drivers/net/virtio/meson.build > > +++ b/dr

Re: [PATCH] build: remove obsolete compiler checks

2025-07-18 Thread David Marchand
On Fri, Jul 18, 2025 at 2:14 PM Bruce Richardson wrote: > diff --git a/drivers/net/virtio/meson.build b/drivers/net/virtio/meson.build > index d3caa3a3b4..a9ff87e863 100644 > --- a/drivers/net/virtio/meson.build > +++ b/drivers/net/virtio/meson.build > @@ -31,7 +31,7 @@ if arch_subdir == 'x86' >

Re: [PATCH] build: remove obsolete compiler checks

2025-07-18 Thread Bruce Richardson
On Fri, Jul 18, 2025 at 02:21:45PM +0200, David Marchand wrote: > On Fri, Jul 18, 2025 at 2:14 PM Bruce Richardson > wrote: > > > > DPDK now recommends compiler versions GCC 8+, and Clang 7+, so remove > > checks and workarounds for versions old than these. > > > > Signed-off-by: Bruce Richardson

Re: [PATCH] build: remove obsolete compiler checks

2025-07-18 Thread David Marchand
On Fri, Jul 18, 2025 at 2:14 PM Bruce Richardson wrote: > > DPDK now recommends compiler versions GCC 8+, and Clang 7+, so remove > checks and workarounds for versions old than these. > > Signed-off-by: Bruce Richardson > --- > config/meson.build | 5 > drivers/event/meson

Re: [PATCH v1] net/ixgbe: add nic and updated recommended matching list

2025-07-18 Thread David Marchand
On Thu, Jul 17, 2025 at 8:55 AM hailinx wrote: > > Signed-off-by: hailinx > --- > doc/guides/nics/ixgbe.rst | 21 + > 1 file changed, 21 insertions(+) > > diff --git a/doc/guides/nics/ixgbe.rst b/doc/guides/nics/ixgbe.rst > index a03ec7a7e8..6380e18feb 100644 > --- a/doc/guid

Re: [PATCH v1] net/ixgbe: add nic and updated recommended matching list

2025-07-18 Thread David Marchand
Hello, On Fri, Jul 18, 2025 at 12:52 PM Bruce Richardson wrote: > > On Thu, Jul 17, 2025 at 02:16:04PM +0800, hailinx wrote: > > Signed-off-by: hailinx > > --- > > doc/guides/nics/ixgbe.rst | 21 + > > 1 file changed, 21 insertions(+) > Acked-by: Bruce Richardson > > > > >

Re: Issue with DPDK-Burst Replay – No Frame Transmission Observed Despite Successful Replay

2025-07-18 Thread Ivan Malov
Hi, (please see below) On Fri, 18 Jul 2025, Gokul K R (MS/ETA7-ETAS) wrote: Hi Team, I’m currently working with the dpdk-burst-replay tool and encountered an issue during execution. Below are the details:

Re: [PATCH v2] doc: update parameters to use for mlx5 on Windows

2025-07-18 Thread Dariusz Sosnowski
On Tue, Jul 15, 2025 at 07:14:49AM -0700, Andre Muezerie wrote: > The linker parameters to use with MSVC and Clang differ. > Showing explicitly what to use with each in the documentation. > > Signed-off-by: Andre Muezerie > --- > doc/guides/platform/mlx5.rst | 27 +++ > 1

Re: [PATCH v1] net/ixgbe: add nic and updated recommended matching list

2025-07-18 Thread Bruce Richardson
On Thu, Jul 17, 2025 at 02:16:04PM +0800, hailinx wrote: > Signed-off-by: hailinx > --- > doc/guides/nics/ixgbe.rst | 21 + > 1 file changed, 21 insertions(+) Acked-by: Bruce Richardson > > diff --git a/doc/guides/nics/ixgbe.rst b/doc/guides/nics/ixgbe.rst > index a03ec7a7

Re: [PATCH v1] net/i40e: updated latest recommended matching list

2025-07-18 Thread Bruce Richardson
On Thu, Jul 17, 2025 at 02:16:03PM +0800, hailinx wrote: > Signed-off-by: hailinx > --- Acked-by: Bruce Richardson The tables in this file really need pruning in next release. They stretch all the way back almost 10 years! > doc/guides/nics/i40e.rst | 4 > 1 file changed, 4 insertions(+)

Re: [PATCH v2] net/ice: updated latest recommended matching list

2025-07-18 Thread Bruce Richardson
On Fri, Jul 18, 2025 at 10:00:08AM +0800, hailinx wrote: > Signed-off-by: hailinx > --- > doc/guides/nics/ice.rst | 23 +-- > 1 file changed, 21 insertions(+), 2 deletions(-) > Acked-by: Bruce Richardson For next release update, I think we can prune the version tables, remov

Re: [RFC PATCH] doc: clarify VLAN and QinQ stripping behaviour

2025-07-18 Thread Bruce Richardson
On Thu, Jul 17, 2025 at 05:03:13PM -0400, Dean Marx wrote: > I've created a v1 of a QinQ test suite around the set of test cases > discussed earlier (which is not set in stone, and I expect it to > change significantly across many future versions.) The PASS/FAIL > values can be mostly disregarded i

RE: [EXTERNAL] Re: [PATCH v0 1/1] doc: announce inter-device DMA capability support in dmadev

2025-07-17 Thread Vamsi Krishna Attunuru
'dev_idx', is it uint16_t? >> Yes, it can be uint16_t and use two different dev_idx (src_dev_idx & >> dest_dev_idx) for read & write. >> >>> 2\ How to implement read/write between two dmadev ? use two >>> different dev_idx? the first for read

RE: [PATCH] net/virtio: Fix check of threshold for Tx freeing

2025-07-17 Thread Jiang, YuX
Message- > From: Hengqi Chen > Sent: Thursday, July 17, 2025 11:04 PM > To: Jiang, YuX > Cc: dev@dpdk.org; Baoyuan Li ; Maxime Coquelin > ; Chenbo Xia > Subject: Re: [PATCH] net/virtio: Fix check of threshold for Tx freeing > > Hi Yu, > > On Fri, Jul 4, 2025 a

Re: [PATCH v1] mailmap: add new email to DPDK

2025-07-17 Thread zhoumin
Recheck-request: rebase=main, loongarch-unit-testing

Re: [RFC PATCH] doc: clarify VLAN and QinQ stripping behaviour

2025-07-17 Thread Dean Marx
I've created a v1 of a QinQ test suite around the set of test cases discussed earlier (which is not set in stone, and I expect it to change significantly across many future versions.) The PASS/FAIL values can be mostly disregarded in the context of this conversation, but I've added logging to expla

Re: [PATCH] doc: remove Mellanox acquisition explanation

2025-07-17 Thread Thomas Monjalon
16/07/2025 12:15, Thomas Monjalon: > Time has passed since Mellanox acquisition by NVIDIA. > No need to explain this anymore. > > Signed-off-by: Thomas Monjalon Applied

Re: [PATCH] examples/multi_process: revert ports cleanup on exit

2025-07-17 Thread Thomas Monjalon
15/07/2025 14:11, Thomas Monjalon: > When closing the primary process, an error occurs when closing ports: > > Error closing ports > EAL: failed to send to (/var/run/dpdk/dpdk_X/mp_socket_Y) due to Bad file > descriptor > EAL: Fail to send request /var/run/dpdk/dpdk_X/mp_socket_Y:mp_malloc_sync >

Re: [PATCH] examples/multi_process: fix cleanup on exit

2025-07-17 Thread Thomas Monjalon
09/07/2025 17:01, Stephen Hemminger: > On Tue, 8 Jul 2025 10:09:54 +0300 > Maayan Kashani wrote: > > > +static void > > +exit_cleanup(void) > > +{ > > + unsigned int i; > > + > > + RTE_LOG(INFO, APP, "Close ports.\n"); > > + for (i = 0; i < num_ports; i++) { > > + if (rte_eal_proc

Re: [PATCH] doc: make table headers more visible in guides

2025-07-17 Thread Thomas Monjalon
16/07/2025 12:14, Thomas Monjalon: > Set a background color to table header > so that it is visually easier to read. > > Signed-off-by: Thomas Monjalon Applied

Re: [PATCH v5 03/14] net/sxe: add tx rx setup and data path

2025-07-17 Thread Stephen Hemminger
On Wed, 9 Jul 2025 21:20:10 -0400 Jie Liu wrote: > s32 __rte_cold __sxe_rx_queue_mbufs_alloc(struct sxe_rx_queue *rxq) > +{ > + struct sxe_rx_buffer *buf_ring = rxq->buffer_ring; > + s32 ret = 0; > + u64 dma_addr; > + u16 i; > + > + for (i = 0; i < rxq->ring_depth; i++) { > +

RE: [RFC PATCH] doc: clarify VLAN and QinQ stripping behaviour

2025-07-17 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Wednesday, 16 July 2025 21.47 > > On Wed, Jul 16, 2025 at 03:24:55PM -0400, Dean Marx wrote: > > I've created a list of test cases which I'm planning on implementing > > in future QinQ testing. After talking with Bruce about some

Re: [PATCH 00/11] NXP DPAA2 driver enhancements and fixes

2025-07-17 Thread Stephen Hemminger
Too late for 25.07 now. But will put in next-net for 25.11 I notice if shadow declaration warning is enabled, lots of warning occur. In file included from ../drivers/net/dpaa2/dpaa2_ethdev.c:26: ../drivers/net/dpaa2/dpaa2_ethdev.c: In function ‘dpaa2_alloc_rx_tx_queues’: ../drivers/bus/fslmc/por

Re: [PATCH v9 02/14] net/sxe: add ethdev probe and remove

2025-07-17 Thread Stephen Hemminger
On Wed, 16 Jul 2025 04:29:18 -0400 Jie Liu wrote: > +static s32 sxe_hdc_cmd_process(struct sxe_hw *hw, u64 trace_id, > + struct sxe_hdc_trans_info *trans_info) > +{ > + s32 ret; > + u8 retry_idx; > + struct sxe_adapter *adapter = hw->adapter; > + sigset

Re: [PATCH] net/virtio: Fix check of threshold for Tx freeing

2025-07-17 Thread Hengqi Chen
Hi Yu, On Fri, Jul 4, 2025 at 7:29 PM Jiang, YuX wrote: > > Hi Hengqi, > > Can you help to check the ticket: https://bugs.dpdk.org/show_bug.cgi?id=1747? > The perf drop is caused by your patch. Thanks so much. > Could you please elaborate how to use trex in your reproduce steps ? Thanks. Cheer

Re: [PATCH] doc: remove Mellanox acquisition explanation

2025-07-17 Thread zhoumin
Recheck-request: rebase=main, loongarch-unit-testing

Re: [PATCH v1] mailmap: add new email to DPDK

2025-07-17 Thread zhoumin
Recheck-request: rebase=main, loongarch-unit-testing

Re: [PATCH 2/2] doc: use common description of EAL parameters

2025-07-17 Thread Bruce Richardson
On Thu, Jul 17, 2025 at 01:46:04PM +0200, David Marchand wrote: > Rather than have a subset of the EAL parameters described in the sample > apps documentation, prefer referring to the full list. > > Signed-off-by: David Marchand > --- Acked-by: Bruce Richardson

Re: [PATCH 1/2] doc: remove reference to device selection option

2025-07-17 Thread Bruce Richardson
On Thu, Jul 17, 2025 at 01:46:03PM +0200, David Marchand wrote: > --use-device was replaced with -a / --vdev options in v1.6 > with commit cac6d08c8bde ("devargs: replace --use-device option by > --pci-whitelist and --vdev"). > > It was reintroduced in the doc in v1.8 when the rst documentation >

Re: [RFC PATCH v2 0/5] rework EAL argument parsing in DPDK

2025-07-17 Thread Bruce Richardson
On Thu, Jul 17, 2025 at 12:41:46PM +0200, David Marchand wrote: > On Tue, Jul 8, 2025 at 7:21 PM Bruce Richardson > wrote: > > > > This RFC is a second, more complete, prototype of one approach we may > > want to take to help improve management of EAL cmdline arguments. > > > > BACKGROUND: > > - T

Re: [RFC PATCH v2 0/5] rework EAL argument parsing in DPDK

2025-07-17 Thread David Marchand
On Tue, Jul 8, 2025 at 7:21 PM Bruce Richardson wrote: > > This RFC is a second, more complete, prototype of one approach we may > want to take to help improve management of EAL cmdline arguments. > > BACKGROUND: > - The first problem that led to this work was that of providing a > way for users

Re: [PATCH] eal: add description of service corelist in usage

2025-07-17 Thread Bruce Richardson
On Thu, Jul 17, 2025 at 11:42:32AM +0200, David Marchand wrote: > The -S option is not described in EAL usage(). > > Fixes: 7dbd7a6413ef ("service: add -S corelist option") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand > --- Acked-by: Bruce Richardson > lib/eal/common/eal_common_opt

Re: [PATCH] net/ice: fix assumption about tag placement order

2025-07-17 Thread David Marchand
On Thu, Jul 17, 2025 at 10:33 AM Bruce Richardson wrote: > > On Thu, Jul 17, 2025 at 10:19:24AM +0200, David Marchand wrote: > > On Wed, Jul 16, 2025 at 7:39 PM Bruce Richardson > > wrote: > > > > > > The specific placement of outer/inner VLAN tags in E810 and related NICs > > > is configurable.

Re: [PATCH] net/ice: fix assumption about tag placement order

2025-07-17 Thread Bruce Richardson
On Thu, Jul 17, 2025 at 10:19:24AM +0200, David Marchand wrote: > On Wed, Jul 16, 2025 at 7:39 PM Bruce Richardson > wrote: > > > > The specific placement of outer/inner VLAN tags in E810 and related NICs > > is configurable. Therefore, remove the assumption that if the L2Tag2 > > field is filled

Re: [PATCH] net/ice: fix assumption about tag placement order

2025-07-17 Thread David Marchand
On Wed, Jul 16, 2025 at 7:39 PM Bruce Richardson wrote: > > The specific placement of outer/inner VLAN tags in E810 and related NICs > is configurable. Therefore, remove the assumption that if the L2Tag2 > field is filled in, that the L2Tag1 must also be. Instead, check the > existing mbuf VLAN fl

Re: [PATCH] net: support VLAN stacking packet type parsing

2025-07-17 Thread fengchengwen
On 2025/7/4 18:18, Morten Brørup wrote: >> From: Dengdui Huang [mailto:huangdeng...@huawei.com] >> Sent: Thursday, 3 July 2025 11.30 >> >> The current rte_net_get_ptype() only supports parsing packets with >> one 0x8100 VLAN tag or two 0x88a8 VLAN tags. This patch extends it >> to support parsing p

Re: [EXTERNAL] Re: [PATCH v0 1/1] doc: announce inter-device DMA capability support in dmadev

2025-07-16 Thread fengchengwen
st_dev_idx) > for read & write. > >> 2\ How to implement read/write between two dmadev ? use two different >> dev_idx? the first for read and the second for write? > Yes, two different dev_idx will be used. > >> >> >> I also re-read the patchset &quo

Re: [PATCH v7 3/3] doc: revise coding guidelines section

2025-07-16 Thread Patrick Robb
On Wed, Jul 16, 2025 at 4:54 PM Dean Marx wrote: > code. > > > How To Write a Test Suite > - > > -All test suites inherit from ``TestSuite`` defined in > ``dts/framework/test_suite.py``. > -There are four types of methods that comprise a test suite: > +All test suites ar

Re: [PATCH v9 02/14] net/sxe: add ethdev probe and remove

2025-07-16 Thread Stephen Hemminger
On Wed, 16 Jul 2025 04:29:18 -0400 Jie Liu wrote: > diff --git a/drivers/net/sxe/meson.build b/drivers/net/sxe/meson.build > index dad9ee44a0..34571522f7 100644 > --- a/drivers/net/sxe/meson.build > +++ b/drivers/net/sxe/meson.build > @@ -1,9 +1,22 @@ > # SPDX-License-Identifier: BSD-3-Clause >

Re: [PATCH v9 02/14] net/sxe: add ethdev probe and remove

2025-07-16 Thread Stephen Hemminger
On Wed, 16 Jul 2025 04:29:18 -0400 Jie Liu wrote: > + > +#define false 0 > +#define true 1 > + Bad idea, conflicts with stdbool.h

Re: [PATCH v9 02/14] net/sxe: add ethdev probe and remove

2025-07-16 Thread Stephen Hemminger
On Wed, 16 Jul 2025 04:29:18 -0400 Jie Liu wrote: > --- /dev/null > +++ b/drivers/net/sxe/base/sxe_common.c > @@ -0,0 +1,66 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright (C), 2022, Linkdata Technology Co., Ltd. > + */ > + > +#include > +#include > +#include > +#include > +#in

Re: [PATCH v9 03/14] net/sxe: add tx rx setup and data path

2025-07-16 Thread Stephen Hemminger
On Wed, 16 Jul 2025 04:29:19 -0400 Jie Liu wrote: > +const alignas(RTE_CACHE_LINE_SIZE) u32 sxe_ptype_table[SXE_PACKET_TYPE_MAX] > = { > + Prefer using DPDK macro __rte_cache_align where possible.

Re: [PATCH v9 03/14] net/sxe: add tx rx setup and data path

2025-07-16 Thread Stephen Hemminger
On Wed, 16 Jul 2025 04:29:19 -0400 Jie Liu wrote: > Add setup, initialization, and logic for tx and rx queues. > > Signed-off-by: Jie Liu > --- Buried in checkpatch warnings are some spelling errors here: WARNING:TYPO_SPELLING: 'unsupport' may be misspelled - perhaps 'unsupported'? #5037: FI

Re: [RFC PATCH] doc: clarify VLAN and QinQ stripping behaviour

2025-07-16 Thread Bruce Richardson
On Wed, Jul 16, 2025 at 03:24:55PM -0400, Dean Marx wrote: > I've created a list of test cases which I'm planning on implementing > in future QinQ testing. After talking with Bruce about some Intel test > results earlier, I've got a solid idea of what the expected behaviors > are in five of these,

Re: [RFC PATCH] doc: clarify VLAN and QinQ stripping behaviour

2025-07-16 Thread Dean Marx
I've created a list of test cases which I'm planning on implementing in future QinQ testing. After talking with Bruce about some Intel test results earlier, I've got a solid idea of what the expected behaviors are in five of these, but I'm unsure about the other three. If anyone is able to provide

Re: [PATCH v5 3/3] doc: revise coding guidelines section

2025-07-16 Thread Patrick Robb
On Wed, Jul 16, 2025 at 9:57 AM Dean Marx wrote: > > + > +* Document ``__init__()`` separately from the class docstring. > +* If an abstract method simply implements a superclass definition without > changes, refer to that superclass in the docstring. > +* Document instance variables in the class

Re: [PATCH] doc: remove Mellanox acquisition explanation

2025-07-16 Thread Stephen Hemminger
On Wed, 16 Jul 2025 17:56:04 +0200 Thomas Monjalon wrote: > 16/07/2025 12:37, Bruce Richardson: > > On Wed, Jul 16, 2025 at 12:15:16PM +0200, Thomas Monjalon wrote: > > > Time has passed since Mellanox acquisition by NVIDIA. > > > No need to explain this anymore. > > > > > > Signed-off-by: Tho

Re: [PATCH] doc: remove Mellanox acquisition explanation

2025-07-16 Thread Thomas Monjalon
16/07/2025 12:37, Bruce Richardson: > On Wed, Jul 16, 2025 at 12:15:16PM +0200, Thomas Monjalon wrote: > > Time has passed since Mellanox acquisition by NVIDIA. > > No need to explain this anymore. > > > > Signed-off-by: Thomas Monjalon > > --- > > I wonder if we should include in DPDK a "future

RE: [PATCH v4 08/22] hash: fix unaligned access in predictable RSS

2025-07-16 Thread Konstantin Ananyev
> > Caught by UBSan: > > ../lib/hash/rte_thash.c:421:8: runtime error: load of misaligned address > 0x0001816c2da3 for type 'uint32_t' (aka 'unsigned int'), > which requires 4 byte alignment > > Fixes: 28ebff11c2dc ("hash: add predictable RSS") > Cc: sta...@dpdk.org > > Signed-off

RE: [PATCH v4 18/22] net: fix IPv4 macro with highest bit

2025-07-16 Thread Konstantin Ananyev
> Without an explicit type, all parameters of this macro are considered as > a signed integer. > > ../app/test/test_fib.c:270:20: runtime error: left shift of > 128 by 24 places cannot be represented in type 'int' > SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior > ../app/te

RE: [EXTERNAL] Re: [PATCH v0 1/1] doc: announce inter-device DMA capability support in dmadev

2025-07-16 Thread Vamsi Krishna Attunuru
is: >1\ What the prototype of 'dev_idx', is it uint16_t? Yes, it can be uint16_t and use two different dev_idx (src_dev_idx & dest_dev_idx) for read & write. >2\ How to implement read/write between two dmadev ? use two different >dev_idx? the first for read and the s

Re: [PATCH] net/mlx5: fix crash when using meter in transfer flow

2025-07-16 Thread Dariusz Sosnowski
On Wed, Jul 16, 2025 at 03:23:19AM -0400, Khadem Ullah wrote: > Hi Dariusz, > > Yes, you are right — I believe this has been fixed since DPDK v24.11 by the > commit you mentioned: > https://github.com/DPDK/dpdk/commit/c30b356a4d48542fe99c47aa470afc8cd1ced9f5 > > Previously, this appeared to be a

Re: [PATCH] doc: remove Mellanox acquisition explanation

2025-07-16 Thread Bruce Richardson
On Wed, Jul 16, 2025 at 12:15:16PM +0200, Thomas Monjalon wrote: > Time has passed since Mellanox acquisition by NVIDIA. > No need to explain this anymore. > > Signed-off-by: Thomas Monjalon > --- I wonder if we should include in DPDK a "future_cleanups" doc which describes cleanups that can or

Re: [RFC PATCH] doc: clarify VLAN and QinQ stripping behaviour

2025-07-16 Thread Bruce Richardson
On Mon, Jul 14, 2025 at 04:09:11PM -0400, Dean Marx wrote: > On Mon, Jul 14, 2025 at 9:30 AM Bruce Richardson > wrote: > > > > The behaviour of VLAN tag stripping Rx offloads is unclear in DPDK, and > > not very well documented. Even the documentation that does exist appears > > contradictory. > >

RE: DPDK release candidate 25.07-rc3

2025-07-16 Thread Varghese, Vipin
[AMD Official Use Only - AMD Internal Distribution Only] Hi Thomas, Please find the AMD EPYC testing results for both rc-1 and rc-2 shared below RC-1: - tuning guide: https://doc.dpdk.org/guides/linux_gsg/amd_platform.html - OS: Ubuntu 24.04.2, 6.8.0 - Grub: default_hugepagesz=1GB isolcpus=7-63

Re: [PATCH] doc: update parameters to use for mlx5 on Windows

2025-07-16 Thread Dariusz Sosnowski
On Tue, Jul 15, 2025 at 06:57:25AM -0700, Andre Muezerie wrote: > On Tue, Jul 15, 2025 at 02:03:45PM +0200, Dariusz Sosnowski wrote: *snip* > > Shouldn't clang linker parameters stay as it was previously i.e., "-L..."? > > Not on Windows. It can be confirmed by looking at > build\meson-logs\mes

Re: [PATCH v9 01/14] net/sxe: add base driver directory and doc

2025-07-16 Thread David Marchand
Hello, On Wed, Jul 16, 2025 at 10:29 AM Jie Liu wrote: > > Adding a minimum maintainable directory structure for the > network driver and request maintenance of the sxe driver. > > Signed-off-by: Jie Liu - Such a big series deserves a cover letter, with annotations/tracking of the changes acros

Re: [PATCH v2 07/10] tailq: fix cast macro for null pointer

2025-07-16 Thread David Marchand
On Mon, Jun 30, 2025 at 6:06 PM Marat Khalili wrote: > > > -Original Message- > > From: David Marchand > > Sent: Monday 23 June 2025 14:53 > > To: dev@dpdk.org > > Cc: sta...@dpdk.org; Bruce Richardson ; Tyler > > Retzlaff ; Neil Horman > > > > Subject: [PATCH v2 07/10] tailq: fix cast m

Re: [PATCH] doc/mlx5: document firmware requirement for flex item

2025-07-16 Thread Khadem Ullah
Hi Dariusz, Thanks for the follow-up. I was using DPDK v23.11 with the following flex item configuration: { "next_header": { "field_mode": "FIELD_MODE_FIXED", "field_size": 0, "field_base": 0 }, "next_protocol": { "field_mode": "FIELD_MODE_FIXED", "field_size": 8, "field_base": 72 }, "sa

Re: [PATCH] net/mlx5: fix crash when using meter in transfer flow

2025-07-16 Thread Khadem Ullah
Hi Dariusz, Yes, you are right ??? I believe this has been fixed since DPDK v24.11 by the commit you mentioned: https://github.com/DPDK/dpdk/commit/c30b356a4d48542fe99c47aa470afc8cd1ced9f5 Previously, this appeared to be an edge case where a segfault was triggered when a transfer rule was creat

Re: [PATCH v2 08/10] hash: fix unaligned access in predictable RSS

2025-07-15 Thread Mattias Rönnblom
On 2025-06-23 15:52, David Marchand wrote: Caught by UBSan: ../lib/hash/rte_thash.c:421:8: runtime error: load of misaligned address 0x0001816c2da3 for type 'uint32_t' (aka 'unsigned int'), which requires 4 byte alignment Fixes: 28ebff11c2dc ("hash: add predictable RSS") Cc: sta

RE: [EXTERNAL] Re: [PATCH v4] doc: announce changes to dma device structures

2025-07-15 Thread Vamsi Krishna Attunuru
>ZjQcmQRYFpfptBannerEnd >On Wed, Jul 31, 2024 at 06:06:33PM +0200, Thomas Monjalon wrote: >> 31/07/2024 13:01, Thomas Monjalon: >> > 30/07/2024 19:27, Jerin Jacob: >> > > On Tue, Jul 30, 2024 at 8:25 PM Amit Prakash Shukla >> > > wrote: >> > > > >> > > > A new flag RTE_DMA_CAPA_QOS will be introdu

Re: [EXTERNAL] Re: [PATCH v0 1/1] doc: announce inter-device DMA capability support in dmadev

2025-07-15 Thread fengchengwen
uint16_t? 2\ How to implement read/write between two dmadev ? use two different dev_idx? the first for read and the second for write? I also re-read the patchset "[PATCH v1 0/3] Add support for inter-domain DMA operations", it introduce: 1\ One 'int controller-id' in the r

Re: [PATCH v4 3/3] doc: revise coding guidelines section

2025-07-15 Thread Patrick Robb
On Mon, Jul 14, 2025 at 1:13 PM Dean Marx wrote: > The Framework Coding Guidelines section includes outdated information > about DTS and how to write a test suite. Updated these points to include > the new test case decorators and setup/teardown hooks. > > Signed-off-by: Dean Marx > Reviewed-by:

Re: [PATCH v4 1/3] dts: rewrite README

2025-07-15 Thread Patrick Robb
On Mon, Jul 14, 2025 at 1:13 PM Dean Marx wrote: > > + > +# Simple Linux Setup > + > +1. On your TG and SUT nodes, add a dedicated user. In this example I will > add a dedicated user for DTS. > This is getting away from what I was suggesting. The original version was: On your TG and SUT nodes,

Re: [RFC PATCH] doc: clarify VLAN and QinQ stripping behaviour

2025-07-15 Thread Patrick Robb
On Tue, Jul 15, 2025 at 3:47 AM Bruce Richardson wrote: > > > Thanks. Let me know how the testing otherwise goes. If only Intel NICs are > supporting QinQ, then it can't be that widely used a feature yet, so we may > be able to tweak things a bit if it diverges from what is expected. > Yeah, the

Re: [PATCH v2] doc: update parameters to use for mlx5 on Windows

2025-07-15 Thread Patrick Robb
+c...@dpdk.org +Manit Mahajan +Andrew Bailey Thank you for this we will modify our Clang and MSVC build pipelines at UNH. Acked-by: Patrick Robb On Tue, Jul 15, 2025 at 10:14 AM Andre Muezerie < andre...@linux.microsoft.com> wrote: > The linker parameters to use with MSVC and Clang differ.

Re: [PATCH] net/mlx5: fix crash when using meter in transfer flow

2025-07-15 Thread Dariusz Sosnowski
On Tue, Jul 15, 2025 at 07:39:53PM +0200, Dariusz Sosnowski wrote: > + mlx5 maintainers > > Thank you for the patch. > > On Wed, Jul 02, 2025 at 08:36:17AM -0400, Khadem Ullah wrote: > > When creating a flow rule with the transfer attribute and a meter action, > > the driver did not validate this

Re: [PATCH] net/mlx5: fix crash when using meter in transfer flow

2025-07-15 Thread Dariusz Sosnowski
+ mlx5 maintainers Thank you for the patch. On Wed, Jul 02, 2025 at 08:36:17AM -0400, Khadem Ullah wrote: > When creating a flow rule with the transfer attribute and a meter action, > the driver did not validate this combination and would crash due to > unsupported handling. > > This patch adds

Re: [RFC PATCH] doc: clarify VLAN and QinQ stripping behaviour

2025-07-15 Thread Bruce Richardson
On Tue, Jul 15, 2025 at 05:04:42PM +0200, Morten Brørup wrote: > FYI: > Last time I looked, it seemed like the VLAN/QINQ "tag present" mbuf RX flags > were only set along with the RX _STRIPPED flags, i.e. not set when stripping > was not enabled. > Although setting the "tag present" flags (and th

RE: [PATCH] doc: announce mbuf fast free configuration requirements

2025-07-15 Thread Konstantin Ananyev
> For TX mbuf fast release offload, the mbuf mempool pointer will be added > to the ethdev tx queue configuration structure, so the ethdev TX burst > operation doesn't need to fetch it from the first mbuf of each burst being > fast free'd to the mempool. > > Signed-off-by: Morten Brørup > --- >

RE: [PATCH v2] net/intel: deprecate some SSE paths

2025-07-15 Thread Konstantin Ananyev
> The SSE rx and tx paths will be removed from the i40e, iavf and ice > drivers in the 25.11 release. Each of these drivers have faster vector > paths (AVX2 and AVX-512) which have feature parity with the soon to be > removed SSE paths. In environments where AVX2 or AVX-512 are not > supported,

Re: [PATCH] maintainers: update for ethdev library

2025-07-15 Thread Ferruh Yigit
On 7/11/2025 3:43 PM, Thomas Monjalon wrote: > Ferruh Yigit has no time this year for ethdev maintenance. > > Signed-off-by: Thomas Monjalon > --- > MAINTAINERS | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 0e9357f3a3..b96496adb7 100644 > --- a/MAINTA

RE: [RFC PATCH] doc: clarify VLAN and QinQ stripping behaviour

2025-07-15 Thread Morten Brørup
FYI: Last time I looked, it seemed like the VLAN/QINQ "tag present" mbuf RX flags were only set along with the RX _STRIPPED flags, i.e. not set when stripping was not enabled. Although setting the "tag present" flags (and the vlan_tci/vlan_tci_outer fields) without stripping would be nice to hav

Re: [PATCH v2 08/10] hash: fix unaligned access in predictable RSS

2025-07-15 Thread David Marchand
On Tue, Jul 15, 2025 at 3:33 PM Konstantin Ananyev wrote: > > > BTW, would our 'unaligned_uint32_t' type help here? > > > > Since most DPDK code rely on aligned types, using an unaligned type > > can work if we have a function that serves as a conversion from > > unaligned to aligned types. > > In

Re: [PATCH v4] doc: announce changes to dma device structures

2025-07-15 Thread Bruce Richardson
On Wed, Jul 31, 2024 at 06:06:33PM +0200, Thomas Monjalon wrote: > 31/07/2024 13:01, Thomas Monjalon: > > 30/07/2024 19:27, Jerin Jacob: > > > On Tue, Jul 30, 2024 at 8:25 PM Amit Prakash Shukla > > > wrote: > > > > > > > > A new flag RTE_DMA_CAPA_QOS will be introduced to advertise dma > > > > de

Re: DPDK release candidate 25.07-rc3

2025-07-15 Thread Thinh Tran
IBM - Power Systems Testing DPDK v25.07-rc3 * Build CI on Fedora 40, 41 and 42 container images for ppc64le * Basic PF on Mellanox: No issue found * Performance: not tested. * OS:- RHEL 9.4 kernel: 5.14.0-427.40.1.el9_4.ppc64le with gcc version 11.4.1 20231218 (Red Hat 11.4.1-3)

Re: [PATCH v2] net/intel: deprecate some SSE paths

2025-07-15 Thread Bruce Richardson
On Thu, Jul 03, 2025 at 02:31:19PM +, Ciara Loftus wrote: > The SSE rx and tx paths will be removed from the i40e, iavf and ice > drivers in the 25.11 release. Each of these drivers have faster vector > paths (AVX2 and AVX-512) which have feature parity with the soon to be > removed SSE paths.

Re: [PATCH] doc: update parameters to use for mlx5 on Windows

2025-07-15 Thread Andre Muezerie
On Tue, Jul 15, 2025 at 02:03:45PM +0200, Dariusz Sosnowski wrote: > Hi, > > On Mon, May 05, 2025 at 08:22:41AM -0700, Andre Muezerie wrote: > > The linker parameters to use with MSVC and Clang differ. > > Showing explicitly what to use with each in the documentation. > > > > Signed-off-by: Andre

  1   2   3   4   5   6   7   8   9   10   >