Re: [PATCH] mempool: fix internal function documentation

2023-10-23 Thread Ferruh Yigit
On 10/20/2023 5:08 PM, Morten Brørup wrote: >> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] >> Sent: Friday, 20 October 2023 16.47 >> >> static function `rte_mempool_do_generic_get()` returns zero on success, >> not >=0 as its function comment documents. >> >> Since this function called by publ

Re: [PATCH] mempool: fix internal function documentation

2023-10-20 Thread lihuisong (C)
Acked-by: Huisong Li 在 2023/10/20 22:46, Ferruh Yigit 写道: static function `rte_mempool_do_generic_get()` returns zero on success, not >=0 as its function comment documents. Since this function called by public API, the comment causes confusion on the public API return value. Fixing the intern

RE: [PATCH] mempool: fix internal function documentation

2023-10-20 Thread Morten Brørup
> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] > Sent: Friday, 20 October 2023 16.47 > > static function `rte_mempool_do_generic_get()` returns zero on success, > not >=0 as its function comment documents. > > Since this function called by public API, the comment causes confusion > on the pub