Re: BUILD bug hidden in SFC driver.

2023-11-13 Thread Stephen Hemminger
On Mon, 13 Nov 2023 16:04:51 +0400 (+04) Ivan Malov wrote: > diff --git a/drivers/net/sfc/sfc_ef100_tx.c b/drivers/net/sfc/sfc_ef100_tx.c > index 1b6374775f..01f37c2616 100644 > --- a/drivers/net/sfc/sfc_ef100_tx.c > +++ b/drivers/net/sfc/sfc_ef100_tx.c > @@ -563,7 +563,7 @@ sfc_ef100_tx_pkt_desc

Re: BUILD bug hidden in SFC driver.

2023-11-13 Thread Tyler Retzlaff
On Sat, Nov 11, 2023 at 08:56:34AM -0800, Stephen Hemminger wrote: > While examining the use of VLA in DPDK, ran into a bug in sfc driver. > > If DPDK is built with -Wvla, then the RTE_BUILD_BUG_ON() macro won't work > as written. Experimenting with a better more portable version of that macro > a

Re: BUILD bug hidden in SFC driver.

2023-11-13 Thread Ivan Malov
Hi Stephen, On Sat, 11 Nov 2023, Stephen Hemminger wrote: While examining the use of VLA in DPDK, ran into a bug in sfc driver. If DPDK is built with -Wvla, then the RTE_BUILD_BUG_ON() macro won't work as written. Experimenting with a better more portable version of that macro as: #def

Re: BUILD bug hidden in SFC driver.

2023-11-11 Thread Stephen Hemminger
On Sat, 11 Nov 2023 08:56:34 -0800 Stephen Hemminger wrote: > While examining the use of VLA in DPDK, ran into a bug in sfc driver. > > If DPDK is built with -Wvla, then the RTE_BUILD_BUG_ON() macro won't work > as written. Experimenting with a better more portable version of that macro > as: >

BUILD bug hidden in SFC driver.

2023-11-11 Thread Stephen Hemminger
While examining the use of VLA in DPDK, ran into a bug in sfc driver. If DPDK is built with -Wvla, then the RTE_BUILD_BUG_ON() macro won't work as written. Experimenting with a better more portable version of that macro as: #define RTE_BUILD_BUG_ON(e) _Static_assert(!(e), #e) revealed th